Re: gcc-12.0.0-0.4.fc36 in rawhide
Hi Jakub, On Fri, Jan 14, 2022 at 03:31:43PM +0100, Jakub Jelinek wrote: > Hi! > > gcc 12 snapshot has landed as the system compiler into rawhide today. > GCC 12 is going to enter its stage4 development phase (only regression > and documentation bugfixes allowed) on Monday 17th, so there should be > just those bugfixes and not new features etc. anymore. > https://gcc.gnu.org/gcc-12/changes.html lists important changes, > most important is probably that vectorization is enabled at -O2 now > which is the option with most of the distribution is built with. > > https://gcc.gnu.org/gcc-12/porting_to.html is so far incomplete and lists > some cases where people need to adjust their code. Other things > include the usual C++ header changes, where previously some standard > header included some other header as an implementation detail but it doesn't > any longer and so code that relied on such indirect include that isn't > required by the standard needs to include the header that provides whatever > it relies on. Or e.g. packages using -Werror where new warnings are > reported with the newer compiler and -Werror results in build failures. Can this be documented soon? https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99032 It hit nextcloud-client: https://bugzilla.redhat.com/show_bug.cgi?id=2041135 which compiles fine with GCC 11 for F34 and F35. > > If there are bugs on the compiler side, please let me know immediately, > so that those bugs can be fixed before the mass rebuild next week. > I'm going to exercise this with the new Folly stack on Monday once the weekly tags are created. Will try and report ASAP. Speaking of which, folly is also affected by this which affected GCC 11, so I'll update the bug either to confirm it is still broken in 12 or it has been fixed: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104008 Best regards, -- Michel Alexandre Salim identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2 signature.asc Description: PGP signature ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Heads-up: trousers (TPM 1.2) silently orphaned
On Sat, Jan 15, 2022 at 11:42:34AM +, Peter Robinson wrote: > On Sat, Jan 15, 2022 at 4:20 AM Michel Alexandre Salim > wrote: > > > > On Fri, Dec 17, 2021 at 12:35:59PM -0800, Adam Williamson wrote: > > > > > > It does seem to be used by robosignatory (the thing that signs Fedora > > > packages, I think): > > > > Sorry for the late reply! Meant to ask you about this, as I tried and > > find what requires trousers before my first post and didn't see > > robosignatory at all. > > I asked Patrick about this last week, it's an old dependency that was > never cleaned up. On a previous generation of HW they used to use a > TPM1 to store bits used by robosignatory but it was never a direct > dependency. That's no longer the case so it can be cleaned up. Ah, that's good to know! I still intend to maintain trousers for at least the next couple of years - but the less dependent packages, the better. Best regards, -- Michel Alexandre Salim identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2 signature.asc Description: PGP signature ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Workflow and other problems with the Fedora container infrastructure
On Thu, Jan 13, 2022 at 02:14:19PM -0500, Neal Gompa wrote: > > One of the things that has recently happened in the Koji space is the > addition of a kiwi-build task to build images using the KIWI tool[1]. > > KIWI supports building all kinds of operating system images, including > OCI containers. The Fedora Cloud WG is poking at the idea of using > KIWI for the cloud image to replace the unmaintained and brittle > ImageFactory, and we could also look at doing container builds with > KIWI to replace the OpenShift Atomic Reactor system. That would > drastically simplify the architecture and make container image builds > considerably more reasonable for the Container SIG and any other > stakeholders. Yeah, thats quite interesting. I would be happy to move to a pipeline thats less fragile here. :) There's also talk about moving things to use ImageBuilder, but I don't think it does containers. kevin signature.asc Description: PGP signature ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: gcc-12.0.0-0.4.fc36 in rawhide
To clarify, this is affecting the
https://src.fedoraproject.org/rpms/json package and (since it is a
header-only library) some or all of the many packages that use it.
Here’s the upstream issue: https://github.com/nlohmann/json/issues/3138
It looks like they’re not sure what to do about it yet.
– Ben
On 1/15/22 13:17, Vitaly Zaitsev via devel wrote:
On 14/01/2022 15:31, Jakub Jelinek wrote:
gcc 12 snapshot has landed as the system compiler into rawhide today.
Another regression:
FAILED: test/CMakeFiles/test-regression1.dir/src/unit-regression1.cpp.o
/usr/bin/g++ -DDOCTEST_CONFIG_SUPER_FAST_ASSERTS -DJSON_DIAGNOSTICS=0
-DJSON_USE_IMPLICIT_CONVERSIONS=1
-I/builddir/build/BUILD/json-3.10.5/redhat-linux-build/include
-I/builddir/build/BUILD/json-3.10.5/test/thirdparty/doctest
-I/builddir/build/BUILD/json-3.10.5/test/thirdparty/fifo_map
-I/builddir/build/BUILD/json-3.10.5/include -O2 -flto=auto
-ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall
-Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
-Wp,-D_GLIBCXX_ASSERTIONS
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1
-mbranch-protection=standard -fasynchronous-unwind-tables
-fstack-clash-protection -Wno-deprecated -Wno-float-equal
-Wno-deprecated-declarations -MD -MT
test/CMakeFiles/test-regression1.dir/src/unit-regression1.cpp.o -MF
test/CMakeFiles/test-regression1.dir/src/unit-regression1.cpp.o.d -o
test/CMakeFiles/test-regression1.dir/src/unit-regression1.cpp.o -c
/builddir/build/BUILD/json-3.10.5/test/src/unit-regression1.cpp
/builddir/build/BUILD/json-3.10.5/test/src/unit-regression1.cpp: In
function 'void DOCTEST_ANON_FUNC_2()':
/builddir/build/BUILD/json-3.10.5/test/src/unit-regression1.cpp:392:22:
error: ambiguous overload for 'operator=' (operand types are
'std::string' {aka 'std::__cxx11::basic_string'} and
'nlohmann::basic_json<>::value_type' {aka 'nlohmann::basic_json<>'})
392 | s2 = o["name"];
| ^
In file included from /usr/include/c++/12/string:53,
from /usr/include/c++/12/bits/locale_classes.h:40,
from /usr/include/c++/12/locale:39,
from
/builddir/build/BUILD/json-3.10.5/test/src/unit-regression1.cpp:33:
/usr/include/c++/12/bits/basic_string.h:733:21: note: candidate:
'std::__cxx11::basic_string<_CharT, _Traits, _Alloc>&
std::__cxx11::basic_string<_CharT, _Traits,
_Alloc>::operator=(std::nullptr_t) [with _CharT = char; _Traits =
std::char_traits; _Alloc = std::allocator; std::nullptr_t
= std::nullptr_t]' (deleted)
733 | basic_string& operator=(nullptr_t) = delete;
| ^~~~
/usr/include/c++/12/bits/basic_string.h:801:7: note: candidate:
'std::__cxx11::basic_string<_CharT, _Traits, _Alloc>&
std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::operator=(const
std::__cxx11::basic_string<_CharT, _Traits, _Alloc>&) [with _CharT =
char; _Traits = std::char_traits; _Alloc = std::allocator]'
801 | operator=(const basic_string& __str)
| ^~~~
/usr/include/c++/12/bits/basic_string.h:842:7: note: candidate:
'std::__cxx11::basic_string<_CharT, _Traits, _Alloc>&
std::__cxx11::basic_string<_CharT, _Traits,
_Alloc>::operator=(std::__cxx11::basic_string<_CharT, _Traits,
_Alloc>&&) [with _CharT = char; _Traits = std::char_traits;
_Alloc = std::allocator]'
842 | operator=(basic_string&& __str)
| ^~~~
In file included from
/builddir/build/BUILD/json-3.10.5/test/thirdparty/doctest/doctest_compatibility.h:6,
from
/builddir/build/BUILD/json-3.10.5/test/src/unit-regression1.cpp:30:
/builddir/build/BUILD/json-3.10.5/test/src/unit-regression1.cpp: In
lambda function:
/builddir/build/BUILD/json-3.10.5/test/src/unit-regression1.cpp:398:37:
error: ambiguous overload for 'operator=' (operand types are
'std::string' {aka 'std::__cxx11::basic_string'} and
'nlohmann::basic_json<>::value_type' {aka 'nlohmann::basic_json<>'})
398 | CHECK_THROWS_AS(s2 = o["int"], json::type_error);
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
Re: gcc-12.0.0-0.4.fc36 in rawhide
On 14/01/2022 15:31, Jakub Jelinek wrote:
gcc 12 snapshot has landed as the system compiler into rawhide today.
Another regression:
FAILED: test/CMakeFiles/test-regression1.dir/src/unit-regression1.cpp.o
/usr/bin/g++ -DDOCTEST_CONFIG_SUPER_FAST_ASSERTS -DJSON_DIAGNOSTICS=0
-DJSON_USE_IMPLICIT_CONVERSIONS=1
-I/builddir/build/BUILD/json-3.10.5/redhat-linux-build/include
-I/builddir/build/BUILD/json-3.10.5/test/thirdparty/doctest
-I/builddir/build/BUILD/json-3.10.5/test/thirdparty/fifo_map
-I/builddir/build/BUILD/json-3.10.5/include -O2 -flto=auto
-ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall
-Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
-Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1
-mbranch-protection=standard -fasynchronous-unwind-tables
-fstack-clash-protection -Wno-deprecated -Wno-float-equal
-Wno-deprecated-declarations -MD -MT
test/CMakeFiles/test-regression1.dir/src/unit-regression1.cpp.o -MF
test/CMakeFiles/test-regression1.dir/src/unit-regression1.cpp.o.d -o
test/CMakeFiles/test-regression1.dir/src/unit-regression1.cpp.o -c
/builddir/build/BUILD/json-3.10.5/test/src/unit-regression1.cpp
/builddir/build/BUILD/json-3.10.5/test/src/unit-regression1.cpp: In
function 'void DOCTEST_ANON_FUNC_2()':
/builddir/build/BUILD/json-3.10.5/test/src/unit-regression1.cpp:392:22:
error: ambiguous overload for 'operator=' (operand types are
'std::string' {aka 'std::__cxx11::basic_string'} and
'nlohmann::basic_json<>::value_type' {aka 'nlohmann::basic_json<>'})
392 | s2 = o["name"];
| ^
In file included from /usr/include/c++/12/string:53,
from /usr/include/c++/12/bits/locale_classes.h:40,
from /usr/include/c++/12/locale:39,
from
/builddir/build/BUILD/json-3.10.5/test/src/unit-regression1.cpp:33:
/usr/include/c++/12/bits/basic_string.h:733:21: note: candidate:
'std::__cxx11::basic_string<_CharT, _Traits, _Alloc>&
std::__cxx11::basic_string<_CharT, _Traits,
_Alloc>::operator=(std::nullptr_t) [with _CharT = char; _Traits =
std::char_traits; _Alloc = std::allocator; std::nullptr_t =
std::nullptr_t]' (deleted)
733 | basic_string& operator=(nullptr_t) = delete;
| ^~~~
/usr/include/c++/12/bits/basic_string.h:801:7: note: candidate:
'std::__cxx11::basic_string<_CharT, _Traits, _Alloc>&
std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::operator=(const
std::__cxx11::basic_string<_CharT, _Traits, _Alloc>&) [with _CharT =
char; _Traits = std::char_traits; _Alloc = std::allocator]'
801 | operator=(const basic_string& __str)
| ^~~~
/usr/include/c++/12/bits/basic_string.h:842:7: note: candidate:
'std::__cxx11::basic_string<_CharT, _Traits, _Alloc>&
std::__cxx11::basic_string<_CharT, _Traits,
_Alloc>::operator=(std::__cxx11::basic_string<_CharT, _Traits,
_Alloc>&&) [with _CharT = char; _Traits = std::char_traits; _Alloc
= std::allocator]'
842 | operator=(basic_string&& __str)
| ^~~~
In file included from
/builddir/build/BUILD/json-3.10.5/test/thirdparty/doctest/doctest_compatibility.h:6,
from
/builddir/build/BUILD/json-3.10.5/test/src/unit-regression1.cpp:30:
/builddir/build/BUILD/json-3.10.5/test/src/unit-regression1.cpp: In
lambda function:
/builddir/build/BUILD/json-3.10.5/test/src/unit-regression1.cpp:398:37:
error: ambiguous overload for 'operator=' (operand types are
'std::string' {aka 'std::__cxx11::basic_string'} and
'nlohmann::basic_json<>::value_type' {aka 'nlohmann::basic_json<>'})
398 | CHECK_THROWS_AS(s2 = o["int"], json::type_error);
--
Sincerely,
Vitaly Zaitsev (vit...@easycoding.org)
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
Re: Review swap
I can take this Can you take https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2041042 in exchange? Thanks Sandro On 15.01.22 14:25, Mattia Verga via devel wrote: Is anyone available for a review swap? I've got https://bugzilla.redhat.com/show_bug.cgi?id=2038675 waiting in the queue, I can offer a review in return (possibly not rust-* or golang-* stuff, where I have little or no knowledge about). Thanks Mattia ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Review swap
Is anyone available for a review swap? I've got https://bugzilla.redhat.com/show_bug.cgi?id=2038675 waiting in the queue, I can offer a review in return (possibly not rust-* or golang-* stuff, where I have little or no knowledge about). Thanks Mattia ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: gcc-12.0.0-0.4.fc36 in rawhide
I (and others) encountered this too. It’s reported here[1], with a fix promised today. [1] https://bugzilla.redhat.com/show_bug.cgi?id=2040825 On Sat, Jan 15, 2022, at 7:06 AM, Vitaly Zaitsev via devel wrote: > On 14/01/2022 15:31, Jakub Jelinek wrote: >> gcc 12 snapshot has landed as the system compiler into rawhide today. > > On ppc64le: > > gcc -c -std=gnu99 -O2 -flto=auto -ffat-lto-objects -fexceptions -g > -grecord-gcc-switches -pipe -Wall -Werror=format-security > -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS > -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong > -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mcpu=power8 > -mtune=power8 -fasynchronous-unwind-tables -fstack-clash-protection > -DNDEBUG -pipe -Iinclude/ -IOpenCL/ -Ideps/LZMA-SDK/C -I/usr/include > -I/usr/include/contrib -I/usr/include -DWITH_BRAIN -I/usr/include > -DWITH_CUBIN -DWITH_HWMON src/affinity.c -o obj/affinity.NATIVE.o -fpic > In file included from /usr/include/CL/cl_platform.h:379, > from /usr/include/CL/cl.h:21, > from include/ext_OpenCL.h:17, > from include/types.h:1095, > from src/affinity.c:7: > /usr/lib/gcc/ppc64le-redhat-linux/12/include/altivec.h:58:10: fatal > error: rs6000-vecdefines.h: No such file or directory > 58 | #include "rs6000-vecdefines.h" >| ^ > compilation terminated. > make: *** [src/Makefile:565: obj/affinity.NATIVE.o] Error 1 > > -- > Sincerely, >Vitaly Zaitsev (vit...@easycoding.org) > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > Do not reply to spam on the list, report it: > https://pagure.io/fedora-infrastructure ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: gcc-12.0.0-0.4.fc36 in rawhide
On Sat, Jan 15, 2022 at 01:06:48PM +0100, Vitaly Zaitsev via devel wrote: > On 14/01/2022 15:31, Jakub Jelinek wrote: > > gcc 12 snapshot has landed as the system compiler into rawhide today. > > On ppc64le: > > gcc -c -std=gnu99 -O2 -flto=auto -ffat-lto-objects -fexceptions -g > -grecord-gcc-switches -pipe -Wall -Werror=format-security > -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS > -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong > -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mcpu=power8 > -mtune=power8 -fasynchronous-unwind-tables -fstack-clash-protection -DNDEBUG > -pipe -Iinclude/ -IOpenCL/ -Ideps/LZMA-SDK/C -I/usr/include > -I/usr/include/contrib -I/usr/include -DWITH_BRAIN -I/usr/include > -DWITH_CUBIN -DWITH_HWMON src/affinity.c -o obj/affinity.NATIVE.o -fpic > In file included from /usr/include/CL/cl_platform.h:379, > from /usr/include/CL/cl.h:21, > from include/ext_OpenCL.h:17, > from include/types.h:1095, > from src/affinity.c:7: > /usr/lib/gcc/ppc64le-redhat-linux/12/include/altivec.h:58:10: fatal error: > rs6000-vecdefines.h: No such file or directory >58 | #include "rs6000-vecdefines.h" > | ^ > compilation terminated. > make: *** [src/Makefile:565: obj/affinity.NATIVE.o] Error 1 That is #2040825 and gcc-12.0.0-0.5.fc36 that should fix it is building in koji for 12 hours already. Jakub ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: gcc-12.0.0-0.4.fc36 in rawhide
On 14/01/2022 15:31, Jakub Jelinek wrote: gcc 12 snapshot has landed as the system compiler into rawhide today. On ppc64le: gcc -c -std=gnu99 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mcpu=power8 -mtune=power8 -fasynchronous-unwind-tables -fstack-clash-protection -DNDEBUG -pipe -Iinclude/ -IOpenCL/ -Ideps/LZMA-SDK/C -I/usr/include -I/usr/include/contrib -I/usr/include -DWITH_BRAIN -I/usr/include -DWITH_CUBIN -DWITH_HWMON src/affinity.c -o obj/affinity.NATIVE.o -fpic In file included from /usr/include/CL/cl_platform.h:379, from /usr/include/CL/cl.h:21, from include/ext_OpenCL.h:17, from include/types.h:1095, from src/affinity.c:7: /usr/lib/gcc/ppc64le-redhat-linux/12/include/altivec.h:58:10: fatal error: rs6000-vecdefines.h: No such file or directory 58 | #include "rs6000-vecdefines.h" | ^ compilation terminated. make: *** [src/Makefile:565: obj/affinity.NATIVE.o] Error 1 -- Sincerely, Vitaly Zaitsev (vit...@easycoding.org) ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Heads-up: trousers (TPM 1.2) silently orphaned
On Sat, Jan 15, 2022 at 4:20 AM Michel Alexandre Salim wrote: > > On Fri, Dec 17, 2021 at 12:35:59PM -0800, Adam Williamson wrote: > > On Fri, 2021-12-17 at 10:35 -0800, Michel Alexandre Salim wrote: > > > On Thu, Dec 16, 2021 at 10:11:53AM -0800, Michel Alexandre Salim wrote: > > > > Hi all, > > > > > > > > `trousers` got silently orphaned around the time an EPEL9 branch for it > > > > was requested: https://bugzilla.redhat.com/show_bug.cgi?id=2032258 > > > > > > > > Looks like we're slowly uncoupling ourselves from it, e.g. > > > > > > > > - for ARM, uboot-tools no longer pulls in vboot-utils which pulls in > > > > trousers: > > > > https://lists.fedoraproject.org/archives/list/scm-comm...@lists.fedoraproject.org/message/JAAC32MNLJMMENVJG7QUSKHGZFABLUHX/ > > > > > > > > - Neal disabled TPM/TSS 1.2 support in strongswan, dropping the trousers > > > > dependency, in > > > > https://src.fedoraproject.org/rpms/strongswan/pull-request/13 > > > > > > > > but there are several dependencies still around (strongswan still shows > > > > up here as the PR just got merged a few hours ago) > > > > > > > I've taken this package for now. > > > > > > It's probably OK for most of the trousers dependent to drop their > > > dependencies on it though, the use case I have in mind is rather > > > specialized. > > > > It does seem to be used by robosignatory (the thing that signs Fedora > > packages, I think): > > Sorry for the late reply! Meant to ask you about this, as I tried and > find what requires trousers before my first post and didn't see > robosignatory at all. I asked Patrick about this last week, it's an old dependency that was never cleaned up. On a previous generation of HW they used to use a TPM1 to store bits used by robosignatory but it was never a direct dependency. That's no longer the case so it can be cleaned up. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: gcc-12.0.0-0.4.fc36 in rawhide
CCing Martin.
On Sat, Jan 15, 2022 at 09:04:35AM +, Richard W.M. Jones wrote:
> There is a new warning in gcc-12.0.0-0.4.fc36.x86_64. In this code:
>
> int
> guestfs_int_create_socketname (guestfs_h *g, const char *filename,
> char (*sockpath)[UNIX_PATH_MAX])
> {
> if (guestfs_int_lazy_make_sockdir (g) == -1)
> return -1;
>
> if (strlen (g->sockdir) + 1 + strlen (filename) > UNIX_PATH_MAX-1) {
> error (g, _("socket path too long: %s/%s"), g->sockdir, filename);
> return -1;
> }
>
> snprintf (*sockpath, UNIX_PATH_MAX, "%s/%s", g->sockdir, filename);
>
> return 0;
> }
>
> [https://github.com/libguestfs/libguestfs/blob/d1e7e1a323619d8f1e913a7833d07009f02a2d33/lib/launch.c#L324]
>
> the new warning is:
>
> launch.c: In function ‘guestfs_int_create_socketname’:
> launch.c:336:43: error: ‘%s’ directive output may be truncated writing up
> to 106 bytes into a region of size between 1 and 107
> [-Werror=format-truncation=]
> 336 | snprintf (*sockpath, UNIX_PATH_MAX, "%s/%s", g->sockdir,
> filename);
> | ^~
> In file included from /usr/include/stdio.h:894,
>from launch.c:30:
> In function ‘snprintf’,
> inlined from ‘guestfs_int_create_socketname’ at launch.c:336:3:
> /usr/include/bits/stdio2.h:71:10: note: ‘__snprintf_chk’ output between 2 and
> 2 14 bytes into a destination of size 108
> 71 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL -
> 1,
> |
> ^~~~
> 72 |__glibc_objsize (__s), __fmt,
> |~
> 73 |__va_arg_pack ());
> |~
> cc1: all warnings being treated as errors
>
> *sockpath is a fixed buffer of size UNIX_PATH_MAX == 108. We check
> that strlen (g->sockdir) + strlen (filename) + 1 (for the '/'
> character) > UNIX_PATH_MAX - 1 (for the terminating '\0').
>
> The check seems correct as far as I can tell. I don't think I'm
> making a fencepost error here. Why does GCC 12 think there should be
> a warning when GCC 11 didn't?
>
> I've attached a standalone test case.
>
> $ gcc -O2 -Wall sp.c -o sp
> sp.c: In function ‘create_sockpath’:
> sp.c:12:43: warning: ‘%s’ directive output may be truncated writing up to
> 106 bytes into a region of size between 1 and 107 [-Wformat-truncation=]
> 12 | snprintf (*sockpath, UNIX_PATH_MAX, "%s/%s", sockdir, filename);
> | ^~
> sp.c:12:3: note: ‘snprintf’ output between 2 and 214 bytes into a
> destination of size 108
> 12 | snprintf (*sockpath, UNIX_PATH_MAX, "%s/%s", sockdir, filename);
> | ^~~
>
> (No warning with gcc-11.2.1-1.fc35.x86_64)
>
> Rich.
>
> --
> Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
> Read my programming and virtualization blog: http://rwmj.wordpress.com
> virt-p2v converts physical machines to virtual machines. Boot with a
> live CD or over the network (PXE) and turn machines into KVM guests.
> http://libguestfs.org/virt-v2v
> /* gcc -O2 -Wall sp.c -o sp */
>
> #include
> #include
> #include
> #include
>
> void
> create_sockpath (const char *sockdir, const char *filename,
> char (*sockpath)[UNIX_PATH_MAX])
> {
> if (strlen (sockdir) + 1 + strlen (filename) > UNIX_PATH_MAX - 1)
> abort ();
> snprintf (*sockpath, UNIX_PATH_MAX, "%s/%s", sockdir, filename);
> }
>
> int
> main (int argc, char *argv[])
> {
> char sockpath[UNIX_PATH_MAX];
>
> if (argc != 3) {
> fprintf (stderr, "%s sockdir filename\n", argv[0]);
> exit (EXIT_FAILURE);
> }
>
> create_sockpath (argv[1], argv[2], &sockpath);
> printf ("sockpath = %s\n", sockpath);
> exit (EXIT_SUCCESS);
> }
Jakub
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
Fedora-Cloud-34-20220115.0 compose check report
No missing expected images. Soft failed openQA tests: 1/8 (x86_64), 1/8 (aarch64) (Tests completed, but using a workaround for a known bug) Old soft failures (same test soft failed in Fedora-Cloud-34-20220114.0): ID: 1105419 Test: x86_64 Cloud_Base-qcow2-qcow2 cloud_autocloud URL: https://openqa.fedoraproject.org/tests/1105419 ID: 1105430 Test: aarch64 Cloud_Base-qcow2-qcow2 cloud_autocloud@uefi URL: https://openqa.fedoraproject.org/tests/1105430 Passed openQA tests: 7/8 (x86_64), 7/8 (aarch64) -- Mail generated by check-compose: https://pagure.io/fedora-qa/check-compose ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: gcc-12.0.0-0.4.fc36 in rawhide
There is a new warning in gcc-12.0.0-0.4.fc36.x86_64. In this code:
int
guestfs_int_create_socketname (guestfs_h *g, const char *filename,
char (*sockpath)[UNIX_PATH_MAX])
{
if (guestfs_int_lazy_make_sockdir (g) == -1)
return -1;
if (strlen (g->sockdir) + 1 + strlen (filename) > UNIX_PATH_MAX-1) {
error (g, _("socket path too long: %s/%s"), g->sockdir, filename);
return -1;
}
snprintf (*sockpath, UNIX_PATH_MAX, "%s/%s", g->sockdir, filename);
return 0;
}
[https://github.com/libguestfs/libguestfs/blob/d1e7e1a323619d8f1e913a7833d07009f02a2d33/lib/launch.c#L324]
the new warning is:
launch.c: In function ‘guestfs_int_create_socketname’:
launch.c:336:43: error: ‘%s’ directive output may be truncated writing up to
106 bytes into a region of size between 1 and 107 [-Werror=format-truncation=]
336 | snprintf (*sockpath, UNIX_PATH_MAX, "%s/%s", g->sockdir, filename);
| ^~
In file included from /usr/include/stdio.h:894,
from launch.c:30:
In function ‘snprintf’,
inlined from ‘guestfs_int_create_socketname’ at launch.c:336:3:
/usr/include/bits/stdio2.h:71:10: note: ‘__snprintf_chk’ output between 2 and 2
14 bytes into a destination of size 108
71 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
| ^~~~
72 |__glibc_objsize (__s), __fmt,
|~
73 |__va_arg_pack ());
|~
cc1: all warnings being treated as errors
*sockpath is a fixed buffer of size UNIX_PATH_MAX == 108. We check
that strlen (g->sockdir) + strlen (filename) + 1 (for the '/'
character) > UNIX_PATH_MAX - 1 (for the terminating '\0').
The check seems correct as far as I can tell. I don't think I'm
making a fencepost error here. Why does GCC 12 think there should be
a warning when GCC 11 didn't?
I've attached a standalone test case.
$ gcc -O2 -Wall sp.c -o sp
sp.c: In function ‘create_sockpath’:
sp.c:12:43: warning: ‘%s’ directive output may be truncated writing up to 106
bytes into a region of size between 1 and 107 [-Wformat-truncation=]
12 | snprintf (*sockpath, UNIX_PATH_MAX, "%s/%s", sockdir, filename);
| ^~
sp.c:12:3: note: ‘snprintf’ output between 2 and 214 bytes into a destination
of size 108
12 | snprintf (*sockpath, UNIX_PATH_MAX, "%s/%s", sockdir, filename);
| ^~~
(No warning with gcc-11.2.1-1.fc35.x86_64)
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v
/* gcc -O2 -Wall sp.c -o sp */
#include
#include
#include
#include
void
create_sockpath (const char *sockdir, const char *filename,
char (*sockpath)[UNIX_PATH_MAX])
{
if (strlen (sockdir) + 1 + strlen (filename) > UNIX_PATH_MAX - 1)
abort ();
snprintf (*sockpath, UNIX_PATH_MAX, "%s/%s", sockdir, filename);
}
int
main (int argc, char *argv[])
{
char sockpath[UNIX_PATH_MAX];
if (argc != 3) {
fprintf (stderr, "%s sockdir filename\n", argv[0]);
exit (EXIT_FAILURE);
}
create_sockpath (argv[1], argv[2], &sockpath);
printf ("sockpath = %s\n", sockpath);
exit (EXIT_SUCCESS);
}
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
Fedora-Cloud-35-20220115.0 compose check report
No missing expected images. Soft failed openQA tests: 1/8 (x86_64), 1/8 (aarch64) (Tests completed, but using a workaround for a known bug) Old soft failures (same test soft failed in Fedora-Cloud-35-20220114.0): ID: 1105403 Test: x86_64 Cloud_Base-qcow2-qcow2 cloud_autocloud URL: https://openqa.fedoraproject.org/tests/1105403 ID: 1105414 Test: aarch64 Cloud_Base-qcow2-qcow2 cloud_autocloud@uefi URL: https://openqa.fedoraproject.org/tests/1105414 Passed openQA tests: 7/8 (x86_64), 7/8 (aarch64) -- Mail generated by check-compose: https://pagure.io/fedora-qa/check-compose ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
