Re: glibc-headers no longer provides xlocale.h in 2.26 (rawhide)?

2017-08-13 Thread Kevin Kofler 
Florian Weimer wrote:
> It's not there if you don't use glibc.

FreeBSD also has an xlocale.h, and the manpage claims Darwin has one too:
https://www.freebsd.org/cgi/man.cgi?query=xlocale=3

Kevin Kofler
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: glibc-headers no longer provides xlocale.h in 2.26 (rawhide)?

2017-08-13 Thread Zbigniew Jędrzejewski-Szmek 
On Sun, Aug 13, 2017 at 09:21:35PM +0200, Florian Weimer wrote:
> On 08/12/2017 04:00 PM, Zbigniew Jędrzejewski-Szmek wrote:
> > On Sat, Aug 12, 2017 at 03:28:15PM +0200, Florian Weimer wrote:
> >> On 08/12/2017 03:22 PM, Richard Shaw wrote:
> >>> During one of the releng rebuilds my package OCE is failing to build[1]
> >>> because it can't find /usr/include/xlocale.h
> >>
> >>> Was this intentional?
> >>
> >> Yes, it used to be installed by accident.  The header itself clearly
> >> said that it was an internal-only header.
> >>
> >> We removed it without a deprecation warning because most programs had
> >> configure checks for  which started to fail after removal,
> >> skipping the #include.
> > 
> > Heh, I just fixed two ftbfs packages with xlocale.h includes, and a bunch
> > more back when glibc 2.25 came out, incl. systemd. From what I've seen,
> > people don't test for xlocale.h because it's "part of glibc, so always 
> > there" ;)
> 
> It's not there if you don't use glibc.
gcc has Requires: glibc-devel...

> Anyway, I was really surprised to learn that systemd sprouted an
> #include .  Looks like that it was introduced in this commit:
> 
> commit 11c3a36649e5e5e77db499c92f3cdcbd619efd3a
> Author: Thomas Hindoe Paaboel Andersen 
> Date:   Mon Nov 30 21:43:37 2015 +0100
> 
> basic: include only what we use
> 
> This is a cleaned up result of running iwyu but without forward
> declarations on src/basic.
> 
> iwyu (“include what you use”,
> )
> apparently produced misleading/incorrect results in this case.  That's
> annoying. I wonder if we can do anything about it.  It doesn't look like
> it can automatically ignore bits/ headers in its edits. 8-(

Sure, it was easy enough to fix when the issue was discovered.
But this is a good example why the issue happens in many packages:
a seemingly-harmless import from a package which is known for
stability and which was already required to be present suddenly
stopped working. No warning was emitted before, and most people don't
look into system header files unless there have some good reason.

Zbyszek
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: glibc-headers no longer provides xlocale.h in 2.26 (rawhide)?

2017-08-13 Thread Florian Weimer 
On 08/12/2017 04:00 PM, Zbigniew Jędrzejewski-Szmek wrote:
> On Sat, Aug 12, 2017 at 03:28:15PM +0200, Florian Weimer wrote:
>> On 08/12/2017 03:22 PM, Richard Shaw wrote:
>>> During one of the releng rebuilds my package OCE is failing to build[1]
>>> because it can't find /usr/include/xlocale.h
>>
>>> Was this intentional?
>>
>> Yes, it used to be installed by accident.  The header itself clearly
>> said that it was an internal-only header.
>>
>> We removed it without a deprecation warning because most programs had
>> configure checks for  which started to fail after removal,
>> skipping the #include.
> 
> Heh, I just fixed two ftbfs packages with xlocale.h includes, and a bunch
> more back when glibc 2.25 came out, incl. systemd. From what I've seen,
> people don't test for xlocale.h because it's "part of glibc, so always there" 
> ;)

It's not there if you don't use glibc.

Anyway, I was really surprised to learn that systemd sprouted an
#include .  Looks like that it was introduced in this commit:

commit 11c3a36649e5e5e77db499c92f3cdcbd619efd3a
Author: Thomas Hindoe Paaboel Andersen 
Date:   Mon Nov 30 21:43:37 2015 +0100

basic: include only what we use

This is a cleaned up result of running iwyu but without forward
declarations on src/basic.

iwyu (“include what you use”,
)
apparently produced misleading/incorrect results in this case.  That's
annoying. I wonder if we can do anything about it.  It doesn't look like
it can automatically ignore bits/ headers in its edits. 8-(

Thanks,
Florian
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: glibc-headers no longer provides xlocale.h in 2.26 (rawhide)?

2017-08-13 Thread Zbigniew Jędrzejewski-Szmek 
On Sun, Aug 13, 2017 at 07:07:31AM -0500, Richard Shaw wrote:
> On Sun, Aug 13, 2017 at 3:52 AM, Antonio Trande 
> wrote:
> 
> >
> > Will 'xlocale.h' be provided newly in 'glibc'?
> > To fix this problem, i set 'xlocale.h' from 'libcxx-devel' package:
> > https://src.fedoraproject.org/rpms/icecat/c/153d3b4c3df56eb1330c0530220fd3
> > 882501028a?branch=master
> 
> 
> I saw that libcxx-devel provided the file as well but I didn't investigate
> further to see if was appropriate to use...
> 
> Looking at the case of OCE is assumes it's available on OSX and Linux,
> doesn't look like it's absolutely required so I'm patching around it for
> now.

Did you try to:
1. just remove the xlocale.h include (usually this just works)
2. replace it with locale.h include
?

xlocale.h is usually included for locale_t, and locale.h provides that.

Zbyszek
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: glibc-headers no longer provides xlocale.h in 2.26 (rawhide)?

2017-08-13 Thread Richard Shaw 
On Sun, Aug 13, 2017 at 3:52 AM, Antonio Trande 
wrote:

>
> Will 'xlocale.h' be provided newly in 'glibc'?
> To fix this problem, i set 'xlocale.h' from 'libcxx-devel' package:
> https://src.fedoraproject.org/rpms/icecat/c/153d3b4c3df56eb1330c0530220fd3
> 882501028a?branch=master


I saw that libcxx-devel provided the file as well but I didn't investigate
further to see if was appropriate to use...

Looking at the case of OCE is assumes it's available on OSX and Linux,
doesn't look like it's absolutely required so I'm patching around it for
now.

Thanks,
Richard
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: glibc-headers no longer provides xlocale.h in 2.26 (rawhide)?

2017-08-13 Thread Antonio Trande 
On 08/13/2017 01:20 AM, Sérgio Basto wrote:
> On Sat, 2017-08-12 at 14:00 +, Zbigniew Jędrzejewski-Szmek wrote:
>> On Sat, Aug 12, 2017 at 03:28:15PM +0200, Florian Weimer wrote:
>>> On 08/12/2017 03:22 PM, Richard Shaw wrote:
 During one of the releng rebuilds my package OCE is failing to
 build[1]
 because it can't find /usr/include/xlocale.h
 Was this intentional?
>>>
>>> Yes, it used to be installed by accident.  The header itself
>>> clearly
>>> said that it was an internal-only header.
>>>
>>> We removed it without a deprecation warning because most programs
>>> had
>>> configure checks for  which started to fail after
>>> removal,
>>> skipping the #include.
>>
>> Heh, I just fixed two ftbfs packages with xlocale.h includes, and a
>> bunch
>> more back when glibc 2.25 came out, incl. systemd. From what I've
>> seen,
>> people don't test for xlocale.h because it's "part of glibc, so
>> always there" ;)
>>
>> Zbyszek
> 
> Thank you Zbyszek for taking care of mlt.
> Richard the mlt fix is here [1].
> [1] 
> https://src.fedoraproject.org/rpms/mlt/c/7ec11616fd9f88c0e1d6f44ec88a4c
> 435e36044f?branch=master
> 

Will 'xlocale.h' be provided newly in 'glibc'?
To fix this problem, i set 'xlocale.h' from 'libcxx-devel' package:
https://src.fedoraproject.org/rpms/icecat/c/153d3b4c3df56eb1330c0530220fd3882501028a?branch=master

-- 
--
Antonio Trande
sagitter AT fedoraproject dot org
See my vCard.
<>

signature.asc
Description: OpenPGP digital signature
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: glibc-headers no longer provides xlocale.h in 2.26 (rawhide)?

2017-08-12 Thread Sérgio Basto 
On Sat, 2017-08-12 at 14:00 +, Zbigniew Jędrzejewski-Szmek wrote:
> On Sat, Aug 12, 2017 at 03:28:15PM +0200, Florian Weimer wrote:
> > On 08/12/2017 03:22 PM, Richard Shaw wrote:
> > > During one of the releng rebuilds my package OCE is failing to
> > > build[1]
> > > because it can't find /usr/include/xlocale.h
> > > Was this intentional?
> > 
> > Yes, it used to be installed by accident.  The header itself
> > clearly
> > said that it was an internal-only header.
> > 
> > We removed it without a deprecation warning because most programs
> > had
> > configure checks for  which started to fail after
> > removal,
> > skipping the #include.
> 
> Heh, I just fixed two ftbfs packages with xlocale.h includes, and a
> bunch
> more back when glibc 2.25 came out, incl. systemd. From what I've
> seen,
> people don't test for xlocale.h because it's "part of glibc, so
> always there" ;)
> 
> Zbyszek

Thank you Zbyszek for taking care of mlt.
Richard the mlt fix is here [1].
[1] 
https://src.fedoraproject.org/rpms/mlt/c/7ec11616fd9f88c0e1d6f44ec88a4c
435e36044f?branch=master

> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
-- 
Sérgio M. B.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: glibc-headers no longer provides xlocale.h in 2.26 (rawhide)?

2017-08-12 Thread Zbigniew Jędrzejewski-Szmek 
On Sat, Aug 12, 2017 at 03:28:15PM +0200, Florian Weimer wrote:
> On 08/12/2017 03:22 PM, Richard Shaw wrote:
> > During one of the releng rebuilds my package OCE is failing to build[1]
> > because it can't find /usr/include/xlocale.h
> 
> > Was this intentional?
> 
> Yes, it used to be installed by accident.  The header itself clearly
> said that it was an internal-only header.
> 
> We removed it without a deprecation warning because most programs had
> configure checks for  which started to fail after removal,
> skipping the #include.

Heh, I just fixed two ftbfs packages with xlocale.h includes, and a bunch
more back when glibc 2.25 came out, incl. systemd. From what I've seen,
people don't test for xlocale.h because it's "part of glibc, so always there" ;)

Zbyszek
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: glibc-headers no longer provides xlocale.h in 2.26 (rawhide)?

2017-08-12 Thread Florian Weimer 
On 08/12/2017 03:22 PM, Richard Shaw wrote:
> During one of the releng rebuilds my package OCE is failing to build[1]
> because it can't find /usr/include/xlocale.h

> Was this intentional?

Yes, it used to be installed by accident.  The header itself clearly
said that it was an internal-only header.

We removed it without a deprecation warning because most programs had
configure checks for  which started to fail after removal,
skipping the #include.

Thanks,
Florian
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

glibc-headers no longer provides xlocale.h in 2.26 (rawhide)?

2017-08-12 Thread Richard Shaw 
During one of the releng rebuilds my package OCE is failing to build[1]
because it can't find /usr/include/xlocale.h

In both Fedora 24/25 it is provided by the glibc-headers package but it
seems to have been dropped in 2.26 in rawhide.

# dnf repoquery --whatprovides /usr/include/xlocale.h
Fedora 26 - x86_64 - Updates
 5.2 MB/s |  10 MB 00:01
Fedora 26 - x86_64
 6.5 MB/s |  53 MB 00:08
Last metadata expiration check: 0:00:03 ago on Sat Aug 12 13:18:38 2017.
glibc-headers-0:2.25-6.fc26.i686
glibc-headers-0:2.25-6.fc26.x86_64
glibc-headers-0:2.25-7.fc26.i686
glibc-headers-0:2.25-7.fc26.x86_64

(Rawhide)
# dnf repoquery --whatprovides /usr/include/xlocale.h
Last metadata expiration check: 0:14:04 ago on Sat Aug 12 13:05:37 2017.

Was this intentional?

Thanks,
Richard

[1] https://kojipkgs.fedoraproject.org//work/tasks/3501/20973501/build.log
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org