This second review takes differs from the previous one with:
* use common.py instead of _common.py
* initialization of the topology. This has been widely rewritten from
previous review in order to run whatever it exists or not instance
(started or not) and exists backups.
On 11/15/2013 04:16 PM, Roberto Polli wrote:
On Friday 15 November 2013 15:18:26 thierry bordaz wrote:
https://fedorahosted.org/389/attachment/ticket/47586/0001-Ticket-47586-CI-te
sts-test-case-for-47490.patch
1- I'd replace the following:
-from lib389._constants import DN_DM
+from lib389
https://fedorahosted.org/389/attachment/ticket/47586/0001-Ticket-47586-CI-tests-test-case-for-47490.patch
--
389-devel mailing list
389-de...@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel
On Friday 15 November 2013 15:18:26 thierry bordaz wrote:
https://fedorahosted.org/389/attachment/ticket/47586/0001-Ticket-47586-CI-te
sts-test-case-for-47490.patch
1- I'd replace the following:
-from lib389._constants import DN_DM
+from lib389 import DN_DM
Files starting with _ are private
