Re: Ancient compilation flags in my pkg - still needed ?
On Thursday, November 30, 2023 5:47:57 AM EST Michal Schorm wrote: > I have this line in the SPECfile of 'mariadb' package: > > CFLAGS="$CFLAGS -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE" > > I read through these macros explanations: > > https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.htm > > l however as I do not navigate well in the problematic, I haven't > understood much. > My question is primarily, whether during the last 20 years something > happened, making the line obsolete (e.g. these macros are no longer > relevant, or they were added to the default build flags, ... ) You might want to check if _GNU_SOURCE has been moved into the right Makefile.am files. Way back when, it may not have occurred to the developers to only use them for the compilation units that need them. If not, then keep it. As for the others, they are to support gigantic files. It might have occurred to the developers to formalize this by adding an option in configure.ac. If they didn't, you may still need these to not regress when gigantic file support is needed. I'd say, upstream should put all of these in the right places so that you do not pass them this way. -Steve -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: Ancient compilation flags in my pkg - still needed ?
Hi, On Thu, Nov 30, 2023 at 11:50 AM Michal Schorm wrote: > > I have this line in the SPECfile of 'mariadb' package: > > CFLAGS="$CFLAGS -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE" These are the necessary flags to support large (> 4 GB) files on 32bit systems, any modern code would already define these already. You should look into the build system for mariadb and confirm this, and then you can remove the flags. Regards, Ismail -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: Ancient compilation flags in my pkg - still needed ?
Your reflection will make me a better engineer Thank you Em qui., 30 de nov. de 2023 às 08:19, Michal Schorm escreveu: > On Thu, Nov 30, 2023 at 11:53 AM Priscila Gutierres > wrote: > > When reading your email I thought about this video > > https://youtu.be/U4ALzqqUIS8?si=_D5seS8Nu_0fxYdO > > Yeah, on point :) > > But as long as I get commit messages explaining *what* has been done > (which is obvious from the code), instead of *why* it was done, I'm > more of an archeologist, than a software engineer. > If people would write *useful* commit messages, I wouldn't need to ask > such questions. > > Michal > > -- > > Michal Schorm > Software Engineer > Core Services - Databases Team > Red Hat > > -- > > On Thu, Nov 30, 2023 at 11:53 AM Priscila Gutierres > wrote: > > > > When reading your email I thought about this video > > > > https://youtu.be/U4ALzqqUIS8?si=_D5seS8Nu_0fxYdO > > > > > > Em qui., 30 de nov. de 2023 às 07:50, Michal Schorm > escreveu: > >> > >> I have this line in the SPECfile of 'mariadb' package: > >> > >> CFLAGS="$CFLAGS -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 > -D_LARGEFILE_SOURCE" > >> > >> Git blame says this line will soon celebrate 20 years: > >> > https://src.fedoraproject.org/rpms/mysql/c/b3810a49b3125662999f444810efd0fd3223612b?branch=rawhide > >> > https://src.fedoraproject.org/rpms/mysql/c/45466935f338593601cf8653b582dce92752152f?branch=rawhide > >> > >> As I'm not very good at baking cakes, I'm researching the possibility > >> of removing the line instead. > >> > >> I read through these macros explanations: > >> > https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html > >> however as I do not navigate well in the problematic, I haven't > understood much. > >> > >> My question is primarily, whether during the last 20 years something > >> happened, making the line obsolete (e.g. these macros are no longer > >> relevant, or they were added to the default build flags, ... ) > >> > >> Michal > >> > >> -- > >> > >> Michal Schorm > >> Software Engineer > >> Core Services - Databases Team > >> Red Hat > >> > >> -- > >> -- > >> ___ > >> devel mailing list -- devel@lists.fedoraproject.org > >> To unsubscribe send an email to devel-le...@lists.fedoraproject.org > >> Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > >> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > >> List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > >> Do not reply to spam, report it: > https://pagure.io/fedora-infrastructure/new_issue > > > > -- > > ___ > > devel mailing list -- devel@lists.fedoraproject.org > > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > > Do not reply to spam, report it: > https://pagure.io/fedora-infrastructure/new_issue > -- > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > Do not reply to spam, report it: > https://pagure.io/fedora-infrastructure/new_issue > -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: Ancient compilation flags in my pkg - still needed ?
On Thu, Nov 30, 2023 at 11:53 AM Priscila Gutierres wrote: > When reading your email I thought about this video > https://youtu.be/U4ALzqqUIS8?si=_D5seS8Nu_0fxYdO Yeah, on point :) But as long as I get commit messages explaining *what* has been done (which is obvious from the code), instead of *why* it was done, I'm more of an archeologist, than a software engineer. If people would write *useful* commit messages, I wouldn't need to ask such questions. Michal -- Michal Schorm Software Engineer Core Services - Databases Team Red Hat -- On Thu, Nov 30, 2023 at 11:53 AM Priscila Gutierres wrote: > > When reading your email I thought about this video > > https://youtu.be/U4ALzqqUIS8?si=_D5seS8Nu_0fxYdO > > > Em qui., 30 de nov. de 2023 às 07:50, Michal Schorm > escreveu: >> >> I have this line in the SPECfile of 'mariadb' package: >> >> CFLAGS="$CFLAGS -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE" >> >> Git blame says this line will soon celebrate 20 years: >> https://src.fedoraproject.org/rpms/mysql/c/b3810a49b3125662999f444810efd0fd3223612b?branch=rawhide >> https://src.fedoraproject.org/rpms/mysql/c/45466935f338593601cf8653b582dce92752152f?branch=rawhide >> >> As I'm not very good at baking cakes, I'm researching the possibility >> of removing the line instead. >> >> I read through these macros explanations: >> https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html >> however as I do not navigate well in the problematic, I haven't understood >> much. >> >> My question is primarily, whether during the last 20 years something >> happened, making the line obsolete (e.g. these macros are no longer >> relevant, or they were added to the default build flags, ... ) >> >> Michal >> >> -- >> >> Michal Schorm >> Software Engineer >> Core Services - Databases Team >> Red Hat >> >> -- >> -- >> ___ >> devel mailing list -- devel@lists.fedoraproject.org >> To unsubscribe send an email to devel-le...@lists.fedoraproject.org >> Fedora Code of Conduct: >> https://docs.fedoraproject.org/en-US/project/code-of-conduct/ >> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines >> List Archives: >> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org >> Do not reply to spam, report it: >> https://pagure.io/fedora-infrastructure/new_issue > > -- > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > Do not reply to spam, report it: > https://pagure.io/fedora-infrastructure/new_issue -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: Ancient compilation flags in my pkg - still needed ?
When reading your email I thought about this video https://youtu.be/U4ALzqqUIS8?si=_D5seS8Nu_0fxYdO Em qui., 30 de nov. de 2023 às 07:50, Michal Schorm escreveu: > I have this line in the SPECfile of 'mariadb' package: > > CFLAGS="$CFLAGS -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE" > > Git blame says this line will soon celebrate 20 years: > > https://src.fedoraproject.org/rpms/mysql/c/b3810a49b3125662999f444810efd0fd3223612b?branch=rawhide > > https://src.fedoraproject.org/rpms/mysql/c/45466935f338593601cf8653b582dce92752152f?branch=rawhide > > As I'm not very good at baking cakes, I'm researching the possibility > of removing the line instead. > > I read through these macros explanations: > > https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html > however as I do not navigate well in the problematic, I haven't understood > much. > > My question is primarily, whether during the last 20 years something > happened, making the line obsolete (e.g. these macros are no longer > relevant, or they were added to the default build flags, ... ) > > Michal > > -- > > Michal Schorm > Software Engineer > Core Services - Databases Team > Red Hat > > -- > -- > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > Do not reply to spam, report it: > https://pagure.io/fedora-infrastructure/new_issue > -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Ancient compilation flags in my pkg - still needed ?
I have this line in the SPECfile of 'mariadb' package: CFLAGS="$CFLAGS -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE" Git blame says this line will soon celebrate 20 years: https://src.fedoraproject.org/rpms/mysql/c/b3810a49b3125662999f444810efd0fd3223612b?branch=rawhide https://src.fedoraproject.org/rpms/mysql/c/45466935f338593601cf8653b582dce92752152f?branch=rawhide As I'm not very good at baking cakes, I'm researching the possibility of removing the line instead. I read through these macros explanations: https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html however as I do not navigate well in the problematic, I haven't understood much. My question is primarily, whether during the last 20 years something happened, making the line obsolete (e.g. these macros are no longer relevant, or they were added to the default build flags, ... ) Michal -- Michal Schorm Software Engineer Core Services - Databases Team Red Hat -- -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
