Re: Clean up your spec files

Dne 8.2.2018 v 16:03 Kamil Dudka napsal(a): > There might be valid reasons for the old stuff appearing in _some_ spec files > beyond your knowledge, for example specfile maintained by upstream, usable not > only by Fedora. AFAIK all mentioned parts are not needed in Fedora and all supported RHELs.

Re: Clean up your spec files

On Fri, Feb 9, 2018 at 4:08 AM, Panu Matilainen wrote: > On 02/08/2018 04:53 PM, Neal Gompa wrote: >> >> On Thu, Feb 8, 2018 at 9:49 AM, Brett Lentz wrote: >>> >>> On 08/02/18 14:09 +0100, Miroslav Suchý wrote: * rm -rf $RPM_BUILD_ROOT >>> >>> rpmdev-newspec still inserts

Re: Clean up your spec files

Chenxiong Qi wrote: > On Thu, Feb 8, 2018 at 9:09 PM, Miroslav Suchý wrote: >> * rm -rf $RPM_BUILD_ROOT >> >> In the past, it was necessary to clean the buildroot at >> the beginning of %install and the end of %clean. This is >> no longer true and not needed since F12. > > Not needed in EL6 as we

Re: Clean up your spec files

On Thu, Feb 8, 2018 at 9:09 PM, Miroslav Suchý wrote: > Hi, > I am sometimes reviewing spec files and I very often see common mistakes. I > mean in packages which are already in > Fedora. For a long time and they have some dust from past times. > > I am not going to file bug reports as those are

Re: Clean up your spec files

On 02/08/2018 04:53 PM, Neal Gompa wrote: On Thu, Feb 8, 2018 at 9:49 AM, Brett Lentz wrote: On 08/02/18 14:09 +0100, Miroslav Suchý wrote: * rm -rf $RPM_BUILD_ROOT rpmdev-newspec still inserts this. It may be worthwhile to file a bug to get it to stop. The only reason I haven't droppe

Re: Clean up your spec files

On Thu, Feb 08, 2018 at 09:53:01AM -0500, Neal Gompa wrote: > The only reason I haven't dropped it yet is because SLE 11 still is > supported, and it requires it. > I could see into adding some magic into removing it when newer rpm is > detected, but I'm not sure it's worth it for a single line. I

Re: Clean up your spec files

On 8 February 2018 at 15:39, Kamil Dudka wrote: [..] > For example logrotate upstream maintains a spec file that is regularly > updated > and CI-tested by Travis: > > https://github.com/logrotate/logrotate/commits/master/logrotate.spec.in OK. Please compare what is one that URL with https://src

Re: Clean up your spec files

On Thu, Feb 08, 2018 at 11:05:38AM -0500, Neal Gompa wrote: > On Thu, Feb 8, 2018 at 10:45 AM, Vít Ondruch wrote: > > https://fedoraproject.org/wiki/Packaging:Guidelines#Spec_Maintenance_and_Canonicity > > > > Not saying it contradicts the guideline above, just FYI. > > > > In practice, there are

Re: Clean up your spec files

On Thu, Feb 8, 2018 at 9:53 AM, Neal Gompa wrote: > On Thu, Feb 8, 2018 at 9:49 AM, Brett Lentz wrote: >> On 08/02/18 14:09 +0100, Miroslav Suchý wrote: >>> >>> >>> * rm -rf $RPM_BUILD_ROOT >>> >> >> rpmdev-newspec still inserts this. It may be worthwhile to file a bug to get >> it to stop. >> >

Re: Clean up your spec files

On Thu, Feb 8, 2018 at 10:45 AM, Vít Ondruch wrote: > > > Dne 8.2.2018 v 16:39 Kamil Dudka napsal(a): >> On Thursday, February 8, 2018 4:21:53 PM CET Tomasz Kłoczko wrote: >>> On 8 February 2018 at 15:03, Kamil Dudka wrote: >>> [..] >>> There might be valid reasons for the old stuff appearin

Re: Clean up your spec files

Dne 8.2.2018 v 16:39 Kamil Dudka napsal(a): > On Thursday, February 8, 2018 4:21:53 PM CET Tomasz Kłoczko wrote: >> On 8 February 2018 at 15:03, Kamil Dudka wrote: >> [..] >> >>> There might be valid reasons for the old stuff appearing in _some_ spec >>> files >>> beyond your knowledge, for exam

Re: Clean up your spec files

Tomasz Kłoczko wrote: > On 8 February 2018 at 15:03, Kamil Dudka > wrote: > [..]  > > There might be valid reasons for the old stuff appearing in _some_ > spec files > beyond your knowledge, for example specfile maintained by upstream, > usable not >

Re: Clean up your spec files

On Thursday, February 8, 2018 4:21:53 PM CET Tomasz Kłoczko wrote: > On 8 February 2018 at 15:03, Kamil Dudka wrote: > [..] > > > There might be valid reasons for the old stuff appearing in _some_ spec > > files > > beyond your knowledge, for example specfile maintained by upstream, usable > > no

Re: Clean up your spec files

On 8 February 2018 at 15:03, Kamil Dudka wrote: [..] > There might be valid reasons for the old stuff appearing in _some_ spec > files > beyond your knowledge, for example specfile maintained by upstream, usable > not > only by Fedora. > Theoretically you may be right. In practice .. nope. Ther

Re: Clean up your spec files

On Thursday, February 8, 2018 2:09:07 PM CET Miroslav Suchý wrote: > Hi, > I am sometimes reviewing spec files and I very often see common mistakes. The issues you are mentioning below hardly classify as mistakes in my view. > I mean in packages which are already in > Fedora. For a long time and

Re: Clean up your spec files

On Thu, Feb 8, 2018 at 9:49 AM, Brett Lentz wrote: > On 08/02/18 14:09 +0100, Miroslav Suchý wrote: >> >> >> * rm -rf $RPM_BUILD_ROOT >> > > rpmdev-newspec still inserts this. It may be worthwhile to file a bug to get > it to stop. > The only reason I haven't dropped it yet is because SLE 11 stil

Re: Clean up your spec files

On 08/02/18 14:09 +0100, Miroslav Suchý wrote: * rm -rf $RPM_BUILD_ROOT rpmdev-newspec still inserts this. It may be worthwhile to file a bug to get it to stop. ---Brett. signature.asc Description: PGP signature ___ devel mailing list -- devel@l

Re: Clean up your spec files

Miroslav thank you for the hints, I will check my packages, but I think Igor Gnatenko already removed such stuff because he made a quick review of them. I would also say that we should increase the usage of *comments* in spec files because they are very useful for new packagers

Clean up your spec files

Hi, I am sometimes reviewing spec files and I very often see common mistakes. I mean in packages which are already in Fedora. For a long time and they have some dust from past times. I am not going to file bug reports as those are not bugs. I will just point it here and leave it up to you to che