Re: Consistent CI Messages
On 08/23/2018 04:21 PM, Neal Gompa wrote: > On Thu, Aug 23, 2018 at 4:18 PM Randy Barlow > wrote: >> >> On 08/23/2018 01:34 PM, Adam Williamson wrote: >>> >>> OUTPUT: "late December" >> >> What about >> >> >> OUTPUT: "late January" >> >> OUTPUT: "late February" > > Also don't forget > > > OUTPUT: "late March" > I'm glad we're all on the same page here, expect it by May of next year! -- Jeremy Cline XMPP: jer...@jcline.org IRC: jcline ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/EEPFPHII3KYRK2N3AQLSSDEYYW2R7SXB/
Re: Consistent CI Messages
On Thu, 2018-08-23 at 20:32 +0100, Richard W.M. Jones wrote: > On Tue, Aug 21, 2018 at 12:50:57PM +0200, Petr Šplíchal wrote: > > Hi, > > > > as part of bringing upstream and downstream workflows related to > > testing one more step closer together and allow easier automation > > tools development and sharing between Fedora, Red Hat Enterprise > > Linux and other products, the CI team is proposing to use a > > consistent format for the CI related messages: > > > > https://pagure.io/fedora-ci/messages > > > > The specification (currently describing koji-build and brew-build > > messages) is written in self-documented YAML files defining a > > JSON SCHEMA which can be used to validate the message format. > > Included is also a set of example messages to get a quick start. > > > > Please, review the proposed format and share your feedback. > > It was really clear if this refers to emails or some other kind of > message. In any case I'd be more than happy if you just fixed the > subject lines of emails. Attached is my previous rant on this topic > for reference :-) It's about message bus messages. For Fedora, fedmsg messages. -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/U3NQDTYNEG5X6FENZMZGCRKFFB4QHVQE/
Re: Consistent CI Messages
On Thu, Aug 23, 2018 at 4:18 PM Randy Barlow wrote: > > On 08/23/2018 01:34 PM, Adam Williamson wrote: > > > > OUTPUT: "late December" > > What about > > > OUTPUT: "late January" > > OUTPUT: "late February" Also don't forget OUTPUT: "late March" -- 真実はいつも一つ！/ Always, there's only one truth! ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/NAIRN65FH4IMAGZUC3VPMYKK6PBBUIWO/
Re: Consistent CI Messages
On 08/23/2018 01:34 PM, Adam Williamson wrote: > > OUTPUT: "late December" What about OUTPUT: "late January" OUTPUT: "late February" ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/ZKKGUIV46NCZM2JBL6YBFMQW5TB4EBWC/
Re: Consistent CI Messages
On Tue, Aug 21, 2018 at 12:50:57PM +0200, Petr Šplíchal wrote: > Hi, > > as part of bringing upstream and downstream workflows related to > testing one more step closer together and allow easier automation > tools development and sharing between Fedora, Red Hat Enterprise > Linux and other products, the CI team is proposing to use a > consistent format for the CI related messages: > > https://pagure.io/fedora-ci/messages > > The specification (currently describing koji-build and brew-build > messages) is written in self-documented YAML files defining a > JSON SCHEMA which can be used to validate the message format. > Included is also a set of example messages to get a quick start. > > Please, review the proposed format and share your feedback. It was really clear if this refers to emails or some other kind of message. In any case I'd be more than happy if you just fixed the subject lines of emails. Attached is my previous rant on this topic for reference :-) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v --- Begin Message --- Here are a small collection of subject lines of emails sent automatically to me by various Fedora systems in the past few days: Subject: upgradepath PASSED for FEDORA-2015-850e89be8b Subject: [Fedora Update] [comment] auto-buildrequires-1.2-1.fc23 Subject: rjones's libguestfs-1.33.1-2.fc24 completed Subject: rpmlint PASSED for libguestfs-1.33.1-2.fc24 Subject: Broken dependencies: libguestfs Subject: ABRT report for package gnome-boxes has reached 10 occurrences Subject: [Bug 1269975] svirt very occasionally prevents parallel libvirt [..] Subject: Fedora 'packager' sponsor needed for suanand Subject: sailer's mingw-sqlite-3.10.1.0-1.fc24 failed to build Subject: libguestfs's builds are back to normal in f24 Subject: dchen pushed to ocaml-lwt (el6). "New upstream version 2.2.0." The only consistent thing is there's nothing consistent about them :-/ I'd like to propose a very lightweight "standard" for subject lines of emails. (1) The first word should be the package name which the email concerns. If the email is not about a package, but about a person, then the first word should be the FAS username of that person. (2) The second word should be the status, reflecting what the reader needs to know or do, for example "succeeded", "failed", "submitted". That's it! The above subject lines might become (chopped to 72 characters to simulate what you might see in a text-based email reader): Subject: auto-buildrequires passed: upgradepath FEDORA-2015-850e89be8b Subject: auto-buildrequires submitted: auto-buildrequires-1.2-1.fc23 Subject: libguestfs completed: rjones's libguestfs-1.33.1-2.fc24 build c Subject: libguestfs passed: rpmlint libguestfs-1.33.1-2.fc24 Subject: libguestfs failed: Broken dependencies found in package libgues Subject: gnome-boxes failed: ABRT report for package gnome-boxes has rea Subject: selinux-policy comment: [Bug 1269975] svirt very occasionally p Subject: suanand requested: Fedora 'packager' sponsor needed for suanand Subject: mingw-sqlite failed: sailer's mingw-sqlite-3.10.1.0-1.fc24 fail Subject: libguestfs passed: libguestfs's builds are back to normal in f2 Subject: ocaml-lwt pushed: dchen pushed to ocaml-lwt (el6). "New upstre Maybe you have some better ideas? A related topic is headers, which could be used for filtering. Various systems add headers -- see examples below -- but again there's not much consistency and the headers aren't particularly useful for filtering. Rich. X-Fedmsg-Topic: org.fedoraproject.prod.taskotron.result.new X-Fedmsg-Category: taskotron X-Fedmsg-Package: libguestfs X-Bodhi-Update-Builds: auto-buildrequires-1.2-1.fc23 X-Bodhi-Update-Pushed: True X-Bodhi-Update-Type: enhancement X-Bodhi-Update-Release: F23 X-Bodhi-Update-Status: testing X-Bodhi-Update-Request: stable X-Bodhi-Update-Submitter: rjones X-Bodhi-Update-Title: auto-buildrequires-1.2-1.fc23 X-Bodhi: fedoraproject.org -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html --- End Message --- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/RKMAEHQ5PZNDK2PLUHIEYHT6E3XEILPF/
Re: Consistent CI Messages
On Thu, 2018-08-23 at 15:45 +, Jeremy Cline wrote: > On 08/23/2018 10:57 AM, Petr Šplíchal wrote: > > On Tue, 21 Aug 2018 at 15:22, Jeremy Cline wrote: > > > > > * URLs can be of type "uri" and JSON schema will enforce that. > > > > That for the hint. I've updated schemas to specify format as well > > (simply using uri as type did not work): > > https://pagure.io/fedora-ci/messages/c/c0cdee9 > > Unfortunately it seems "python-jsonschema" does not enforce this. > > > > Ah, that's good to know. > > > > I'm curious, are you aware of https://fedora-messaging.readthedocs.io/ > > > and generally the plan for Fedora infrastructure to move to AMQP? > > > fedora-messaging uses JSON schema as well and enforces the schema when > > > sending or receiving. > > > > Didn't know that. Thanks for the pointer! Will have a look. Do you > > know what's the time frame when the migration should happen? > > There's a broker cluster in stg now, and bridges for the ZMQ publishers > and subscribers will be set up in the next week or two. Once all the > issues discovered there are fixed up we'll set up a production cluster > and applications can start to migrate. Optimistically, I'd say > mid-September? QA TIME ESTIMATE CONVERSION START> INPUT: "mid-September" "late October" "early November" "late November" OUTPUT: "late December" QA TIME ESTIMATE CONVERSION END> :P -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/4KPTLKSSTVZS4LHL66XF2YBZOA76JT22/
Re: Consistent CI Messages
On 08/23/2018 10:57 AM, Petr Šplíchal wrote: > On Tue, 21 Aug 2018 at 15:22, Jeremy Cline wrote: > >> * URLs can be of type "uri" and JSON schema will enforce that. > > That for the hint. I've updated schemas to specify format as well > (simply using uri as type did not work): > https://pagure.io/fedora-ci/messages/c/c0cdee9 > Unfortunately it seems "python-jsonschema" does not enforce this. > Ah, that's good to know. >> I'm curious, are you aware of https://fedora-messaging.readthedocs.io/ >> and generally the plan for Fedora infrastructure to move to AMQP? >> fedora-messaging uses JSON schema as well and enforces the schema when >> sending or receiving. > > Didn't know that. Thanks for the pointer! Will have a look. Do you > know what's the time frame when the migration should happen? There's a broker cluster in stg now, and bridges for the ZMQ publishers and subscribers will be set up in the next week or two. Once all the issues discovered there are fixed up we'll set up a production cluster and applications can start to migrate. Optimistically, I'd say mid-September? -- Jeremy Cline XMPP: jer...@jcline.org IRC: jcline ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/5PIOGGC5OW6ZREF4RECKUD4KW4GHNDKN/
Re: Consistent CI Messages
On Tue, 21 Aug 2018 at 15:22, Jeremy Cline wrote: > > Hi Petr, > > On 08/21/2018 11:50 AM, Petr Šplíchal wrote: > > Hi, > > > > as part of bringing upstream and downstream workflows related to > > testing one more step closer together and allow easier automation > > tools development and sharing between Fedora, Red Hat Enterprise > > Linux and other products, the CI team is proposing to use a > > consistent format for the CI related messages: > > > > https://pagure.io/fedora-ci/messages > > > > The specification (currently describing koji-build and brew-build > > messages) is written in self-documented YAML files defining a > > JSON SCHEMA which can be used to validate the message format. > > Included is also a set of example messages to get a quick start. > > > > Please, review the proposed format and share your feedback. > > Thanks! > > I've only skimmed the format and I don't work on anything that consumes > these messages, so I can't provide great feedback on that. A couple of > quick notes on the schema itself, though: Thanks for the review, Jeremy. > * "generated_at" is in a human-readable format, but doesn't include the > timezone (UTC). It would be nice to include that, or use a machine- > readable format and keep it documented as being UTC. You should also > be able to enforce this with JSON schema's "date-time" type if you > opt to go the human-readable route. Yes, this is expected to be UTC as defined by the spec here: https://pagure.io/fedora-ci/messages/blob/master/f/schemas/common.yaml#_20 Also the description suggests using the ISO format so I guess we should be set here. > * URLs can be of type "uri" and JSON schema will enforce that. That for the hint. I've updated schemas to specify format as well (simply using uri as type did not work): https://pagure.io/fedora-ci/messages/c/c0cdee9 Unfortunately it seems "python-jsonschema" does not enforce this. > I'm curious, are you aware of https://fedora-messaging.readthedocs.io/ > and generally the plan for Fedora infrastructure to move to AMQP? > fedora-messaging uses JSON schema as well and enforces the schema when > sending or receiving. Didn't know that. Thanks for the pointer! Will have a look. Do you know what's the time frame when the migration should happen? psss... > > > -- > Jeremy Cline > XMPP: jer...@jcline.org > IRC: jcline ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/APFPP6LKQSQGVA2TMGXWMM2CQSYFVTE7/
Re: Consistent CI Messages
On Tue, 2018-08-21 at 14:10 -0700, Adam Williamson wrote: > On Tue, 2018-08-21 at 14:18 -0600, Ken Dreyer wrote: > > On Tue, Aug 21, 2018 at 4:50 AM, Petr Šplíchal wrote: > > > Hi, > > > > > > as part of bringing upstream and downstream workflows related to > > > testing one more step closer together and allow easier automation > > > tools development and sharing between Fedora, Red Hat Enterprise > > > Linux and other products, the CI team is proposing to use a > > > consistent format for the CI related messages: > > > > > > https://pagure.io/fedora-ci/messages > > > > > > The specification (currently describing koji-build and brew-build > > > messages) is written in self-documented YAML files defining a > > > JSON SCHEMA which can be used to validate the message format. > > > Included is also a set of example messages to get a quick start. > > > > > > Please, review the proposed format and share your feedback. > > > Thanks! > > > > Are these completely separate from what Koji generates with > > https://pagure.io/koji/blob/master/f/plugins/hub/protonmsg.py ? > > This initiative is specific to messages to do with automated testing, > it's not a spec for *all* message bus messages sent by anything ever. > It'd mainly be relevant to automated test systems we have in Fedora > like the CI pipeline, Taskotron, openQA and autocloud. Ah, and if you're confused by "currently describing koji-build and brew-build messages" - those are the 'artifacts', in the parlance of this spec, the things being tested. Right now the spec describes how messages from testing systems that relate to testing of a package build in Koji should be formatted. That's what 'koji-build' means in context. -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/S3LLY4ZVTTKQN6LMPW6DKYYKT7EXLAQV/
Re: Consistent CI Messages
On Tue, 2018-08-21 at 14:18 -0600, Ken Dreyer wrote: > On Tue, Aug 21, 2018 at 4:50 AM, Petr Šplíchal wrote: > > Hi, > > > > as part of bringing upstream and downstream workflows related to > > testing one more step closer together and allow easier automation > > tools development and sharing between Fedora, Red Hat Enterprise > > Linux and other products, the CI team is proposing to use a > > consistent format for the CI related messages: > > > > https://pagure.io/fedora-ci/messages > > > > The specification (currently describing koji-build and brew-build > > messages) is written in self-documented YAML files defining a > > JSON SCHEMA which can be used to validate the message format. > > Included is also a set of example messages to get a quick start. > > > > Please, review the proposed format and share your feedback. > > Thanks! > > Are these completely separate from what Koji generates with > https://pagure.io/koji/blob/master/f/plugins/hub/protonmsg.py ? This initiative is specific to messages to do with automated testing, it's not a spec for *all* message bus messages sent by anything ever. It'd mainly be relevant to automated test systems we have in Fedora like the CI pipeline, Taskotron, openQA and autocloud. -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/WWT7IOYAF3VNQJ6LTRVUBIC7KZ4MZTPO/
Re: Consistent CI Messages
On Tue, Aug 21, 2018 at 4:50 AM, Petr Šplíchal wrote: > Hi, > > as part of bringing upstream and downstream workflows related to > testing one more step closer together and allow easier automation > tools development and sharing between Fedora, Red Hat Enterprise > Linux and other products, the CI team is proposing to use a > consistent format for the CI related messages: > > https://pagure.io/fedora-ci/messages > > The specification (currently describing koji-build and brew-build > messages) is written in self-documented YAML files defining a > JSON SCHEMA which can be used to validate the message format. > Included is also a set of example messages to get a quick start. > > Please, review the proposed format and share your feedback. > Thanks! Are these completely separate from what Koji generates with https://pagure.io/koji/blob/master/f/plugins/hub/protonmsg.py ? - Ken ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/DSTQB2LKEGKDN3AXAHWWH45HWJUZQDG2/
Re: Consistent CI Messages
Hi Petr, On 08/21/2018 11:50 AM, Petr Šplíchal wrote: > Hi, > > as part of bringing upstream and downstream workflows related to > testing one more step closer together and allow easier automation > tools development and sharing between Fedora, Red Hat Enterprise > Linux and other products, the CI team is proposing to use a > consistent format for the CI related messages: > > https://pagure.io/fedora-ci/messages > > The specification (currently describing koji-build and brew-build > messages) is written in self-documented YAML files defining a > JSON SCHEMA which can be used to validate the message format. > Included is also a set of example messages to get a quick start. > > Please, review the proposed format and share your feedback. > Thanks! I've only skimmed the format and I don't work on anything that consumes these messages, so I can't provide great feedback on that. A couple of quick notes on the schema itself, though: * "generated_at" is in a human-readable format, but doesn't include the timezone (UTC). It would be nice to include that, or use a machine- readable format and keep it documented as being UTC. You should also be able to enforce this with JSON schema's "date-time" type if you opt to go the human-readable route. * URLs can be of type "uri" and JSON schema will enforce that. I'm curious, are you aware of https://fedora-messaging.readthedocs.io/ and generally the plan for Fedora infrastructure to move to AMQP? fedora-messaging uses JSON schema as well and enforces the schema when sending or receiving. -- Jeremy Cline XMPP: jer...@jcline.org IRC: jcline ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/CAPBTRO27S2JZYNGTHGILEBCSI5N6PSX/
Consistent CI Messages
Hi, as part of bringing upstream and downstream workflows related to testing one more step closer together and allow easier automation tools development and sharing between Fedora, Red Hat Enterprise Linux and other products, the CI team is proposing to use a consistent format for the CI related messages: https://pagure.io/fedora-ci/messages The specification (currently describing koji-build and brew-build messages) is written in self-documented YAML files defining a JSON SCHEMA which can be used to validate the message format. Included is also a set of example messages to get a quick start. Please, review the proposed format and share your feedback. Thanks! psss... ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/3DZK35E6WWWVFHTPVQCR4KKRG4DHOPE2/
