Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2020-01-06 Thread Gary Buhrmaster
On Mon, Jan 6, 2020 at 4:22 PM drago01 wrote: > What does windows do? Is it the equivalent of the discard mount option or is > it more like fstrim? Well, as I understand it(*), it's complicated, and there are a lot of various tuning knobs one can use to change behavior. But typically, with

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2020-01-06 Thread drago01
On Monday, January 6, 2020, Kamil Paral wrote: > On Thu, Dec 19, 2019 at 10:43 PM Ben Cotton wrote: > >> https://fedoraproject.org/wiki/Changes/EnableFSTrimTimer >> >> == Summary == >> Enabling fstrim.timer will cause fstrim.service to execute weekly, >> which in turn executes `/usr/sbin/fstrim

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2020-01-06 Thread Kamil Paral
On Thu, Dec 19, 2019 at 10:43 PM Ben Cotton wrote: > https://fedoraproject.org/wiki/Changes/EnableFSTrimTimer > > == Summary == > Enabling fstrim.timer will cause fstrim.service to execute weekly, > which in turn executes `/usr/sbin/fstrim --fstab --verbose --quiet` > > > == Owner == > * Name:

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2020-01-03 Thread Chris Murphy
On Fri, Jan 3, 2020 at 11:48 AM Louis Lagendijk wrote: > > virt-manager does not enable discards on IDE or virtio disks. I think > it DOES enable discard on SCSI disks. So strictly speaking the above is > true as long as the default emulation layer is not SCSI but it is a > matter of a few clicks

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2020-01-03 Thread Louis Lagendijk
On Fri, 2020-01-03 at 10:21 -0700, Chris Murphy wrote: > On Fri, Jan 3, 2020 at 9:06 AM Robbie Harwood > wrote: > > Nico Kadel-Garcia writes: > > > > > On Thu, Jan 2, 2020 at 2:48 PM Robbie Harwood < > > > rharw...@redhat.com> wrote: > > > > "John M. Harris Jr" writes: > > > > > On Friday,

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2020-01-03 Thread Robbie Harwood
Chris Murphy writes: > On Fri, Jan 3, 2020 at 9:06 AM Robbie Harwood wrote: >> Nico Kadel-Garcia writes: >>> On Thu, Jan 2, 2020 at 2:48 PM Robbie Harwood wrote: "John M. Harris Jr" writes: > On Friday, December 20, 2019 10:59:52 AM MST Chris Murphy wrote: > >> Issuing the

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2020-01-03 Thread Daniel P . Berrangé
On Fri, Jan 03, 2020 at 11:05:43AM -0500, Robbie Harwood wrote: > Nico Kadel-Garcia writes: > > > On Thu, Jan 2, 2020 at 2:48 PM Robbie Harwood wrote: > >> "John M. Harris Jr" writes: > >>> On Friday, December 20, 2019 10:59:52 AM MST Chris Murphy wrote: > >>> > Issuing the command once

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2020-01-03 Thread Chris Murphy
On Fri, Jan 3, 2020 at 9:06 AM Robbie Harwood wrote: > > Nico Kadel-Garcia writes: > > > On Thu, Jan 2, 2020 at 2:48 PM Robbie Harwood wrote: > >> "John M. Harris Jr" writes: > >>> On Friday, December 20, 2019 10:59:52 AM MST Chris Murphy wrote: > >>> > Issuing the command once per week

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2020-01-03 Thread Robbie Harwood
Nico Kadel-Garcia writes: > On Thu, Jan 2, 2020 at 2:48 PM Robbie Harwood wrote: >> "John M. Harris Jr" writes: >>> On Friday, December 20, 2019 10:59:52 AM MST Chris Murphy wrote: >>> Issuing the command once per week harms no one >>> >>> Based on what's actual in the Change proposal,

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2020-01-02 Thread Nico Kadel-Garcia
On Thu, Jan 2, 2020 at 2:48 PM Robbie Harwood wrote: > > "John M. Harris Jr" writes: > > > On Friday, December 20, 2019 10:59:52 AM MST Chris Murphy wrote: > >> Issuing the command once per week harms no one > > > > Based on what's actual in the Change proposal, this is not the case. > > > >

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2020-01-02 Thread John M. Harris Jr
On Thursday, January 2, 2020 12:47:37 PM MST Robbie Harwood wrote: > "John M. Harris Jr" writes: > > On Friday, December 20, 2019 10:59:52 AM MST Chris Murphy wrote: > >> Issuing the command once per week harms no one > > > > Based on what's actual in the Change proposal, this is not the case. >

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2020-01-02 Thread Robbie Harwood
"John M. Harris Jr" writes: > On Friday, December 20, 2019 10:59:52 AM MST Chris Murphy wrote: >> Issuing the command once per week harms no one > > Based on what's actual in the Change proposal, this is not the case. > > Even if this goes through, in my opinion, it should only affect the GNOME

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-26 Thread John M. Harris Jr.
On Monday, December 23, 2019 8:01:14 AM MST Rex Dieter wrote: > Ben Cotton wrote: > > > > https://fedoraproject.org/wiki/Changes/EnableFSTrimTimer > > > Maybe it should be obvious, but the feature page doesn't include details on > how to manually enable(opt-in) or disable(opt-out) of the

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-23 Thread Rex Dieter
Ben Cotton wrote: > https://fedoraproject.org/wiki/Changes/EnableFSTrimTimer Maybe it should be obvious, but the feature page doesn't include details on how to manually enable(opt-in) or disable(opt-out) of the feature. Please add that. -- Rex ___

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-22 Thread Chris Murphy
On Fri, Dec 20, 2019 at 2:24 AM Lennart Poettering wrote: > So, if this is desirable, why doesn't the kernel do this on its own? A relevant recent article on the subject: Issues around discard https://lwn.net/Articles/787272/ There is a huge range of device firmware flash translation layer

Re: fstrim and LUKS [Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default]

2019-12-21 Thread John M. Harris Jr
On Saturday, December 21, 2019 1:59:03 AM MST Vitaly Zaitsev via devel wrote: > On 20.12.2019 21:53, Chris Murphy wrote: > > > If your LUKS drives are listed in fstab, they will have fstrim issued > > and it will pass down to the physical drive. > > > Only with enabled discard option in

Re: fstrim and LUKS [Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default]

2019-12-21 Thread Vitaly Zaitsev via devel
On 20.12.2019 21:53, Chris Murphy wrote: > If your LUKS drives are listed in fstab, they will have fstrim issued > and it will pass down to the physical drive. Only with enabled discard option in /etc/crypttab, because trimming of LUKS significantly decrease security level (everyone even without

Re: fstrim and LUKS [Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default]

2019-12-21 Thread Vitaly Zaitsev via devel
On 20.12.2019 21:30, Jan Kratochvil wrote: > This is AFAIK not enough for LUKS drives, will it be supported for LUKS? If you want to enable TRIM for LUKS, you should add discard option to /etc/crypttab file. -- Sincerely, Vitaly Zaitsev (vit...@easycoding.org)

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread John M. Harris Jr
On Friday, December 20, 2019 5:48:17 PM MST Alexander Ploumistos wrote: > On Sat, Dec 21, 2019 at 1:43 AM John M. Harris Jr > wrote: > > > > > > On Friday, December 20, 2019 5:33:59 PM MST Rahul Sundaram wrote: > > > > > Hi > > > > > > > > > > > > On Fri, Dec 20, 2019 at 7:15 PM John M. Harris

Re: fstrim and LUKS [Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default]

2019-12-20 Thread John M. Harris Jr
On Friday, December 20, 2019 7:27:20 PM MST Chris Murphy wrote: > On Fri, Dec 20, 2019 at 5:42 PM John M. Harris Jr > wrote: > > > > > > On Friday, December 20, 2019 1:53:41 PM MST Chris Murphy wrote: > > > > > On Fri, Dec 20, 2019 at 1:37 PM Jan Kratochvil > > > wrote: > > > > > > > > > > > >

Re: fstrim and LUKS [Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default]

2019-12-20 Thread Chris Murphy
On Fri, Dec 20, 2019 at 5:42 PM John M. Harris Jr wrote: > > On Friday, December 20, 2019 1:53:41 PM MST Chris Murphy wrote: > > On Fri, Dec 20, 2019 at 1:37 PM Jan Kratochvil > > wrote: > > > > > > > > > > > On Thu, 19 Dec 2019 22:42:02 +0100, Ben Cotton wrote: > > > > > > > == Summary == > > >

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Alexander Ploumistos
On Sat, Dec 21, 2019 at 1:43 AM John M. Harris Jr wrote: > > On Friday, December 20, 2019 5:33:59 PM MST Rahul Sundaram wrote: > > Hi > > > > On Fri, Dec 20, 2019 at 7:15 PM John M. Harris Jr > > > > wrote: > > > > ...release notes are published on the docs site as they have always > > > > been:

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Rahul Sundaram
Hi On Fri, Dec 20, 2019 at 7:43 PM John M. Harris Jr wrote: > On Friday, December 20, 2019 5:33:59 PM MST Rahul Sundaram wrote: > > No, I mean the things that actually changed between the two. "What's new" > or > so on. This looks like it's just general documentation, and not release > notes? >

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread John M. Harris Jr
On Friday, December 20, 2019 5:33:59 PM MST Rahul Sundaram wrote: > Hi > > On Fri, Dec 20, 2019 at 7:15 PM John M. Harris Jr > > wrote: > > > ...release notes are published on the docs site as they have always > > > been: > > > https://docs.fedoraproject.org/en-US/fedora/f31/release-notes/ > >

Re: fstrim and LUKS [Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default]

2019-12-20 Thread John M. Harris Jr
On Friday, December 20, 2019 1:53:41 PM MST Chris Murphy wrote: > On Fri, Dec 20, 2019 at 1:37 PM Jan Kratochvil > wrote: > > > > > > > On Thu, 19 Dec 2019 22:42:02 +0100, Ben Cotton wrote: > > > > > == Summary == > > > Enabling fstrim.timer will cause fstrim.service to execute weekly, > > >

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread John M. Harris Jr
On Friday, December 20, 2019 10:59:52 AM MST Chris Murphy wrote: > Issuing the command once per week harms no one Based on what's actual in the Change proposal, this is not the case. Even if this goes through, in my opinion, it should only affect the GNOME Spin, or perhaps even "all graphical"

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Rahul Sundaram
Hi On Fri, Dec 20, 2019 at 7:15 PM John M. Harris Jr wrote: > > > ...release notes are published on the docs site as they have always been: > > https://docs.fedoraproject.org/en-US/fedora/f31/release-notes/ > > Where are the changes from the previous release there? > Do you mean 30?

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread John M. Harris Jr
On Friday, December 20, 2019 8:07:50 AM MST Ben Cotton wrote: > On Fri, Dec 20, 2019 at 4:13 AM John M. Harris Jr > wrote: > > > > > > One, didn't we kill the release notes package recently? > > > Yes, but ... > > > > Are release notes even > > being written now, or do you have to go and

Re: fstrim and LUKS [Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default]

2019-12-20 Thread Chris Murphy
On Fri, Dec 20, 2019 at 1:37 PM Jan Kratochvil wrote: > > On Thu, 19 Dec 2019 22:42:02 +0100, Ben Cotton wrote: > > == Summary == > > Enabling fstrim.timer will cause fstrim.service to execute weekly, > > which in turn executes `/usr/sbin/fstrim --fstab --verbose --quiet` > > This is AFAIK not

fstrim and LUKS [Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default]

2019-12-20 Thread Jan Kratochvil
On Thu, 19 Dec 2019 22:42:02 +0100, Ben Cotton wrote: > == Summary == > Enabling fstrim.timer will cause fstrim.service to execute weekly, > which in turn executes `/usr/sbin/fstrim --fstab --verbose --quiet` This is AFAIK not enough for LUKS drives, will it be supported for LUKS? Jan

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Damian Ivanov
I was heavily affected by this not running by default. I was almost convinced my hardware was broken, since there is no warning while having it not enabled, the last journalctl entries when the system freezes during a copy operation is from libinput that the mouse events can't be handled due to

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Chris Murphy
On Fri, Dec 20, 2019 at 10:22 AM Lennart Poettering wrote: > > On Fr, 20.12.19 18:11, Louis Lagendijk (lo...@fazant.net) wrote: > > > On Fri, 2019-12-20 at 17:46 +0100, Lennart Poettering wrote: > > > > > > Or let me ask this differently: the "discard" mount option of various > > > kernel file

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Chris Murphy
On Fri, Dec 20, 2019 at 2:24 AM Lennart Poettering wrote: > > On Do, 19.12.19 16:42, Ben Cotton (bcot...@redhat.com) wrote: > > > Over time, some users experience slow downs in certain flash storage > > devices. This might be alleviated by issuing a periodic fstrim command > > to the mounted file

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Lennart Poettering
On Fr, 20.12.19 18:11, Louis Lagendijk (lo...@fazant.net) wrote: > On Fri, 2019-12-20 at 17:46 +0100, Lennart Poettering wrote: > > > > Or let me ask this differently: the "discard" mount option of various > > kernel file systems, what does it differently than what this new > > fedora feature is

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Louis Lagendijk
On Fri, 2019-12-20 at 17:46 +0100, Lennart Poettering wrote: > > Or let me ask this differently: the "discard" mount option of various > kernel file systems, what does it differently than what this new > fedora feature is supposed to do? > fstrim does the discard once a week (or whenever it it

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Lennart Poettering
On Fr, 20.12.19 14:10, Karel Zak (k...@redhat.com) wrote: > On Fri, Dec 20, 2019 at 10:23:50AM +0100, Lennart Poettering wrote: > > On Do, 19.12.19 16:42, Ben Cotton (bcot...@redhat.com) wrote: > > > > > Over time, some users experience slow downs in certain flash storage > > > devices. This

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Lennart Poettering
On Fr, 20.12.19 13:39, Fedora Development ML (devel@lists.fedoraproject.org) wrote: > On 20.12.2019 10:23, Lennart Poettering wrote: > > So, if this is desirable, why doesn't the kernel do this on its own? > > Kernel's TRIM has issues with data corruption on some SSD controllers. > You can check

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Ben Cotton
On Fri, Dec 20, 2019 at 4:13 AM John M. Harris Jr wrote: > > One, didn't we kill the release notes package recently? Yes, but ... > Are release notes even > being written now, or do you have to go and check the wiki for the list of > Changes? > ...release notes are published on the docs site

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Dec 19, 2019 at 10:39:45PM -0500, Stuart D. Gathman wrote: > On Thu, 19 Dec 2019, Ben Cotton wrote: > > >https://fedoraproject.org/wiki/Changes/EnableFSTrimTimer > > > >== Summary == > >Enabling fstrim.timer will cause fstrim.service to execute weekly, > >which in turn executes

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Karel Zak
On Fri, Dec 20, 2019 at 12:25:24PM +0100, Miro Hrončok wrote: > On 19. 12. 19 22:42, Ben Cotton wrote: > > https://fedoraproject.org/wiki/Changes/EnableFSTrimTimer > > > > == Summary == > > Enabling fstrim.timer will cause fstrim.service to execute weekly, > > which in turn executes

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Karel Zak
On Fri, Dec 20, 2019 at 10:23:50AM +0100, Lennart Poettering wrote: > On Do, 19.12.19 16:42, Ben Cotton (bcot...@redhat.com) wrote: > > > Over time, some users experience slow downs in certain flash storage > > devices. This might be alleviated by issuing a periodic fstrim command > > to the

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Vitaly Zaitsev via devel
On 20.12.2019 10:23, Lennart Poettering wrote: > So, if this is desirable, why doesn't the kernel do this on its own? Kernel's TRIM has issues with data corruption on some SSD controllers. You can check drivers/ata/libata-core.c of Linux kernel sources for more information. -- Sincerely,

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Miro Hrončok
On 19. 12. 19 22:42, Ben Cotton wrote: https://fedoraproject.org/wiki/Changes/EnableFSTrimTimer == Summary == Enabling fstrim.timer will cause fstrim.service to execute weekly, which in turn executes `/usr/sbin/fstrim --fstab --verbose --quiet` Could we please have a summary that contains at

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Tomasz Torcz
On Thu, Dec 19, 2019 at 11:59:54PM -0700, Chris Murphy wrote: > > After the initial change of defaults, the fstrim.timer SHOULD NOT be > > re-enabled on subsequent updates if a user (who like me prefers choosing > > when to run fstrim on which filesystem) has disabled it. > > It's an interesting

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread Lennart Poettering
On Do, 19.12.19 16:42, Ben Cotton (bcot...@redhat.com) wrote: > Over time, some users experience slow downs in certain flash storage > devices. This might be alleviated by issuing a periodic fstrim command > to the mounted file system. Devices and file systems that don't > support fstrim are

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-20 Thread John M. Harris Jr
On Friday, December 20, 2019 12:24:44 AM MST Igor Gnatenko wrote: > Always before upgrade to a new *major* version of distribution, you > are supposed to read release notes. This will be noted there and you, > as a user, can explicitly disable it after upgrade. Or even ship your > own preset which

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-19 Thread Igor Gnatenko
Always before upgrade to a new *major* version of distribution, you are supposed to read release notes. This will be noted there and you, as a user, can explicitly disable it after upgrade. Or even ship your own preset which would override system's one. On Fri, Dec 20, 2019 at 8:12 AM John M.

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-19 Thread John M. Harris Jr
On Thursday, December 19, 2019 11:59:54 PM MST Chris Murphy wrote: > On Thu, Dec 19, 2019 at 8:40 PM Stuart D. Gathman > wrote: > > > > > > On Thu, 19 Dec 2019, Ben Cotton wrote: > > > > > > > > > https://fedoraproject.org/wiki/Changes/EnableFSTrimTimer > > > > > > > > > > > > == Summary == > > >

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-19 Thread Chris Murphy
On Thu, Dec 19, 2019 at 8:40 PM Stuart D. Gathman wrote: > > On Thu, 19 Dec 2019, Ben Cotton wrote: > > > https://fedoraproject.org/wiki/Changes/EnableFSTrimTimer > > > > == Summary == > > Enabling fstrim.timer will cause fstrim.service to execute weekly, > > which in turn executes

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-19 Thread John M. Harris Jr
On Thursday, December 19, 2019 8:39:45 PM MST Stuart D. Gathman wrote: > On Thu, 19 Dec 2019, Ben Cotton wrote: > > > > https://fedoraproject.org/wiki/Changes/EnableFSTrimTimer > > > > > > > > == Summary == > > Enabling fstrim.timer will cause fstrim.service to execute weekly, > > which in turn

Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-19 Thread Stuart D. Gathman
On Thu, 19 Dec 2019, Ben Cotton wrote: https://fedoraproject.org/wiki/Changes/EnableFSTrimTimer == Summary == Enabling fstrim.timer will cause fstrim.service to execute weekly, which in turn executes `/usr/sbin/fstrim --fstab --verbose --quiet` == How To Test == The low level function of

Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-19 Thread Ben Cotton
https://fedoraproject.org/wiki/Changes/EnableFSTrimTimer == Summary == Enabling fstrim.timer will cause fstrim.service to execute weekly, which in turn executes `/usr/sbin/fstrim --fstab --verbose --quiet` == Owner == * Name: [[User:chrismurphy| Chris Murphy]] * Email:

Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default

2019-12-19 Thread Ben Cotton
https://fedoraproject.org/wiki/Changes/EnableFSTrimTimer == Summary == Enabling fstrim.timer will cause fstrim.service to execute weekly, which in turn executes `/usr/sbin/fstrim --fstab --verbose --quiet` == Owner == * Name: [[User:chrismurphy| Chris Murphy]] * Email: