Re: Question about conditional BuildRequires lines
On Wed, Feb 14, 2024 at 5:55 PM Tom Hughes via devel
wrote:
>
> On 14/02/2024 15:48, Richard W.M. Jones wrote:
> > On Wed, Feb 14, 2024 at 03:21:38PM +, Tom Hughes wrote:
> >> On 14/02/2024 14:54, Richard W.M. Jones wrote:
> >>
> >>> https://src.fedoraproject.org/rpms/rapidjson/pull-request/7
> >>>
> >>> I don't think what Tom is saying there is correct, or is it?
> >>
> >> The answer is that I'm wrong about it breaking things, because
> >> koji uses the unpacked spec file to install dependencies not the
> >> requires from the srpm.
> >>
> >> However the guidelines whilst not mentioning this case do prohibit
> >> the use of %{_isa} in BRs because it produces incorrect dependencies
> >> in the srpm - the only real difference is that this case give you
> >> a missing dependency rather than a broken one.
> >
> > I was hoping that people with more experience would comment on the
> > bug, and they did, so thanks.
> >
> > The issue we have is that valgrind is simply not a package on RISC-V.
> > Valgrind requires upstream porting work which is only partially
> > complete (and IIRC not upstream yet). I don't know any other way to
> > express this other than using:
>
> As it happens I'm an upstream valgrind developer and yes there
> are patches around but they're not merged yet.
>
> I'm not saying I won't take the patch I was just surprised it
> was allowed and/or worked and was trying to find out more details
> before I did anything.
There are a number of _arches macros defined in Fedora. Usually that's
language specific, but not always (e.g. qt webengine). Those are
mostly used for BuildRequires, ExclusiveArch, enabling/disabled
configure/test/etc. flags.
Cheers,
david
>
> Tom
>
> --
> Tom Hughes (t...@compton.nu)
> http://compton.nu/
> --
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
> Do not reply to spam, report it:
> https://pagure.io/fedora-infrastructure/new_issue
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
Re: Question about conditional BuildRequires lines
On 14/02/2024 15:48, Richard W.M. Jones wrote:
On Wed, Feb 14, 2024 at 03:21:38PM +, Tom Hughes wrote:
On 14/02/2024 14:54, Richard W.M. Jones wrote:
https://src.fedoraproject.org/rpms/rapidjson/pull-request/7
I don't think what Tom is saying there is correct, or is it?
The answer is that I'm wrong about it breaking things, because
koji uses the unpacked spec file to install dependencies not the
requires from the srpm.
However the guidelines whilst not mentioning this case do prohibit
the use of %{_isa} in BRs because it produces incorrect dependencies
in the srpm - the only real difference is that this case give you
a missing dependency rather than a broken one.
I was hoping that people with more experience would comment on the
bug, and they did, so thanks.
The issue we have is that valgrind is simply not a package on RISC-V.
Valgrind requires upstream porting work which is only partially
complete (and IIRC not upstream yet). I don't know any other way to
express this other than using:
As it happens I'm an upstream valgrind developer and yes there
are patches around but they're not merged yet.
I'm not saying I won't take the patch I was just surprised it
was allowed and/or worked and was trying to find out more details
before I did anything.
Tom
--
Tom Hughes (t...@compton.nu)
http://compton.nu/
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
Re: Question about conditional BuildRequires lines
On Wed, Feb 14, 2024 at 03:21:38PM +, Tom Hughes wrote:
> On 14/02/2024 14:54, Richard W.M. Jones wrote:
>
> >https://src.fedoraproject.org/rpms/rapidjson/pull-request/7
> >
> >I don't think what Tom is saying there is correct, or is it?
>
> The answer is that I'm wrong about it breaking things, because
> koji uses the unpacked spec file to install dependencies not the
> requires from the srpm.
>
> However the guidelines whilst not mentioning this case do prohibit
> the use of %{_isa} in BRs because it produces incorrect dependencies
> in the srpm - the only real difference is that this case give you
> a missing dependency rather than a broken one.
I was hoping that people with more experience would comment on the
bug, and they did, so thanks.
The issue we have is that valgrind is simply not a package on RISC-V.
Valgrind requires upstream porting work which is only partially
complete (and IIRC not upstream yet). I don't know any other way to
express this other than using:
%ifarch %{valgrind_arches}
BuildRequires: valgrind
%endif
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
Re: Question about conditional BuildRequires lines
On 14/02/2024 14:54, Richard W.M. Jones wrote:
https://src.fedoraproject.org/rpms/rapidjson/pull-request/7
I don't think what Tom is saying there is correct, or is it?
The answer is that I'm wrong about it breaking things, because
koji uses the unpacked spec file to install dependencies not the
requires from the srpm.
However the guidelines whilst not mentioning this case do prohibit
the use of %{_isa} in BRs because it produces incorrect dependencies
in the srpm - the only real difference is that this case give you
a missing dependency rather than a broken one.
Tom
--
Tom Hughes (t...@compton.nu)
http://compton.nu/
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
Question about conditional BuildRequires lines
https://src.fedoraproject.org/rpms/rapidjson/pull-request/7 I don't think what Tom is saying there is correct, or is it? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
