Re: Rebase option suddenly missing from src.fo.o PRs?
On Tue, Aug 20, 2019 at 9:46 PM Fabio Valentini wrote: > > On Tue, Aug 20, 2019 at 11:16 AM Miro Hrončok wrote: > > > > I've recently noticed that src.fo.o PRs no longer let me click "Rebase" > > under > > the "Merge" button. > > > > Am I the only one impacted? > > > > Is that deliberate or some bug worth reporting? > > FWIW, the "Merge" button from the "merge popup" is also gone for me. > I assume this is a regression from updating pagure from 5.5 to 5.7 > that happened a few days ago. > The issue is known and a fix is pending: https://pagure.io/pagure/pull-request/4575 Once the PR is validated and merged, I will backport it to the pagure package in Fedora and EPEL, which will let us roll out the fix to production shortly thereafter. -- 真実はいつも一つ！/ Always, there's only one truth! ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Rebase option suddenly missing from src.fo.o PRs?
On Tue, Aug 20, 2019, 12:57 Julen Landa Alustiza wrote: > AFAIK, here are two different things, > > > On one hand, since 5.6 you must check the allow rebase checklist button to > allow the project owner to rebase your fork branch from where the PR is > created. This property had been set to False on the migration from 5.5 to > 5.7.4, so the previously existing PRs will not allow the owner to rebase > PR. This is a feature. More background on > https://pagure.io/pagure/c/e180e7ed38a944f087063a31c51ba6ac12bb715c?branch=master > > On the other hand, there is a regression around the merge button > showing|hiding logic. This part is a bug. > Ah, thanks for clarifying. Also I can't even merge PRs via the API, since one can't create API tokens that have the necessary ACL for merging pull requests ... merging stuff locally should work, but it's annoying that the UI is broken. Fabio 19/8/20 11:26(e)an, Fabio Valentini igorleak idatzi zuen: > > On Tue, Aug 20, 2019 at 11:16 AM Miro Hrončok > wrote: > > I've recently noticed that src.fo.o PRs no longer let me click "Rebase" under > the "Merge" button. > > Am I the only one impacted? > > Is that deliberate or some bug worth reporting? > > FWIW, the "Merge" button from the "merge popup" is also gone for me. > I assume this is a regression from updating pagure from 5.5 to 5.7 > that happened a few days ago. > > Fabio > > > -- > Miro Hrončok > -- > Phone: +420777974800 > IRC: mhroncok > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > > -- > Julen Landa Alustiza > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Rebase option suddenly missing from src.fo.o PRs?
AFAIK, here are two different things, On one hand, since 5.6 you must check the allow rebase checklist button to allow the project owner to rebase your fork branch from where the PR is created. This property had been set to False on the migration from 5.5 to 5.7.4, so the previously existing PRs will not allow the owner to rebase PR. This is a feature. More background on https://pagure.io/pagure/c/e180e7ed38a944f087063a31c51ba6ac12bb715c?branch=master On the other hand, there is a regression around the merge button showing|hiding logic. This part is a bug. 19/8/20 11:26(e)an, Fabio Valentini igorleak idatzi zuen: > On Tue, Aug 20, 2019 at 11:16 AM Miro Hrončok wrote: >> I've recently noticed that src.fo.o PRs no longer let me click "Rebase" under >> the "Merge" button. >> >> Am I the only one impacted? >> >> Is that deliberate or some bug worth reporting? > FWIW, the "Merge" button from the "merge popup" is also gone for me. > I assume this is a regression from updating pagure from 5.5 to 5.7 > that happened a few days ago. > > Fabio > >> -- >> Miro Hrončok >> -- >> Phone: +420777974800 >> IRC: mhroncok >> ___ >> devel mailing list -- devel@lists.fedoraproject.org >> To unsubscribe send an email to devel-le...@lists.fedoraproject.org >> Fedora Code of Conduct: >> https://docs.fedoraproject.org/en-US/project/code-of-conduct/ >> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines >> List Archives: >> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org -- Julen Landa Alustiza ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Rebase option suddenly missing from src.fo.o PRs?
On Tue, Aug 20, 2019 at 11:16 AM Miro Hrončok wrote: > > I've recently noticed that src.fo.o PRs no longer let me click "Rebase" under > the "Merge" button. > > Am I the only one impacted? > > Is that deliberate or some bug worth reporting? FWIW, the "Merge" button from the "merge popup" is also gone for me. I assume this is a regression from updating pagure from 5.5 to 5.7 that happened a few days ago. Fabio > -- > Miro Hrončok > -- > Phone: +420777974800 > IRC: mhroncok > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Rebase option suddenly missing from src.fo.o PRs?
I've recently noticed that src.fo.o PRs no longer let me click "Rebase" under the "Merge" button. Am I the only one impacted? Is that deliberate or some bug worth reporting? -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
