Re: Specify debug build in qtmake?

2020-03-31 Thread Richard Shaw
On Tue, Mar 31, 2020 at 8:04 AM Vascom  wrote:

> So this spec not follow Fedora's packaging guidlines and need to be fixed
> according them.
>

Already done and new builds kicked off. Thanks for the quick reply!

Thanks,
Richard
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: Specify debug build in qtmake?

2020-03-31 Thread Vascom
So this spec not follow Fedora's packaging guidlines and need to be fixed
according them.

вт, 31 мар. 2020 г., 15:57 Richard Shaw :

> On Tue, Mar 31, 2020 at 7:34 AM Vascom  wrote:
>
>> Why you not use macro %qmake_qt5?
>> It contain all flags.
>>
>
> Good question. I inherited this package and hadn't dug into it much since
> it was building until today.
>
> Thanks,
> Richard
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
>
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: Specify debug build in qtmake?

2020-03-31 Thread Richard Shaw
On Tue, Mar 31, 2020 at 7:34 AM Vascom  wrote:

> Why you not use macro %qmake_qt5?
> It contain all flags.
>

Good question. I inherited this package and hadn't dug into it much since
it was building until today.

Thanks,
Richard
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: Specify debug build in qtmake?

2020-03-31 Thread Vascom
Why you not use macro %qmake_qt5?
It contain all flags.

вт, 31 мар. 2020 г., 15:25 Richard Shaw :

> Has something changed with Qt 5.14? I'm trying to update klog to new
> version but debuginfo is not being generated.
>
> Looking at the build log it's definitely missing "-g" during building but
> a debug build is requested:
>
> qmake-qt5 "PREFIX=%{buildroot}%{_prefix}" "CONFIG+=debug c++17" KLog.pro
>
> Looking at KLog.pro I see:
>
> CONFIG += release
>
> and
>
> #DEFINES *= QT_NO_DEBUG_OUTPUT
>
> Which I assume is ok. I should be overriding the first line and the second
> is commented out.
>
> Tips?
>
> Thanks,
> Richard
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
>
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Specify debug build in qtmake?

2020-03-31 Thread Richard Shaw
Has something changed with Qt 5.14? I'm trying to update klog to new
version but debuginfo is not being generated.

Looking at the build log it's definitely missing "-g" during building but a
debug build is requested:

qmake-qt5 "PREFIX=%{buildroot}%{_prefix}" "CONFIG+=debug c++17" KLog.pro

Looking at KLog.pro I see:

CONFIG += release

and

#DEFINES *= QT_NO_DEBUG_OUTPUT

Which I assume is ok. I should be overriding the first line and the second
is commented out.

Tips?

Thanks,
Richard
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org