Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-14 Thread Jaroslav Mracek
On Fri, Feb 11, 2022 at 7:42 PM Miro Hrončok wrote: > On 11. 02. 22 13:50, Jaroslav Mracek wrote: > > > No we didn't and it will make the feature less usable - see > reported issues > > > during testing in original request ( > > >

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-11 Thread Miro Hrončok
On 11. 02. 22 21:58, Kevin Kofler via devel wrote: Miro Hrončok wrote: Another thing I'd like to understand from your POV is why would packagers actually *need* exactly-versioned Recommends. Could you please give me an example use case? I understand why they might *assume they need* it, because

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-11 Thread Kevin Kofler via devel
Miro Hrončok wrote: > Another thing I'd like to understand from your POV is why would packagers > actually *need* exactly-versioned Recommends. Could you please give me an > example use case? I understand why they might *assume they need* it, > because packaging is complex and this might seem like

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-11 Thread Miro Hrončok
On 11. 02. 22 13:50, Jaroslav Mracek wrote: > No we didn't and it will make the feature less usable - see reported issues > during testing in original request ( > https://bugzilla.redhat.com/show_bug.cgi?id=1699672#c74

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-11 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 11, 2022 at 02:05:15PM +0100, Kevin Kofler via devel wrote: > Am Freitag, 11. Februar 2022 13:50:57 CET schrieb Jaroslav Mracek: > > On Tue, Feb 8, 2022 at 7:30 PM Zbigniew Jędrzejewski-Szmek < > > zbys...@in.waw.pl> wrote: > > > Hmm, but why is metadata of repository needed? IIUC, all

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-11 Thread Kevin Kofler via devel
Am Freitag, 11. Februar 2022 13:50:57 CET schrieb Jaroslav Mracek: On Tue, Feb 8, 2022 at 7:30 PM Zbigniew Jędrzejewski-Szmek < zbys...@in.waw.pl> wrote: Hmm, but why is metadata of repository needed? IIUC, all deps (including rich) are part of the package header, i.e. are in the RPM database

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-11 Thread Jaroslav Mracek
On Tue, Feb 8, 2022 at 7:30 PM Zbigniew Jędrzejewski-Szmek < zbys...@in.waw.pl> wrote: > On Tue, Feb 08, 2022 at 02:30:30PM +0100, Jaroslav Mracek wrote: > > On Tue, Feb 8, 2022 at 1:56 PM Kevin Kofler via devel < > > devel@lists.fedoraproject.org> wrote: > > > > > Jaroslav Mracek wrote: > > > >

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-08 Thread Miro Hrončok
On 08. 02. 22 14:30, Jaroslav Mracek wrote: > Rich dependencies are dynamic and they change from release to release > (version macros, ...) That is a different issue, and also happens for non-rich dependencies. I think we agreed back when the Change was submitted that a

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-08 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Feb 08, 2022 at 02:30:30PM +0100, Jaroslav Mracek wrote: > On Tue, Feb 8, 2022 at 1:56 PM Kevin Kofler via devel < > devel@lists.fedoraproject.org> wrote: > > > Jaroslav Mracek wrote: > > > I am really sorry but this suggestion is incorrect. Basically we have 3 > > > major

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-08 Thread Jaroslav Mracek
On Tue, Feb 8, 2022 at 1:56 PM Kevin Kofler via devel < devel@lists.fedoraproject.org> wrote: > Jaroslav Mracek wrote: > > I am really sorry but this suggestion is incorrect. Basically we have 3 > > major misunderstandings - what is rich deps and how it is evaluated, what > > DNF stores in the

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-08 Thread Kevin Kofler via devel
Jaroslav Mracek wrote: > I am really sorry but this suggestion is incorrect. Basically we have 3 > major misunderstandings - what is rich deps and how it is evaluated, what > DNF stores in the history database and how SAT solver in libsolv works. > Rich deps are very complex things with multiple

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-08 Thread Jaroslav Mracek
On Mon, Feb 7, 2022 at 5:20 PM Kevin Kofler via devel < devel@lists.fedoraproject.org> wrote: > Miro Hrončok wrote: > > this is about the following Fedora change: > > > > https://fedoraproject.org/wiki/Changes/ExcludeFromWeakAutodetect > > > > In the tracking bugzilla, the relevant comment is: >

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-08 Thread Jaroslav Mracek
I would like to prefer to go with for Fedora 36: > 3. do not ignore already broken weak rich deps (partially reverts the change) It will enable lang packs user case but provides significant part of requested functionality. I created PR

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-07 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Feb 07, 2022 at 03:01:43PM -0800, Adam Williamson wrote: > On Mon, 2022-02-07 at 15:17 +0100, Miro Hrončok wrote: > > > > The change owner proposed 4 options to move forward. I understand them as > > follows: > > > > 1. do nothing, keep it broken > > 2. disable this behavior by default,

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-07 Thread Adam Williamson
On Mon, 2022-02-07 at 15:17 +0100, Miro Hrončok wrote: > > The change owner proposed 4 options to move forward. I understand them as > follows: > > 1. do nothing, keep it broken > 2. disable this behavior by default, keep it optional, but keep it broken > 3. do not ignore already broken weak

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-07 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Feb 07, 2022 at 03:25:44PM +0100, Miro Hrončok wrote: > > 1. do nothing, keep it broken > > I pretty much dislike this option. Clearly, the current behavior is not what > was approved in this change proposal. For me, it's a bad option. Agreed. We want to use langpacks with rich

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-07 Thread Miro Hrončok
On 07. 02. 22 17:17, Kevin Kofler via devel wrote: So I would currently tend towards: * postponing the Change to F37, * implementing option 2. for F36 (i.e., adding the option as experimental and disabled by default, which should not need a Change at all), AND * looking further for a proper

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-07 Thread Kevin Kofler via devel
Miro Hrončok wrote: > this is about the following Fedora change: > > https://fedoraproject.org/wiki/Changes/ExcludeFromWeakAutodetect > > In the tracking bugzilla, the relevant comment is: > > https://bugzilla.redhat.com/show_bug.cgi?id=2013327#c4 > > If I understand this correctly, the

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-07 Thread Fabio Valentini
On Mon, Feb 7, 2022 at 3:26 PM Miro Hrončok wrote: > > > 3. do not ignore already broken weak rich deps (partially reverts the > > change) > > This sounds like a possible path forward -- it would probably still be an > improvement over the the Fedora 35 status quo, however the results might be >

Re: What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-07 Thread Miro Hrončok
On 07. 02. 22 15:17, Miro Hrončok wrote: Hello, this is about the following Fedora change: https://fedoraproject.org/wiki/Changes/ExcludeFromWeakAutodetect In the tracking bugzilla, the relevant comment is: https://bugzilla.redhat.com/show_bug.cgi?id=2013327#c4 If I understand this

What should we do about the "Install only newly recommended packages on upgrades" F36 change?

2022-02-07 Thread Miro Hrončok
Hello, this is about the following Fedora change: https://fedoraproject.org/wiki/Changes/ExcludeFromWeakAutodetect In the tracking bugzilla, the relevant comment is: https://bugzilla.redhat.com/show_bug.cgi?id=2013327#c4 If I understand this correctly, the current implementation is not doing