Re: ardour5 build failures in rawhide

2017-09-15 Thread Jonathan Wakely

On 15/09/17 11:41 +0200, Guido Aulisi wrote:

Hi,
recently ardour5 failed to build in rawhide, I think because glibmm
now requires c++14.

I patched the spec at the beginning this way and it works on my pc:

# glibmm needs --std=c++11 for F-23..F-27 and --std=c++14 for F-28 and later
# --std=c++14 is the default for F-28
%if !0%{?fedora}%{?rhel} || ( 0%{?fedora} >= 23 && 0%{?fedora} < 28 )
|| 0%{?rhel} >= 8
%bcond_without cxx11
%else
%bcond_with cxx11
%endif

But I think we should remove all c++ explicit standard selection and
let the compiler use its default, which should work for every fedora
version (I hope).

What do you think about it?


Makes sense to me, the default -std=gnu++14 will work for building all
versions.

___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


ardour5 build failures in rawhide

2017-09-15 Thread Guido Aulisi
Hi,
recently ardour5 failed to build in rawhide, I think because glibmm
now requires c++14.

I patched the spec at the beginning this way and it works on my pc:

# glibmm needs --std=c++11 for F-23..F-27 and --std=c++14 for F-28 and later
# --std=c++14 is the default for F-28
%if !0%{?fedora}%{?rhel} || ( 0%{?fedora} >= 23 && 0%{?fedora} < 28 )
|| 0%{?rhel} >= 8
%bcond_without cxx11
%else
%bcond_with cxx11
%endif

But I think we should remove all c++ explicit standard selection and
let the compiler use its default, which should work for every fedora
version (I hope).

What do you think about it?

Nils, please let me know your opinion when you have time.

Thanks

Guido Aulisi
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org