Re: bodhi updates skipping updates-testing entirely
Fabio Valentini wrote: > This sounds like you didn't read my whole post. > Because I don't want to make updates going from "pending -> stable" > directly impossible, Well, several of the people who replied do want that, if I understand their replies correctly. I think your original proposal that only blocks the automated push, requiring a manual push, would be workable. (I think autokarma pushes are a bad idea to begin with.) Still, it is more than what would be required to address the technical issue at hand. > I just want it not to happen unless necessary, because it drastically > reduces the exposure of updates to broader user testing. It is always a tradeoff between getting urgent fixes out fast and waiting for more users to test them. >> > That isn't that big of a problem most of the time, since "fedora" / >> > "updates" and "updates-testing" repositories are composed daily, but >> > during freezes, this leads to the weird problem that possibly >> > important updates get stuck in a state where they are available from >> > *no repository at all*. >> >> That is the real problem that needs fixing, and the fix for that would be >> for Bodhi to: >> * if an update is in pending → stable state for Fedora n, AND >> * if Fedora n is currently in a freeze (and ONLY in that case), THEN >> 1. push the update to testing instead AND >> 2. keep it queued for stable, i.e., put it into testing → stable state. >> >> But there is no valid reason to do that for releases that are not frozen >> and where the update can just go out directly to stable. > > Why should updates for "stable" releases receive less testing coverage > than those for a pre-release? That doesn't make any sense. Because the pre-releases are in a freeze that prevents getting the updates out to stable and the stable releases are not. My argument is a purely technical one, not a policy one. Kevin Kofler ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: bodhi updates skipping updates-testing entirely
On Sun, Oct 17, 2021 at 3:08 AM Kevin Kofler via devel
wrote:
>
> Fabio Valentini wrote:
> > There seems to be some inconsistency with how our update workflow
> > currently works. When an update gets enough positive karma "pre-push"
> > (still in "pending → testing" state) so that it can be pushed to
> > stable, bodhi changes its state to ("pending → stable"), making it
> > skip the "updates-testing" repository entirely.
>
> And that is a feature. We already have too many bureaucratic (minimum karma
> requirements) and technical (at most one push per day) delays for updates.
> Why can't a tested update go out to stable?
This sounds like you didn't read my whole post.
Because I don't want to make updates going from "pending -> stable"
directly impossible, I just want it not to happen unless necessary,
because it drastically reduces the exposure of updates to broader user
testing.
> > That isn't that big of a problem most of the time, since "fedora" /
> > "updates" and "updates-testing" repositories are composed daily, but
> > during freezes, this leads to the weird problem that possibly
> > important updates get stuck in a state where they are available from
> > *no repository at all*.
>
> That is the real problem that needs fixing, and the fix for that would be
> for Bodhi to:
> * if an update is in pending → stable state for Fedora n, AND
> * if Fedora n is currently in a freeze (and ONLY in that case), THEN
> 1. push the update to testing instead AND
> 2. keep it queued for stable, i.e., put it into testing → stable state.
>
> But there is no valid reason to do that for releases that are not frozen and
> where the update can just go out directly to stable.
Why should updates for "stable" releases receive less testing coverage
than those for a pre-release? That doesn't make any sense.
Fabio
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
Re: bodhi updates skipping updates-testing entirely
Fabio Valentini wrote:
> There seems to be some inconsistency with how our update workflow
> currently works. When an update gets enough positive karma "pre-push"
> (still in "pending → testing" state) so that it can be pushed to
> stable, bodhi changes its state to ("pending → stable"), making it
> skip the "updates-testing" repository entirely.
And that is a feature. We already have too many bureaucratic (minimum karma
requirements) and technical (at most one push per day) delays for updates.
Why can't a tested update go out to stable?
> That isn't that big of a problem most of the time, since "fedora" /
> "updates" and "updates-testing" repositories are composed daily, but
> during freezes, this leads to the weird problem that possibly
> important updates get stuck in a state where they are available from
> *no repository at all*.
That is the real problem that needs fixing, and the fix for that would be
for Bodhi to:
* if an update is in pending → stable state for Fedora n, AND
* if Fedora n is currently in a freeze (and ONLY in that case), THEN
1. push the update to testing instead AND
2. keep it queued for stable, i.e., put it into testing → stable state.
But there is no valid reason to do that for releases that are not frozen and
where the update can just go out directly to stable.
Kevin Kofler
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
Re: bodhi updates skipping updates-testing entirely
Hi Fabio, Fabio Valentini writes: > So, I wonder, should updates always be allowed to skip being in the > "updates-testing" repository entirely? There's probably good reasons > for it sometimes (for example, time-critical security updates, i.e. > firefox, kernel, etc.), but in the general case, not giving regular > "non-koji" update testers any time to test updates before they're > pushed to stable seems suboptimal. No I don't think that this should be generally allowed, it should be imho prohibited for critical path updates where we schedule a full openQA run. > Maybe updates should only be able to be pushed to stable by karma if > they are in the "testing" state, and need a manual "submit to stable" > button push if they're still "pending"? That should be both fairly > straightforward to implement in bodhi, and should allow for both the > "pending → stable fast-track, this is urgent" and the "lets wait and > let it sit in updates-testing for at least one day" scenarios. > > What do you think? Having packages at least a day in testing (unless absolute urgency is required) sounds like a good idea to me. This could very well happen automatically like Miro suggested. Cheers, Dan ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: bodhi updates skipping updates-testing entirely
On Tue, Oct 12, 2021 at 10:49 AM Miro Hrončok wrote:
>
> On 12. 10. 21 10:35, Fabio Valentini wrote:
> > Hi everybody,
> >
> > There seems to be some inconsistency with how our update workflow
> > currently works. When an update gets enough positive karma "pre-push"
> > (still in "pending → testing" state) so that it can be pushed to
> > stable, bodhi changes its state to ("pending → stable"), making it
> > skip the "updates-testing" repository entirely.
> >
> > That isn't that big of a problem most of the time, since "fedora" /
> > "updates" and "updates-testing" repositories are composed daily, but
> > during freezes, this leads to the weird problem that possibly
> > important updates get stuck in a state where they are available from
> > *no repository at all*.
> >
> > For example, this now happened to the flatpak 1.12.1 update:
> > https://bodhi.fedoraproject.org/updates/FEDORA-2021-256d5ee9fe
> >
> > It got +5 karma before the update was even available from the
> > updates-testing repository (presumably users tested the builds from
> > koji directly - I hope?), so it got pushed to "stable" by bodhi. But
> > now it's been sitting in "pending → stable" state for two days because
> > of the final freeze, making the update available from *no repository*,
> > while it's a pretty big update (1.11 → 1.12) and also contains
> > security fixes and bug fixes for Steam - maybe it should get a freeze
> > exception now, otherwise it will only become available as a 0day
> > update.
> >
> > So, I wonder, should updates always be allowed to skip being in the
> > "updates-testing" repository entirely? There's probably good reasons
> > for it sometimes (for example, time-critical security updates, i.e.
> > firefox, kernel, etc.), but in the general case, not giving regular
> > "non-koji" update testers any time to test updates before they're
> > pushed to stable seems suboptimal.
> >
> > Maybe updates should only be able to be pushed to stable by karma if
> > they are in the "testing" state, and need a manual "submit to stable"
> > button push if they're still "pending"? That should be both fairly
> > straightforward to implement in bodhi, and should allow for both the
> > "pending → stable fast-track, this is urgent" and the "lets wait and
> > let it sit in updates-testing for at least one day" scenarios.
> >
> > What do you think?
>
> This could also be solved by implementing the "pending -> stable" action to
> always behave like "pending -> testing -> stable", rather than waiting an
> extra
> day, no?
Yeah, that's effectively what I meant to say by what I wrote.
Since pushes happen once per day (if everything works), packages would
spend at least one day in the "testing" state, which is better than
"no time" in most cases, I think.
Fabio
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
Re: bodhi updates skipping updates-testing entirely
Understood. Filed a bug https://bugzilla.redhat.com/show_bug.cgi?id=2013168#c1. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: bodhi updates skipping updates-testing entirely
On Tue, Oct 12, 2021 at 9:48 AM Artem Tim wrote: > > Noticed this a long time ago when in freeze stage and this could a serious > issue sometimes. BTW please push flatpak 1.12.1 update to Stable manually > since people still complain and stuck with 1.12.0. This is not a place to request random updates be pushed to stable, there's a blocker bug process for that. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: bodhi updates skipping updates-testing entirely
On 12. 10. 21 10:35, Fabio Valentini wrote:
Hi everybody,
There seems to be some inconsistency with how our update workflow
currently works. When an update gets enough positive karma "pre-push"
(still in "pending → testing" state) so that it can be pushed to
stable, bodhi changes its state to ("pending → stable"), making it
skip the "updates-testing" repository entirely.
That isn't that big of a problem most of the time, since "fedora" /
"updates" and "updates-testing" repositories are composed daily, but
during freezes, this leads to the weird problem that possibly
important updates get stuck in a state where they are available from
*no repository at all*.
For example, this now happened to the flatpak 1.12.1 update:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-256d5ee9fe
It got +5 karma before the update was even available from the
updates-testing repository (presumably users tested the builds from
koji directly - I hope?), so it got pushed to "stable" by bodhi. But
now it's been sitting in "pending → stable" state for two days because
of the final freeze, making the update available from *no repository*,
while it's a pretty big update (1.11 → 1.12) and also contains
security fixes and bug fixes for Steam - maybe it should get a freeze
exception now, otherwise it will only become available as a 0day
update.
So, I wonder, should updates always be allowed to skip being in the
"updates-testing" repository entirely? There's probably good reasons
for it sometimes (for example, time-critical security updates, i.e.
firefox, kernel, etc.), but in the general case, not giving regular
"non-koji" update testers any time to test updates before they're
pushed to stable seems suboptimal.
Maybe updates should only be able to be pushed to stable by karma if
they are in the "testing" state, and need a manual "submit to stable"
button push if they're still "pending"? That should be both fairly
straightforward to implement in bodhi, and should allow for both the
"pending → stable fast-track, this is urgent" and the "lets wait and
let it sit in updates-testing for at least one day" scenarios.
What do you think?
This could also be solved by implementing the "pending -> stable" action to
always behave like "pending -> testing -> stable", rather than waiting an extra
day, no?
--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
Re: bodhi updates skipping updates-testing entirely
Noticed this a long time ago when in freeze stage and this could a serious issue sometimes. BTW please push flatpak 1.12.1 update to Stable manually since people still complain and stuck with 1.12.0. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
bodhi updates skipping updates-testing entirely
Hi everybody,
There seems to be some inconsistency with how our update workflow
currently works. When an update gets enough positive karma "pre-push"
(still in "pending → testing" state) so that it can be pushed to
stable, bodhi changes its state to ("pending → stable"), making it
skip the "updates-testing" repository entirely.
That isn't that big of a problem most of the time, since "fedora" /
"updates" and "updates-testing" repositories are composed daily, but
during freezes, this leads to the weird problem that possibly
important updates get stuck in a state where they are available from
*no repository at all*.
For example, this now happened to the flatpak 1.12.1 update:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-256d5ee9fe
It got +5 karma before the update was even available from the
updates-testing repository (presumably users tested the builds from
koji directly - I hope?), so it got pushed to "stable" by bodhi. But
now it's been sitting in "pending → stable" state for two days because
of the final freeze, making the update available from *no repository*,
while it's a pretty big update (1.11 → 1.12) and also contains
security fixes and bug fixes for Steam - maybe it should get a freeze
exception now, otherwise it will only become available as a 0day
update.
So, I wonder, should updates always be allowed to skip being in the
"updates-testing" repository entirely? There's probably good reasons
for it sometimes (for example, time-critical security updates, i.e.
firefox, kernel, etc.), but in the general case, not giving regular
"non-koji" update testers any time to test updates before they're
pushed to stable seems suboptimal.
Maybe updates should only be able to be pushed to stable by karma if
they are in the "testing" state, and need a manual "submit to stable"
button push if they're still "pending"? That should be both fairly
straightforward to implement in bodhi, and should allow for both the
"pending → stable fast-track, this is urgent" and the "lets wait and
let it sit in updates-testing for at least one day" scenarios.
What do you think?
Fabio
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
