F15 Feature - online Ex4 defragmentatnion (Re: e4defrag support?)

2010-10-25 Thread Michał Piotrowski
Hi,

2010/10/6 Eric Sandeen sand...@redhat.com:
 OK gang, it's in e2fsprogs-1.41.12-6.fc15

 you have to invoke it with -test options to make it go ;)

 Word of warning, it's not had a lot of attention, and the whole
 design could change in the future, but it's something to play with :)

 -Eric

Would it make sense to propose online ext4 defragmentation as a
Fedora 15 feature?

Rationale - more people would point their attention to this feature -
more people would test it.

Contingency Plan:
None. Just delete feature from features page :)

I'm not sure how it is in other distros, but it's probably not very
popular feature.

Any suggestions?

Kind regards,
Michal
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: F15 Feature - online Ex4 defragmentatnion (Re: e4defrag support?)

2010-10-25 Thread Eric Sandeen
Michał Piotrowski wrote:
 Hi,
 
 2010/10/6 Eric Sandeen sand...@redhat.com:
 OK gang, it's in e2fsprogs-1.41.12-6.fc15

 you have to invoke it with -test options to make it go ;)

 Word of warning, it's not had a lot of attention, and the whole
 design could change in the future, but it's something to play with :)

 -Eric
 
 Would it make sense to propose online ext4 defragmentation as a
 Fedora 15 feature?

At this time, I don't think I'll be able to commit to that work.

I'd usually sign up a feature for Fedora when it is reaching completion
upstream, rather than using Fedora as a driver for upstream priorities...

This might change but I'm not going to commit to it today, sorry.

-Eric

 Rationale - more people would point their attention to this feature -
 more people would test it.
 
 Contingency Plan:
 None. Just delete feature from features page :)
 
 I'm not sure how it is in other distros, but it's probably not very
 popular feature.
 
 Any suggestions?
 
 Kind regards,
 Michal

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: F15 Feature - online Ex4 defragmentatnion (Re: e4defrag support?)

2010-10-25 Thread Michał Piotrowski
W dniu 25 października 2010 17:19 użytkownik Eric Sandeen
sand...@redhat.com napisał:
 Michał Piotrowski wrote:
 Hi,

 2010/10/6 Eric Sandeen sand...@redhat.com:
 OK gang, it's in e2fsprogs-1.41.12-6.fc15

 you have to invoke it with -test options to make it go ;)

 Word of warning, it's not had a lot of attention, and the whole
 design could change in the future, but it's something to play with :)

 -Eric

 Would it make sense to propose online ext4 defragmentation as a
 Fedora 15 feature?

 At this time, I don't think I'll be able to commit to that work.

 I'd usually sign up a feature for Fedora when it is reaching completion
 upstream, rather than using Fedora as a driver for upstream priorities...

 This might change but I'm not going to commit to it today, sorry.

I did not mean burdening your in bug reports with the annotation
please fix this bug before F15 :)

All bug reports should be sent to NEC's e4defrag developers. It seems
to me that they are the most appropriate people to fix e4defrag bugs
(of course if they still want to maintain this project - it is hard to
deduce anything from git log - only five commits after merge - one
from author).


 -Eric


Regards,
Michal
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: e4defrag repetable segfault (Re: e4defrag support?)

2010-10-11 Thread Eric Sandeen
Michał Piotrowski wrote:
 e4defrag[23597]: segfault at 20 ip 0040232c sp
 7fff5bb0cd20 error 4 in e4defrag[40+5000]
 
 This is caused by the race between rm and e4defrag
 
 repeatable with attached
 canto_della_terra2.sh /mnt/tmp/test/ /mnt/tmp/reply.sh 50
 
 Regards,
 Michal
 

File a bug please?  Also, what is reply.sh?

Thanks,
-Eric
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: e4defrag repetable segfault (Re: e4defrag support?)

2010-10-11 Thread Michał Piotrowski
2010/10/11 Eric Sandeen sand...@redhat.com:
 Michał Piotrowski wrote:
 e4defrag[23597]: segfault at 20 ip 0040232c sp
 7fff5bb0cd20 error 4 in e4defrag[40+5000]

 This is caused by the race between rm and e4defrag

 repeatable with attached
 canto_della_terra2.sh /mnt/tmp/test/ /mnt/tmp/reply.sh 50

 Regards,
 Michal


 File a bug please?

https://bugzilla.redhat.com/show_bug.cgi?id=641926

  Also, what is reply.sh?

It's file where cdt scripts stores it's actions - you can try to reply
them (although it is difficult because of the racing nature of cdt
script)


 Thanks,
 -Eric

Regards,
Michal
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: e4defrag support?

2010-10-11 Thread Michał Piotrowski
W dniu 6 października 2010 15:42 użytkownik Eric Sandeen
sand...@redhat.com napisał:
 Michał Piotrowski wrote:
 W dniu 6 października 2010 05:01 użytkownik Eric Sandeen
 sand...@redhat.com napisał:

 ...

 cool!  I suppose I could turn it on in rawhide, or you could just
 build your own e2fsprogs to get it ...

 I already built my own version.

 Ok, let me know if you can break anything! :)

 (Some of my concern, which is admittedly hand-wavy, is the
 kernelside design of the thing, but any outright breakage
 of the current implementation would be good to find as well)

 Some things to test would be attempting to defrag files
 which are being actively written to / read from in various
 ways - concurrent access, mmap, etc.  Also possibly testing large
 and/or sparse files, files with extended attributes, testing
 enospc conditions 

Does it makes sense to run tests on a large filesystem? I have a spare
1tb hdd, but I do not know if it's worth to run such tests.

Regards,
Michal
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


e4defrag repetable segfault (Re: e4defrag support?)

2010-10-10 Thread Michał Piotrowski
2010/10/6 Eric Sandeen sand...@redhat.com:
 Frank Murphy wrote:
 On 06/10/10 16:31, Eric Sandeen wrote:

 Maybe I'm being a bit too paranoid but it is your data after all :)


 I just use Rawhide for testing,
 so a little reinstall keeps you in practice :D


 OK gang, it's in e2fsprogs-1.41.12-6.fc15

 you have to invoke it with -test options to make it go ;)

 Word of warning, it's not had a lot of attention, and the whole
 design could change in the future, but it's something to play with :)

 -Eric

It's my e2fsbuild build

e4defrag[23597]: segfault at 20 ip 0040232c sp
7fff5bb0cd20 error 4 in e4defrag[40+5000]
e4defrag[29272]: segfault at 20 ip 0040232c sp
7fff7383d540 error 4 in e4defrag[40+5000]
e4defrag[13291]: segfault at 20 ip 0040232c sp
7fff32ede890 error 4 in e4defrag[40+5000]
e4defrag[13682]: segfault at 20 ip 0040232c sp
7fff44f5c970 error 4 in e4defrag[40+5000]
e4defrag[13990]: segfault at 20 ip 0040232c sp
7fff8a7b7300 error 4 in e4defrag[40+5000]
e4defrag[14961]: segfault at 20 ip 0040232c sp
7fff05e724f0 error 4 in e4defrag[40+5000]
e4defrag[15501]: segfault at 20 ip 0040232c sp
7fff1e406530 error 4 in e4defrag[40+5000]

How to repeat?

create an ext4 image and mount it in /mnt/tmp/test
run
canto_della_terra.sh /mnt/tmp/test/ /mnt/tmp/reply.sh 30

Regards,
Michal


canto_della_terra.sh
Description: Bourne shell script
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: e4defrag repetable segfault (Re: e4defrag support?)

2010-10-10 Thread Michał Piotrowski
 e4defrag[23597]: segfault at 20 ip 0040232c sp
 7fff5bb0cd20 error 4 in e4defrag[40+5000]

This is caused by the race between rm and e4defrag

repeatable with attached
canto_della_terra2.sh /mnt/tmp/test/ /mnt/tmp/reply.sh 50

Regards,
Michal


canto_della_terra2.sh
Description: Bourne shell script
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: e4defrag support?

2010-10-06 Thread Eric Sandeen
Michał Piotrowski wrote:
 W dniu 6 października 2010 05:01 użytkownik Eric Sandeen
 sand...@redhat.com napisał:

...

 cool!  I suppose I could turn it on in rawhide, or you could just
 build your own e2fsprogs to get it ...
 
 I already built my own version.

Ok, let me know if you can break anything! :)

(Some of my concern, which is admittedly hand-wavy, is the
kernelside design of the thing, but any outright breakage
of the current implementation would be good to find as well)

Some things to test would be attempting to defrag files
which are being actively written to / read from in various
ways - concurrent access, mmap, etc.  Also possibly testing large
and/or sparse files, files with extended attributes, testing
enospc conditions 

If you find a way to break it we can enshrine it as a regression
test in the testsuite.

Thanks!

-Eric
 
 -Eric

 
 Regards,
 Michal

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: e4defrag support?

2010-10-06 Thread Chris Adams
Once upon a time, Eric Sandeen sand...@redhat.com said:
 Some things to test would be attempting to defrag files
 which are being actively written to / read from in various
 ways - concurrent access, mmap, etc.

Also make sure to test files used by sendfile() and splice()/vmsplice().

-- 
Chris Adams cmad...@hiwaay.net
Systems and Network Administrator - HiWAAY Internet Services
I don't speak for anybody but myself - that's enough trouble.
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: e4defrag support?

2010-10-06 Thread Clyde E. Kunkel
On 10/05/2010 11:01 PM, Eric Sandeen wrote:
 snip
 cool!  I suppose I could turn it on in rawhide, or you could just
 build your own e2fsprogs to get it ...

 -Eric



Cool if you turn it on in rawhide.  Helps those of us who are build 
challenged :-).  I can test in raid and LV environments.

Regards,
OldFart
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: e4defrag support?

2010-10-06 Thread Eric Sandeen
Clyde E. Kunkel wrote:
 On 10/05/2010 11:01 PM, Eric Sandeen wrote:
 snip
 cool!  I suppose I could turn it on in rawhide, or you could just
 build your own e2fsprogs to get it ...

 -Eric

 
 
 Cool if you turn it on in rawhide.  Helps those of us who are build 
 challenged :-).  I can test in raid and LV environments.

ok... now, everyone promise not to cry if it does something bad
to your rawhide box!  ;)
 
I'll turn it on today... hm I might rename it e4defrag_test for now,
just to make it a little more obvious.

Maybe I'm being a bit too paranoid but it is your data after all :)

-Eric

 Regards,
 OldFart

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: e4defrag support?

2010-10-06 Thread Frank Murphy
On 06/10/10 16:29, Clyde E. Kunkel wrote:
snip
 Cool if you turn it on in rawhide.  Helps those of us who are build
 challenged :-).  I can test in raid and LV environments.

 Regards,
 OldFart

Likewise, if basic instruction provided.

-- 
Regards,

Frank Murphy
UTF_8 Encoded
Friend of Fedora
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: e4defrag support?

2010-10-06 Thread Frank Murphy
On 06/10/10 16:31, Eric Sandeen wrote:


 Maybe I'm being a bit too paranoid but it is your data after all :)


I just use Rawhide for testing,
so a little reinstall keeps you in practice :D

-- 
Regards,

Frank Murphy
UTF_8 Encoded
Friend of Fedora
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: e4defrag support?

2010-10-06 Thread Eric Sandeen
Frank Murphy wrote:
 On 06/10/10 16:31, Eric Sandeen wrote:

 Maybe I'm being a bit too paranoid but it is your data after all :)

 
 I just use Rawhide for testing,
 so a little reinstall keeps you in practice :D
 

OK gang, it's in e2fsprogs-1.41.12-6.fc15

you have to invoke it with -test options to make it go ;)

Word of warning, it's not had a lot of attention, and the whole
design could change in the future, but it's something to play with :)

-Eric
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: e4defrag support?

2010-10-06 Thread Clyde E. Kunkel
On 10/06/2010 02:01 PM, Eric Sandeen wrote:
snip
 OK gang, it's in e2fsprogs-1.41.12-6.fc15

 you have to invoke it with -test options to make it go ;)

 Word of warning, it's not had a lot of attention, and the whole
 design could change in the future, but it's something to play with :)

 -Eric

Docs with it?  In man pages?

Thanks!!
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: e4defrag support?

2010-10-06 Thread Eric Sandeen
Clyde E. Kunkel wrote:
 On 10/06/2010 02:01 PM, Eric Sandeen wrote:
 snip
 OK gang, it's in e2fsprogs-1.41.12-6.fc15

 you have to invoke it with -test options to make it go ;)

 Word of warning, it's not had a lot of attention, and the whole
 design could change in the future, but it's something to play with :)

 -Eric
 
 Docs with it?  In man pages?

yep :)

/usr/sbin/e4defrag
/usr/share/man/man8/e4defrag.8.gz

-Eric

 Thanks!!

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: e4defrag support?

2010-10-06 Thread Michał Piotrowski
W dniu 6 października 2010 15:42 użytkownik Eric Sandeen
sand...@redhat.com napisał:
 Michał Piotrowski wrote:
 W dniu 6 października 2010 05:01 użytkownik Eric Sandeen
 sand...@redhat.com napisał:

 ...

 cool!  I suppose I could turn it on in rawhide, or you could just
 build your own e2fsprogs to get it ...

 I already built my own version.

 Ok, let me know if you can break anything! :)

 (Some of my concern, which is admittedly hand-wavy, is the
 kernelside design of the thing, but any outright breakage
 of the current implementation would be good to find as well)

 Some things to test would be attempting to defrag files
 which are being actively written to / read from in various
 ways - concurrent access, mmap, etc

I want to start with basic scenario:
- mad file/directory/link creation/delete/move - something like fsrace/fsfuzzer
- create file checksums
- defrag file/dir/image
- verify checksums

.  Also possibly testing large
 and/or sparse files, files with extended attributes, testing
 enospc conditions 

 If you find a way to break it we can enshrine it as a regression
 test in the testsuite.

I plan to log all actions taken by the script - something like a
reply option :)

I do not know if it will work but worth a try


 Thanks!

 -Eric

Regards,
Michal
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


e4defrag support?

2010-10-05 Thread Michał Piotrowski
Hi,

I'm curious why e4defrag isn't enabled in e2fsprogs. Are there any
problems with this tool?

Regards,
Michal
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: e4defrag support?

2010-10-05 Thread Eric Sandeen
Michał Piotrowski wrote:
 Hi,
 
 I'm curious why e4defrag isn't enabled in e2fsprogs. Are there any
 problems with this tool?

It's had really limited testing, and the kernel interface has had
some problems in the past (though I guess that's irrelevant to
shipping the userspace)

I guess it's a little of a chicken-and-egg problem; no binary, no
testing; no testing, I hesitate to unleash the binary, which has
serious data integrity implications.

I think it's going to need some concentrated development  testing
love to get to full readiness.

-Eric
 
 Regards,
 Michal

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: e4defrag support?

2010-10-05 Thread Michał Piotrowski
2010/10/6 Eric Sandeen sand...@redhat.com:
 Michał Piotrowski wrote:
 Hi,

 I'm curious why e4defrag isn't enabled in e2fsprogs. Are there any
 problems with this tool?

 It's had really limited testing, and the kernel interface has had
 some problems in the past (though I guess that's irrelevant to
 shipping the userspace)

 I guess it's a little of a chicken-and-egg problem; no binary, no
 testing; no testing, I hesitate to unleash the binary, which has
 serious data integrity implications.

 I think it's going to need some concentrated development  testing
 love to get to full readiness.

I can help with testing. I have some experience in creating test
scripts/cases etc.


 -Eric

Regards,
Michal
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: e4defrag support?

2010-10-05 Thread Eric Sandeen
Michał Piotrowski wrote:
 2010/10/6 Eric Sandeen sand...@redhat.com:
 Michał Piotrowski wrote:
 Hi,

 I'm curious why e4defrag isn't enabled in e2fsprogs. Are there any
 problems with this tool?
 It's had really limited testing, and the kernel interface has had
 some problems in the past (though I guess that's irrelevant to
 shipping the userspace)

 I guess it's a little of a chicken-and-egg problem; no binary, no
 testing; no testing, I hesitate to unleash the binary, which has
 serious data integrity implications.

 I think it's going to need some concentrated development  testing
 love to get to full readiness.
 
 I can help with testing. I have some experience in creating test
 scripts/cases etc.

cool!  I suppose I could turn it on in rawhide, or you could just
build your own e2fsprogs to get it ...

-Eric

 -Eric
 
 Regards,
 Michal

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: e4defrag support?

2010-10-05 Thread Michał Piotrowski
W dniu 6 października 2010 05:01 użytkownik Eric Sandeen
sand...@redhat.com napisał:
 Michał Piotrowski wrote:
 2010/10/6 Eric Sandeen sand...@redhat.com:
 Michał Piotrowski wrote:
 Hi,

 I'm curious why e4defrag isn't enabled in e2fsprogs. Are there any
 problems with this tool?
 It's had really limited testing, and the kernel interface has had
 some problems in the past (though I guess that's irrelevant to
 shipping the userspace)

 I guess it's a little of a chicken-and-egg problem; no binary, no
 testing; no testing, I hesitate to unleash the binary, which has
 serious data integrity implications.

 I think it's going to need some concentrated development  testing
 love to get to full readiness.

 I can help with testing. I have some experience in creating test
 scripts/cases etc.

 cool!  I suppose I could turn it on in rawhide, or you could just
 build your own e2fsprogs to get it ...

I already built my own version.


 -Eric


Regards,
Michal
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel