Re: jplesnik pushed to perl-XML-Parser (master). "Specify all dependencies"

2018-07-25 Thread Vít Ondruch
Dne 23.7.2018 v 16:40 Vít Ondruch napsal(a): > > Dne 23.7.2018 v 15:28 Florian Weimer napsal(a): >> On 07/23/2018 02:35 PM, Vít Ondruch wrote: >>> >>> Dne 23.7.2018 v 14:19 Vít Ondruch napsal(a): Dne 23.7.2018 v 14:14 Dominik 'Rathann' Mierzejewski napsal(a): > On Monday, 23 July 2018 at

Re: jplesnik pushed to perl-XML-Parser (master). "Specify all dependencies"

2018-07-23 Thread Vít Ondruch
Dne 23.7.2018 v 15:28 Florian Weimer napsal(a): > On 07/23/2018 02:35 PM, Vít Ondruch wrote: >> >> >> Dne 23.7.2018 v 14:19 Vít Ondruch napsal(a): >>> >>> Dne 23.7.2018 v 14:14 Dominik 'Rathann' Mierzejewski napsal(a): On Monday, 23 July 2018 at 14:07, Florian Weimer wrote: > On 07/23/20

Re: jplesnik pushed to perl-XML-Parser (master). "Specify all dependencies"

2018-07-23 Thread Florian Weimer
On 07/23/2018 02:35 PM, Vít Ondruch wrote: Dne 23.7.2018 v 14:19 Vít Ondruch napsal(a): Dne 23.7.2018 v 14:14 Dominik 'Rathann' Mierzejewski napsal(a): On Monday, 23 July 2018 at 14:07, Florian Weimer wrote: On 07/23/2018 02:00 PM, Dominik 'Rathann' Mierzejewski wrote: On Monday, 23 July 2

Re: jplesnik pushed to perl-XML-Parser (master). "Specify all dependencies"

2018-07-23 Thread Igor Gnatenko
On Mon, Jul 23, 2018 at 3:01 PM Florian Weimer wrote: > On 07/23/2018 02:00 PM, Dominik 'Rathann' Mierzejewski wrote: > > On Monday, 23 July 2018 at 13:12, Jitka Plesníková wrote: > >> I've added BR glibc-common, because it contains the iconv binary. iconv > >> is used in spec file. > > > > Maybe

Re: jplesnik pushed to perl-XML-Parser (master). "Specify all dependencies"

2018-07-23 Thread Vít Ondruch
Dne 23.7.2018 v 14:19 Vít Ondruch napsal(a): > > Dne 23.7.2018 v 14:14 Dominik 'Rathann' Mierzejewski napsal(a): >> On Monday, 23 July 2018 at 14:07, Florian Weimer wrote: >>> On 07/23/2018 02:00 PM, Dominik 'Rathann' Mierzejewski wrote: On Monday, 23 July 2018 at 13:12, Jitka Plesníková wro

Re: jplesnik pushed to perl-XML-Parser (master). "Specify all dependencies"

2018-07-23 Thread Vít Ondruch
Dne 23.7.2018 v 14:14 Dominik 'Rathann' Mierzejewski napsal(a): > On Monday, 23 July 2018 at 14:07, Florian Weimer wrote: >> On 07/23/2018 02:00 PM, Dominik 'Rathann' Mierzejewski wrote: >>> On Monday, 23 July 2018 at 13:12, Jitka Plesníková wrote: I've added BR glibc-common, because it cont

Re: jplesnik pushed to perl-XML-Parser (master). "Specify all dependencies"

2018-07-23 Thread Tom Hughes
On 23/07/18 13:14, Dominik 'Rathann' Mierzejewski wrote: On Monday, 23 July 2018 at 14:07, Florian Weimer wrote: On 07/23/2018 02:00 PM, Dominik 'Rathann' Mierzejewski wrote: On Monday, 23 July 2018 at 13:12, Jitka Plesníková wrote: I've added BR glibc-common, because it contains the iconv bin

Re: jplesnik pushed to perl-XML-Parser (master). "Specify all dependencies"

2018-07-23 Thread Dominik 'Rathann' Mierzejewski
On Monday, 23 July 2018 at 14:07, Florian Weimer wrote: > On 07/23/2018 02:00 PM, Dominik 'Rathann' Mierzejewski wrote: > > On Monday, 23 July 2018 at 13:12, Jitka Plesníková wrote: > > > I've added BR glibc-common, because it contains the iconv binary. iconv > > > is used in spec file. > > > > Ma

Re: jplesnik pushed to perl-XML-Parser (master). "Specify all dependencies"

2018-07-23 Thread Florian Weimer
On 07/23/2018 02:00 PM, Dominik 'Rathann' Mierzejewski wrote: On Monday, 23 July 2018 at 13:12, Jitka Plesníková wrote: I've added BR glibc-common, because it contains the iconv binary. iconv is used in spec file. Maybe it's better to do: BuildRequires: %{_bindir}/iconv instead? We need to

Re: jplesnik pushed to perl-XML-Parser (master). "Specify all dependencies"

2018-07-23 Thread Dominik 'Rathann' Mierzejewski
On Monday, 23 July 2018 at 13:12, Jitka Plesníková wrote: > I've added BR glibc-common, because it contains the iconv binary. iconv > is used in spec file. Maybe it's better to do: BuildRequires: %{_bindir}/iconv instead? Regards, Dominik -- Fedora https://getfedora.org | RPMFusion http:

Re: jplesnik pushed to perl-XML-Parser (master). "Specify all dependencies"

2018-07-23 Thread Florian Weimer
On 07/23/2018 01:12 PM, Jitka Plesníková wrote: I've added BR glibc-common, because it contains the iconv binary. iconv is used in spec file. Jitka On 07/23/2018 12:57 PM, Florian Weimer wrote: On 07/23/2018 10:06 AM, notificati...@fedoraproject.org wrote: +BuildRequires:  glibc-common glib

Re: jplesnik pushed to perl-XML-Parser (master). "Specify all dependencies"

2018-07-23 Thread Jitka Plesníková
I've added BR glibc-common, because it contains the iconv binary. iconv is used in spec file. Jitka On 07/23/2018 12:57 PM, Florian Weimer wrote: > On 07/23/2018 10:06 AM, notificati...@fedoraproject.org wrote: >> +BuildRequires:  glibc-common > > glibc-common is an internal implementation detail

Re: jplesnik pushed to perl-XML-Parser (master). "Specify all dependencies"

2018-07-23 Thread Florian Weimer
On 07/23/2018 10:06 AM, notificati...@fedoraproject.org wrote: +BuildRequires: glibc-common glibc-common is an internal implementation detail of glibc. You should not add dependencies on it. For building against the C run-time, you should only specify Requires: gcc or (if necessary)