Re: libtommath minor soname bump

2023-09-10 Thread Kevin Kofler via devel
František Šumšal wrote:
> I plan to bump libtommath to 1.2.1 in Rawhide, which bumps the respective
> shared library to libtommath.so.1.2.1. According to repoquery all
> dependencies depend only on libtommath.1, so no rebuild should be
> necessary:

That is not an soname bump then. :-)

The soname is just what is written in the DT_SONAME field, which is what the 
applications end up depending on, and is in this case "libtommath.so.1". It 
typically only includes the major soversion (e.g., 1), not the full version 
(e.g., 1.2.1). "libtommath.so.1.2.1" is the fully versioned name, but a bump 
of that name should have no effect on applications (unless upstream either 
does not understand soversioning or made an inadvertent mistake).

If you find something in such a minor version bump that (unexpectedly) 
requires applications to be rebuilt, then you should urge upstream to bump 
the major soversion and hence the soname (so that they would ship, e.g., 
libtommath.so.2→libtommath.so.2.0.0 instead of 
libtommath.so.1→libtommath.so.1.2.1), but this does not seem to be the case 
here. Hence, no bump of the major soversion is needed, and hence, no 
announcement is needed either.

Kevin Kofler
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: libtommath minor soname bump

2023-09-08 Thread Dominik 'Rathann' Mierzejewski
On Thursday, 07 September 2023 at 22:40, František Šumšal wrote:
[...]
> Both abipkgdiff and rpmsodiff seem to be happy, i.e. there were no
> added/changed/removed symbols between 1.2.0 and 1.2.1, so the bump
> should be safe.

Excellent, this means the version update should be transparent to any
package depending on the library. You do not have to announce such
updates here.

Regards,
Dominik
-- 
Fedora   https://fedoraproject.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
-- from "Collected Sayings of Muad'Dib" by the Princess Irulan
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: libtommath minor soname bump

2023-09-07 Thread František Šumšal

On 9/7/23 11:40, Dominik 'Rathann' Mierzejewski wrote:

On Thursday, 07 September 2023 at 11:13, František Šumšal wrote:

Hello,

I plan to bump libtommath to 1.2.1 in Rawhide, which bumps the respective 
shared library to libtommath.so.1.2.1. According to repoquery all dependencies 
depend only on libtommath.1, so no rebuild should be necessary:

$ dnf repoquery --releasever rawhide --whatrequires 'libtommath.so.*'
Last metadata expiration check: 0:20:29 ago on Thu Sep  7 10:34:05 2023.
dropbear-0:2022.82-3.fc39.x86_64
firebird-0:4.0.3.2975-1.fc39.x86_64
libfbclient2-0:4.0.3.2975-1.fc39.i686
libfbclient2-0:4.0.3.2975-1.fc39.x86_64
libtomcrypt-0:1.18.2-17.fc39.i686
libtomcrypt-0:1.18.2-17.fc39.x86_64
libtommath-devel-0:1.2.0-13.fc40.i686
libtommath-devel-0:1.2.0-13.fc40.x86_64
moarvm-0:2023.06-1.fc39.i686
moarvm-0:2023.06-1.fc39.x86_64

$ dnf repoquery --releasever rawhide --whatrequires 'libtommath.so.1.*'
Last metadata expiration check: 0:21:06 ago on Thu Sep  7 10:34:05 2023.
<...no results...>

Please correct me if I'm missing something.


Your first step should be checking for any ABI changes using abipkgdiff
and rpmsodiff. Only if there are removed symbols do you need to worry
about rebuilding consumers. However, added unversioned symbols do mean
that backwards compatibility is not preserved (i.e. an application built
against a newer version, say 1.2.1, might not work with 1.2.0 installed
if it depends on a symbol introduced in 1.2.1).


Thanks for the pointers, much appreciated!

Both abipkgdiff and rpmsodiff seem to be happy, i.e. there were no
added/changed/removed symbols between 1.2.0 and 1.2.1, so the bump
should be safe.

Cheers,
Frantisek
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: libtommath minor soname bump

2023-09-07 Thread Dominik 'Rathann' Mierzejewski
On Thursday, 07 September 2023 at 11:13, František Šumšal wrote:
> Hello,
> 
> I plan to bump libtommath to 1.2.1 in Rawhide, which bumps the respective 
> shared library to libtommath.so.1.2.1. According to repoquery all 
> dependencies depend only on libtommath.1, so no rebuild should be necessary:
> 
> $ dnf repoquery --releasever rawhide --whatrequires 'libtommath.so.*'
> Last metadata expiration check: 0:20:29 ago on Thu Sep  7 10:34:05 2023.
> dropbear-0:2022.82-3.fc39.x86_64
> firebird-0:4.0.3.2975-1.fc39.x86_64
> libfbclient2-0:4.0.3.2975-1.fc39.i686
> libfbclient2-0:4.0.3.2975-1.fc39.x86_64
> libtomcrypt-0:1.18.2-17.fc39.i686
> libtomcrypt-0:1.18.2-17.fc39.x86_64
> libtommath-devel-0:1.2.0-13.fc40.i686
> libtommath-devel-0:1.2.0-13.fc40.x86_64
> moarvm-0:2023.06-1.fc39.i686
> moarvm-0:2023.06-1.fc39.x86_64
> 
> $ dnf repoquery --releasever rawhide --whatrequires 'libtommath.so.1.*'
> Last metadata expiration check: 0:21:06 ago on Thu Sep  7 10:34:05 2023.
> <...no results...>
> 
> Please correct me if I'm missing something.

Your first step should be checking for any ABI changes using abipkgdiff
and rpmsodiff. Only if there are removed symbols do you need to worry
about rebuilding consumers. However, added unversioned symbols do mean
that backwards compatibility is not preserved (i.e. an application built
against a newer version, say 1.2.1, might not work with 1.2.0 installed
if it depends on a symbol introduced in 1.2.1).

Regards,
Dominik
-- 
Fedora   https://fedoraproject.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
-- from "Collected Sayings of Muad'Dib" by the Princess Irulan
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


libtommath minor soname bump

2023-09-07 Thread František Šumšal

Hello,

I plan to bump libtommath to 1.2.1 in Rawhide, which bumps the respective 
shared library to libtommath.so.1.2.1. According to repoquery all dependencies 
depend only on libtommath.1, so no rebuild should be necessary:

$ dnf repoquery --releasever rawhide --whatrequires 'libtommath.so.*'
Last metadata expiration check: 0:20:29 ago on Thu Sep  7 10:34:05 2023.
dropbear-0:2022.82-3.fc39.x86_64
firebird-0:4.0.3.2975-1.fc39.x86_64
libfbclient2-0:4.0.3.2975-1.fc39.i686
libfbclient2-0:4.0.3.2975-1.fc39.x86_64
libtomcrypt-0:1.18.2-17.fc39.i686
libtomcrypt-0:1.18.2-17.fc39.x86_64
libtommath-devel-0:1.2.0-13.fc40.i686
libtommath-devel-0:1.2.0-13.fc40.x86_64
moarvm-0:2023.06-1.fc39.i686
moarvm-0:2023.06-1.fc39.x86_64

$ dnf repoquery --releasever rawhide --whatrequires 'libtommath.so.1.*'
Last metadata expiration check: 0:21:06 ago on Thu Sep  7 10:34:05 2023.
<...no results...>

Please correct me if I'm missing something.

Cheers,
Frantisek
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue