Re: rawhide no longer recognizing autotool macros

2019-06-20 Thread Neal Gompa
On Thu, Jun 20, 2019 at 6:27 PM Jason Tibbitts wrote: > > > "PK" == Philip Kovacs via devel writes: > > PK> Years ago when I was writing my specs to add the packages I now > PK> maintain, I recall someone recommended to me the use of these macros as > PK> Fedora "tribal knowledge." I am happy

Re: rawhide no longer recognizing autotool macros

2019-06-20 Thread Jason Tibbitts
> "PK" == Philip Kovacs via devel writes: PK> Years ago when I was writing my specs to add the packages I now PK> maintain, I recall someone recommended to me the use of these macros as PK> Fedora "tribal knowledge." I am happy to remove mine if their use is PK> unnecessary and could lead to

Re: rawhide no longer recognizing autotool macros

2019-06-19 Thread Pavel Raiskup
On Wednesday, June 19, 2019 6:27:31 PM CEST Philip Kovacs via devel wrote: > I use those macros wherever possible, but sometimes I need a raw `make`in > order to specify uncommon targets. I'll just replace `__make` with `make` > for now. No harm there. $ rpm --eval %make_build /usr/bin/make

Re: rawhide no longer recognizing autotool macros

2019-06-19 Thread Philip Kovacs via devel
I use those macros wherever possible, but sometimes I need a raw `make`in order to specify uncommon targets. I'll just replace `__make` with `make` for now.   No harm there.On Wednesday, June 19, 2019, 12:06:44 PM EDT, Vitaly Zaitsev via devel wrote: Hello, Philip Kovacs via devel. W

Re: rawhide no longer recognizing autotool macros

2019-06-19 Thread Vitaly Zaitsev via devel
Hello, Philip Kovacs via devel. Wed, 19 Jun 2019 15:28:10 + (UTC) you wrote: > I notice I am still using the `__make` macro in my specs.  While they > still work, should we proactively replace them with `make` ? You can use %make_build and %make_install instead. -- Sincerely, Vitaly Zaitse

Re: rawhide no longer recognizing autotool macros

2019-06-19 Thread Philip Kovacs via devel
None that I can tell.  Years ago when I was writing my specs to add the packages I now maintain, I recallsomeone recommended to me the use of these macros as Fedora "tribal knowledge."   I am happy to remove mine if their use is unnecessary and could lead to breakage. On Wednesday, June 19

Re: rawhide no longer recognizing autotool macros

2019-06-19 Thread Christophe de Dinechin
> On 19 Jun 2019, at 17:28, Philip Kovacs via devel > wrote: > > I notice I am still using the `__make` macro in my specs. While they still > work, should we proactively replace them with `make` ? Is there any downside in replacing it? > > The additional message I am getting here is that

Re: rawhide no longer recognizing autotool macros

2019-06-19 Thread Philip Kovacs via devel
I notice I am still using the `__make` macro in my specs.  While they still work, should we proactively replace them with `make` ? The additional message I am getting here is that the under-under macros might be subject to removal. ThanksPhil___ devel m

Re: rawhide no longer recognizing autotool macros

2019-06-19 Thread Panu Matilainen
On 6/19/19 11:40 AM, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Jun 19, 2019 at 01:21:38AM -0400, Elliott Sales de Andrade wrote: On Wed, 19 Jun 2019 at 01:18, Philip Kovacs via devel wrote: OK, my builds are back in order having removed those macros and replaced them with commands. I expec

Re: rawhide no longer recognizing autotool macros

2019-06-19 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jun 19, 2019 at 01:21:38AM -0400, Elliott Sales de Andrade wrote: > On Wed, 19 Jun 2019 at 01:18, Philip Kovacs via devel > wrote: > > > > OK, my builds are back in order having removed those macros and replaced > > them with commands. > > > > I expect that many package maintainers will b

Re: rawhide no longer recognizing autotool macros

2019-06-18 Thread Panu Matilainen
On 6/19/19 6:59 AM, Neal Gompa wrote: On Tue, Jun 18, 2019 at 10:48 PM Philip Kovacs via devel wrote: I'm getting new build failures on the autotools macros that had been working for years. rpmbuild doesn't like them anymore in rawhide. The macros are (or were) in the file `/usr/lib/rpm/ma

Re: rawhide no longer recognizing autotool macros

2019-06-18 Thread Elliott Sales de Andrade
On Wed, 19 Jun 2019 at 01:18, Philip Kovacs via devel wrote: > > OK, my builds are back in order having removed those macros and replaced them > with commands. > > I expect that many package maintainers will be hit with this. There are in fact only 10 packages using these macros: $ rg '__(acloc

Re: rawhide no longer recognizing autotool macros

2019-06-18 Thread Philip Kovacs via devel
OK, my builds are back in order having removed those macros and replaced them with commands. I expect that many package maintainers will be hit with this. On Wednesday, June 19, 2019, 12:01:31 AM EDT, Neal Gompa wrote: On Tue, Jun 18, 2019 at 10:48 PM Philip Kovacs via devel wrote: >

Re: rawhide no longer recognizing autotool macros

2019-06-18 Thread Neal Gompa
On Tue, Jun 18, 2019 at 10:48 PM Philip Kovacs via devel wrote: > > I'm getting new build failures on the autotools macros that had been working > for years. rpmbuild doesn't like > them anymore in rawhide. The macros are (or were) in the file > `/usr/lib/rpm/macros`. The relevant portion >

rawhide no longer recognizing autotool macros

2019-06-18 Thread Philip Kovacs via devel
I'm getting new build failures on the autotools macros that had been working for years.  rpmbuild doesn't likethem anymore in rawhide.  The macros are (or were) in the file `/usr/lib/rpm/macros`.   The relevant portion of my spec is here: -- spec -- %build%{__aclocal} -I auxdir%{__autoconf}%{__a