Re: rpmbuild: Bad Requireflags: qualifiers: Requires(posttrans)
On Mon, Jan 24, 2011 at 06:52:50PM +0100, Adrian Reber wrote: I was trying to do a scratch build an got following error: error: line 78: Bad Requireflags: qualifiers: Requires(posttrans): /sbin/service Is Requires(posttrans) deprecated with the newest RPM or is that a bug? http://koji.fedoraproject.org/koji/taskinfo?taskID=2738326 Thanks for all the help. Now something similar happened: Trying to build ccache: http://ppc.koji.fedoraproject.org/koji/getfile?taskID=125311name=build.log error: line 29: Bad Requireflags: qualifiers: Requires(triggerin): coreutils Will rpm also be patched to handle it again? Or are changes to the spec file necessary? Adrian -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: rpmbuild: Bad Requireflags: qualifiers: Requires(posttrans)
On 01/24/2011 09:02 PM, Bill Nottingham wrote: Rich Megginson (rmegg...@redhat.com) said: Ok. Do I need any Requires at all for this? Or should I just remove that line from the spec? I believe folding any requirements for %posttrans scripts into 'Requires(post)' should be sufficient. Plain old Requires: foo is better for %posttrans. Requires(post) and such have ordering implications that are best avoided when not needed, and %posttrans doesn't require any particular ordering. FWIW I'm considering allowing Requires(posttrans) to be handled as regular requires for now (which is how older rpms happened to treat any unknown qualifiers). The correct implementation of Requires(posttrans) semantics is twistier than that but it's a reasonable approximation. - Panu - -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: rpmbuild: Bad Requireflags: qualifiers: Requires(posttrans)
On 01/24/2011 11:16 PM, Matt McCutchen wrote: On Mon, 2011-01-24 at 14:02 -0500, Bill Nottingham wrote: I believe folding any requirements for %posttrans scripts into 'Requires(post)' should be sufficient. I don't think so... IIUC, Requires(post) only applies until installation is complete, but a %posttrans script also runs following uninstallation. Granted, it may not be a problem for other reasons. %posttrans does NOT run on uninstallation. So in that sense Requires(post) is in fact more correct than plain Requires. It really does need its own dependency type to be handled correctly though: %posttrans dependencies should not be taken into account on ordering, and it should be possible to remove such dependencies after installation (provided that nothing else depends on them of course). %posttrans dependencies only need to guarantee the dependency doesn't get removed in the same transaction. - Panu - -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: rpmbuild: Bad Requireflags: qualifiers: Requires(posttrans)
On 01/25/2011 02:54 PM, Panu Matilainen wrote: On 01/24/2011 11:16 PM, Matt McCutchen wrote: On Mon, 2011-01-24 at 14:02 -0500, Bill Nottingham wrote: I believe folding any requirements for %posttrans scripts into 'Requires(post)' should be sufficient. I don't think so... IIUC, Requires(post) only applies until installation is complete, but a %posttrans script also runs following uninstallation. Granted, it may not be a problem for other reasons. %posttrans does NOT run on uninstallation. So in that sense Requires(post) is in fact more correct than plain Requires. It really does need its own dependency type to be handled correctly though: %posttrans dependencies should not be taken into account on ordering, and it should be possible to remove such dependencies after installation (provided that nothing else depends on them of course). %posttrans dependencies only need to guarantee the dependency doesn't get removed in the same transaction. ...and that said, Requires(posttrans) is now implemented in rpm-4.9.0-0.beta1.4.fc15 and can be used once the new version hits the builders (in an hour or so). Unlike some other qualifiers that have been used while rpm was looking the other way, posttrans reflects an existing mechanism and expecting Requires(posttrans) to work is perfectly reasonable (pretrans dependencies were already implemented in rpm-4.9.0-beta1) - Panu - -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: rpmbuild: Bad Requireflags: qualifiers: Requires(posttrans)
Adrian Reber (adr...@lisas.de) said: I was trying to do a scratch build an got following error: error: line 78: Bad Requireflags: qualifiers: Requires(posttrans): /sbin/service Is Requires(posttrans) deprecated with the newest RPM or is that a bug? AFAIK, it never existed. So it's always been a syntax error, just one that was tolerated before. Bill -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: rpmbuild: Bad Requireflags: qualifiers: Requires(posttrans)
Rich Megginson (rmegg...@redhat.com) said: Ok. Do I need any Requires at all for this? Or should I just remove that line from the spec? I believe folding any requirements for %posttrans scripts into 'Requires(post)' should be sufficient. Bill -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: rpmbuild: Bad Requireflags: qualifiers: Requires(posttrans)
On 01/24/2011 12:02 PM, Bill Nottingham wrote: Rich Megginson (rmegg...@redhat.com) said: Ok. Do I need any Requires at all for this? Or should I just remove that line from the spec? I believe folding any requirements for %posttrans scripts into 'Requires(post)' should be sufficient. Ok - https://bugzilla.redhat.com/show_bug.cgi?id=672313 Bill -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: rpmbuild: Bad Requireflags: qualifiers: Requires(posttrans)
On Mon, 2011-01-24 at 14:02 -0500, Bill Nottingham wrote: I believe folding any requirements for %posttrans scripts into 'Requires(post)' should be sufficient. I don't think so... IIUC, Requires(post) only applies until installation is complete, but a %posttrans script also runs following uninstallation. Granted, it may not be a problem for other reasons. -- Matt -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
