Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-11-07 Thread Adam Williamson
On Wed, 2012-08-22 at 16:12 -0700, Adam Williamson wrote: > Hey folks - just in case you haven't all figured this out yet, if > you're using the neat little trick of putting a few lines in your > ~/.bashrc so that when you're in a directory containing a git repo, the > prompt will display what b

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-27 Thread Adam Williamson
On 2012-08-25 16:31, Garrett Holmstrom wrote: On 2012-08-25 10:09, Todd Zullinger wrote: Enrico Scholz wrote: Todd Zullinger writes: Doing this would break current users that have already configured their system to use __git_ps1(). What are "current users"? Those who installed your just rel

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-25 Thread Garrett Holmstrom
On 2012-08-25 10:09, Todd Zullinger wrote: Enrico Scholz wrote: Todd Zullinger writes: Doing this would break current users that have already configured their system to use __git_ps1(). What are "current users"? Those who installed your just released rawhide changes? No, it breaks anyone t

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-25 Thread Enrico Scholz
Todd Zullinger writes: >>> Doing this would break current users that have already configured >>> their system to use __git_ps1(). >> >> What are "current users"? Those who installed your just released >> rawhide changes? > > No, it breaks anyone that's currently using __git_ps1(), as the > functi

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-25 Thread Todd Zullinger
Enrico Scholz wrote: Todd Zullinger writes: Doing this would break current users that have already configured their system to use __git_ps1(). What are "current users"? Those who installed your just released rawhide changes? No, it breaks anyone that's currently using __git_ps1(), as the

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-25 Thread Enrico Scholz
Todd Zullinger writes: >>> I placed git-prompt.sh in /etc/profile.d where it should be sourced >>> for normal login shells. >> >> As I wrote in the update comment, please revert it. It pollutes the >> environment of every user with functions which are probably never be >> used. > ... > Doing thi

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-25 Thread Todd Zullinger
Enrico Scholz wrote: Todd Zullinger writes: I placed git-prompt.sh in /etc/profile.d where it should be sourced for normal login shells. As I wrote in the update comment, please revert it. It pollutes the environment of every user with functions which are probably never be used. As thes

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-24 Thread Ville Skyttä
On 2012-08-24 13:08, Enrico Scholz wrote: > Please move the script to /usr/share/git or to /etc/bash_completion.d > where it can be requested by the user explicitly. +1, but /etc/bash_completion.d would be a bad choice as AFAIK this script has nothing to do with completion (and besides, everythin

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-24 Thread Enrico Scholz
Todd Zullinger writes: > I placed git-prompt.sh in /etc/profile.d where it should be sourced > for normal login shells. As I wrote in the update comment, please revert it. It pollutes the environment of every user with functions which are probably never be used. As these functions are useless

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-24 Thread Dodji Seketeli
Todd Zullinger a écrit: > I placed git-prompt.sh in /etc/profile.d where it should be sourced > for normal login shells. This should make the change transparent to > most users. > > https://admin.fedoraproject.org/updates/git-1.7.12-2.fc18 Great. Thank you for doing this. Do you think it woul

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-23 Thread Scott Schmit
On Thu, Aug 23, 2012 at 12:23:48PM -0400, Stephen Gallagher wrote: > On Wed, 2012-08-22 at 16:12 -0700, Adam Williamson wrote: > > because upstream split the prompt stuff out from the bash_completion > > script. Perhaps the git packagers could consider providing git-prompt.sh > > in a more perman

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-23 Thread Todd Zullinger
I wrote: This is definitely planned. I mailed Adam (the other Adam) today to point out that this was broken by the 1.7.12 update. I don't have time to work on a fix though. But certainly, git-prompt.sh should be placed in a more permanent location in the next build. I placed git-prompt.sh

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-23 Thread Stephen Gallagher
On Wed, 2012-08-22 at 16:12 -0700, Adam Williamson wrote: > Hey folks - just in case you haven't all figured this out yet, if > you're using the neat little trick of putting a few lines in your > ~/.bashrc so that when you're in a directory containing a git repo, the > prompt will display what b

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-23 Thread John Ellson
On 08/23/2012 08:45 AM, Ville Skyttä wrote: On 2012-08-23 15:12, Jon Ciesla wrote: things in %doc shouldn't be things that affect run-time operation True, but there are other considerations in favour of unversioned dirs such as bookmarkability and general referenceability, consistency with othe

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-23 Thread Jon Ciesla
On Thu, Aug 23, 2012 at 7:45 AM, Ville Skyttä wrote: > On 2012-08-23 15:12, Jon Ciesla wrote: >> things in %doc shouldn't be things that affect run-time operation > > True, but there are other considerations in favour of unversioned dirs > such as bookmarkability and general referenceability, cons

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-23 Thread Ville Skyttä
On 2012-08-23 15:12, Jon Ciesla wrote: > things in %doc shouldn't be things that affect run-time operation True, but there are other considerations in favour of unversioned dirs such as bookmarkability and general referenceability, consistency with other distros, and general cleanliness. But this

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-23 Thread Jon Ciesla
On Thu, Aug 23, 2012 at 7:06 AM, Ville Skyttä wrote: > On 2012-08-23 04:34, Todd Zullinger wrote: >> Adam Williamson wrote: >> >>> source /usr/share/doc/git-1.7.12/contrib/completion/git-prompt.sh >>> >>> because upstream split the prompt stuff out from the bash_completion >>> script. Perhaps the

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-23 Thread Ville Skyttä
On 2012-08-23 04:34, Todd Zullinger wrote: > Adam Williamson wrote: > >> source /usr/share/doc/git-1.7.12/contrib/completion/git-prompt.sh >> >> because upstream split the prompt stuff out from the bash_completion >> script. Perhaps the git packagers could consider providing >> git-prompt.sh in a

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-22 Thread Todd Zullinger
Adam Williamson wrote: Hey folks - just in case you haven't all figured this out yet, if you're using the neat little trick of putting a few lines in your ~/.bashrc so that when you're in a directory containing a git repo, the prompt will display what branch you're in, it'll stop working when

Re: small tip regarding git branch bash prompt in F18/Rawhide

2012-08-22 Thread Pádraig Brady
On 08/23/2012 12:12 AM, Adam Williamson wrote: > Hey folks - just in case you haven't all figured this out yet, if you're > using the neat little trick of putting a few lines in your ~/.bashrc so that > when you're in a directory containing a git repo, the prompt will display > what branch you'r

small tip regarding git branch bash prompt in F18/Rawhide

2012-08-22 Thread Adam Williamson
Hey folks - just in case you haven't all figured this out yet, if you're using the neat little trick of putting a few lines in your ~/.bashrc so that when you're in a directory containing a git repo, the prompt will display what branch you're in, it'll stop working when you update to the latest