Re: speed-dreams-2.3.0: how to handle bundled jar files in spec file ?
On 25/07/2023 10:18, Martin Gansser wrote: that is, remove the jar files from the speed-dreams package and link to the Fedora jar files in the spec file. JAR files must be compiled from sources. Bundled precompiled files must be removed in %prep. -- Sincerely, Vitaly Zaitsev (vit...@easycoding.org) ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: speed-dreams-2.3.0: how to handle bundled jar files in spec file ?
Am Di., 25. Juli 2023 um 10:19 Uhr schrieb Martin Gansser : > > Hi, > > i want to package the current version of speed-dreams 2.3.0, but i noticed > that jar files for the trackeditor are included in the package, but they > already exist in the system. Not really, there are two different things going on: > compilation error: > Checking for unpackaged file(s): /usr/lib/rpm/check-files > /home/martin/rpmbuild/BUILDROOT/speed-dreams-2.3.0-1.fc38.x86_64 > error: Installed (but unpackaged) file(s) found: >/usr/bin/bsh-2.0b4.jar >/usr/bin/jdom-1.1.3.jar >/usr/bin/jgoodies-common-1.8.1.jar >/usr/bin/jgoodies-looks-2.5.3.jar This just says that your spec file installs those files as part of the build process (to the BUILDROOT, where check-files found them) but that your spec file does not declare them (in the %files section). > In the file src/tools/trackeditor/CMakeLists.txt from line 181 to line 230 > the jar files are copied as you can see. > https://sourceforge.net/p/speed-dreams/code/HEAD/tree/trunk/src/tools/trackeditor/CMakeLists.txt#l181 And that is why they get installed into the BUILDROOT. I don't think /usr/bin is a good place for jars. > do i have to use the jar files from the fedora packages now ? > > bsh-2.1.0-8.fc38.noarch > jdom-1.1.3-32.fc38.noarch > jgoodies-common-1.8.1-17.fc38.noarch > jgoodies-looks-2.7.0-7.fc38.noarch You should not "bundle" them with speed-dreams if they are available as separate packages. In that sense: Yes. BTW: The jdom package puts its jar into /usr/share/java/ as it should. > that is, remove the jar files from the speed-dreams package and link to the > Fedora jar files in the spec file. speed-dreams should "require" those packages. And you will need to adjust speed-dreams so that it uses them - by setting CLASSPATH if necessary or whatever makes speed-dreams find those jars. If your package comes with tests you might also need to buildrequire the others. Cheers Michael ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: speed-dreams-2.3.0: how to handle bundled jar files in spec file ?
I think it is better to do without the track editor for the time being and to use SD with the option -DOPTION_TRACKEDITOR:BOOL=OFF to compile. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
speed-dreams-2.3.0: how to handle bundled jar files in spec file ?
Hi, i want to package the current version of speed-dreams 2.3.0, but i noticed that jar files for the trackeditor are included in the package, but they already exist in the system. compilation error: Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/martin/rpmbuild/BUILDROOT/speed-dreams-2.3.0-1.fc38.x86_64 error: Installed (but unpackaged) file(s) found: /usr/bin/bsh-2.0b4.jar /usr/bin/jdom-1.1.3.jar /usr/bin/jgoodies-common-1.8.1.jar /usr/bin/jgoodies-looks-2.5.3.jar In the file src/tools/trackeditor/CMakeLists.txt from line 181 to line 230 the jar files are copied as you can see. https://sourceforge.net/p/speed-dreams/code/HEAD/tree/trunk/src/tools/trackeditor/CMakeLists.txt#l181 do i have to use the jar files from the fedora packages now ? bsh-2.1.0-8.fc38.noarch jdom-1.1.3-32.fc38.noarch jgoodies-common-1.8.1-17.fc38.noarch jgoodies-looks-2.7.0-7.fc38.noarch that is, remove the jar files from the speed-dreams package and link to the Fedora jar files in the spec file. Regards Martin ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
