Re: [Geany-Devel] Gaeny-plugins: Some minor changes to silence warnings

2013-02-19 Thread Frank Lanitz
Am 17.02.2013 04:09, schrieb Lex Trotman: Attached is a patch containing a few obvious fixes for warnings in the plugins, mostly adding consts, gpointer casts and unsigned int loop counters. The only one that is likely to have been bad (tm) is in treebrowser.c it g_freed a static string.

Re: [Geany-Devel] Gaeny-plugins: Some minor changes to silence warnings

2013-02-19 Thread Colomban Wendling
Le 19/02/2013 13:22, Frank Lanitz a écrit : Am 17.02.2013 04:09, schrieb Lex Trotman: Attached is a patch containing a few obvious fixes for warnings in the plugins, mostly adding consts, gpointer casts and unsigned int loop counters. The only one that is likely to have been bad (tm) is in

Re: [Geany-Devel] Feature: editor tab width

2013-02-19 Thread Steven Blatnick
Hope you don't mind my CCing the list. Answers/questions inline below. On 02/17/2013 01:02 AM, Matthew Brush wrote: On 13-02-16 11:50 PM, Matthew Brush wrote: On 13-02-16 07:22 PM, Steven Blatnick wrote: Do I need to change anything this time, or is it okay this once? See my notes :)

Re: [Geany-Devel] Feature: editor tab width

2013-02-19 Thread Steven Blatnick
Oh, sorry! I forgot the bottom pane is called the Message Window. I thought you were referring to dialogs. Disregard my confusion I just tried on master, and the key-binding fix I made seems to be there since I can now switch tabs on the Message Window. I did note that the key-binding to

Re: [Geany-Devel] Gaeny-plugins: Some minor changes to silence warnings

2013-02-19 Thread Lex Trotman
Additional patch to treebrowser.c make sure every path leading to a g_free has a g_strdup(), oops. Note I am only using the HACKING approved -Wall -Wextra -O2 -Wno-unused-parameter not the full War and Peace novel of options that Colomban uses :) Cheers Lex On 20 February 2013 00:31, Colomban