Re: [Geany-Devel] codesubmit plugin

2013-03-04 Thread Mayank Jha
@all developers please point out any insufficiency in my code! ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel

Re: [Geany-Devel] codesubmit plugin

2013-03-01 Thread Mayank Jha
Does embedded python code refer to the following? line 264 onwards https://github.com/mjnovice/geany-plugins/edit/master/codesubmit/src/codesubmit.c or is it the file y.py in the geany-plugins tree? ___ Devel mailing list Devel@lists.geany.org https://lis

Re: [Geany-Devel] codesubmit plugin

2013-02-28 Thread Matthew Brush
On 13-02-28 01:12 PM, Mayank Jha wrote: thanx a lot for ur feedback. I could not get a few things clearly: 1. Is this readme not OK? https://github.com/mjnovice/geany-plugins/blob/master/codesubmit/README You need to compile it with doc-utils/rst2html to be sure. Also you should copy other plu

Re: [Geany-Devel] codesubmit plugin

2013-02-28 Thread Mayank Jha
thanx a lot for ur feedback. I could not get a few things clearly: 1. Is this readme not OK? https://github.com/mjnovice/geany-plugins/blob/master/codesubmit/README 2. " #include "config.h" (check other plugins for it if needed)" couldn't get what do we need to do here? 3. Do I need to provide a s

Re: [Geany-Devel] codesubmit plugin

2013-02-27 Thread Frank Lanitz
Am 27.02.2013 00:08, schrieb Mayank Jha: > To all esteemed developers Frank Lanitz, Matthew Brush. Kindly review my > code which i have modified according to your suggestions. My note without looking into it to much: - README is missing - Licence is missing - Make usage of PLUGIN_SET_TRANSLATABLE_

Re: [Geany-Devel] codesubmit plugin

2013-02-26 Thread Matthew Brush
On 13-02-26 03:43 PM, Lex Trotman wrote: On 27 February 2013 10:26, Thomas Martitz wrote: Am 27.02.2013 00:08, schrieb Mayank Jha: To all esteemed developers Frank Lanitz, Matthew Brush. Kindly review my code which i have modified according to your suggestions. Shall we guess what your pl

Re: [Geany-Devel] codesubmit plugin

2013-02-26 Thread Lex Trotman
On 27 February 2013 10:26, Thomas Martitz wrote: > Am 27.02.2013 00:08, schrieb Mayank Jha: > >> To all esteemed developers Frank Lanitz, Matthew Brush. Kindly review my >> code which i have modified according to your suggestions. > > > > Shall we guess what your plugin does? > > Regarding the emb

Re: [Geany-Devel] codesubmit plugin

2013-02-26 Thread Lex Trotman
1) Please get your indentation right, it makes it hard to read with randomly incorrect indentation, limit lines to ~80 characters, sloppy styling makes it hard to read and does not give us much confidence in the quality of your code, layout the python script string so it is legible, remove the comm

Re: [Geany-Devel] codesubmit plugin

2013-02-26 Thread Thomas Martitz
Am 27.02.2013 00:08, schrieb Mayank Jha: To all esteemed developers Frank Lanitz, Matthew Brush. Kindly review my code which i have modified according to your suggestions. Shall we guess what your plugin does? Regarding the embedded python script. I don't think you actually need to write it

[Geany-Devel] codesubmit plugin

2013-02-26 Thread Mayank Jha
To all esteemed developers Frank Lanitz, Matthew Brush. Kindly review my code which i have modified according to your suggestions. codesubmitc Description: Binary data Makefile.am Description: Binary data ___ Devel mailing list Devel@lists.geany.org h