Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Lex Trotman
KMP calculates a table of how many characters it can skip if some of the search string matches but not all of it. Its more useful for relatively large search strings since it can skip potentially a lot of compares. Since this use is always going to search the whole file, to mark all occurrances

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Lex Trotman
Does it have any major drawbacks? I read it has to some kind prefix table prior to running the search, but I guess that's negligible for all reasonable search terms? I think KMP does not have drawbacks. The prefix table is of length m+1, m is the length of the string P for which you

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Lex Trotman
On 29 May 2015 at 23:22, Lex Trotman ele...@gmail.com wrote: Does it have any major drawbacks? I read it has to some kind prefix table prior to running the search, but I guess that's negligible for all reasonable search terms? I think KMP does not have drawbacks. The prefix table is of

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Matthew Brush
On 2015-05-29 02:03 PM, Jiří Techet wrote: On Fri, May 29, 2015 at 1:25 AM, Matthew Brush mbr...@codebrainz.ca wrote: Ideally you could improve the underlying implementation of an existing one if your way is better[0] and they perform the same function. It's really confusing for users to

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Matthew Brush
On 2015-05-29 04:45 PM, Matthew Brush wrote: [snip] I was thinking something like this for implementation: [snip] - Upon Scintilla notification of position changed, check if there's a current word at the cursor. Question: Is it important to make it mark the selection if there is one,

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Colomban Wendling
Le 29/05/2015 02:38, Lex Trotman a écrit : […] That being said, showing occurrences of the word is such a common and fairly useful feature for an IDE, I'd personally rather see the 3-4 existing plugins obsoleted by a good implementation in core Geany[1]. +1 Gotta agree, this is so

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Colomban Wendling
Hey, Le 30/05/2015 01:45, Matthew Brush a écrit : […] I was thinking something like this for implementation: - Have a preference to enable the feature (since it would now be automatic). Have the preference turned off by default. Put the preference in Preferences-Editor-Display as a

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Lex Trotman
On 30 May 2015 at 11:24, Matthew Brush mbr...@codebrainz.ca wrote: On 2015-05-29 06:09 PM, Colomban Wendling wrote: Le 29/05/2015 02:38, Lex Trotman a écrit : […] That being said, showing occurrences of the word is such a common and fairly useful feature for an IDE, I'd personally rather

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Jiří Techet
On Fri, May 29, 2015 at 1:25 AM, Matthew Brush mbr...@codebrainz.ca wrote: Ideally you could improve the underlying implementation of an existing one if your way is better[0] and they perform the same function. It's really confusing for users to figure out what is the right plugin when