Re: [Geany-Devel] Fwd: Re: Github loses comments

2015-07-08 Thread Colomban Wendling
Le 08/07/2015 05:19, Matthew Brush a écrit : […] So does that mean it's ok to make comments either on the main page of the pull request or the files changed view which shows the combined changes? Depends what you mean ok, but yeah they shouldn't get lost. The problem is that sometimes it's

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-07-08 Thread Colomban Wendling
Le 29/06/2015 10:24, Thomas Martitz a écrit : […] That helps only existing users, and only that fraction that actually reads release notes (I would think the bulk of them doesn't). Perhaps it would be indeed best to not toggle the default for this release already? Makes sense to me, and

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-07-08 Thread Steven Blatnick
So I've finally got a chance to look at my non-API calls. I was able to code around most of them, but there are two that would be much easier if we could make them APIs. (I haven't pushed any of these changes to my git repo yet.) Could we consider making these API? *

Re: [Geany-Devel] [RFC]: No force push policy on Github PRs

2015-07-08 Thread Jiří Techet
On Wed, Jul 8, 2015 at 5:47 AM, Matthew Brush mbr...@codebrainz.ca wrote: I propose that we disallow force pushing, rebasing, squashing, etc. on any PR until it is fully ready for final merging. […] ready for merging. At that point it _might_ make sense to fudge history and get rid of some

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-07-08 Thread Steve
On Jul 8, 2015 7:18 PM, Matthew Brush mbr...@codebrainz.ca wrote: On 2015-07-08 10:57 AM, Steven Blatnick wrote: So I've finally got a chance to look at my non-API calls.  I was able to code around most of them, but there are two that would be much easier if we could make them APIs. 

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-07-08 Thread Matthew Brush
On 2015-07-08 07:28 PM, Steve wrote: On Jul 8, 2015 7:18 PM, Matthew Brush mbr...@codebrainz.ca wrote: On 2015-07-08 10:57 AM, Steven Blatnick wrote: So I've finally got a chance to look at my non-API calls. I was able to code around most of them, but there are two that would be much easier

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-07-08 Thread Matthew Brush
On 2015-07-08 10:57 AM, Steven Blatnick wrote: [snip] Let me know if this is possible or how I should proceed. I use geany with my plugins daily, and can't upgrade my code base until my plugins are working. I forgot to mention, if you made your plugin part of the Geany-Plugins project (I'm

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-07-08 Thread Thomas Martitz
Am 09.07.2015 um 04:28 schrieb Steve: On Jul 8, 2015 7:18 PM, Matthew Brush mbr...@codebrainz.ca wrote: On 2015-07-08 10:57 AM, Steven Blatnick wrote: So I've finally got a chance to look at my non-API calls. I was able to code around most of them, but there are two that would be much easier

Re: [Geany-Devel] [RFC]: No force push policy on Github PRs

2015-07-08 Thread Matthew Brush
On 2015-07-08 01:03 PM, Jiří Techet wrote: On Wed, Jul 8, 2015 at 5:47 AM, Matthew Brush mbr...@codebrainz.ca [snip] So personally I wouldn't carve any rules in stone and would decide case to case. For bigger patches with many review comments it's probably best to ask the reviewer which way he

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-07-08 Thread Matthew Brush
On 2015-07-08 10:57 AM, Steven Blatnick wrote: So I've finally got a chance to look at my non-API calls. I was able to code around most of them, but there are two that would be much easier if we could make them APIs. (I haven't pushed any of these changes to my git repo yet.) Could we