Am 08.07.2015 um 05:47 schrieb Matthew Brush:
Everyone else? (Silence = don't care)
I just don't care much to be honest. ;)
However, I'd prefer as less as possible commits at the end if they are
still atomic. Losing of outdated comments ... well... ok. Most of them
can be dismissed as these are
On Wed, Jul 8, 2015 at 5:47 AM, Matthew Brush mbr...@codebrainz.ca wrote:
I propose that we disallow force pushing, rebasing, squashing, etc.
on any PR until it is fully ready for final merging. […] ready for
merging. At that point it _might_ make sense to fudge history and get
rid of some
On 2015-07-08 01:03 PM, Jiří Techet wrote:
On Wed, Jul 8, 2015 at 5:47 AM, Matthew Brush mbr...@codebrainz.ca
[snip]
So personally I wouldn't carve any rules in stone and would decide case
to case. For bigger patches with many review comments it's probably best
to ask the reviewer which way he
Hello,
first of all, I think github should fix this problem, instead of
enforcing a suboptimal workflow on us.
I reported this problem to github, let's see if they respond.
Am 07.07.2015 um 02:13 schrieb Matthew Brush:
Hi All,
As anyone trying to follow Pull Requests on Github has probably
On 2015-07-06 11:41 PM, Thomas Martitz wrote:
Hello,
first of all, I think github should fix this problem, instead of
enforcing a suboptimal workflow on us.
I reported this problem to github, let's see if they respond.
I think I reported it before already. IIRC they said something to the
Le 07/07/2015 08:41, Thomas Martitz a écrit :
[...]
Am 07.07.2015 um 02:13 schrieb Matthew Brush:
Hi All,
As anyone trying to follow Pull Requests on Github has probably
noticed, when you force push to your PR branch, Github deletes various
comments related to the PR, depending on what
Le 07/07/2015 02:13, Matthew Brush a écrit :
Hi All,
As anyone trying to follow Pull Requests on Github has probably
noticed, when you force push to your PR branch, Github deletes
various comments related to the PR, […]
Yeah, that annoyed the hell out of me more than a few times.
This
On 2015-07-07 06:07 AM, Colomban Wendling wrote:
Le 07/07/2015 02:13, Matthew Brush a écrit :
[snip]
In addition to the dropped comments, it makes it harder to follow
the changes made since it clobbers the Git history too, so you have
to basically review the entire changset by looking at the
On 7 July 2015 at 23:07, Colomban Wendling lists@herbesfolles.org wrote:
Le 07/07/2015 02:13, Matthew Brush a écrit :
Hi All,
As anyone trying to follow Pull Requests on Github has probably
noticed, when you force push to your PR branch, Github deletes
various comments related to the PR,
Hi All,
As anyone trying to follow Pull Requests on Github has probably noticed,
when you force push to your PR branch, Github deletes various comments
related to the PR, depending on what got clobbered (it seems).
This makes it extremely difficult to keep track of and finally merge PRs
10 matches
Mail list logo
