Re: [Geany-Devel] Zombified pull requests

2016-01-06 Thread Lex Trotman
On 6 January 2016 at 20:44, Thomas Martitz wrote: > Am 06.01.2016 um 04:32 schrieb Matthew Brush: >> >> >> Agree, I sometimes avoid putting LGTM when I think something is a good >> idea, because I don't want to give the impression that I have (or even will) >> reviewed or

Re: [Geany-Devel] Zombified pull requests

2016-01-06 Thread Thomas Martitz
Am 06.01.2016 um 12:39 schrieb Matthew Brush: On 2016-01-06 02:44 AM, Thomas Martitz wrote: Am 06.01.2016 um 04:32 schrieb Matthew Brush: Agree, I sometimes avoid putting LGTM when I think something is a good idea, because I don't want to give the impression that I have (or even will)

Re: [Geany-Devel] Zombified pull requests

2016-01-06 Thread Matthew Brush
On 2016-01-06 02:44 AM, Thomas Martitz wrote: Am 06.01.2016 um 04:32 schrieb Matthew Brush: Agree, I sometimes avoid putting LGTM when I think something is a good idea, because I don't want to give the impression that I have (or even will) reviewed or tested it. Maybe just a "thumbs up" could

Re: [Geany-Devel] Zombified pull requests

2016-01-06 Thread Matthew Brush
On 2016-01-06 03:47 AM, Lex Trotman wrote: On 6 January 2016 at 20:44, Thomas Martitz wrote: [...] I agree that PRs should be merged earlier, with possible fix-up/follow-up commits in a new PR. This way changes acutally get the testing they need. The problem with a

Re: [Geany-Devel] Zombified pull requests

2016-01-06 Thread Thomas Martitz
Am 06.01.2016 um 12:47 schrieb Lex Trotman: I can't put labels on github. The feature seems to be limited to those with write access to the repository, so it's useless if we want more reviewers. Please just add a comment, its actually clearer anyway since we don't have a well defined semantics

Re: [Geany-Devel] Zombified pull requests

2016-01-06 Thread Lex Trotman
> > The advantage of labels is that you see them on the PR overview. Whereas > with comments you have to open every single PR and look for strings that may > indicate a review result. While labels can be named arbitrarily, in the end > there's going to be a handful common ones which can be looked

Re: [Geany-Devel] Zombified pull requests

2016-01-06 Thread Jiří Techet
Hi Lex, On Wed, Jan 6, 2016 at 4:12 AM, Lex Trotman wrote: > Hi Jiri, > > Its a worthwhile thing to talk about. Some specific comments below, > but first a couple of general ones. > > I occasionally talk to some of the Geany devs/contributors in other > forums and its clear

Re: [Geany-Devel] Zombified pull requests

2016-01-06 Thread Jiří Techet
Hi Matthew, On Wed, Jan 6, 2016 at 4:32 AM, Matthew Brush wrote: > On 2016-01-05 12:46 PM, Jiří Techet wrote: > >> Hi, >> >> happy new year and let's celebrate it with something cheerful - zombies! >> >> > Wouldn't they only be zombies if we closed them and they re-opened

Re: [Geany-Devel] Zombified pull requests

2016-01-05 Thread Matthew Brush
On 2016-01-05 12:46 PM, Jiří Techet wrote: Hi, happy new year and let's celebrate it with something cheerful - zombies! Wouldn't they only be zombies if we closed them and they re-opened themselves? :) I've noticed there are more and more pull requests on github which don't get merged to