Re: [PATCH #3355] Add sysfs support for powering down the OLPC 88W8838 wireless chip.

2008-06-14 Thread Deepak Saxena
On Jun 13 2008, at 20:05, Chris Ball was caught saying: Hi Deepak, I think the preffered way to do this is via sscanf() of the incoming buffer as you can catch errors such as non-integer input. simple_stroul() will just return 0 which is not what we want. I'd also

[PATCH #3355] Add sysfs support for powering down the OLPC 88W8838 wireless chip.

2008-06-13 Thread Chris Ball
This uses the OLPC EC 0x35/0x25 interface. Question: is simple_strtoul() safe here? Signed-off-by: Chris Ball [EMAIL PROTECTED] --- arch/x86/kernel/olpc-pm.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/arch/x86/kernel/olpc-pm.c

Re: [PATCH #3355] Add sysfs support for powering down the OLPC 88W8838 wireless chip.

2008-06-13 Thread Deepak Saxena
On Jun 13 2008, at 19:00, Chris Ball was caught saying: This uses the OLPC EC 0x35/0x25 interface. Question: is simple_strtoul() safe here? I think the preffered way to do this is via sscanf() of the incoming buffer as you can catch errors such as non-integer input. simple_stroul() will

Re: [PATCH #3355] Add sysfs support for powering down the OLPC 88W8838 wireless chip.

2008-06-13 Thread Chris Ball
#3355] Add sysfs support for powering down the OLPC 88W8838 wireless chip. This uses the OLPC EC 0x35/0x25 interface. Signed-off-by: Chris Ball [EMAIL PROTECTED] --- arch/x86/kernel/olpc-pm.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git