Re: [PATCH] Remove Ctrl-O (the letter oh) keyboard shortcut to fix #4646

2008-04-09 Thread Tomeu Vizoso 
Pushed, will be in next sugar release.

Thanks, Martin!

Tomeu

On Mon, Apr 7, 2008 at 4:41 PM, Eben Eliason [EMAIL PROTECTED] wrote:
 Yes, I'm fine with this.

  - Eben




  On Mon, Apr 7, 2008 at 6:53 AM, Martin Dengler [EMAIL PROTECTED] wrote:
   Eben,
  
There's been a trac bug open for a while about removing the Control-O
shortcut from the keystrokes captured by sugar so that nano can work
from the Terminal.  nano's the recommended editor, IIRC.  Control-O is
save in nano.
  
It's a one line patch, and you said ages ago in trac (#4646) that you
wouldn't be sad if Control-O went away.
  
Do you feel you can approve this patch?
  
Martin
  
  
  
On Thu, Apr 03, 2008 at 09:22:18PM +0200, Marco Pesenti Gritti wrote:
 Eben are you ok with this?

 On Thu, Apr 3, 2008 at 8:37 PM,  [EMAIL PROTECTED] wrote:
  From: Martin Dengler [EMAIL PROTECTED]
 
   ---
src/view/keyhandler.py |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
 
   diff --git a/src/view/keyhandler.py b/src/view/keyhandler.py
   index 82b6b1c..b14d27d 100644
   --- a/src/view/keyhandler.py
   +++ b/src/view/keyhandler.py
   @@ -61,7 +61,6 @@ _actions_table = {
   'ctrlEscape'   : 'close_window',
   'ctrlq': 'close_window',
   '0xDC'   : 'open_search',
   -'ctrlo': 'open_search',
   'alts' : 'say_text'
}
 
   --
   1.5.4.1
 
   ___
   Devel mailing list
   Devel@lists.laptop.org
   http://lists.laptop.org/listinfo/devel
 
  
  ___
  Devel mailing list
  Devel@lists.laptop.org
  http://lists.laptop.org/listinfo/devel

___
Devel mailing list
Devel@lists.laptop.org
http://lists.laptop.org/listinfo/devel

Re: [PATCH] Remove Ctrl-O (the letter oh) keyboard shortcut to fix #4646

2008-04-07 Thread Martin Dengler 
Eben,

There's been a trac bug open for a while about removing the Control-O
shortcut from the keystrokes captured by sugar so that nano can work
from the Terminal.  nano's the recommended editor, IIRC.  Control-O is
save in nano.

It's a one line patch, and you said ages ago in trac (#4646) that you
wouldn't be sad if Control-O went away.

Do you feel you can approve this patch?

Martin

On Thu, Apr 03, 2008 at 09:22:18PM +0200, Marco Pesenti Gritti wrote:
 Eben are you ok with this?
 
 On Thu, Apr 3, 2008 at 8:37 PM,  [EMAIL PROTECTED] wrote:
  From: Martin Dengler [EMAIL PROTECTED]
 
   ---
src/view/keyhandler.py |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
 
   diff --git a/src/view/keyhandler.py b/src/view/keyhandler.py
   index 82b6b1c..b14d27d 100644
   --- a/src/view/keyhandler.py
   +++ b/src/view/keyhandler.py
   @@ -61,7 +61,6 @@ _actions_table = {
   'ctrlEscape'   : 'close_window',
   'ctrlq': 'close_window',
   '0xDC'   : 'open_search',
   -'ctrlo': 'open_search',
   'alts' : 'say_text'
}
 
   --
   1.5.4.1
 
   ___
   Devel mailing list
   Devel@lists.laptop.org
   http://lists.laptop.org/listinfo/devel
 


pgpvGOHVUBFcA.pgp
Description: PGP signature
___
Devel mailing list
Devel@lists.laptop.org
http://lists.laptop.org/listinfo/devel

Re: [PATCH] Remove Ctrl-O (the letter oh) keyboard shortcut to fix #4646

2008-04-07 Thread Eben Eliason 
Yes, I'm fine with this.

- Eben


On Mon, Apr 7, 2008 at 6:53 AM, Martin Dengler [EMAIL PROTECTED] wrote:
 Eben,

  There's been a trac bug open for a while about removing the Control-O
  shortcut from the keystrokes captured by sugar so that nano can work
  from the Terminal.  nano's the recommended editor, IIRC.  Control-O is
  save in nano.

  It's a one line patch, and you said ages ago in trac (#4646) that you
  wouldn't be sad if Control-O went away.

  Do you feel you can approve this patch?

  Martin



  On Thu, Apr 03, 2008 at 09:22:18PM +0200, Marco Pesenti Gritti wrote:
   Eben are you ok with this?
  
   On Thu, Apr 3, 2008 at 8:37 PM,  [EMAIL PROTECTED] wrote:
From: Martin Dengler [EMAIL PROTECTED]
   
 ---
  src/view/keyhandler.py |1 -
  1 files changed, 0 insertions(+), 1 deletions(-)
   
 diff --git a/src/view/keyhandler.py b/src/view/keyhandler.py
 index 82b6b1c..b14d27d 100644
 --- a/src/view/keyhandler.py
 +++ b/src/view/keyhandler.py
 @@ -61,7 +61,6 @@ _actions_table = {
 'ctrlEscape'   : 'close_window',
 'ctrlq': 'close_window',
 '0xDC'   : 'open_search',
 -'ctrlo': 'open_search',
 'alts' : 'say_text'
  }
   
 --
 1.5.4.1
   
 ___
 Devel mailing list
 Devel@lists.laptop.org
 http://lists.laptop.org/listinfo/devel
   

___
Devel mailing list
Devel@lists.laptop.org
http://lists.laptop.org/listinfo/devel

[PATCH] Remove Ctrl-O (the letter oh) keyboard shortcut to fix #4646

2008-04-03 Thread martin 
From: Martin Dengler [EMAIL PROTECTED]

---
 src/view/keyhandler.py |1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/view/keyhandler.py b/src/view/keyhandler.py
index 82b6b1c..b14d27d 100644
--- a/src/view/keyhandler.py
+++ b/src/view/keyhandler.py
@@ -61,7 +61,6 @@ _actions_table = {
 'ctrlEscape'   : 'close_window',
 'ctrlq': 'close_window',
 '0xDC'   : 'open_search',
-'ctrlo': 'open_search',
 'alts' : 'say_text'
 }
 
-- 
1.5.4.1

___
Devel mailing list
Devel@lists.laptop.org
http://lists.laptop.org/listinfo/devel

Re: [PATCH] Remove Ctrl-O (the letter oh) keyboard shortcut to fix #4646

2008-04-03 Thread Marco Pesenti Gritti 
Eben are you ok with this?

On Thu, Apr 3, 2008 at 8:37 PM,  [EMAIL PROTECTED] wrote:
 From: Martin Dengler [EMAIL PROTECTED]

  ---
   src/view/keyhandler.py |1 -
   1 files changed, 0 insertions(+), 1 deletions(-)

  diff --git a/src/view/keyhandler.py b/src/view/keyhandler.py
  index 82b6b1c..b14d27d 100644
  --- a/src/view/keyhandler.py
  +++ b/src/view/keyhandler.py
  @@ -61,7 +61,6 @@ _actions_table = {
  'ctrlEscape'   : 'close_window',
  'ctrlq': 'close_window',
  '0xDC'   : 'open_search',
  -'ctrlo': 'open_search',
  'alts' : 'say_text'
   }

  --
  1.5.4.1

  ___
  Devel mailing list
  Devel@lists.laptop.org
  http://lists.laptop.org/listinfo/devel

___
Devel mailing list
Devel@lists.laptop.org
http://lists.laptop.org/listinfo/devel