Re: PATCH: suspend and poweroff (#3603 candidate)

2007-09-23 Thread Bernardo Innocenti
Bernardo Innocenti wrote: > Tomorrow I'll try to make sense of all this with the help of the other > developers. I didn't make much sense of it in the end, but somehow I managed to test the kernel on both B2 and B3 and it seems to be working fine. Coming soon with a new candidate patch integrati

Re: PATCH: suspend and poweroff (#3603 candidate)

2007-09-21 Thread Bernardo Innocenti
Bernardo Innocenti wrote: > Jordan Crouse wrote: > >> Two comments inline - this looks good to me, but i'll need to apply it >> to see whats up with GX. Next step is to toss it into the playground, >> I guess to get some miles on it before Andres pulls it in. It turns out that the security syst

Re: PATCH: suspend and poweroff (#3603 candidate)

2007-09-20 Thread Bernardo Innocenti
Jordan Crouse wrote: > Two comments inline - this looks good to me, but i'll need to apply it > to see whats up with GX. Next step is to toss it into the playground, > I guess to get some miles on it before Andres pulls it in. Normally I'd do that, especially for such an invasive patch. But eve

Re: PATCH: suspend and poweroff (#3603 candidate)

2007-09-19 Thread Jordan Crouse
Two comments inline - this looks good to me, but i'll need to apply it to see whats up with GX. Next step is to toss it into the playground, I guess to get some miles on it before Andres pulls it in. On 19/09/07 18:59 -0400, Bernardo Innocenti wrote: > diff --git a/drivers/video/fbmem.c b/driver

PATCH: suspend and poweroff (#3603 candidate)

2007-09-19 Thread Bernardo Innocenti
Here's a proposed patch for the green icons bug. I'm afraid it came up a bit long and somewhat invasive. Tested on B4: OK! Tested on B2: KO (does not unfreeze the screen when Sugar comes up) I must have broken something in the GX part when I merged the two powerup() and powerdown() functions, bu