Re: [RFC PATCH] libertas: turn radio off when down

2007-11-22 Thread Sjoerd Simons
On Wed, Nov 21, 2007 at 02:06:19AM -0500, Chris Ball wrote: Hi Dan, Last I knew there were cases where mesh forwarding was _not_ supposed to be on due to the high power drain of the 8388 when the radio was enabled, plus the airplane case. As long as the networking core

Re: [RFC PATCH] libertas: turn radio off when down

2007-11-20 Thread James Cameron
On Tue, Nov 20, 2007 at 11:18:07PM -0500, Dan Williams wrote: This should allow NetworkManager to be told to go to sleep, at which point it will mark all devices down, and with this patch should turn off the radio and save power. Good. Comments? Very slight possibility of further

Re: [RFC PATCH] libertas: turn radio off when down

2007-11-20 Thread elw
: James Cameron [EMAIL PROTECTED] To: Dan Williams [EMAIL PROTECTED] Cc: Andres Salomon [EMAIL PROTECTED], [EMAIL PROTECTED], Brajesh Dave [EMAIL PROTECTED] Subject: Re: [RFC PATCH] libertas: turn radio off when down On Tue, Nov 20, 2007 at 11:18:07PM -0500, Dan Williams wrote: This should

RE: [RFC PATCH] libertas: turn radio off when down

2007-11-20 Thread Ashish Shukla
Mesh forwarding is always on. Therefore, disabling radio when interface in not up will disable mesh forwarding as well. Have you thought of this? Thanks -Ashish -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Dan Williams Sent: Wednesday, November 21,

Re: [RFC PATCH] libertas: turn radio off when down

2007-11-20 Thread Dan Williams
, 21 Nov 2007 16:26:57 +1100 From: James Cameron [EMAIL PROTECTED] To: Dan Williams [EMAIL PROTECTED] Cc: Andres Salomon [EMAIL PROTECTED], [EMAIL PROTECTED], Brajesh Dave [EMAIL PROTECTED] Subject: Re: [RFC PATCH] libertas: turn radio off when down On Tue, Nov 20, 2007 at 11:18

RE: [RFC PATCH] libertas: turn radio off when down

2007-11-20 Thread Dan Williams
On Tue, 2007-11-20 at 21:45 -0800, Ashish Shukla wrote: Mesh forwarding is always on. Therefore, disabling radio when interface in not up will disable mesh forwarding as well. Have you thought of this? Yes, though interactions with suspend/resume need to be investigated here. First, if NM is

Re: [RFC PATCH] libertas: turn radio off when down

2007-11-20 Thread Chris Ball
Hi Dan, Last I knew there were cases where mesh forwarding was _not_ supposed to be on due to the high power drain of the 8388 when the radio was enabled, plus the airplane case. As long as the networking core doesn't close the devices on suspend, this patch shouldn't have