Re: [PATCH OpenFirmware] XO-1.5 DSDT: enable THRM# GPIO (ebook) by default
On Tue, Dec 14, 2010 at 08:09:58PM +, Daniel Drake wrote: > This change means that the ebook switch is automatically functional, > without an ugly code block in the ebook switch driver which changes > low-level system registers. > > This should be a safe change; any working ebook switch driver will > already have been making this config space tweak anyway. But it might be > wise to ask Quanta for a quick Windows test. Test passed at Quanta. Acked-by: James Cameron Committed as changeset 2079, expected to be included in q3a62. -- James Cameron http://quozl.linux.org.au/ ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
[PATCH OpenFirmware] XO-1.5 DSDT: enable THRM# GPIO (ebook) by default
This change means that the ebook switch is automatically functional,
without an ugly code block in the ebook switch driver which changes
low-level system registers.
This should be a safe change; any working ebook switch driver will
already have been making this config space tweak anyway. But it might be
wise to ask Quanta for a quick Windows test.
Index: cpu/x86/pc/olpc/via/dsdt.dsl
===
--- cpu/x86/pc/olpc/via/dsdt.dsl(revisión: 2065)
+++ cpu/x86/pc/olpc/via/dsdt.dsl(copia de trabajo)
@@ -343,6 +343,9 @@
// always want to hear both lid events when awake
Store (GPI7, LPOL) // watch either edge
+// always want to hear ebook events (through THRM# GPIO)
+Store (One, \_SB.PCI0.VT86.ENTH)
+
Return (0)
}
@@ -1173,6 +1176,10 @@
, 7,
IOBA, 9,// Power Management I/O Base
+Offset(0x8c), // Host Power Management Control
+, 3,
+ENTH, 1, // THRM# enable
+
Offset(0x94),
, 5,
PLLD, 1,// RX9405 Internal PLL Reset During Suspend
0:Enable,1:Disable
@@ -2354,6 +2361,7 @@
Method(_INI, 0)
{
+Store (One, \_SB.PCI0.VT86.ENTH)
Store (One, THRM)
Store (GPI9, TPOL) // init edge detect from current state
}
___
Devel mailing list
Devel@lists.laptop.org
http://lists.laptop.org/listinfo/devel
Re: XO-1.5 DSDT: enable THRM# GPIO (ebook) by default
I know very little about how ebook detection works on Windows. There is
a magic Windows driver that does that stuff, and we don't have much
insight into its inner workings.
The only thing I can suggest is to test it.
On 12/4/2010 5:20 AM, Daniel Drake wrote:
> Hi Mitch,
>
> With this DSDT change, we can remove an ugly hunk from the Linux driver for
> the ebook switch. Then the linux driver becomes agnostic to the fact that
> this is on the thermal interrupt GPIO (or even on any GPIO at all).
>
> Paul suggested that we get you to get a quick look at this and think
> about if it has any implications on Windows.
>
> cheers
> Daniel
>
> Index: cpu/x86/pc/olpc/via/dsdt.dsl
> ===
> --- cpu/x86/pc/olpc/via/dsdt.dsl (revisión: 2065)
> +++ cpu/x86/pc/olpc/via/dsdt.dsl (copia de trabajo)
> @@ -343,6 +343,9 @@
> // always want to hear both lid events when awake
> Store (GPI7, LPOL) // watch either edge
>
> +// always want to hear ebook events (through THRM# GPIO)
> +Store (One, \_SB.PCI0.VT86.ENTH)
> +
> Return (0)
> }
>
> @@ -1173,6 +1176,10 @@
> , 7,
> IOBA, 9,// Power Management I/O Base
>
> +Offset(0x8c), // Host Power Management Control
> +, 3,
> +ENTH, 1, // THRM# enable
> +
> Offset(0x94),
> , 5,
> PLLD, 1,// RX9405 Internal PLL Reset During Suspend
> 0:Enable,1:Disable
> @@ -2354,6 +2361,7 @@
>
> Method(_INI, 0)
> {
> +Store (One, \_SB.PCI0.VT86.ENTH)
> Store (One, THRM)
> Store (GPI9, TPOL) // init edge detect from current state
> }
___
Devel mailing list
Devel@lists.laptop.org
http://lists.laptop.org/listinfo/devel
XO-1.5 DSDT: enable THRM# GPIO (ebook) by default
Hi Mitch,
With this DSDT change, we can remove an ugly hunk from the Linux driver for
the ebook switch. Then the linux driver becomes agnostic to the fact that
this is on the thermal interrupt GPIO (or even on any GPIO at all).
Paul suggested that we get you to get a quick look at this and think
about if it has any implications on Windows.
cheers
Daniel
Index: cpu/x86/pc/olpc/via/dsdt.dsl
===
--- cpu/x86/pc/olpc/via/dsdt.dsl(revisión: 2065)
+++ cpu/x86/pc/olpc/via/dsdt.dsl(copia de trabajo)
@@ -343,6 +343,9 @@
// always want to hear both lid events when awake
Store (GPI7, LPOL) // watch either edge
+// always want to hear ebook events (through THRM# GPIO)
+Store (One, \_SB.PCI0.VT86.ENTH)
+
Return (0)
}
@@ -1173,6 +1176,10 @@
, 7,
IOBA, 9,// Power Management I/O Base
+Offset(0x8c), // Host Power Management Control
+, 3,
+ENTH, 1, // THRM# enable
+
Offset(0x94),
, 5,
PLLD, 1,// RX9405 Internal PLL Reset During Suspend
0:Enable,1:Disable
@@ -2354,6 +2361,7 @@
Method(_INI, 0)
{
+Store (One, \_SB.PCI0.VT86.ENTH)
Store (One, THRM)
Store (GPI9, TPOL) // init edge detect from current state
}
___
Devel mailing list
Devel@lists.laptop.org
http://lists.laptop.org/listinfo/devel
