Re: [PATCH v3 05/12] cpu_map: Add versioned EPYC CPUs

2024-02-20 Thread Jim Fehlig
On 12/15/23 15:12, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/cpu_map/index.xml | 6 + src/cpu_map/meson.build | 6 + src/cpu_map/x86_EPYC-Milan-v2.xml | 108 ++ src/cpu_map/x86_EPYC-Rome-v2.x

Re: [PATCH v3 01/12] cpu_map: update script to handle versioned CPUs

2024-02-20 Thread Jim Fehlig
On 12/15/23 15:11, Jonathon Jongsma wrote: Previously, the script only generated the parent CPU and any versions that had a defined alias. The script now generates all CPU versions. Any version that had a defined alias will continue to use that alias, but those without aliases will use the genera

Re: [PATCH v3 07/12] tools: add switches persisted and transient to nodedev-list

2024-02-20 Thread Jonathon Jongsma
same as previous patch: commit subject says "persisted" instead of "persistent" On 2/16/24 8:52 AM, Boris Fiuczynski wrote: Now that we can filter persisted and transient node devices in virConnectListAllNodeDevices(), add these switches also to the virsh nodedev-list command. Signed-off-by: B

Re: [PATCH v3 06/12] nodedev: add persisted and transient filter on list

2024-02-20 Thread Jonathon Jongsma
Minor nit: the commit subject still says "persisted" instead of "persistent" On 2/16/24 8:52 AM, Boris Fiuczynski wrote: Allow to filter node devices based on their persisted or transient states. Signed-off-by: Boris Fiuczynski Reviewed-by: Jonathon Jongsma --- include/libvirt/libvirt-noded

[PATCH v2] ch: Enable hyperv hypervisor

2024-02-20 Thread Praveen K Paladugu
From: Praveen K Paladugu Cloud-Hypervisor is capable of running VMs with kvm or mshv as the hypervisor on Linux Host. Guest to hypevisor ABI with mshv hypervisor is the same as in the case of VIR_DOMAIN_VIRT_HYPERV. So, VIR_DOMAIN_VIRT_HYPERV type will be reused to represent the config with Linux

Re: [PATCH v2 1/2] domain_validate: Account for NVDIMM label size properly when checking for memory conflicts

2024-02-20 Thread Martin Kletzander
On Tue, Feb 20, 2024 at 04:53:29PM +0100, Michal Privoznik wrote: As of v9.8.0-rc1~7 we check whether two devices don't overlap (since we allow setting where a device should be mapped to). We do this pretty straightforward, by comparing start and end address of each device combination. But sin

[PATCH v2 2/2] qemuxmlconftest: Introduce memory-hotplug-nvdimm-overlap test case

2024-02-20 Thread Michal Privoznik
This new test case checks whether we are handling NVDIMMs correctly when checking for overlapping memory devices (see previous commit). Without previous commit, this test case would fail, yet it was produced in real life (at least the NVDIMM part) and thus it is valid. Signed-off-by: Michal Privoz

[PATCH v2 0/2] domain_validate: Account for NVDIMM label size properly when checking for memory conflicts

2024-02-20 Thread Michal Privoznik
v2 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/WPIZ2FUSIPV3HSZFV6V6Q7TLJBNMI5HK/ diff to v1: - Amended commit message to 1/2 (appended Fixes: with respective commits), - Added new test case Michal Prívozník (2): domain_validate: Account for NVDIMM label size prop

[PATCH v2 1/2] domain_validate: Account for NVDIMM label size properly when checking for memory conflicts

2024-02-20 Thread Michal Privoznik
As of v9.8.0-rc1~7 we check whether two devices don't overlap (since we allow setting where a device should be mapped to). We do this pretty straightforward, by comparing start and end address of each device combination. But since only the start address is given (an exposed in the XML), the end

Re: [PATCH v2 4/4] cpu_map: Rewrite feature sync script

2024-02-20 Thread Jiri Denemark
On Mon, Feb 05, 2024 at 11:44:24 +0100, Tim Wiederhake wrote: > Previously, the script would only detect differences between > libvirt's and qemu's list of x86 features, adding those features > to libvirt was a manual and error prone procedure. > > Replace with a script that can generate libvirt's

Re: [PATCH 0/9] docs: Various fixes, mostly around :since: tags

2024-02-20 Thread Michal Prívozník
On 2/20/24 10:41, Andrea Bolognani wrote: > The way we use :since: is awfully inconsistent. This series doesn't > try to fix everything, but takes care of at least a few low-hanging > fruits plus a bunch of odds and ends. > > Abridged version, with the full one available from > > https://gitlab

Re: [PATCH v2 3/4] cpu_map: Format comments

2024-02-20 Thread Jiri Denemark
On Mon, Feb 05, 2024 at 11:44:23 +0100, Tim Wiederhake wrote: > Signed-off-by: Tim Wiederhake > --- > src/cpu_map/x86_features.xml | 50 > 1 file changed, 33 insertions(+), 17 deletions(-) Reviewed-by: Jiri Denemark __

Re: [PATCH v2 2/4] cpu_map: Format register values

2024-02-20 Thread Jiri Denemark
On Mon, Feb 05, 2024 at 11:44:22 +0100, Tim Wiederhake wrote: > Use "0x%08x" as format for all values: > > sed \ > -e "s/'0x\(..\)'/'0x00\\1'/g" \ > -e "s/'0x\(...\)'/'0x0\\1'/g" > > Signed-off-by: Tim Wiederhake > --- > src/cpu_map/x86_features.xml | 538 +++

Re: [PATCH v2 1/4] cpu_map: Sort cpu features

2024-02-20 Thread Jiri Denemark
On Mon, Feb 05, 2024 at 11:44:21 +0100, Tim Wiederhake wrote: > Some feature words were not sorted correctly. > > Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email t

Re: [PATCH v2] virsh-completer: modify and fix bug in virshPoolTypeCompleter, now used for more commands

2024-02-20 Thread Michal Prívozník
On 2/20/24 10:31, Adam Julis wrote: > Signed-off-by: Adam Julis > --- > v2: > - instead new completer is used already existing virshPoolTypeCompleter > - added flag VIRSH_POOL_TYPE_COMPLETER_COMMA for the completer > - fixed bug in pool-list --type command > > v1: > https://lists.libvirt.org/arch

Re: [PATCH v2] virsh-completer: modify and fix bug in virshPoolTypeCompleter, now used for more commands

2024-02-20 Thread Adam Julis
On 2/20/24 10:31, Adam Julis wrote: Signed-off-by: Adam Julis --- v2: - instead new completer is used already existing virshPoolTypeCompleter - added flag VIRSH_POOL_TYPE_COMPLETER_COMMA for the completer - fixed bug in pool-list --type command v1: https://lists.libvirt.org/archives/list/devel

Re: [PATCH 0/8] qemuMigrationDstPrepareStorage: Refactor and fix for VDPA storage

2024-02-20 Thread Michal Prívozník
On 2/19/24 14:49, Peter Krempa wrote: > Peter Krempa (8): > qemuMigrationDstPrepareStorage: Use 'switch' statement to include all > storage types > qemuMigrationDstPrepareStorage: Properly consider path for 'vdpa' > devices > qemuMigrationDstPrecreateDisk: Refactor cleanup > qemuMig

[PATCH 7/9] docs: Rewrite a few awkward sections

2024-02-20 Thread Andrea Bolognani
Address several oddities, and bring them in line with the style used for the vast majority of our documentation. In a couple of cases, some of the possible values for an attribute were listed with :since: information matching that off the attribute itself, making it redundant. Signed-off-by: Andre

[PATCH 8/9] docs: Other fixes to :since: tags

2024-02-20 Thread Andrea Bolognani
Make sure that they're entirely contained within a single line and that punctuation is used in a way that doesn't make the resulting HTML look weird. Signed-off-by: Andrea Bolognani --- docs/drvbhyve.rst| 30 +-- docs/drvesx.rst | 19 +- docs/drvqemu.rst

[PATCH 6/9] docs: Leave kernel version out of :since:

2024-02-20 Thread Andrea Bolognani
Tweak things so that the required kernel version is still listed, just not as part of the :since: tag. Signed-off-by: Andrea Bolognani --- docs/formatdomain.rst | 4 ++-- docs/formatnetwork.rst | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.rst b/do

[PATCH 9/9] syntax-check: Validate :since: tags

2024-02-20 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- build-aux/syntax-check.mk | 5 + 1 file changed, 5 insertions(+) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 0a10259bd8..2ac8c5760f 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1342,6 +1342,11 @@ s

[PATCH 4/9] docs: Don't use "line blocks"

2024-02-20 Thread Andrea Bolognani
It's unclear why the conversion process decided to insert them, but they don't seem to do much. Signed-off-by: Andrea Bolognani --- docs/bugs.rst | 14 ++-- docs/firewall.rst | 23 --- docs/formatdomain.rst | 17 ++--- docs/hooks.rst| 146 +-

[PATCH 5/9] docs: Fix a few weird :since: tags

2024-02-20 Thread Andrea Bolognani
These either mention libvirt explicitly, which is something that we generally don't do, or lack the word "since", which makes the resulting HTML awkward. Signed-off-by: Andrea Bolognani --- docs/formatdomain.rst | 38 ++ 1 file changed, 18 insertions(+), 20 de

[PATCH 3/9] docs: Fix list of values

2024-02-20 Thread Andrea Bolognani
One of them got chopped up. Signed-off-by: Andrea Bolognani --- docs/formatnwfilter.rst | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/docs/formatnwfilter.rst b/docs/formatnwfilter.rst index 434da5b1fd..b749edadfc 100644 --- a/docs/formatnwfilter.r

[PATCH 2/9] docs: Remove unnecessary whitespace

2024-02-20 Thread Andrea Bolognani
It slipped in during the conversion to reStructuredText. In one case, part of the preformatted text shouldn't have been marked as such, so that's addressed too. A spurious opening parenthesis is dropped as well. Signed-off-by: Andrea Bolognani --- docs/drvnodedev.rst| 2 +- docs/formatdoma

[PATCH 1/9] docs: Format lists of files better

2024-02-20 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- docs/api_extension.rst | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/docs/api_extension.rst b/docs/api_extension.rst index 152e64487e..a42c82daca 100644 --- a/docs/api_extension.rst +++ b/docs/api_extension.rs

[PATCH 0/9] docs: Various fixes, mostly around :since: tags

2024-02-20 Thread Andrea Bolognani
The way we use :since: is awfully inconsistent. This series doesn't try to fix everything, but takes care of at least a few low-hanging fruits plus a bunch of odds and ends. Abridged version, with the full one available from https://gitlab.com/abologna/libvirt/-/commits/docs-rst-since Andrea B

Re: [PATCH] domain_validate: Account for NVDIMM label size properly when checking for memory conflicts

2024-02-20 Thread Peter Krempa
On Tue, Feb 20, 2024 at 10:14:10 +0100, Michal Privoznik wrote: > As of v9.8.0-rc1~7 we check whether two devices don't > overlap (since we allow setting where a device should > be mapped to). We do this pretty straightforward, by comparing > start and end address of each device combination. > B

[PATCH v2] virsh-completer: modify and fix bug in virshPoolTypeCompleter, now used for more commands

2024-02-20 Thread Adam Julis
Signed-off-by: Adam Julis --- v2: - instead new completer is used already existing virshPoolTypeCompleter - added flag VIRSH_POOL_TYPE_COMPLETER_COMMA for the completer - fixed bug in pool-list --type command v1: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/K6GT4P5S52DS

[PATCH] domain_validate: Account for NVDIMM label size properly when checking for memory conflicts

2024-02-20 Thread Michal Privoznik
As of v9.8.0-rc1~7 we check whether two devices don't overlap (since we allow setting where a device should be mapped to). We do this pretty straightforward, by comparing start and end address of each device combination. But since only the start address is given (an exposed in the XML), the end

[PATCH] daemon: fix wrong request count for sparse stream

2024-02-20 Thread Vincent Vanlaer
Similar to when actual data is being written to the stream, it is necessary to acknowledge handling of the client request when a hole is encountered. This is done later in daemonStreamHandleWrite by sending a fake zero-length reply if the status variable is set to VIR_STREAM_CONTINUE. It seems that