Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-13 Thread Michael Galaxy via Devel
One thing to keep in mind here (despite me not having any hardware to test) was that one of the original goals here in the RDMA implementation was not simply raw throughput nor raw latency, but a lack of CPU utilization in kernel space due to the offload. While it is entirely possible that newer

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-13 Thread Daniel P . Berrangé
On Mon, May 13, 2024 at 10:22:22PM +0800, Zhao Liu wrote: > Cc Paolo for x86 topology part > > Hi Daniel, > > On Mon, May 13, 2024 at 01:33:57PM +0100, Daniel P. Berrangé wrote: > > Date: Mon, 13 May 2024 13:33:57 +0100 > > From: "Daniel P. Berrangé" > > Subject: [PATCH 1/2] hw/core: allow

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-13 Thread Zhao Liu
Cc Paolo for x86 topology part Hi Daniel, On Mon, May 13, 2024 at 01:33:57PM +0100, Daniel P. Berrangé wrote: > Date: Mon, 13 May 2024 13:33:57 +0100 > From: "Daniel P. Berrangé" > Subject: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any > machine > > This effectively reverts >

[PATCH v2] qemu_hotplug: Properly assign USB address to hotplugged usb-net device

2024-05-13 Thread Rayhan Faizel
Previously, the network device hotplug logic would try to ensure only CCW or PCI addresses. With recent support for the usb-net model, this patch will ensure USB addresses for usb-net network devices. [Changes in v2] - Additional information in commit message - Relevant gitlab issue link (mostly

Re: [PATCH] vmx: Do not require DVS Port ID

2024-05-13 Thread Ján Tomko
On a Monday in 2024, Martin Kletzander wrote: It can be safely removed from the VMX, VMWare will still boot the machine and once another ethernet is added it is updated in the VMX to zero. So do not require it and default to zero too since this part of the XML is done as best effort and it is

Re: [PATCH 0/2] hw/core: revert deprecation of 'parameter=1' for SMP topology

2024-05-13 Thread Ján Tomko
On a Monday in 2024, Daniel P. Berrangé wrote: Since QEMU 9.0, users are complaining that depecation messages are shown for every VM libvirt starts. This is due to the newly introduced deprecation of 'parameter=1' for -smp. This proposes reverting that, see the 1st patch for further commentary.

[PATCH] vmx: Do not require DVS Port ID

2024-05-13 Thread Martin Kletzander
It can be safely removed from the VMX, VMWare will still boot the machine and once another ethernet is added it is updated in the VMX to zero. So do not require it and default to zero too since this part of the XML is done as best effort and it is mentioned even in our documentation.

Re: [PATCH] qemu_hotplug: Properly assign USB address to hotplugged usb-net device

2024-05-13 Thread Michal Prívozník
On 5/11/24 21:29, Rayhan Faizel wrote: > Signed-off-by: Rayhan Faizel > --- > src/qemu/qemu_hotplug.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) Can you expand the commit message a bit? And if there's a gitlab issue associated, please put a link too. Michal

Re: [PATCH] NEWS: Announce virtio sound model support

2024-05-13 Thread Michal Prívozník
On 5/10/24 13:16, Rayhan Faizel wrote: > Signed-off-by: Rayhan Faizel > --- > NEWS.rst | 6 ++ > 1 file changed, 6 insertions(+) > Reviewed-by: Michal Privoznik Michal ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an

[PATCH 2/2] tests: add testing of parameter=1 for SMP topology

2024-05-13 Thread Daniel P . Berrangé
Validate that it is possible to pass 'parameter=1' for any SMP topology parameter, since unsupported parameters are implicitly considered to always have a value of 1. Signed-off-by: Daniel P. Berrangé --- tests/unit/test-smp-parse.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-13 Thread Daniel P . Berrangé
This effectively reverts commit 54c4ea8f3ae614054079395842128a856a73dbf9 Author: Zhao Liu Date: Sat Mar 9 00:01:37 2024 +0800 hw/core/machine-smp: Deprecate unsupported "parameter=1" SMP configurations but is not done as a 'git revert' since the part of the changes to the file

[PATCH 0/2] hw/core: revert deprecation of 'parameter=1' for SMP topology

2024-05-13 Thread Daniel P . Berrangé
Since QEMU 9.0, users are complaining that depecation messages are shown for every VM libvirt starts. This is due to the newly introduced deprecation of 'parameter=1' for -smp. This proposes reverting that, see the 1st patch for further commentary. Daniel P. Berrangé (2): hw/core: allow

Re: [PATCH] docs: mention migrate-setmaxdowntime's impact on snapshot-create

2024-05-13 Thread Peter Krempa
On Mon, May 13, 2024 at 01:36:27 +0530, Abhiram Tilak wrote: > The migrate-setmaxdowntime command sets the max allowed downtime during > live-migration, but since `snapshot-create` performs qmp migration, it also > affects the downtime during internal/external snapshot creation. > > Resolves:

Re: [PATCH] "docs: formatsnapshot: add docs for snapshotDeleteInProgress"

2024-05-13 Thread Peter Krempa
On Sun, May 12, 2024 at 01:30:45 +0530, Abhiram Tilak wrote: > Adds documentation for the element to > the libvirt snapshot format XML reference. The > element, introduced at commit 565bcb5d79, ensures the consistency of qcow2 > images during snapshot deletion operations by marking disks in

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-13 Thread Jinpu Wang via Devel
Hi Peter, Hi Chuan, On Thu, May 9, 2024 at 4:14 PM Peter Xu wrote: > > On Thu, May 09, 2024 at 04:58:34PM +0800, Zheng Chuan via wrote: > > That's a good news to see the socket abstraction for RDMA! > > When I was developed the series above, the most pain is the RDMA migration > > has no

[PATCH] docs: mention migrate-setmaxdowntime's impact on snapshot-create

2024-05-13 Thread Abhiram Tilak
The migrate-setmaxdowntime command sets the max allowed downtime during live-migration, but since `snapshot-create` performs qmp migration, it also affects the downtime during internal/external snapshot creation. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/593 Signed-off-by: Abhiram

[PATCH] "docs: formatsnapshot: add docs for snapshotDeleteInProgress"

2024-05-13 Thread Abhiram Tilak
Adds documentation for the element to the libvirt snapshot format XML reference. The element, introduced at commit 565bcb5d79, ensures the consistency of qcow2 images during snapshot deletion operations by marking disks in snapshot metadata as invalid until deletion is successfully completed.

Re: [PATCH] network: add modify-or-add feature to net-update

2024-05-13 Thread atp exp
ping, it's been a while since i have put this out. On Sat, 16 Mar 2024 at 01:51, Abhiram Tilak wrote: > The current way of updating a network configuration uses `virsh > net-update` to add, delete or modify entries. But with such a mechansim > one should know if an entry with current info