Re: [PATCH v5 12/30] network: support setting firewallBackend from network.conf

2024-05-20 Thread Laine Stump
On 5/20/24 6:14 AM, Daniel P. Berrangé wrote: On Fri, May 17, 2024 at 01:29:49PM -0400, Laine Stump wrote: It still can have only one useful value ("iptables"), but once a 2nd value is supported, it will be selectable by setting "firewall_backend=nftables" in /etc/libvirt/network.conf. If

Re: [PATCH v5 00/30] native support for nftables in virtual network driver

2024-05-20 Thread Laine Stump
On 5/20/24 5:39 AM, Daniel P. Berrangé wrote: On Fri, May 17, 2024 at 01:29:37PM -0400, Laine Stump wrote: V4: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/HX3RDEIQYJ6IOS2TDQANFKCKAXJMKCJN/#HX3RDEIQYJ6IOS2TDQANFKCKAXJMKCJN V3:

Re: [PATCH] Сheck snapshot disk is not NULL when searching it in the VM config

2024-05-20 Thread Peter Krempa
On Mon, May 20, 2024 at 14:48:47 +, Efim Shevrin via Devel wrote: > Hello, > > > If vmdisk is NULL, shouldn't this function (qemuSnapshotDeleteValidate()) > > return an error? > > I think this qemuSnapshotDeleteValidate should not return an error. > > It seems to me that when vmdisk is

Re: [PATCH] Сheck snapshot disk is not NULL when searching it in the VM config

2024-05-20 Thread Efim Shevrin via Devel
Hello, > If vmdisk is NULL, shouldn't this function (qemuSnapshotDeleteValidate()) > return an error? I think this qemuSnapshotDeleteValidate should not return an error. It seems to me that when vmdisk is NULL, this does not invalidate the snapshot itself, but indicates that the config has

[PATCH] virt-host-validate: Improve translatability of messages printed by 'virHostMsgCheck()'

2024-05-20 Thread Peter Krempa
Move the word 'Checking' into the appropriate formatting strings and mark all outstanding ones for translation. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/637 Signed-off-by: Peter Krempa --- tools/virt-host-validate-bhyve.c | 2 +- tools/virt-host-validate-ch.c | 2 +-

Re: [PATCH v5 12/30] network: support setting firewallBackend from network.conf

2024-05-20 Thread Daniel P . Berrangé
On Fri, May 17, 2024 at 01:29:49PM -0400, Laine Stump wrote: > It still can have only one useful value ("iptables"), but once a 2nd > value is supported, it will be selectable by setting > "firewall_backend=nftables" in /etc/libvirt/network.conf. > > If firewall_backend isn't set in network.conf,

Re: [PATCH v5 00/30] native support for nftables in virtual network driver

2024-05-20 Thread Daniel P . Berrangé
On Fri, May 17, 2024 at 01:29:37PM -0400, Laine Stump wrote: > V4: > https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/HX3RDEIQYJ6IOS2TDQANFKCKAXJMKCJN/#HX3RDEIQYJ6IOS2TDQANFKCKAXJMKCJN > V3: >

Plans for 10.4.0 release (freeze on Tuesday 28 May)

2024-05-20 Thread Jiri Denemark
We are getting close to 10.4.0 release of libvirt. To aim for the release on Monday 03 Jun I suggest entering the freeze on Tuesday 28 May and tagging RC2 on Thursday 30 May. I hope this works for everyone. Jirka

Re: [PATCH] Сheck snapshot disk is not NULL when searching it in the VM config

2024-05-20 Thread Michal Prívozník
On 4/29/24 14:43, Fima Shevrin via Devel wrote: > When creating a snapshot of a VM with multiple hard disks, > the snapshot takes into account the presence of all disks > in the system. If, over time, one of the disks is deleted, > the snapshot will continue to store knowledge of the deleted disk.

[PATCH] fix virLogCleanerParseFilename logic

2024-05-20 Thread David Negreira
We should return the full filename path when we don't have a match on the third group of the regex. Signed-off-by: David Negreira --- src/logging/log_cleaner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/logging/log_cleaner.c b/src/logging/log_cleaner.c index

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-20 Thread Yu Zhang via Devel
Hello Michael and Peter, Exactly, not so compelling, as I did it first only on servers widely used for production in our data center. The network adapters are Ethernet controller: Broadcom Inc. and subsidiaries NetXtreme BCM5720 2-port Gigabit Ethernet PCIe InfiniBand controller: Mellanox

Re: [PATCH 2/2] tests: add testing of parameter=1 for SMP topology

2024-05-20 Thread Zhao Liu
On Mon, May 13, 2024 at 01:33:58PM +0100, Daniel P. Berrangé wrote: > Date: Mon, 13 May 2024 13:33:58 +0100 > From: "Daniel P. Berrangé" > Subject: [PATCH 2/2] tests: add testing of parameter=1 for SMP topology > > Validate that it is possible to pass 'parameter=1' for any SMP topology >

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-20 Thread Zhao Liu
On Mon, May 13, 2024 at 01:33:57PM +0100, Daniel P. Berrangé wrote: > Date: Mon, 13 May 2024 13:33:57 +0100 > From: "Daniel P. Berrangé" > Subject: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any > machine > > This effectively reverts > > commit

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-20 Thread Zhao Liu
On Wed, May 15, 2024 at 06:06:56PM +0100, Daniel P. Berrangé wrote: > Date: Wed, 15 May 2024 18:06:56 +0100 > From: "Daniel P. Berrangé" > Subject: Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any > machine > > On Tue, May 14, 2024 at 11:49:40AM +0800, Zhao Liu wrote: > > >

Re: [PATCH 2/2] tests: add testing of parameter=1 for SMP topology

2024-05-20 Thread Xiaoyao Li
On 5/13/2024 8:33 PM, Daniel P. Berrangé wrote: Validate that it is possible to pass 'parameter=1' for any SMP topology parameter, since unsupported parameters are implicitly considered to always have a value of 1. Signed-off-by: Daniel P. Berrangé --- tests/unit/test-smp-parse.c | 8

Re: [PATCH v2] network: add modify-or-add feature to net-update

2024-05-20 Thread atp exp
Please ignore this, forgot to add v2 in `git-send-email` On Wed, 15 May 2024 at 15:41, Abhiram Tilak wrote: > The current way of updating a network configuration uses `virsh > net-update` to add, delete or modify entries. But with such a mechansim > one should know if an entry with current info

[PATCH v2] network: add modify-or-add feature to net-update

2024-05-20 Thread Abhiram Tilak
The current way of updating a network configuration uses `virsh net-update` to add, delete or modify entries. But with such a mechansim one should know if an entry with current info already exists. Adding modify-or-add option automatically performs either modify or add depending on the current

[PATCH v2] network: add modify-or-add feature to net-update

2024-05-20 Thread Abhiram Tilak
The current way of updating a network configuration uses `virsh net-update` to add, delete or modify entries. But with such a mechansim one should know if an entry with current info already exists. Adding modify-or-add option automatically performs either modify or add depending on the current

Re: [PATCH] network: add modify-or-add feature to net-update

2024-05-20 Thread atp exp
On Tue, 14 May 2024 at 18:33, Martin Kletzander wrote: > On Sat, Mar 16, 2024 at 01:43:52AM +0530, Abhiram Tilak wrote: > >The current way of updating a network configuration uses `virsh > >net-update` to add, delete or modify entries. But with such a mechansim > >one should know if an entry

Re: [PATCH v2] docs: formatsnapshot: add docs for snapshotDeleteInProgress

2024-05-20 Thread atp exp
Alright. I will check it out. On Wed, 15 May 2024 at 12:03, Peter Krempa wrote: > On Mon, May 13, 2024 at 20:37:53 +0530, Abhiram Tilak wrote: > > Adds documentation for the element to > > the libvirt snapshot format XML reference. The > > > element, introduced at commit 565bcb5d79, ensures

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-20 Thread Yu Zhang via Devel
Hello Peter and all, I did a comparison of the VM live-migration speeds between RDMA and TCP/IP on our servers and plotted the results to get an initial impression. Unfortunately, the Ethernet NICs are not the recent ones, therefore, it may not make much sense. I can do it on servers with more