[PATCH] qemu: virtiofs: format --rlimit-nofile

2024-07-16 Thread Adam Julis
Resolves: https://gitlab.com/libvirt/libvirt/-/issues/485 Signed-off-by: Adam Julis --- src/qemu/qemu_virtiofs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c index 0e3c7dbb58..703f1226a2 100644 --- a/src/qemu/qemu_virtiofs.c +++ b/src/

[PATCH] conf: virtiofs: add rlimit_nofile element

2024-07-16 Thread Adam Julis
Add an element to configure the rlimit nofile size: ... ... Non-positive values are forbidden in 'domaincommon.rng'. Added separate test file, created by modifying the 'vhost-user-fs-fd-memory.xml'. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/485 Signed-off-by: Adam Julis --- do

Re: [PATCH 3/4] qemu snapshot: use QMP snapshot-save/delete for internal snapshots

2024-07-16 Thread Daniel P . Berrangé
On Tue, Jul 16, 2024 at 10:32:56AM +0200, Peter Krempa wrote: > On Tue, Jul 16, 2024 at 10:21:12 +0200, Denis V. Lunev via Devel wrote: > > On 7/16/24 00:42, Nikolai Barybin wrote: > > > The usage of HMP commands are highly discouraged by qemu. Moreover, > > > current snapshot creation routine does

Re: [PATCH 3/4] qemu snapshot: use QMP snapshot-save/delete for internal snapshots

2024-07-16 Thread Daniel P . Berrangé
On Tue, Jul 16, 2024 at 01:42:27AM +0300, Nikolai Barybin via Devel wrote: > The usage of HMP commands are highly discouraged by qemu. Moreover, > current snapshot creation routine does not provide flexibility in > choosing target device for VM state snapshot. > > This patch makes use of QMP comma

Re: [PATCH 3/4] qemu snapshot: use QMP snapshot-save/delete for internal snapshots

2024-07-16 Thread Peter Krempa
On Tue, Jul 16, 2024 at 10:27:29 +0200, Denis V. Lunev via Devel wrote: > On 7/16/24 00:42, Nikolai Barybin wrote: > > The usage of HMP commands are highly discouraged by qemu. Moreover, > > current snapshot creation routine does not provide flexibility in > > choosing target device for VM state sn

Re: [PATCH] vmx: Be even more lax when trying to comprehend serial ports

2024-07-16 Thread Michal Prívozník
On 7/15/24 16:12, Martin Kletzander wrote: > So much can happen in the fileName field of the VMX that the easiest > thing is to silently report a serial type="null". > > This effectively reverts commits de81bdb8d4cd and 62c53db0421a, but > keeps the test files to show the fix is still in place. >

Re: [PATCH 3/4] qemu snapshot: use QMP snapshot-save/delete for internal snapshots

2024-07-16 Thread Peter Krempa
On Tue, Jul 16, 2024 at 10:21:12 +0200, Denis V. Lunev via Devel wrote: > On 7/16/24 00:42, Nikolai Barybin wrote: > > The usage of HMP commands are highly discouraged by qemu. Moreover, > > current snapshot creation routine does not provide flexibility in > > choosing target device for VM state sn

Re: [PATCH 3/4] qemu snapshot: use QMP snapshot-save/delete for internal snapshots

2024-07-16 Thread Denis V. Lunev via Devel
On 7/16/24 00:42, Nikolai Barybin wrote: The usage of HMP commands are highly discouraged by qemu. Moreover, current snapshot creation routine does not provide flexibility in choosing target device for VM state snapshot. This patch makes use of QMP commands snapshot-save/delete and by default ch

Re: [PATCH 3/4] qemu snapshot: use QMP snapshot-save/delete for internal snapshots

2024-07-16 Thread Denis V. Lunev via Devel
On 7/16/24 00:42, Nikolai Barybin wrote: The usage of HMP commands are highly discouraged by qemu. Moreover, current snapshot creation routine does not provide flexibility in choosing target device for VM state snapshot. This patch makes use of QMP commands snapshot-save/delete and by default ch