The order of such ``throttlefilter`` doesn't matter within ``throttlefilters``.
I will put above statement into doc
Signed-off-by: Ariel Otilibili
---
examples/domstart.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/domstart.py b/examples/domstart.py
index fdfe25f..9a7d129 100755
--- a/examples/domstart.py
+++ b/examples/domstart.py
@@ -27,7 +27,7 @@ parser = ArgumentParser(des
* aligned list with supported Python versions [1]
* as of today, supported versions are 3.8 to 3.12
https://devguide.python.org/versions/
Signed-off-by: Ariel Otilibili
---
tox.ini | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tox.ini b/tox.ini
index 3dca5c7..8902423 10064
* env variable used to be Python3.6
* Python3.6 is end of life since December 2021 [1].
[1] https://devguide.python.org/versions/
Signed-off-by: Ariel Otilibili
---
Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index b08e2bd..1cab66c 100644
-
Hello,
I have been using libvirt for some years, and this is my first ever
contribution; your feedback is more than welcome.
This is a set of patches about changes done in Makefile, tox.ini, and
domstart.py.
Regards,
Ariel
LGTM!
On 8/5/2024 9:40 AM, Purna Pavan Chandra wrote:
Current ch driver supports restore only for domains without any network
configuration defined. This was because libvirt explicitly passes network fds
and CH did not had support to restore with new net FDS. This support has been
added recently
Signed-off-by: Purna Pavan Chandra
---
NEWS.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 44df5d08f7..bbd30ab3b5 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -19,6 +19,12 @@ v10.7.0 (unreleased)
* **Improvements**
+ * ch: support restore with network dev
Cloud-hypervisor now supports restoring with new net fds.
Ref: https://github.com/cloud-hypervisor/cloud-hypervisor/pull/6402
So, pass new tap fds via SCM_RIGHTS to CH's restore api.
Signed-off-by: Purna Pavan Chandra
---
src/ch/ch_capabilities.c | 6 +++
src/ch/ch_capabilities.h | 1 +
src/ch
Invoke virCHProcessStop to kill CH process incase of any failures during
restore operation.
Signed-off-by: Purna Pavan Chandra
---
src/ch/ch_process.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/ch/ch_process.c b/src/ch/ch_process.c
index ff0fc5ca63..38216bbf8
Remove the unwanted utility function and make api calls directly from
virCHMonitorSaveVM fn
Signed-off-by: Purna Pavan Chandra
---
src/ch/ch_monitor.c | 27 +++
1 file changed, 7 insertions(+), 20 deletions(-)
diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c
index
Instead of curl, use low-level socket connections to make restore api
request to CH. This will enable passing new net FDs to CH while
restoring domains with network configuration.
Signed-off-by: Purna Pavan Chandra
---
src/ch/ch_monitor.c | 13 +++--
src/ch/ch_monitor.h | 2 +-
src/ch/c
Move monitor socket connection, response handling and closing FDs code into
new functions in preparation for adding restore support for net devices.
Signed-off-by: Purna Pavan Chandra
---
src/ch/ch_process.c | 121 +---
1 file changed, 80 insertions(+), 41
chSocketRecv fn can be used by operations such as restore, which cannot
have a specific poll timeout. The runtime of these operations at server
side (vmm) cannot be determined or capped as it depends on the guest
configuration. Hence, add a new parameter 'use_timeout' which when set
will pass -1 as
Pass "net_" as net id to CH. This is to have better control over
the network configs. This id can be further used in performing
operations like restore etc.
Signed-off-by: Purna Pavan Chandra
---
src/ch/ch_monitor.c | 7 ++-
src/ch/ch_monitor.h | 4 +++-
src/ch/ch_process.c | 2 +-
3 files c
The response message from CH for vm.add-net api will be more helpful in
debugging. Hence, log the message instead of just response code.
Signed-off-by: Purna Pavan Chandra
---
src/ch/ch_process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ch/ch_process.c b/src/ch/ch_
Current ch driver supports restore only for domains without any network
configuration defined. This was because libvirt explicitly passes network fds
and CH did not had support to restore with new net FDS. This support has been
added recently, https://github.com/cloud-hypervisor/cloud-hypervisor/pu
On Thu, Jul 25, 2024 at 12:04:47PM -0500, Praveen K Paladugu wrote:
>
>
> On 7/4/2024 6:13 AM, Purna Pavan Chandra wrote:
> > Cloud-hypervisor now supports restoring with new net fds.
> > Ref: https://github.com/cloud-hypervisor/cloud-hypervisor/pull/6402
> > So, pass new tap fds via SCM_RIGHTS t
The QEMU package in Debian has recently moved the
qemu-bridge-helper binary under /usr/libexec/qemu. Update the
AppArmor profile accordingly.
https://bugs.debian.org/1077915
Signed-off-by: Andrea Bolognani
---
src/security/apparmor/usr.sbin.libvirtd.in | 4 ++--
src/security/apparmor/usr.sbin.
@Akihiko Odaki The RSC is supported with vhost and without vhost
The 'in-qemu RSC' is related to VIRTIO_NET_F_RSC_EXT feature, it is
intended for one specific WHCK test only and should not be used in any
functional setup.
When it is used the vhost should be off
On Tue, Jul 30, 2024 at 1:23 PM Akih
Hi Peter,
> On Jul 29, 2024, at 22:23, Peter Krempa wrote:
>
> On Mon, Jul 22, 2024 at 15:43:22 +0900, Itaru Kitayama wrote:
>> Hi,
>>
>> With the below virt-install options, I am trying to import a Realm VM:
>>
>> […]
>> export LIBVIRT_QEMU=/home/realm/qemu-system-aarch64
>>
>> virt-install
The 10.6.0 release of both libvirt and libvirt-python is tagged and
signed tarballs are available at
https://download.libvirt.org/
https://download.libvirt.org/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing feedback. Your work is
On Mon, Aug 05, 2024 at 06:37:58PM +0900, Akihiko Odaki wrote:
> If cross-migrate=off, QEMU can still migrate on the same host (checkpoint
> and restart). QEMU can also migrate across hosts if the user ensures they
> are on the same platform.
What is so special about checkpoint/restart? I guess we
On Mon, Aug 05, 2024 at 10:50:43AM +0200, Adam Julis wrote:
This reverts commit cf934c87cca32149675020ea595712aad25978e6.
The matching logic is flawed and it would complicate support of
this command.
Signed-off-by: Adam Julis
Thanks.
Reviewed-by: Martin Kletzander
signature.asc
Descripti
On 2024/08/05 17:23, Michael S. Tsirkin wrote:
On Mon, Aug 05, 2024 at 04:53:52PM +0900, Akihiko Odaki wrote:
On 2024/08/05 16:30, Michael S. Tsirkin wrote:
On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote:
I suggest disabling all offload features of virtio-net with 9.2.
Yea ...
This reverts commit cf934c87cca32149675020ea595712aad25978e6.
The matching logic is flawed and it would complicate support of
this command.
Signed-off-by: Adam Julis
---
See discussion:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/6VV6ZAFNGUYUIQZGNS3PZ2FN64NPHXBT/
sr
On Mon, Aug 05, 2024 at 04:53:52PM +0900, Akihiko Odaki wrote:
> On 2024/08/05 16:30, Michael S. Tsirkin wrote:
> > On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote:
> > > I suggest disabling all offload features of virtio-net with 9.2.
> >
> > Yea ... no.
> >
> > > I want to keep th
On Wed, Jul 10, 2024 at 10:30:31AM +0200, Michal Prívozník wrote:
On 7/9/24 17:23, Adam Julis wrote:
The "modify" command allows to replace an existing Srv record
(some of its elements respectively: port, priority and weight).
The primary key used to choose the modify record is the remaining
par
On 2024/08/05 16:30, Michael S. Tsirkin wrote:
On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote:
I suggest disabling all offload features of virtio-net with 9.2.
Yea ... no.
I want to keep things consistent so I want to disable all at once. This
change will be very uncomfortable
On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote:
> I suggest disabling all offload features of virtio-net with 9.2.
Yea ... no.
> I want to keep things consistent so I want to disable all at once. This
> change will be very uncomfortable for us, who are implementing offload
> featur
On 2024/08/04 22:08, Peter Xu wrote:
On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote:
On 2024/08/03 1:26, Peter Xu wrote:
On Sat, Aug 03, 2024 at 12:54:51AM +0900, Akihiko Odaki wrote:
I'm not sure if I read it right. Perhaps you meant something more generic
than -platform but s
30 matches
Mail list logo