Re: [PATCH 17/20] include: Define constants for parallel save/restore

2024-10-14 Thread Jim Fehlig via Devel
On 10/14/24 11:42, Daniel P. Berrangé wrote: On Mon, Oct 14, 2024 at 06:00:53PM +0200, Claudio Fontana wrote: On 10/10/24 15:29, Daniel P. Berrangé wrote: On Thu, Aug 08, 2024 at 05:38:10PM -0600, Jim Fehlig via Devel wrote: From: Claudio Fontana Add a new VIR_DOMAIN_SAVE_PARALLEL flag to th

Re: [PATCH 17/20] include: Define constants for parallel save/restore

2024-10-14 Thread Daniel P . Berrangé
On Mon, Oct 14, 2024 at 06:00:53PM +0200, Claudio Fontana wrote: > On 10/10/24 15:29, Daniel P. Berrangé wrote: > > On Thu, Aug 08, 2024 at 05:38:10PM -0600, Jim Fehlig via Devel wrote: > >> From: Claudio Fontana > >> > >> Add a new VIR_DOMAIN_SAVE_PARALLEL flag to the save and restore > >> APIs,

Re: [libvirt ci] Why no artifacts for macOS & FreeBSD?

2024-10-14 Thread Richard W.M. Jones
On Mon, Oct 14, 2024 at 06:26:23PM +0100, Richard W.M. Jones wrote: > On Mon, Oct 14, 2024 at 06:21:32PM +0100, Richard W.M. Jones wrote: > > On Mon, Oct 14, 2024 at 09:48:51AM +0100, Daniel P. Berrangé wrote: > > > On Sat, Oct 12, 2024 at 11:57:57AM +0100, Richard W.M. Jones wrote: > > > > [I coul

Re: [libvirt ci] Why no artifacts for macOS & FreeBSD?

2024-10-14 Thread Richard W.M. Jones
On Mon, Oct 14, 2024 at 06:21:32PM +0100, Richard W.M. Jones wrote: > On Mon, Oct 14, 2024 at 09:48:51AM +0100, Daniel P. Berrangé wrote: > > On Sat, Oct 12, 2024 at 11:57:57AM +0100, Richard W.M. Jones wrote: > > > [I couldn't find out where to send questions / bugs related > > > to libvirt CI, so

Re: [libvirt ci] Why no artifacts for macOS & FreeBSD?

2024-10-14 Thread Richard W.M. Jones
On Mon, Oct 14, 2024 at 09:48:51AM +0100, Daniel P. Berrangé wrote: > On Sat, Oct 12, 2024 at 11:57:57AM +0100, Richard W.M. Jones wrote: > > [I couldn't find out where to send questions / bugs related > > to libvirt CI, so here I am ...] > > > > https://gitlab.com/nbdkit/libnbd/-/pipelines/149314

Re: [PATCH v2 00/13] Implement support for QCOW2 data files

2024-10-14 Thread Peter Krempa
On Sat, Sep 07, 2024 at 17:15:15 +0300, Nikolai Barybin via Devel wrote: As I've fixed merge conflicts in this series in order to review it you can fetch the fixed patches at: git fetch https://gitlab.com/pipo.sk/libvirt.git review-qcow2-datafile

Re: [PATCH v2 13/13] tests: add qcow2 data-file basic tests to qemublocktest

2024-10-14 Thread Peter Krempa
On Sat, Sep 07, 2024 at 17:15:42 +0300, Nikolai Barybin via Devel wrote: > Signed-off-by: Nikolai Barybin > --- > tests/qemublocktest.c | 78 +++ > ...backing-with-data-file-noopts-srconly.json | 27 +++ > ...e-qcow2-backing-with-data-file-noopts.json |

Re: [PATCH 17/20] include: Define constants for parallel save/restore

2024-10-14 Thread Claudio Fontana
On 10/10/24 15:29, Daniel P. Berrangé wrote: > On Thu, Aug 08, 2024 at 05:38:10PM -0600, Jim Fehlig via Devel wrote: >> From: Claudio Fontana >> >> Add a new VIR_DOMAIN_SAVE_PARALLEL flag to the save and restore >> APIs, which can be used to specify the use of multiple, parallel >> channels for sa

Re: [PATCH v2 12/13] conf: implement XML parsing/formatingo for dataFileStore

2024-10-14 Thread Peter Krempa
On Sat, Sep 07, 2024 at 17:15:40 +0300, Nikolai Barybin via Devel wrote: As noted separately, tests and documentation is missing. > Signed-off-by: Nikolai Barybin > --- > src/conf/domain_conf.c | 98 ++ > src/conf/domain_conf.h | 13 ++ > 2 files chan

Re: [PATCH v3 3/5] schema: add TPM emulator

2024-10-14 Thread Daniel P . Berrangé
On Mon, Oct 14, 2024 at 10:41:56AM -0400, Stefan Berger wrote: > > > On 10/14/24 9:41 AM, Daniel P. Berrangé wrote: > > On Mon, Oct 14, 2024 at 09:35:14AM -0400, Stefan Berger wrote: > > > > > > > > > On 10/14/24 5:17 AM, Daniel P. Berrangé wrote: > > > > On Fri, Oct 11, 2024 at 10:16:51AM -040

Re: [PATCH v3 3/5] schema: add TPM emulator

2024-10-14 Thread Stefan Berger
On 10/14/24 9:41 AM, Daniel P. Berrangé wrote: On Mon, Oct 14, 2024 at 09:35:14AM -0400, Stefan Berger wrote: On 10/14/24 5:17 AM, Daniel P. Berrangé wrote: On Fri, Oct 11, 2024 at 10:16:51AM -0400, Stefan Berger wrote: On 10/11/24 10:10 AM, Marc-André Lureau wrote: Hi On Fri, Oct 11,

Re: [PATCH] qemu: migration: Fix blockdev config with VIR_MIGRATE_PARAM_MIGRATE_DISKS_DETECT_ZEROES

2024-10-14 Thread Jiri Denemark
On Mon, Oct 14, 2024 at 16:13:07 +0200, Peter Krempa wrote: > The idea of migration with VIR_MIGRATE_PARAM_MIGRATE_DISKS_DETECT_ZEROES > populated is to sparsify the image. The QEMU NBD client as it was > configured in commit 621f879adf98e2c93ac5c8c869733a57f06cd9aa would > signal to the destinatio

Re: [PATCH 10/20] qemu: Add support for mapped-ram on save

2024-10-14 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Thu, Oct 10, 2024 at 02:52:56PM -0300, Fabiano Rosas wrote: >> Daniel P. Berrangé writes: >> >> > On Thu, Oct 10, 2024 at 12:06:51PM -0300, Fabiano Rosas wrote: >> >> Daniel P. Berrangé writes: >> >> >> >> > On Thu, Aug 08, 2024 at 05:38:03PM -0600, Jim Fehlig

[PATCH] qemu: migration: Fix blockdev config with VIR_MIGRATE_PARAM_MIGRATE_DISKS_DETECT_ZEROES

2024-10-14 Thread Peter Krempa
The idea of migration with VIR_MIGRATE_PARAM_MIGRATE_DISKS_DETECT_ZEROES populated is to sparsify the image. The QEMU NBD client as it was configured in commit 621f879adf98e2c93ac5c8c869733a57f06cd9aa would signal to the destination to do thick allocation of holes which would result in a non-sparse

Re: [PATCH v3 3/5] schema: add TPM emulator

2024-10-14 Thread Daniel P . Berrangé
On Mon, Oct 14, 2024 at 09:35:14AM -0400, Stefan Berger wrote: > > > On 10/14/24 5:17 AM, Daniel P. Berrangé wrote: > > On Fri, Oct 11, 2024 at 10:16:51AM -0400, Stefan Berger wrote: > > > > > > > > > On 10/11/24 10:10 AM, Marc-André Lureau wrote: > > > > Hi > > > > > > > > On Fri, Oct 11, 202

Re: [PATCH v3 3/5] schema: add TPM emulator

2024-10-14 Thread Stefan Berger
On 10/14/24 5:17 AM, Daniel P. Berrangé wrote: On Fri, Oct 11, 2024 at 10:16:51AM -0400, Stefan Berger wrote: On 10/11/24 10:10 AM, Marc-André Lureau wrote: Hi On Fri, Oct 11, 2024 at 5:49 PM Stefan Berger wrote: On 10/4/24 9:32 AM, marcandre.lur...@redhat.com wrote: From: Marc-Andr

Re: [PATCH v3 3/5] schema: add TPM emulator

2024-10-14 Thread Daniel P . Berrangé
On Mon, Oct 14, 2024 at 09:15:16AM -0400, Stefan Berger wrote: > > > On 10/14/24 5:19 AM, Daniel P. Berrangé wrote: > > On Fri, Oct 11, 2024 at 10:46:58AM -0400, Stefan Berger wrote: > > > > > > > > > On 10/11/24 10:32 AM, Marc-André Lureau wrote: > > > > Hi > > > > > > > > On Fri, Oct 11, 202

Re: [PATCH v3 3/5] schema: add TPM emulator

2024-10-14 Thread Stefan Berger
On 10/14/24 5:19 AM, Daniel P. Berrangé wrote: On Fri, Oct 11, 2024 at 10:46:58AM -0400, Stefan Berger wrote: On 10/11/24 10:32 AM, Marc-André Lureau wrote: Hi On Fri, Oct 11, 2024 at 6:17 PM Stefan Berger wrote: On 10/11/24 10:10 AM, Marc-André Lureau wrote: Hi On Fri, Oct 11, 202

Re: [PATCH v2 10/13] qemu: enable basic qcow2 data-file feature support

2024-10-14 Thread Peter Krempa
On Sat, Sep 07, 2024 at 17:15:35 +0300, Nikolai Barybin via Devel wrote: > - propogate data-file to cmdline > - determine data-file within disk chain > - enable live disk insertion > > Signed-off-by: Nikolai Barybin > --- > src/qemu/qemu_block.c | 7 +++ > src/qemu/qemu_command.c | 5 +++

Re: [PATCH v2 09/13] qemu: factor out qemuDomainPrepareStorageSource()

2024-10-14 Thread Peter Krempa
On Sat, Sep 07, 2024 at 17:15:33 +0300, Nikolai Barybin via Devel wrote: > This refactoring will simplify next changes. > > Signed-off-by: Nikolai Barybin > --- > src/qemu/qemu_domain.c | 40 +++- > 1 file changed, 27 insertions(+), 13 deletions(-) Reviewed-b

Re: [PATCH v2 08/13] qemu: put data-file path to VM's cgroup and namespace

2024-10-14 Thread Peter Krempa
On Sat, Sep 07, 2024 at 17:15:31 +0300, Nikolai Barybin via Devel wrote: > Signed-off-by: Nikolai Barybin > --- > src/qemu/qemu_cgroup.c| 4 > src/qemu/qemu_namespace.c | 5 + > 2 files changed, 9 insertions(+) Firstly, that applies everywhere, you must not use the 'path' member of

Re: [PATCH v2 07/13] security: apparmor: handle qcow2 data-file

2024-10-14 Thread Peter Krempa
On Sat, Sep 07, 2024 at 17:15:29 +0300, Nikolai Barybin via Devel wrote: > Signed-off-by: Nikolai Barybin > --- > src/security/virt-aa-helper.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c > index 067a17f331..4e8334eb3

Re: [PATCH v2 06/13] security: selinux: handle qcow2 data-file on image label set/restore

2024-10-14 Thread Peter Krempa
On Sat, Sep 07, 2024 at 17:15:27 +0300, Nikolai Barybin via Devel wrote: > Signed-off-by: Nikolai Barybin > --- > src/security/security_selinux.c | 20 > 1 file changed, 16 insertions(+), 4 deletions(-) Same comments as in: [PATCH v2 05/13] security: DAC: handle qcow2 data-

Re: [PATCH v2 05/13] security: DAC: handle qcow2 data-file on image label set/restore

2024-10-14 Thread Peter Krempa
On Sat, Sep 07, 2024 at 17:15:25 +0300, Nikolai Barybin via Devel wrote: > Signed-off-by: Nikolai Barybin > --- > src/security/security_dac.c | 26 +- > 1 file changed, 21 insertions(+), 5 deletions(-) > > diff --git a/src/security/security_dac.c b/src/security/security_d

Re: [PATCH v3 3/5] schema: add TPM emulator

2024-10-14 Thread Daniel P . Berrangé
On Fri, Oct 11, 2024 at 10:46:58AM -0400, Stefan Berger wrote: > > > On 10/11/24 10:32 AM, Marc-André Lureau wrote: > > Hi > > > > On Fri, Oct 11, 2024 at 6:17 PM Stefan Berger wrote: > > > > > > > > > > > > On 10/11/24 10:10 AM, Marc-André Lureau wrote: > > > > Hi > > > > > > > > On Fri, O

Re: [PATCH v3 3/5] schema: add TPM emulator

2024-10-14 Thread Daniel P . Berrangé
On Fri, Oct 11, 2024 at 10:16:51AM -0400, Stefan Berger wrote: > > > On 10/11/24 10:10 AM, Marc-André Lureau wrote: > > Hi > > > > On Fri, Oct 11, 2024 at 5:49 PM Stefan Berger wrote: > > > > > > > > > > > > On 10/4/24 9:32 AM, marcandre.lur...@redhat.com wrote: > > > > From: Marc-André Lure

Re: [PATCH 10/20] qemu: Add support for mapped-ram on save

2024-10-14 Thread Daniel P . Berrangé
On Thu, Oct 10, 2024 at 02:52:56PM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Thu, Oct 10, 2024 at 12:06:51PM -0300, Fabiano Rosas wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Thu, Aug 08, 2024 at 05:38:03PM -0600, Jim Fehlig via Devel wrote: > >> >> Introduce su

Re: [libvirt ci] Why no artifacts for macOS & FreeBSD?

2024-10-14 Thread Daniel P . Berrangé
On Sat, Oct 12, 2024 at 11:57:57AM +0100, Richard W.M. Jones wrote: > [I couldn't find out where to send questions / bugs related > to libvirt CI, so here I am ...] > > https://gitlab.com/nbdkit/libnbd/-/pipelines/1493147187 > > It would be much easier to fix the above pipeline (which doesn't > r

Re: [PATCH v2 04/13] storage file: fill in src->dataFileStore during file probe

2024-10-14 Thread Peter Krempa
On Sat, Sep 07, 2024 at 17:15:23 +0300, Nikolai Barybin via Devel wrote: > Signed-off-by: Nikolai Barybin > --- > src/storage_file/storage_source.c | 28 > src/storage_file/storage_source.h | 3 +++ > 2 files changed, 31 insertions(+) > > diff --git a/src/storage_fi

Re: [PATCH v2 03/13] storage file: add qcow2 data-file path parsing from header

2024-10-14 Thread Peter Krempa
On Sat, Sep 07, 2024 at 17:15:21 +0300, Nikolai Barybin via Devel wrote: > Signed-off-by: Nikolai Barybin > --- > src/storage_file/storage_file_probe.c | 53 +-- > 1 file changed, 49 insertions(+), 4 deletions(-) > > diff --git a/src/storage_file/storage_file_probe.c > b

Re: [PATCH v2 01/13] conf: add data-file feature and related fields to virStorageSource

2024-10-14 Thread Peter Krempa
On Sat, Sep 07, 2024 at 17:15:17 +0300, Nikolai Barybin via Devel wrote: > Signed-off-by: Nikolai Barybin > --- > src/conf/storage_source_conf.c | 11 +++ > src/conf/storage_source_conf.h | 5 + > 2 files changed, 16 insertions(+) > > diff --git a/src/conf/storage_source_conf.c b/sr

Re: [PATCH RFC v4 11/17] qemu: block: Support block disk along with throttle filters

2024-10-14 Thread Peter Krempa
On Mon, Sep 30, 2024 at 15:40:58 +0200, Peter Krempa wrote: > On Mon, Sep 30, 2024 at 10:14:59 +, Edward Arulanadam wrote: > > Dear All, > > > > My sincere apologies on reaching out regarding this change as I know, > > someone would be reviewing the change and provide review comments as per