Tested on this branch with qemu-kvm-9.1.0-5.el9.x86_64:
# for i in $(/usr/libexec/qemu-kvm -cpu help|grep deprecated -v|awk
'/Available CPUs/,/Recognized CPUID flags/'|grep '^ '|awk '{print $1}');do
if ! virsh cpu-models x86_64|grep -q $i;then echo $i;fi;done
Opteron_G4-v1
Opteron_G5-v1
base
host
These functions return value is invariant since VIR_EXPAND_N check
removal in 7d2fd6e, so change its type and remove all dependent checks.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Reported-by: Pavel Nekrasov
Signed-off-by: Alexander Kuznetsov
---
src/util/virsysinfo.c
This function return value is invariant since VIR_EXPAND_N check
removal in 7d2fd6e, so change its type and remove all dependent checks.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Reported-by: Pavel Nekrasov
Signed-off-by: Alexander Kuznetsov
---
src/hyperv/hyperv_wmi.c
This function return value is invariant since VIR_EXPAND_N check
removal in 7d2fd6e, so change its type and remove all dependent checks.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Reported-by: Pavel Nekrasov
Signed-off-by: Alexander Kuznetsov
---
src/remote/remote_driver
This function return value is invariant since VIR_EXPAND_N check
removal in 7d2fd6e, so change its type and remove all dependent checks.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Reported-by: Pavel Nekrasov
Signed-off-by: Alexander Kuznetsov
---
src/admin/admin_remote.c
This function return value is invariant since VIR_EXPAND_N check
removal in 7d2fd6e, so change its type and remove all dependent checks.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Reported-by: Pavel Nekrasov
Signed-off-by: Alexander Kuznetsov
---
src/locking/lock_daemon.
This function return value is invariant since VIR_EXPAND_N check
removal in 7d2fd6e, so change its type and remove all dependent checks.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Reported-by: Pavel Nekrasov
Signed-off-by: Alexander Kuznetsov
---
src/access/viraccessdriv
These functions return value is invariant since VIR_EXPAND_N check
removal in 7d2fd6e, so change its type and remove all dependent checks.
Best regards,
Alexander Kuznetsov
---
v2:
- One function/file per commit.
Alexander Kuznetsov (6):
access: Change return type of virAccessDriverStackAppend
On Thu, Nov 14, 2024 at 02:25:09AM -0800, Purna Pavan Chandra Aekkaladevi wrote:
> Thanks for the review, Michal.
>
> I will add your suggestion to not abort() and fix the possible memory
> leak issue in V4.
>
> On Mon, Nov 11, 2024 at 02:37:00PM +0100, Michal Prívozník wrote:
> > On 10/23/24 10:
I have just tagged v10.10.0-rc2 in the repository and pushed signed
tarballs to https://download.libvirt.org/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make sure the issu
CPU models that do not have a list of versions attached are still
advertised as aliases to corresponding -v1 variants. We should add the
missing variants to the CPU map.
Signed-off-by: Jiri Denemark
---
src/cpu_map/index.xml | 2 +
src/cpu_map/meson.build
QEMU supports -v1 variant of any CPU model even though the list of
versions is not defined (i.e., even { .version = 1 } item is missing).
Signed-off-by: Jiri Denemark
---
src/cpu_map/sync_qemu_models_i386.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/cpu_map/sync_qemu_models_i386
Do not try to generated definition of ancient models (and their
versions). We don't want to generate (and then manually get remove
before committing) -v1 variants of CPU models that are pretty much
useless now.
Signed-off-by: Jiri Denemark
---
Notes:
The main questions is which models should
When adding new CPU models to CPU map it's easy (and very common) to
forget to add the new files to meson.build. We already update index.xml
with the new models so updating meson.build too makes sense.
Signed-off-by: Jiri Denemark
---
src/cpu_map/sync_qemu_models_i386.py | 27 +++
Signed-off-by: Jiri Denemark
---
src/cpu_map/meson.build | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/cpu_map/meson.build b/src/cpu_map/meson.build
index 88d67f4cce..f659ef230e 100644
--- a/src/cpu_map/meson.build
+++ b/src/cpu_map/meson.build
@@ -4,8 +
CPU models that do not have a list of versions attached are still
advertised as aliases to corresponding -v1 variants. We should add the
missing variants to the CPU map.
Available on gitlab:
git fetch https://gitlab.com/jirkade/libvirt.git cpu-versions
Pipeline: https://gitlab.com/jirkade/li
This function return value is invariant since 18f3771, so change
its type and remove all dependent checks.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Reported-by: Pavel Nekrasov
Signed-off-by: Alexander Kuznetsov
---
src/hypervisor/virhostdev.c | 6 ++
src/util/virpc
This function return value is invariant since 18f3771, so change
its type and remove all dependent checks.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Reported-by: Pavel Nekrasov
Signed-off-by: Alexander Kuznetsov
---
src/logging/log_daemon.c| 8 ++--
src/logg
This function return value is invariant since 18f3771, so change
its type and remove all dependent checks.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Reported-by: Pavel Nekrasov
Signed-off-by: Alexander Kuznetsov
---
src/hypervisor/virhostdev.c | 3 +--
src/util/virscsiv
This function return value is invariant since 18f3771, so change
its type and remove all dependent checks.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Reported-by: Pavel Nekrasov
Signed-off-by: Alexander Kuznetsov
---
src/hypervisor/virhostdev.c | 12
src/uti
These functions return value is invariant since 18f3771, so change
its type and remove all dependent checks.
Best regards,
Alexander Kuznetsov
---
v2:
- One function per commit.
Alexander Kuznetsov (4):
util: Change return type of virPCIDeviceSetUsedBy to void
util: Change return type of vi
On Thu, Nov 28, 2024 at 10:40:03 +0100, Michal Privoznik wrote:
> There are some features/improvements/bug fixes I've either
> contributed or reviewed/merged. Document them for upcoming
> release.
>
> Signed-off-by: Michal Privoznik
> ---
> NEWS.rst | 28
> 1 file ch
There are some features/improvements/bug fixes I've either
contributed or reviewed/merged. Document them for upcoming
release.
Signed-off-by: Michal Privoznik
---
NEWS.rst | 28
1 file changed, 28 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 4b7f4e8244..65e2
On Wed, Nov 27, 2024 at 18:45:09 +0300, Alexander Kuznetsov wrote:
> These functions return value is invariant since VIR_EXPAND_N check
> removal in 7d2fd6e, so change its type and remove all dependent checks.
>
> Found by Linux Verification Center (linuxtesting.org) with Svace.
>
> Reported-by:
On Thu, Nov 28, 2024 at 10:24:07 +0100, Peter Krempa wrote:
> On Thu, Nov 28, 2024 at 10:22:53 +0100, Jiri Denemark wrote:
> > On Tue, Nov 26, 2024 at 16:16:17 +0100, Peter Krempa wrote:
> > > Extract the matching of the node name of a single virStorage source so
> > > that the logic can be extende
On Wed, Nov 27, 2024 at 18:41:57 +0300, Alexander Kuznetsov wrote:
> These functions return value is invariant since 18f3771, so change
> its type and remove all dependent checks.
>
> Found by Linux Verification Center (linuxtesting.org) with Svace.
>
> Reported-by: Pavel Nekrasov
> Signed-off-b
These functions return value is invariant since 18f3771, so change
its type and remove all dependent checks.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Reported-by: Pavel Nekrasov
Signed-off-by: Alexander Kuznetsov
---
src/hypervisor/virhostdev.c | 21 +++
These functions return value is invariant since VIR_EXPAND_N check
removal in 7d2fd6e, so change its type and remove all dependent checks.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Reported-by: Pavel Nekrasov
Signed-off-by: Alexander Kuznetsov
---
src/access/viraccessdr
On Thu, Nov 28, 2024 at 10:22:53 +0100, Jiri Denemark wrote:
> On Tue, Nov 26, 2024 at 16:16:17 +0100, Peter Krempa wrote:
> > Extract the matching of the node name of a single virStorage source so
> > that the logic can be extended in the upcoming patch.
>
> This is confusing. I was expecting the
On Tue, Nov 26, 2024 at 16:16:11 +0100, Peter Krempa wrote:
> Couple fixes for the feature when used with blockjobs:
> - fixes for qemuBlockReopenAccess (code driving 'blockdev-reopen' in
>qemu) for bugs noticed during testing of
> - the 'auto-read-only' qemu feature doesn't apply od the 'd
On Tue, Nov 26, 2024 at 16:16:17 +0100, Peter Krempa wrote:
> Extract the matching of the node name of a single virStorage source so
> that the logic can be extended in the upcoming patch.
This is confusing. I was expecting the logic in
qemuDomainVirStorageSourceFindByNodeName to be extended in th
On 11/28/24 09:32, Peter Krempa wrote:
> 'virschematest' didn't test the majority of files for some time so some
> schema problems snuck in.
>
> Peter Krempa (5):
> schemas: domain: Make subelement of NFS disk source
> optional
> schemas: domaincaps: Add schema for 'panic' device
> sche
On 11/28/24 09:32, Peter Krempa wrote:
> Due to a bug in the optimization to avoid testing symlinked tests
> multiple times all tests were skipped.
>
> In commit f997fcca71a16b102e6ee663 I made an attempt to optimize the
> tests by avoiding testing symlinks. This optimization was buggy as I've
> p
On Thu, Nov 28, 2024 at 10:16:10 +0100, Jiri Denemark wrote:
> On Tue, Nov 26, 2024 at 16:16:16 +0100, Peter Krempa wrote:
> > For the reason outlined in previous commit qemu doesn't do this
> > automatically. Handle it manually after the snapshot.
> >
> > Signed-off-by: Peter Krempa
> > ---
> >
On Tue, Nov 26, 2024 at 16:16:16 +0100, Peter Krempa wrote:
> For the reason outlined in previous commit qemu doesn't do this
> automatically. Handle it manually after the snapshot.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_snapshot.c | 12 ++--
> 1 file changed, 10 insertion
'virschematest' didn't test the majority of files for some time so some
schema problems snuck in.
Peter Krempa (5):
schemas: domain: Make subelement of NFS disk source
optional
schemas: domaincaps: Add schema for 'panic' device
schemas: domaincaps: Add schema for 'canonical' cpu model n
Due to a bug in the optimization to avoid testing symlinked tests
multiple times all tests were skipped.
In commit f997fcca71a16b102e6ee663 I made an attempt to optimize the
tests by avoiding testing symlinks. This optimization was buggy as I've
passed the 'd_name' field of 'struct dirent' which i
Due to broken 'virschematest' commit f4dc248a952aaebcc793c7809c6c083d9
forgot to introduce schema for the new element.
Fixes: f4dc248a952aaebcc793c7809c6c083d9cc30d0c
Signed-off-by: Peter Krempa
---
src/conf/schemas/domaincaps.rng | 14 ++
1 file changed, 14 insertions(+)
diff --git
Due to 'virschematest' being broken commit fff2bbee7feb0fdfbf40aac4fe9
forgot to add schema for the new attribute.
Fixes: fff2bbee7feb0fdfbf40aac4fe9efd070f72ce9e
Signed-off-by: Peter Krempa
---
src/conf/schemas/domaincaps.rng | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/conf/sch
Due to 'virschematest' being broken commit a52cd504b3618c67abf3a07c669
introduced a new element to the domain caps but didn't add schema for
it.
Fixes: a52cd504b3618c67abf3a07c669fd5e5ab18aa50
Signed-off-by: Peter Krempa
---
src/conf/schemas/domaincaps.rng | 10 ++
1 file changed, 10 ins
Both the 'user' and 'group' attribute are optional so can
be empty. Allow it to be omitted completely. The parser and qemu code
can handle that.
The schema was introduced in 943871f971d680f72726a9d6e9330eec264f6588
and in d018c8dc9ebcd0496c7a564bc2e8b1c9cbd8d96f an offending test was
added.
Fixe
41 matches
Mail list logo
