Re: [PATCH] qemucapabilitiestest: Update 'caps_10.0.0_x86_64' to 'v9.2.0-1967-gb69801dd6b'

2025-02-24 Thread Pavel Hrdina
On Mon, Feb 24, 2025 at 04:55:19PM +0100, Peter Krempa wrote: > Notable changes: > - 'NETDEV_VHOST_USER_CONNECTED'/'NETDEV_VHOST_USER_DISCONNECTED' events >added > - 'handshake-max-seconds' argument for 'nbd-server-start' added > > Signed-off-by: Peter Krempa > --- > .../caps_10.0.0_x86_64

Re: [PATCH v2 1/2] qemu: check for/require shared memory for *any* vhostuser interface

2025-02-24 Thread Laine Stump
On 2/24/25 7:27 AM, Michal Prívozník wrote: On 2/21/25 20:05, Laine Stump wrote: It has always been true that vhostuser interfaces require shared memory, but we've never had that check in the validation. Recently I added that check for the case of interface type='vhostuser' backend type='passt'.

Re: [PATCH] run: Use correct SELinux context for modular daemons

2025-02-24 Thread Michal Prívozník
On 2/24/25 14:49, Jiri Denemark wrote: > Only libvirtd uses virtd_t/virt_exec_t context, modular daemons use > their specific context each. > > Signed-off-by: Jiri Denemark > --- > run.in | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > Reviewed-by: Michal Privoznik Mic

Re: [PATCH] cpu: Do not call g_strv_contains on NULL list

2025-02-24 Thread Michal Prívozník
On 2/24/25 15:22, Jiri Denemark wrote: > When virCPUx86UpdateLive checks whether a feature was added to a CPU > model after the model was already released (vmx-* features in most Intel > models), the following assert could be logged by glib: > > g_strv_contains: assertion 'strv != NULL' failed

Re: [PATCH v2 11/12] hw/arm/raspi: Deprecate old raspiX machine names

2025-02-24 Thread Jared Mauch
On Tue, Feb 04, 2025 at 10:58:39AM +0100, BALATON Zoltan wrote: > On Tue, 4 Feb 2025, Philippe Mathieu-Daudé wrote: > > On 4/2/25 10:22, Peter Maydell wrote: > > > On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé > > > wrote: > > > > > > > > All previous raspi machines can be created using the

[PATCH] cpu: Do not call g_strv_contains on NULL list

2025-02-24 Thread Jiri Denemark
When virCPUx86UpdateLive checks whether a feature was added to a CPU model after the model was already released (vmx-* features in most Intel models), the following assert could be logged by glib: g_strv_contains: assertion 'strv != NULL' failed While most of our CPU models have a non-empty l

[PATCH] run: Use correct SELinux context for modular daemons

2025-02-24 Thread Jiri Denemark
Only libvirtd uses virtd_t/virt_exec_t context, modular daemons use their specific context each. Signed-off-by: Jiri Denemark --- run.in | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/run.in b/run.in index 2821b71230..d8db7cf697 100644 --- a/run.in +++ b/run.in

Entering freeze for libvirt-11.1.0

2025-02-24 Thread Jiri Denemark
I have just tagged v11.1.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

Re: [PATCH v2 1/2] qemu: check for/require shared memory for *any* vhostuser interface

2025-02-24 Thread Michal Prívozník
On 2/21/25 20:05, Laine Stump wrote: > It has always been true that vhostuser interfaces require shared > memory, but we've never had that check in the validation. Recently I > added that check for the case of interface type='vhostuser' backend > type='passt'. This patch generalizes that check to r

Re: [PATCH v2 2/2] qemu: forbid a few unsupported things for vhost-user/passt interfaces

2025-02-24 Thread Michal Prívozník
On 2/21/25 20:05, Laine Stump wrote: > vhost-user with a passt backend doesn't support using multiple queues. > > The path of the socket is auto-generated by libvirt for > vhost-user/passt; it can't be set by the user > > The passt end of a vhost-user socket is always the server, and the > qemu e

Re: [PATCH 00/21] qemu: Refactor domstats code to avoid error reporting

2025-02-24 Thread Peter Krempa
On Mon, Feb 24, 2025 at 10:42:05 +0100, Peter Krempa wrote: > On Mon, Feb 24, 2025 at 09:33:51 +, Daniel P. Berrangé wrote: > > On Thu, Feb 20, 2025 at 10:01:13AM +0100, Peter Krempa wrote: > > > The workers of qemuDomainGetStats should not report errors if they can't > > > fetch data; but rath

Re: [PATCH 00/21] qemu: Refactor domstats code to avoid error reporting

2025-02-24 Thread Daniel P . Berrangé
On Mon, Feb 24, 2025 at 10:42:05AM +0100, Peter Krempa wrote: > On Mon, Feb 24, 2025 at 09:33:51 +, Daniel P. Berrangé wrote: > > On Thu, Feb 20, 2025 at 10:01:13AM +0100, Peter Krempa wrote: > > > The workers of qemuDomainGetStats should not report errors if they can't > > > fetch data; but ra

Re: [PATCH 00/21] qemu: Refactor domstats code to avoid error reporting

2025-02-24 Thread Peter Krempa
On Mon, Feb 24, 2025 at 09:33:51 +, Daniel P. Berrangé wrote: > On Thu, Feb 20, 2025 at 10:01:13AM +0100, Peter Krempa wrote: > > The workers of qemuDomainGetStats should not report errors if they can't > > fetch data; but rather omit the entries. Refactor the code to > > de-incentivize error r

Re: [PATCH 1/2] tests: be consistent about following DO_TEST_*() with a ;

2025-02-24 Thread Daniel P . Berrangé
On Thu, Feb 20, 2025 at 11:49:43PM -0500, Laine Stump wrote: > As is often the case with macros (especially those that resolve to > multiple statements), it isn't technically necessary to end any of the > invocations of the DO_TEST_*() macros with a semicolon (as evidenced > by the lines changed in

Re: [PATCH 00/21] qemu: Refactor domstats code to avoid error reporting

2025-02-24 Thread Daniel P . Berrangé
On Thu, Feb 20, 2025 at 10:01:13AM +0100, Peter Krempa wrote: > The workers of qemuDomainGetStats should not report errors if they can't > fetch data; but rather omit the entries. Refactor the code to > de-incentivize error reporting. Why shouldn't they report errors ? Can you give an example of