From: Liu Song
The ff callback is never called in remoteStreamCallbackFree() because
cbdata->cb can not be NULL. This causes a leak of 'cbdata->opaque'.
The leak can be reproduced by attaching and detaching to the console of
an VM using `virsh console`.
ASAN reports the leak stack as:
Direct le
On 24/06/2025 14:03, Daniel P. Berrangé wrote:
On Tue, Jun 24, 2025 at 01:55:20PM +0200, Markus Armbruster wrote:
Laurent Vivier writes:
On 24/06/2025 10:16, Markus Armbruster wrote:
Laurent Vivier writes:
This commit introduces support for passt as a new network backend.
passt is an unpr
On Mon, Jun 23, 2025 at 21:59:17 +0200, Peter Krempa wrote:
> From: Peter Krempa
>
> Modify the validation of empty cdroms to trigger only for
> VIR_DOMAIN_DISK_MODEL_USB_STORAGE as with 'usb-bot' we can properly
> emulate a cdrom.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_validate
From: Ján Tomko
--werror does not accept any arguments for me and setting
git_werror was also needed to disable it with git.
Signed-off-by: Ján Tomko
---
docs/compiling.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/compiling.rst b/docs/compiling.rst
index 0a4
I have just tagged v11.5.0-rc1 in the repository and pushed signed
tarballs to https://download.libvirt.org/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make sure the issue
On Tue, Jun 24, 2025 at 14:57:13 +0200, Jiri Denemark wrote:
> On Mon, Jun 23, 2025 at 21:59:18 +0200, Peter Krempa wrote:
> > From: Akihiko Odaki
> >
> > usb-storage is a compound device that automatically creates a USB mass
> > storage device and a SCSI device as its backend. Unfortunately it l
On Mon, Jun 23, 2025 at 21:59:18 +0200, Peter Krempa via Devel wrote:
> From: Akihiko Odaki
>
> usb-storage is a compound device that automatically creates a USB mass
> storage device and a SCSI device as its backend. Unfortunately it lacks
> some configuration options that are usually present wi
On Tue, Jun 24, 2025 at 12:51:57 +0200, Peter Krempa wrote:
> On Tue, Jun 24, 2025 at 11:25:03 +0200, Jiri Denemark wrote:
> > On Mon, Jun 23, 2025 at 21:59:13 +0200, Peter Krempa wrote:
> > > From: Peter Krempa
> > >
> > > Historically libvirt specified 'usb-storage' as driver for USB disks.
> >
On Mon, Jun 23, 2025 at 21:59:18 +0200, Peter Krempa wrote:
> From: Akihiko Odaki
>
> usb-storage is a compound device that automatically creates a USB mass
> storage device and a SCSI device as its backend. Unfortunately it lacks
> some configuration options that are usually present with a SCSI
From: Michal Privoznik
Inside of qemuMonitorJSONGetBlockInfo() there's a for loop in
which a variable of struct qemuDomainDiskInfo type is declared
and initialized as { false }. This works only because stdbool.h
declares 'false' as a macro, so preprocessor expands initializer
to proper form of {
Laurent Vivier writes:
> On 24/06/2025 10:16, Markus Armbruster wrote:
>> Laurent Vivier writes:
>>
>>> This commit introduces support for passt as a new network backend.
>>> passt is an unprivileged, user-mode networking solution that provides
>>> connectivity for virtual machines by launching
On Mon, Jun 23, 2025 at 21:59:16 +0200, Peter Krempa wrote:
> From: Peter Krempa
>
> The helper sets the 'attached' property of the 'usb-bot' device to true,
> which will be used on the hotplug code path.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_monitor.c | 12
>
On Mon, Jun 23, 2025 at 21:59:12 +0200, Peter Krempa wrote:
> From: Peter Krempa
>
> The QEMU_CAPS_DEVICE_USB_BOT device can be compiled out but
> realistically it makes no sense to do it thus also makes no sense to
> have another variant of input data for it.
>
> Add another invocation of "disk
On Mon, Jun 23, 2025 at 21:59:11 +0200, Peter Krempa wrote:
> From: Akihiko Odaki
>
> usb-bot is supported by all supported QEMU versions; it is present since
> 1.4.0 and libvirt supports 4.2.0 or later.
>
> Add a capability just in case USB_STORAGE_BOT is disabled when building
> QEMU.
>
> Sig
On Mon, Jun 23, 2025 at 21:59:10 +0200, Peter Krempa wrote:
> From: Peter Krempa
>
> The 'removable' property is tested for 'usb' and 'scsi' disks. The test
> case for 'usb' disks already has another test case for this, so add
> testing of 'removable' SCSI disks into the 'disk-scsi' case and remo
On Mon, Jun 23, 2025 at 21:59:09 +0200, Peter Krempa wrote:
> From: Peter Krempa
>
> The test case is now redundant since 'disk-usb-device' case also tests
> all cdrom configurations. Remove it.
>
> Signed-off-by: Peter Krempa
> ---
> .../disk-cdrom-bus-other.x86_64-latest.args | 34
On Mon, Jun 23, 2025 at 21:59:08 +0200, Peter Krempa wrote:
> From: Peter Krempa
>
> Signed-off-by: Peter Krempa
> ---
> tests/qemusecuritytest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Jiri Denemark
On Mon, Jun 23, 2025 at 21:59:07 +0200, Peter Krempa wrote:
> From: Peter Krempa
>
> Add multiple USB disks to the definition testing a matrix of 'disk' and
> 'cdrom' elements with user-aliases, 'serial' and 'removable'
> properties configured.
>
> This patch also removes the 'ide' disk which i
On Mon, Jun 23, 2025 at 21:59:06 +0200, Peter Krempa wrote:
> From: Peter Krempa
>
> The qemu hotplug code parses the device with ABI updates enabled so
> qemuhotplugtest ought to do the same.
>
> Signed-off-by: Peter Krempa
> ---
> tests/qemuhotplugtest.c | 4 ++--
> 1 file changed, 2 inserti
On Mon, Jun 23, 2025 at 21:59:14 +0200, Peter Krempa wrote:
> From: Peter Krempa
>
> While 'usb-bot' and 'usb-storage' are ABI and migration compatible for
> disks it's not the case for cdroms. When migrating from a new config
> using 'usb-bot' to an older daemon which would use 'usb-storage' the
On Mon, Jun 23, 2025 at 21:59:13 +0200, Peter Krempa wrote:
> From: Peter Krempa
>
> Historically libvirt specified 'usb-storage' as driver for USB disks.
> This though combined with '-blockdev' doesn't properly configure the
> device to look like CDROM for .
>
> 'usb-bot' acts like a controler
CC: libvirt devel list
Hi Kevin/Peter,
Thank you so much for addressing this issue. I tried out few more things and
here is my analysis:
Even when I removed the readonly option from guest xml I was still seeing the
issue in migration,In the qemu-commandline I could still see auto-read-only
opti
22 matches
Mail list logo
