Re: [PATCH v1] virBitmapNextClearBit: Correct virBitmapNextClearBit function header comment

> and merged. Congratulations on your first libvirt contribution! Thank you Michal ! Glad to help :-)

Re: [RFC] x86 Host CPU features detection by MSRs

On Wed, Jul 9, 2025 at 12:01 PM Daniel P. Berrangé wrote: > On Wed, Jul 09, 2025 at 05:58:03AM -0400, Andrea Bolognani wrote: > > On Wed, Jul 09, 2025 at 09:53:40AM +0100, Daniel P. Berrangé via Devel > wrote: > > > On Wed, Jul 09, 2025 at 10:29:32AM +0200, Hector Cao wrote: > > > > > >3. if

Re: [PATCH 0/2] virnetdevvportprofile: Misc cleanups

On a Wednesday in 2025, Michal Privoznik via Devel wrote: *** BLURB HERE *** Michal Prívozník (2): virnetdevvportprofile: Drop explicit enum virNetDevVPortProfile declaration virnetdevvportprofile: Turn 'virtPortType' of virNetDevVPortProfile into proper enum type src/conf/netdev_vport_

Re: [PATCH 0/5] secdriver: Misc cleanups

On a Wednesday in 2025, Michal Privoznik via Devel wrote: *** BLURB HERE *** Michal Prívozník (5): security: Drop some G_GNUC_UNUSED attributes security_selinux: Drop needless checks for seclabel->model == "selinux" security_dac: Drop needless checks for seclabel->model == "dac" security_

[PATCH 1/2] virnetdevvportprofile: Drop explicit enum virNetDevVPortProfile declaration

From: Michal Privoznik The virNetDevVPortProfile enum is both explicitly declared and also typedef-ed. This repetition is redundant. Just use typedef. To make matters worse, there's another type with the same name, but because in the code, those few places used 'enum virNetDevVPortProfile var;' t

[PATCH 2/2] virnetdevvportprofile: Turn 'virtPortType' of virNetDevVPortProfile into proper enum type

From: Michal Privoznik Convert the member to the appropriate type, fix few missing cases in switch() and switch to virXMLPropEnum() in parsing. Signed-off-by: Michal Privoznik --- src/conf/netdev_vport_profile_conf.c | 9 - src/hypervisor/virhostdev.c | 1 + src/qemu/qemu_mi

[PATCH 0/2] virnetdevvportprofile: Misc cleanups

*** BLURB HERE *** Michal Prívozník (2): virnetdevvportprofile: Drop explicit enum virNetDevVPortProfile declaration virnetdevvportprofile: Turn 'virtPortType' of virNetDevVPortProfile into proper enum type src/conf/netdev_vport_profile_conf.c | 11 +-- src/hypervisor/virhost

[PATCH 4/5] security_apparmor: Drop needless checks for seclabel->model == "apparmor"

From: Michal Privoznik In few instances, after virDomainDefGetSecurityLabelDef(SECURITY_APPARMOR_NAME) was called, we take the returned secdef and compare secdef->model against SECURITY_APPARMOR_NAME. This makes no sense because virDomainDefGetSecurityLabelDef() has already done this comparison.

[PATCH 5/5] security_dac: Drop needles typecast in virSecurityDACGenLabel()

From: Michal Privoznik Inside of virSecurityDACGenLabel() there's a switch() statement and the variable it uses is typecasted to virDomainSeclabelType. Well, as of v7.10.0-rc1~26 the variable is already of that type rendering the typecast needless. Drop it. Signed-off-by: Michal Privoznik ---

[PATCH 2/5] security_selinux: Drop needless checks for seclabel->model == "selinux"

From: Michal Privoznik In few instances, after virDomainDefGetSecurityLabelDef(SECURITY_SELINUX_NAME) was called, we take the returned secdef and compare secdef->model against SECURITY_SELINUX_NAME. This makes no sense because virDomainDefGetSecurityLabelDef() has already done this comparison. S

[PATCH 1/5] security: Drop some G_GNUC_UNUSED attributes

From: Michal Privoznik Some variables are annotated with G_GNUC_UNUSED attribute so that compiles knows to not complain about unused variable. Well, some variables are annotated and then used. Drop the G_GNUC_UNUSED attribute in such cases. Signed-off-by: Michal Privoznik --- src/security/secu

[PATCH 3/5] security_dac: Drop needless checks for seclabel->model == "dac"

From: Michal Privoznik In one instance, after virDomainDefGetSecurityLabelDef(SECURITY_DAC_NAME) was called, we take the returned secdef and compare secdef->model against SECURITY_DAC_NAME. This makes no sense because virDomainDefGetSecurityLabelDef() has already done this comparison. Signed-off

[PATCH 0/5] secdriver: Misc cleanups

*** BLURB HERE *** Michal Prívozník (5): security: Drop some G_GNUC_UNUSED attributes security_selinux: Drop needless checks for seclabel->model == "selinux" security_dac: Drop needless checks for seclabel->model == "dac" security_apparmor: Drop needless checks for seclabel->model ==

Re: [PATCH v2 2/4] util: virSecretLookupParseSecret refactor

On 7/22/25 17:12, Kirill Shchetiniuk via Devel wrote: > From: Kirill Shchetiniuk > > Refactored the virSecretLookupParseSecret fucntion to use the > virXMLPropUUID fucntion, avoid getting the string and parsing it > later. Previously two separate error states merged into one by using > boolean NX

Re: [PATCH v2 1/4] conf: virNetDevVPortProfileParse refactor

On 7/22/25 17:12, Kirill Shchetiniuk via Devel wrote: > From: Kirill Shchetiniuk > > Refactored the virNetDevVPortProfileParse function to use the appropriate > virXMLProp* functions to parse input configuration XML. > > Signed-off-by: Kirill Shchetiniuk > --- > src/conf/netdev_vport_profile_c

Re: [PATCH v2 0/4] Some parsing functions refactor

On 7/22/25 17:12, Kirill Shchetiniuk via Devel wrote: > This patch series is supposed to refactor the existing logic of > some parsing functions, changing the previous approach of getting > the string fisrt and then parsing the string itself. Now the > parsing logic is implemented by using the appr

Re: libvirt-gitlab-executor - maintainer?

On Wed, Jul 23, 2025 at 08:56:18AM +0200, Kristina Hanicova wrote: > On Fri, Jul 18, 2025 at 8:45 PM Daniel P. Berrangé > wrote: > > > On Fri, Jul 18, 2025 at 05:28:59PM +0200, Kristina Hanicova via Devel > > wrote: > > > Hello Libvirt friends, > > > > > > Is anyone interested in maintaining this

Re: [PATCH 0/4] qemu: add support for RBD namespace

On 6/25/25 17:56, Peter Krempa via Devel wrote: > After recent inquiry on libvirt-users I've necromanced this already very > old series that I still had laying around. > > This series: > - turns virStorageSource's 'protocol' to real enum > - removes virStorageSource's 'volume' > - wires in the

[RFC PATCH 8/8] tests: Add qemuxmlconftest for ACPI EGM memory device

Add test coverage for the ACPI EGM memory device feature: - Add test case to qemuxmlconftest.c for aarch64 architecture - Add acpi-egm-memory capability to QEMU 10.0.0 aarch64 capabilities - Create test input XML with EGM device configuration - Generate expected output XML and QEMU command line ar

[RFC PATCH 7/8] docs: Document ACPI EGM memory device

Add documentation for the ACPI EGM memory device feature: - Describe the purpose and use cases - Document XML configuration options - Provide example configurations - Explain requirements and limitations Signed-off-by: Ian May --- docs/formatdomain.rst | 80 +

[RFC PATCH 6/8] qemu: Add cgroup and namespace setup for ACPI EGM memory device

Implement proper isolation and access control for ACPI EGM memory devices: - Add device to cgroup for access control - Set up namespace mappings for device access - Ensure proper permissions in containerized environments Signed-off-by: Ian May --- src/qemu/qemu_cgroup.c| 21

[RFC PATCH 5/8] qemu: Add command line generation for ACPI EGM memory device

Implement QEMU command line generation for the ACPI EGM memory device. This includes: - Adding the device to the QEMU command line - Setting up memory backend properties - Configuring device parameters (alias, PCI device, NUMA node) Signed-off-by: Ian May --- src/qemu/qemu_command.c | 37 ++

[RFC PATCH 4/8] qemu: Add validation for ACPI EGM memory device configuration

Implement validation logic for ACPI EGM memory device configuration: - Validate PCI device reference exists and is properly configured - Check NUMA node assignment is valid - Verify device paths exist and are accessible - Ensure proper permissions on device files Signed-off-by: Ian May --- src/

[RFC PATCH 2/8] conf: Add definitions and XML parsing for ACPI EGM memory device

Implement the core data structures and XML parsing for ACPI EGM memory device support. This includes: - New device type VIR_DOMAIN_DEVICE_EGM - Data structure virDomainAcpiEgmDef for device configuration - XML parsing and formatting functions - Integration with existing device handling infrastruct

[RFC PATCH 3/8] qemu: Add capability detection for ACPI EGM memory device

Add QEMU capability detection for the ACPI EGM memory device feature. This allows libvirt to determine if the QEMU binary supports the required functionality before attempting to use it. The capability is exposed through the QEMU device type 'acpi-egm-memory' and is used to validate device configu

[RFC PATCH 1/8] conf: Add schema definition for ACPI EGM memory device

Add RelaxNG schema definition for the ACPI EGM memory device configuration. This schema defines the XML structure for configuring extended memory access through ACPI tables. The schema includes: - Device alias for unique identification - PCI device reference for memory source - NUMA node assignmen

[RFC PATCH 0/8] Add support for Grace ACPI Extended GPU Memory (EGM) devices

The Grace SOC introduces Extended GPU Memory (EGM) [3], a feature that enables GPUs to efficiently access system memory within and across nodes. This patch series adds support for virtualizing EGM (vEGM) in libvirt, allowing VMs to utilize dedicated EGM memory regions through ACPI. RFC Status

Clarification Needed: virsh snapshot-delete Behavior with External Snapshots (--disk-only)

Hello libvirt community, I am seeking clarification on the behavior of `virsh snapshot-delete` when used with external snapshots (created with the `--disk-only` option). **Environment:** - libvirt version: 10.5.0 - Kernel version: 5.14.0-503.22.1.el9_5.x86_64 - Disk image format: qcow2 - Host OS

Re: libvirt-gitlab-executor - maintainer?

On 7/23/25 08:56, Kristina Hanicova via Devel wrote: > > On Fri, Jul 18, 2025 at 8:45 PM Daniel P. Berrangé > wrote: > > On Fri, Jul 18, 2025 at 05:28:59PM +0200, Kristina Hanicova via > Devel wrote: > > Hello Libvirt friends, > > > > Is anyone int

Re: [PATCH v1] virBitmapNextClearBit: Correct virBitmapNextClearBit function header comment

On 7/22/25 19:59, Aaron M. Brown wrote: > This patch corrects the header comment for virBitmapNextClearBIt. > Currently, the header comment reads: > > `@pos can be -1 to search for the first set bit.` > > However, this statement is false. > > We can prove this by referencing the virbitmaptest fu