Re: [PATCH v3 4/9] tests: Add tests for SEV firmware selection

2025-09-11 Thread Andrea Bolognani via Devel
On Thu, Sep 11, 2025 at 12:54:25PM -0600, Jim Fehlig wrote: > On 9/11/25 01:38, Andrea Bolognani wrote: > > If you want, I can add a comment along the lines of > > > >/* This succeeds, but the selected firmware is not the one > > * we want */ > > > > to qemuxmlconftest.c and drop it once de

Re: [PATCH 5/8] qemu: Generate acpi-generic-initiator command from acpi nodeset

2025-09-11 Thread Andrea Righi via Devel
On Mon, Sep 08, 2025 at 06:19:38PM +0100, Daniel P. Berrangé wrote: > On Mon, Sep 08, 2025 at 07:15:18PM +0200, Andrea Righi wrote: > > Hi Daniel, > > > > On Mon, Sep 08, 2025 at 06:02:20PM +0100, Daniel P. Berrangé wrote: > > > On Sat, Sep 06, 2025 at 03:09:00PM +0200, Andrea Righi wrote: > > > >

Re: [libvirt-python PATCH] build: Adapt to PEP 625 distribution file naming

2025-09-11 Thread Pavel Hrdina via Devel
On Wed, Sep 10, 2025 at 02:04:39PM +0200, Jiri Denemark via Devel wrote: > The version of setuptools shipped by Fedora 42 is PEP 625 compliant, > which requires distribution files to contain a normalized package name. > Thus the generated tarball is called libvirt_python-$VER.tar.gz rather > than l

Re: [PATCH v3 2/3] NEWS: ch: announce riscv-aia feature for RISC-V KVM

2025-09-11 Thread Peter Krempa via Devel
On Thu, Sep 04, 2025 at 17:05:34 +0800, BillXiang wrote: Summary (subject) mentions "Cloud Hypervisor" driver but the patches add the support to the QEMU driver. > From: xiangwencheng > > Signed-off-by: BillXiang > --- > NEWS.rst | 10 ++ > 1 file changed, 10 insertions(+) > > diff -

Re: [PATCH 13/14] qemu: Let qemuMonitorJSONGetCPUProperties also return disabled features

2025-09-11 Thread Peter Krempa via Devel
On Thu, Sep 04, 2025 at 16:47:01 +0200, Jiri Denemark via Devel wrote: > From: Jiri Denemark > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_monitor_json.c | 30 +- > 1 file changed, 17 insertions(+), 13 deletions(-) Reviewed-by: Peter Krempa

[PATCH 4/4] ch: Implement VIR_DOMAIN_DESTROY_GRACEFUL flag support

2025-09-11 Thread Michal Privoznik via Devel
From: Michal Privoznik The virDomainDestroyFlags() API has several flags, including VIR_DOMAIN_DESTROY_GRACEFUL which is documented to send only SIGTERM to the emulator process. Implement its support into CH driver. Signed-off-by: Michal Privoznik --- src/ch/ch_driver.c | 9 ++--- 1 file c

Re: [PATCH 4/8] qemu: Validate acpi nodeset

2025-09-11 Thread Daniel P . Berrangé via Devel
On Sat, Sep 06, 2025 at 03:08:59PM +0200, Andrea Righi wrote: > Signed-off-by: Andrea Righi > --- > src/qemu/qemu_validate.c | 8 > 1 file changed, 8 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/phot

Re: [PATCH 1/8] qemu: capabilies: Introduce QEMU_CAPS_ACPI_GENERIC_INITIATOR

2025-09-11 Thread Daniel P . Berrangé via Devel
On Sat, Sep 06, 2025 at 03:08:56PM +0200, Andrea Righi wrote: > This capability tracks whether QEMU supports the acpi-generic-initiator > object type. > > This object has been introduced in QEMU with the commit: > b64b7ed8bb ("qom: new object to associate device to NUMA node"). > > Signed-off-by:

Re: vDPA devices and random MAC address assignment

2025-09-11 Thread Jason Wang via Devel
On Thu, Sep 11, 2025 at 2:18 PM Beñat Gartzia Arruabarrena wrote: > > Hello, > > I am trying to find a solution to an issue related to vhost-vdpa devices > and random mac addresses being assigned to them, if not set by the user. > > vDPA devices are assigned a MAC address the time they are created

[libvirt PATCH 0/8] qemu: test command line of external helpers

2025-09-11 Thread Ján Tomko via Devel
Ján Tomko (8): qemu: passt: split out qemuPasstBuildCommand tests: qemuxmlconftests: store suffix in testQemuInfo tests: qemuxmlconftest: Introduce testQemuConfMarkUsed export qemuVirtioFSBuildCommandLine tests: qemuxmlconftest: test passt command line too tests: qemuxmlconf: virtiofs:

Re: [PATCH v3 4/9] tests: Add tests for SEV firmware selection

2025-09-11 Thread Jim Fehlig via Devel
On 9/11/25 01:38, Andrea Bolognani wrote: On Wed, Sep 10, 2025 at 04:39:20PM -0600, Jim Fehlig wrote: On 9/10/25 07:57, Andrea Bolognani via Devel wrote: One of the new test cases demonstrates how firmware autoselection doesn't currently work correctly for domains using SEV-SNP: the descriptor

Re: [PATCH 2/2] qemu: implement driver support for domainBlockRebaseParams API

2025-09-11 Thread Peter Krempa via Devel
On Thu, Sep 11, 2025 at 18:27:43 +0300, Nikolai Barybin via Devel wrote: > Parse params list and pass arguments to underlying call to > qemuDomainBlockPullCommon. > > Now bandwidth unit of messurement is passed as param and passed further > with a use of VIR_DOMAIN_BLOCK_PULL_BANDWIDTH_BYTES flag.

Re: [PATCH 1/2] api: remote: introduce virDomainBlockRebaseParams API

2025-09-11 Thread Peter Krempa via Devel
On Thu, Sep 11, 2025 at 18:27:42 +0300, Nikolai Barybin via Devel wrote: > This new API is a combination of virDomainBlockPull and > virDomainBlockRebase (without copy mode) which supports extendable > list of virTypedParameterPtr params. > > It is designed to allow more configurable use of underl

[PATCH 2/2] qemu: implement driver support for domainBlockRebaseParams API

2025-09-11 Thread Nikolai Barybin via Devel
Parse params list and pass arguments to underlying call to qemuDomainBlockPullCommon. Now bandwidth unit of messurement is passed as param and passed further with a use of VIR_DOMAIN_BLOCK_PULL_BANDWIDTH_BYTES flag. virDomainBlockRebase2 doesn't use equavivalent external flag. Signed-off-by: Niko

[PATCH 1/2] api: remote: introduce virDomainBlockRebaseParams API

2025-09-11 Thread Nikolai Barybin via Devel
This new API is a combination of virDomainBlockPull and virDomainBlockRebase (without copy mode) which supports extendable list of virTypedParameterPtr params. It is designed to allow more configurable use of underlying 'block-stream' QMP command. If "base" == NULL and flags == 0 it is equivalent

Re: [PATCH 0/2] ch: Two simple fixes

2025-09-11 Thread Ján Tomko via Devel
On a Thursday in 2025, Michal Privoznik via Devel wrote: While working on emitting more events from the CH driver and playing with cloud-hypervisor itself, I've noticed one memleak and one forgotten call to unlock. Michal Prívozník (2): ch: Avoid memory leak in virCHProcessEvents() ch: Unlock

[PATCH 0/2] ch: Two simple fixes

2025-09-11 Thread Michal Privoznik via Devel
While working on emitting more events from the CH driver and playing with cloud-hypervisor itself, I've noticed one memleak and one forgotten call to unlock. Michal Prívozník (2): ch: Avoid memory leak in virCHProcessEvents() ch: Unlock domain in virCHEventStopProcess() on all exit paths src

[PATCH 2/2] ch: Unlock domain in virCHEventStopProcess() on all exit paths

2025-09-11 Thread Michal Privoznik via Devel
From: Michal Privoznik The aim of virCHEventStopProcess() is to clean up after stopped domain by calling virCHProcessStop(). But in order to do that it needs to acquire a job and in order to do that it needs to lock the domain object. Well, the object is not unlocked in all exit paths, i.e. when

Re: [PATCH v3 4/9] tests: Add tests for SEV firmware selection

2025-09-11 Thread Andrea Bolognani via Devel
On Wed, Sep 10, 2025 at 04:39:20PM -0600, Jim Fehlig wrote: > On 9/10/25 07:57, Andrea Bolognani via Devel wrote: > > One of the new test cases demonstrates how firmware > > autoselection doesn't currently work correctly for domains > > using SEV-SNP: the descriptor for a suitable firmware exists,

Re: [PATCH 0/4] ch: Disk attach/detach fixes

2025-09-11 Thread Ján Tomko via Devel
On a Wednesday in 2025, Michal Privoznik via Devel wrote: While reviewing Stefan patches [1] I've changed some of them before merging and oopsie, I've introduced a bug (patch 1/4) but fortunately forgot to remove the code I intended to move so it actually works :-D. 1: https://lists.libvirt.or