[PATCH] qemuDomainDiskChangeSupported: Fill in missing check

The attribute 'discard_no_unref' is not allowed to be changed while the virtual machine is running. Resolves: https://issues.redhat.com/browse/RHEL-37542 Signed-off-by: Adam Julis --- src/qemu/qemu_domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu

[PATCH] conf: Drop unused declaration

Remove unused declaration of the virDomainDiskFindByBusAndDst(). Signed-off-by: Adam Julis --- src/conf/domain_conf.h | 4 1 file changed, 4 deletions(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index a06f015444..cdab6ef2da 100644 --- a/src/conf/domain_conf.h +++ b/src

[PATCH 2/2] qemu: implement iommu coldplug/unplug

Resolves: https://issues.redhat.com/browse/RHEL-23833 Signed-off-by: Adam Julis --- src/qemu/qemu_driver.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 67b9778c67..74d5e3bb86 100644 --- a/src/qemu

[PATCH 1/2] syms: Properly export virDomainIOMMUDefFree()

While the function is exported via header, the symbol itself was not. Signed-off-by: Adam Julis --- src/libvirt_private.syms | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 653c84a520..8d760aca04 100644 --- a/src/libvirt_private.syms

[PATCH 0/2] qemu: implement iommu coldplug/unplug

Adam Julis (2): syms: Properly export virDomainIOMMUDefFree() qemu: implement iommu coldplug/unplug src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 20 ++-- 2 files changed, 19 insertions(+), 2 deletions(-) -- 2.45.0

[PATCH 2/2] qemu: implement iommu coldplug/unplug

Resolves: https://issues.redhat.com/browse/RHEL-23833 Signed-off-by: Adam Julis --- src/qemu/qemu_driver.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 67b9778c67..74d5e3bb86 100644 --- a/src/qemu

[PATCH] conf: add validation of potential dependencies

, the virDomainDefValidate is added at the end. Signed-off-by: Adam Julis --- src/qemu/qemu_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e2698c7924..67b9778c67 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -6869,6 +6869,9

[PATCH] qemu_saveimage: add zstd to supported compression formats

Extend the list of supported formats, update and clarify comment in qemu.conf.in (removed misleading sentence about the order of compression format types). Signed-off-by: Adam Julis --- libvirt.spec.in | 1 + src/qemu/qemu.conf.in | 7 +++ src/qemu/qemu_saveimage.c | 2 ++ 3

[PATCH] qemuDomainChangeNet: Error when boot index changes in live XML

be an error. Resolves: https://issues.redhat.com/browse/RHEL-23416 Fixies: Commit hash aa3e07caec6179dfa6479deab14a21a493637d53 Signed-off-by: Adam Julis --- src/qemu/qemu_hotplug.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index b9c502613c

[PATCH] virt-admin: Fix segfault when libvirtd dies

vshAdmCatchDisconnect requires non-NULL structure vshControl for getting connection name (stored at opaque), but virAdmConnectRegisterCloseCallback at vshAdmConnect called it with NULL. Signed-off-by: Adam Julis --- tools/virt-admin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] virsh: Fix overflow error of freepages command

Signed-off-by: Adam Julis --- tools/virsh-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 6c14be865f..5a934d7a7f 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -335,7 +335,7 @@ cmdFreepages(vshControl *ctl, const

[PATCH] virsh: Fix overflow error of freepages command

Trying to print pages of a size larger than the UINT_MAX of the given platform, a system error was printed, but this is a legitimate request, fixed Signed-off-by: Adam Julis --- tools/virsh-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-host.c b/tools

[PATCH] virfile: switch to virReportSystemError in VIR_CLOSE() cond.

VIR_CLOSE also set errno, so it's not nessesary use virReportError with explicit error code Signed-off-by: Adam Julis --- src/util/virfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 9463833d31..deaf4555fd 100644 --- a/src

Re: [PATCH v2] virsh-completer: modify and fix bug in virshPoolTypeCompleter, now used for more commands

On 2/20/24 10:31, Adam Julis wrote: Signed-off-by: Adam Julis --- v2: - instead new completer is used already existing virshPoolTypeCompleter - added flag VIRSH_POOL_TYPE_COMPLETER_COMMA for the completer - fixed bug in pool-list --type command v1: https://lists.libvirt.org/archives/list

[PATCH v2] virsh-completer: modify and fix bug in virshPoolTypeCompleter, now used for more commands

Signed-off-by: Adam Julis --- v2: - instead new completer is used already existing virshPoolTypeCompleter - added flag VIRSH_POOL_TYPE_COMPLETER_COMMA for the completer - fixed bug in pool-list --type command v1: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message

[PATCH] virsh: completer for --type of commands find-storage-pool-sources and find-storage-pool-sources-as

Signed-off-by: Adam Julis --- tools/virsh-completer-pool.c | 11 +++ tools/virsh-completer-pool.h | 5 + tools/virsh-pool.c | 2 ++ 3 files changed, 18 insertions(+) diff --git a/tools/virsh-completer-pool.c b/tools/virsh-completer-pool.c index 0600394411..1081e5c10c