Signed-off-by: Boris Fiuczynski
---
tests/qemucapabilitiesdata/README.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemucapabilitiesdata/README.rst
b/tests/qemucapabilitiesdata/README.rst
index 727695c6b0..f65f07cfca 100644
--- a/tests/qemucapabilitiesdata
Reviewed-by: Boris Fiuczynski
and tested.
On 8/1/24 3:52 PM, Peter Krempa wrote:
Replace the 'misc-acpi' case by testing a bunch of architectures for how
ACPI is handled including a test for the s390 ACPI strip hack added in
previous commit.
The input files are adapted from the cor
muDomainDefACPIPostParse(def, qemuCaps, parseFlags);
+
if (qemuDomainDefBootPostParse(def, driver, parseFlags) < 0)
return -1;
Anyway
Reviewed-by: Boris Fiuczynski
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender
Reviewed-by: Boris Fiuczynski
On 7/31/24 1:02 PM, Peter Krempa wrote:
The s390(x) machines never supported ACPI. That didn't stop users
enabling ACPI in their config. As of libvirt-9.2 (98c4e3d073) with new
enough qemu we reject configs which require ACPI, but qemu can't satisfy
Reviewed-by: Boris Fiuczynski
On 7/31/24 1:02 PM, Peter Krempa wrote:
Replace the 'misc-acpi' case by testing a bunch of architectures for how
ACPI is handled including a test for the s390 ACPI strip hack added in
previous commit.
Signed-off-by: Peter Krempa
---
.../aar
was silently tolerated. To allow migration from libvirt
versions prior 9.1.0 which allowed the ACPI feature to be used on S390
tolerate ACPI by setting it to absent if specified and QEMU does not
support it.
Resolves: https://issues.redhat.com/browse/RHEL-49516
Signed-off-by: Boris Fiuczynski
s: Be more forgiving when decoding OEM strings
+
+On some systems, OEM strings are scattered in multiple sections. This
+confused libvirt when generating capabilities XML. Not anymore.
+
v10.5.0 (2024-07-01)
--
Mit freundlichen Grüßen/Kind regards
Boris Fi
On 7/22/24 2:01 PM, Jiri Denemark wrote:
On Mon, Jul 22, 2024 at 10:55:05 +0200, Michal Prívozník wrote:
On 7/19/24 17:44, Boris Fiuczynski wrote:
In cases when a QEMU process takes longer than the time sigterm and
sigkill are issued to kill the process do not simply fail and leave the
VM in
On 7/22/24 10:55 AM, Michal Prívozník wrote:
On 7/19/24 17:44, Boris Fiuczynski wrote:
In cases when a QEMU process takes longer than the time sigterm and
sigkill are issued to kill the process do not simply fail and leave the
VM in state VIR_DOMAIN_SHUTDOWN until the daemon stops. Instead set
yscall() fro that matter.
Ups, I forgot about that. Sending a v3 out.
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
cleanup the VM state.
Resolves: https://issues.redhat.com/browse/RHEL-28819
Signed-off-by: Boris Fiuczynski
---
src/qemu/qemu_domain.c | 8 +++
src/qemu/qemu_domain.h | 2 +
src/qemu/qemu_driver.c | 18 ++
src/qemu/qemu_process.c | 124 ++--
src/qemu
cleanup the VM state.
Resolves: https://issues.redhat.com/browse/RHEL-28819
Signed-off-by: Boris Fiuczynski
---
src/qemu/qemu_domain.c | 8 +++
src/qemu/qemu_domain.h | 2 +
src/qemu/qemu_driver.c | 18 +++
src/qemu/qemu_process.c | 115 ++--
src/qemu
cleanup the VM state.
Resolves: https://issues.redhat.com/browse/RHEL-28819
Signed-off-by: Boris Fiuczynski
---
src/qemu/qemu_domain.c | 8 +++
src/qemu/qemu_domain.h | 2 +
src/qemu/qemu_driver.c | 18 ++
src/qemu/qemu_process.c | 127 ++--
src/qemu
with this
change. Thanks for adding this to the news update.
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergerich
On 6/20/24 9:41 AM, Michal Prívozník wrote:
On 6/19/24 14:29, Boris Fiuczynski wrote:
Adjusting how DASDs are handled as recently ID_* tags are also included
in the udev information which causes the problems reported by
https://issues.redhat.com/browse/RHEL-39497
Removing the filtering of
Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
object consistency and not end up with multiple node objects
for DASDs.
Resolves: https://issues.redhat.com/browse/RHEL-39497
Reviewed-by: Marc Hartmayer
Signed-off-by: Boris Fiuczynski
---
src/node_device/node_device_udev.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/node_device
Prevent the creation of a new DASD node object when the device does not
exist.
Resolves: https://issues.redhat.com/browse/RHEL-39497
Reviewed-by: Marc Hartmayer
Signed-off-by: Boris Fiuczynski
---
src/node_device/node_device_udev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src
online again. The
state information is made available in the ccw capability as an optional
state element.
Boris Fiuczynski (4):
nodedev: refactor storage type fixup
nodedev: improve DASD detection
nodedev: prevent invalid DASD node object creation
nodedev: add ccw device state and remove
Instead of fencing offline ccw devices add the state to the ccw
capability.
Resolves: https://issues.redhat.com/browse/RHEL-39497
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c| 24
src/conf/node_device_conf.h| 11 +++
src/conf
Refactor the storage type fixup into a reusable method.
Reviewed-by: Marc Hartmayer
Signed-off-by: Boris Fiuczynski
---
src/node_device/node_device_udev.c | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/src/node_device/node_device_udev.c
b/src
someone to push his series.
Seems like patches 2, 3 and 20 are missing your rb or did Marc forget to
add them?
@Marc, could you send a rebased v3 since it seems the series no longer
cleanly applies on master.
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research
Reviewed-by: Boris Fiuczynski
On 4/23/24 8:09 PM, Marc Hartmayer wrote:
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/node_device/node_device_udev.c
b/src/node_device/node_device_udev.c
index
Cole, thanks for fixing the problem in test_driver caused by my changes.
Reviewed-by: Boris Fiuczynski
On 4/23/24 15:44, Cole Robinson wrote:
Commit v10.0.0-265-ge67bca23e4 added a `active_config` and
`defined_config` to nodedev mdev internal XML handling.
`defined_config` can be filled at
Reviewed-by: Boris Fiuczynski
On 4/23/24 15:44, Cole Robinson wrote:
- Error if INACTIVE requested for transient object
- Force dumping INACTIVE XML when object is inactive
Signed-off-by: Cole Robinson
---
src/test/test_driver.c | 17 -
1 file changed, 16 insertions(+), 1
Reviewed-by: Boris Fiuczynski
On 4/23/24 15:44, Cole Robinson wrote:
This was the implied default before nodedevs gained a notion of
being inactive and transient. It also matches the implied default
when parsing other object types
Signed-off-by: Cole Robinson
---
src/test/test_driver.c | 2
Reviewed-by: Boris Fiuczynski
On 4/23/24 20:09, Marc Hartmayer wrote:
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/node_device/node_device_udev.c
b/src/node_device/node_device_udev.c
index
Reviewed-by: Boris Fiuczynski
On 4/22/24 16:57, Peter Krempa wrote:
The CCW variant of the 'vhost-user-fs' device in qemu doesn't
deliberately support the 'bootindex' attribute as the machine is unable
to boot from such device.
Reject 'https://issues.redhat.com/b
Reviewed-by: Boris Fiuczynski
On 4/22/24 16:57, Peter Krempa wrote:
Replace symlink by a real output file so that we can also test updates
to input file.
Signed-off-by: Peter Krempa
---
.../vhost-user-fs-hugepages.x86_64-latest.xml | 79 ++-
1 file changed, 78 insertions
Reviewed-by: Boris Fiuczynski
On 4/22/24 16:57, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
.../vhost-user-fs-ccw.s390x-latest.args | 37
.../vhost-user-fs-ccw.s390x-latest.xml| 43 +++
tests/qemuxmlconfdata/vhost-user-fs-ccw.xml
Reviewed-by: Boris Fiuczynski
On 4/19/24 16:49, Marc Hartmayer wrote:
Instead of accessing the global `driver` object pass the `udevEventData` as
parameter to the thread handler and watch callback. This has the advantage that:
1. proper refcounting
2. easier to read and test
Signed-off-by
Reviewed-by: Boris Fiuczynski
On 4/19/24 16:49, Marc Hartmayer wrote:
Use this feature in `udevEventDataNew`.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/src/node_device
Reviewed-by: Boris Fiuczynski
On 4/19/24 16:49, Marc Hartmayer wrote:
There is only one case where force is true, therefore let's inline that case.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 25 +++--
1 file changed, 11 insertions(+
This could be quashed with patch 3 but I am also fine with this if you
do not want to spend the effort.
Reviewed-by: Boris Fiuczynski
On 4/19/24 16:49, Marc Hartmayer wrote:
When an udev event occurs the mdev active config data requires an update via
mdevctl as the udev does not contain all
With the too-many-rebase-add-change and the additional comment
explaining why currently only one worker must be used
Reviewed-by: Boris Fiuczynski
On 4/19/24 16:49, Marc Hartmayer wrote:
Use a worker pool for processing the events (e.g. udev, mdevctl config changes)
and the initialization
Reviewed-by: Boris Fiuczynski
On 4/19/24 16:49, Marc Hartmayer wrote:
It's better practice for all functions called by the threads to pass the driver
via parameter and not global variables. Easier to test and cleaner.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_dri
Reviewed-by: Boris Fiuczynski
On 4/19/24 16:49, Marc Hartmayer wrote:
The documentation of gobject signals reads:
"If you are connecting handlers to signals and using a GObject instance as your
signal handler user data, you should remember to pair calls to
g_signal_connect() with cal
Reviewed-by: Boris Fiuczynski
On 4/19/24 16:49, Marc Hartmayer wrote:
Introduce and use the driver functions for the node state shutdown preparation
and wait. As they're also called in the error/cleanup path of
`nodeStateInitialize`, they must be written in a way, that they can safe
Reviewed-by: Boris Fiuczynski
On 4/19/24 16:49, Marc Hartmayer wrote:
Even if `priv->udev_monitor` was never initialized, the mdevctlLock, udevThread
were. Therefore let's match the order of releasing the resources the order of
allocating the resources in `nodeStateInitialize`.
In
Reviewed-by: Boris Fiuczynski
On 4/19/24 16:49, Marc Hartmayer wrote:
Commit a99d876a0f58 ("node_device: Use automatic mutex management") replaced the
locking mechanism and accidentally removed the comment with the reason why the
lock is taken. The reason was to "ensure only
Reviewed-by: Boris Fiuczynski
On 4/19/24 16:49, Marc Hartmayer wrote:
Everything is released in `udevEventDataDispose` except for the threads, change
this as this makes the code easier to read as it can be simplified a little.
Signed-off-by: Marc Hartmayer
---
src/node_device
ev.active_config.nattributes,
- attr);
-}
-}
}
if (!(actual = virNodeDeviceDefFormat(dev, flags)))
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
hen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
___
Reviewed-by: Boris Fiuczynski
On 4/12/24 15:36, Marc Hartmayer wrote:
Inline `udevRemoveOneDevice` as it's used only once.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git
reate udev enumerate thread"));
-g_clear_pointer(&priv->initThread, g_free);
-goto cleanup;
- }
+nodeDeviceEventSubmit(NODE_DEVICE_EVENT_INIT, udev_ref(udev));
return VIR_DRV_STATE_INIT_COMPLETE;
@@ -2446,6 +2558,9 @@ nodeStateShutdownPrepare(void)
Reviewed-by: Boris Fiuczynski
On 4/12/24 15:36, Marc Hartmayer wrote:
There is only one case where force is true, therefore let's inline that case.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 25 +++--
1 file changed, 11 insertions(+
Reviewed-by: Boris Fiuczynski
On 4/12/24 15:36, Marc Hartmayer wrote:
There is no reason to serialize the `mdevctl list` calls.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/node_device
Reviewed-by: Boris Fiuczynski
On 4/12/24 15:36, Marc Hartmayer wrote:
When an udev event occurs the mdev active config data requires an update via
mdevctl as the udev does not contain all config data. This update needs to occur
immediate and to be finished before the libvirt nodedev event is
Reviewed-by: Boris Fiuczynski
On 4/12/24 15:36, Marc Hartmayer wrote:
Use the proper driver functions for the node state shutdown preparation and
wait. In the next patch, these functions will be extended.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 54
Reviewed-by: Boris Fiuczynski
On 4/12/24 15:36, Marc Hartmayer wrote:
@def is owned by @obj after adding it the node device object list. As soon as
the @obj lock has been released, another thread could free @obj and therefore
@def. If now someone accesses @def this would lead to a heap-use
Makes sens and also adding the prefix to the other three attributes you
mentioned in you follow up email.
To all four...
Reviewed-by: Boris Fiuczynski
On 4/3/24 16:03, Marc Hartmayer wrote:
The new thread name makes it easier to understand the purpose of the thread.
Signed-off-by: Marc
Reviewed-by: Boris Fiuczynski
On 4/3/24 16:03, Marc Hartmayer wrote:
Since @driver->privateData is modified take the lock.
Question: In theory we could take the udevEventData->mdevctlLock?
Isn't that protecting the access to the mdevctlMonitor?
On the first sight scheduleMdevctl
Reviewed-by: Boris Fiuczynski
On 4/3/24 16:03, Marc Hartmayer wrote:
Commit a99d876a0f58 ("node_device: Use automatic mutex management") replaced the
locking mechanism and accidentally removed the comment with the reason why the
lock is taken. Restore this comment and add a new com
Reviewed-by: Boris Fiuczynski
On 4/3/24 16:03, Marc Hartmayer wrote:
It is done a little differently everywhere in libvirt, but most common is to
test for != -1.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions
Reviewed-by: Boris Fiuczynski
On 4/3/24 16:03, Marc Hartmayer wrote:
Remove the timeout when the udevEventData is disposed, analogous to priv->watch.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/node_dev
attr);
- }
-}
}
if (!(actual = virNodeDeviceDefFormat(dev, flags)))
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: Davi
requirement to mock dumping transient mdevs.
virNodeDeviceObjSetSkipUpdateCaps(obj, true);
virNodeDeviceObjEndAPI(&obj);
}
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wol
Reviewed-by: Boris Fiuczynski
On 4/9/24 16:56, Cole Robinson wrote:
Signed-off-by: Cole Robinson
---
src/test/test_driver.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index f9bd6f4e67..41828f86b6 100644
--- a/src
Reviewed-by: Boris Fiuczynski
On 4/9/24 16:56, Cole Robinson wrote:
Signed-off-by: Cole Robinson
---
src/test/test_driver.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 852a084bce..f9bd6f4e67 100644
--- a/src
Reviewed-by: Boris Fiuczynski
On 4/9/24 16:56, Cole Robinson wrote:
$ virsh --connect test:///default nodedev-list
error: Failed to list node devices
error: unsupported flags (0x8000) in function testConnectListAllNodeDevices
The test driver handles the nodedev state flags, we just need
On 4/9/24 17:09, Michal Prívozník wrote:
On 4/9/24 16:56, Cole Robinson wrote:
The virt-manager test suite is busted with libvirt 10.1.0+ after
this commit:
commit e67bca23e4fe38a3491749f724b9edf743d0e916
Author: Boris Fiuczynski
Date: Thu Feb 22 14:02:01 2024 +0100
nodedev: add an
onfig->nattributes = 0;
+}
+
+
A good portion of this function is duplicating code that exists in
virNodeDevCapsDefFree(). Let's just factor that code out into a
virMediatedDeviceConfigClear() function and then use it from both
locations.
OK, will do.
--
Mit freundlichen Grüßen/Ki
These patches fix copying the configuration data when starting a
persistent mdev and improve the reliability of configuration data
being up to date when mdev configuration data is changed.
Boris Fiuczynski (3):
nodedev: fix mdev add udev event data handling
nodedev: immediate update of active
invalid data. Instead copying the defined config data will
store valid data into the newly added node object.
Signed-off-by: Boris Fiuczynski
---
src/node_device/node_device_udev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/node_device/node_device_udev.c
b/src
When an udev add event occurs the mdev active config data requires an
update via mdevctl as the udev does not contain all config data.
This update needs to occur immediate and to be finished before the
libvirt CREATE event is issued to keep the API usage reliable.
Signed-off-by: Boris Fiuczynski
When a mdev device is destroyed or stopped the udev remove event
handling needs to reset the active config data of the node object
representing a persisted mdev.
Signed-off-by: Boris Fiuczynski
---
src/node_device/node_device_driver.c | 22 ++
src/node_device
Adding 'save' ACL to REMOTE_PROC_NODE_DEVICE_DEFINE_XML to make
REMOTE_PROC_NODE_DEVICE_UPDATE ACLs meaningful.
Fixes: 69f9e7dbc24657e85761f03574779540d0f18315
Signed-off-by: Boris Fiuczynski
---
src/remote/remote_protocol.x | 1 +
1 file changed, 1 insertion(+)
diff --git a/
On 2/26/24 15:21, Ján Tomko wrote:
On a Thursday in 2024, Boris Fiuczynski wrote:
A public API method which allows to update or modify objects is
implemented for almost all other objects that have a concept of
persistent definition and activatability. Currently node devices of type
mdev can be
Michal,
thanks for fixing this.
Reviewed-by: Boris Fiuczynski
On 2/26/24 13:22, Michal Privoznik wrote:
There are two memleaks inside of nodedevmdevctltest:
1) In the testCommandDryRunCallback() - when appending lines to
stdinbuf the pointer is overwritten without freeing the old
eries
before the freeze. Thanks.
On 2/22/24 7:01 AM, Boris Fiuczynski wrote:
The series adds a dual state to the mdev node devices as these objects
can be active and defined at the same time. These two states can
become different. To be able to also introspect the persistent and
transient nod
Create a new structure holding type and attributes as these are
modifiable in a persistent mdev configuration and run out of sync with
the active mdev configuration.
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 18 +++
src/conf/node_device_conf.h | 4
Allow to filter node devices based on their persistent or transient
states.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
include/libvirt/libvirt-nodedev.h | 2 ++
src/conf/node_device_conf.h | 7 ++-
src/conf/virnodedeviceobj.c | 8
3 files changed
virBufferEscapeString already contains the null check.
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index a8554102fc..febc58afd1 100644
--- a
Refactor attribute handling code into methods for easier reuse.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
src/conf/node_device_conf.c | 27 ---
src/node_device/node_device_driver.c | 104 ---
2 files changed, 80 insertions(+), 51
Allow to dump the XML of the persistent mdev when the mdev has been
started instead of the current state only.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
docs/manpages/virsh.rst | 7 +--
tools/virsh-nodedev.c | 10 +-
2 files changed, 14 insertions(+), 3
Add ability to update node devices.
Signed-off-by: Boris Fiuczynski
---
docs/drvnodedev.rst | 4 +-
docs/manpages/virsh.rst | 19
tools/virsh-nodedev.c | 98 +
3 files changed, 120 insertions(+), 1 deletion(-)
diff --git a/docs
available
* renamed persisted and persist into persistent
* removed persistent precheck in virsh
* addressed all other review comments made on v1
* added NEWS
Boris Fiuczynski (12):
virmdev: prepare type and attributes for dual state
node_device: refactor mdev attributes handling
node_device
: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
NEWS.rst | 7 +
libvirt.spec.in | 1 +
src/node_device/node_device_driver.c | 224 +-
src/node_device/node_device_driver.h | 11 +
src
. mdevctl supports with callout scripts to do an
attribute retrieval of started mdevs which is already implemented in
libvirt.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
include/libvirt/libvirt-nodedev.h | 11
src/conf/node_device_conf.c
Allow to modify a node device by using virNodeDeviceDefineXML() to align
its behavior with other drivers define methods.
Signed-off-by: Boris Fiuczynski
---
NEWS.rst | 5 +++
src/libvirt-nodedev.c| 4 ++-
src/node_device/node_device_driver.c | 47
Commit 26136e3 allowed to use option all with option tree but did not
update the manpage.
Signed-off-by: Boris Fiuczynski
---
docs/manpages/virsh.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index 248807d0e9
devices as well.
Signed-off-by: Boris Fiuczynski
---
include/libvirt/libvirt-nodedev.h | 18 +
src/access/viraccessperm.c| 1 +
src/access/viraccessperm.h| 6 +
src/conf/virnodedeviceobj.c | 42 +
src/conf/virnodedeviceobj.h
Now that we can filter persistent and transient node devices in
virConnectListAllNodeDevices(), add these switches also to the
virsh nodedev-list command.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
docs/manpages/virsh.rst | 8 ++--
tools/virsh-nodedev.c | 24
On 2/21/24 18:27, Jonathon Jongsma wrote:
On 2/16/24 8:52 AM, Boris Fiuczynski wrote:
Allow to modify a node device by using virNodeDeviceDefineXML() to align
its behavior with other drivers define methods.
Signed-off-by: Boris Fiuczynski
---
NEWS.rst | 5
On 2/20/24 23:23, Jonathon Jongsma wrote:
Minor nit: the commit subject still says "persisted" instead of
"persistent"
Sorry I missed these. I have sent a v4 fixing these.
On 2/16/24 8:52 AM, Boris Fiuczynski wrote:
Allow to filter node devices based on their persisted
Add ability to update node devices.
Signed-off-by: Boris Fiuczynski
---
docs/drvnodedev.rst | 4 +-
docs/manpages/virsh.rst | 19
tools/virsh-nodedev.c | 98 +
3 files changed, 120 insertions(+), 1 deletion(-)
diff --git a/docs
devices as well.
Signed-off-by: Boris Fiuczynski
---
include/libvirt/libvirt-nodedev.h | 18 +
src/access/viraccessperm.c| 1 +
src/access/viraccessperm.h| 6 +
src/conf/virnodedeviceobj.c | 42 +
src/conf/virnodedeviceobj.h
. mdevctl supports with callout scripts to do an
attribute retrieval of started mdevs which is already implemented in
libvirt.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
include/libvirt/libvirt-nodedev.h | 11
src/conf/node_device_conf.c
: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
NEWS.rst | 7 +
libvirt.spec.in | 1 +
src/node_device/node_device_driver.c | 224 +-
src/node_device/node_device_driver.h | 11 +
src
Now that we can filter persistent and transient node devices in
virConnectListAllNodeDevices(), add these switches also to the
virsh nodedev-list command.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
docs/manpages/virsh.rst | 8 ++--
tools/virsh-nodedev.c | 24
Allow to modify a node device by using virNodeDeviceDefineXML() to align
its behavior with other drivers define methods.
Signed-off-by: Boris Fiuczynski
---
NEWS.rst | 5 +++
src/libvirt-nodedev.c| 4 +-
src/node_device/node_device_driver.c | 62
Allow to filter node devices based on their persistent or transient
states.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
include/libvirt/libvirt-nodedev.h | 2 ++
src/conf/node_device_conf.h | 7 ++-
src/conf/virnodedeviceobj.c | 8
3 files changed
Refactor attribute handling code into methods for easier reuse.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
src/conf/node_device_conf.c | 27 ---
src/node_device/node_device_driver.c | 104 ---
2 files changed, 80 insertions(+), 51
Allow to dump the XML of the persistent mdev when the mdev has been
started instead of the current state only.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
docs/manpages/virsh.rst | 7 +--
tools/virsh-nodedev.c | 10 +-
2 files changed, 14 insertions(+), 3
Commit 26136e3 allowed to use option all with option tree but did not
update the manpage.
Signed-off-by: Boris Fiuczynski
---
docs/manpages/virsh.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index 248807d0e9
virBufferEscapeString already contains the null check.
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index a8554102fc..febc58afd1 100644
--- a
Create a new structure holding type and attributes as these are
modifiable in a persistent mdev configuration and run out of sync with
the active mdev configuration.
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 18 +++
src/conf/node_device_conf.h | 4
since v1:
* replaced spec file requirement for v1.3.0 of mdevctl by a dynamic
support check and an unsupported message if not available
* removed persisted precheck in virsh
* renamed persisted and persist into persistent
* addressed all other review comments made on v1
* added NEWS
Boris
: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
NEWS.rst | 7 +
libvirt.spec.in | 1 +
src/node_device/node_device_driver.c | 224 +-
src/node_device/node_device_driver.h | 11 +
src
Add ability to update node devices.
Signed-off-by: Boris Fiuczynski
---
docs/drvnodedev.rst | 4 +-
docs/manpages/virsh.rst | 19
tools/virsh-nodedev.c | 98 +
3 files changed, 120 insertions(+), 1 deletion(-)
diff --git a/docs
1 - 100 of 152 matches
Mail list logo
