[libvirt-python PATCH] build: Adapt to PEP 625 distribution file naming

2025-09-20 Thread Jiri Denemark via Devel
The version of setuptools shipped by Fedora 42 is PEP 625 compliant, which requires distribution files to contain a normalized package name. Thus the generated tarball is called libvirt_python-$VER.tar.gz rather than libvirt-python-$VER.tar.gz created by older setuptools. The source directory insid

Plans for 11.8.0 release (freeze on 2025-09-25)

2025-09-19 Thread Jiri Denemark via Devel
We are getting close to 11.8.0 release of libvirt. To aim for the release on Wednesday 01 Oct I suggest entering the freeze on Thursday 25 Sep and tagging RC2 on Monday 29 Sep. I hope this works for everyone. Jirka

[PATCH] tests: Drop unused vm variable in testQemuMonitorCPUInfo

2025-09-07 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/qemumonitorjsontest.c | 5 - 1 file changed, 5 deletions(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 38779a20d0..65b14ca318 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests/qemumonitorjsontes

[PATCH 01/14] qemu: Drop legacy probing of CPU features

2025-09-05 Thread Jiri Denemark via Devel
From: Jiri Denemark The legacy probing which reads CPUID registers from QEMU and interprets the individual bits is not used with any QEMU version currently supported by libvirt. Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor.c | 30 --- src/qemu/qemu_monitor.h

[PATCH 12/14] qemu: Merge qemuMonitorJSONGetCPUDataDisabled in qemuMonitorJSONGetGuestCPU

2025-09-04 Thread Jiri Denemark via Devel
From: Jiri Denemark The qemuMonitorJSONGetCPUDataDisabled function is just a wrapper around two function calls and it is only used by qemuMonitorJSONGetGuestCPU. Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor_json.c | 26 ++ 1 file changed, 6 insertions(+), 20 d

[PATCH 13/14] qemu: Let qemuMonitorJSONGetCPUProperties also return disabled features

2025-09-04 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor_json.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 6b736aefd0..f8be1a79b1 100644 --- a/src/qemu/q

[PATCH 10/14] qemu: Merge qemuMonitorJSONGetCPUData in qemuMonitorJSONGetGuestCPU

2025-09-04 Thread Jiri Denemark via Devel
From: Jiri Denemark The qemuMonitorJSONGetCPUData function is just a wrapper around two function calls and it is only used by qemuMonitorJSONGetGuestCPU. Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor_json.c | 27 ++- 1 file changed, 6 insertions(+), 21 deletion

[PATCH 00/14] qemu: Optimize guest CPU probing

2025-09-04 Thread Jiri Denemark via Devel
When a domain starts we need to check what CPU features were enabled and if any of the features we asked for were disabled. Currently this requires more than 470 QMP commands (and the number is growing everytime QEMU adds a new feature or other property to the CPU object). Thanks to a new qom-list-

[PATCH 07/14] qemu: Use qom-list-get for checking enabled CPU features

2025-09-04 Thread Jiri Denemark via Devel
From: Jiri Denemark qom-list-get is a new QMP command (since QEMU 10.1) that combines qom-list for listing properties of a specified object with qom-get for getting a value of a given property. The new command provides an array of all properties and their values, which allows us to dramatically r

[PATCH 05/14] qemu: Move feature filtering to qemuMonitorJSONGetCPUProperties

2025-09-04 Thread Jiri Denemark via Devel
From: Jiri Denemark When getting enabled CPU features (qemuMonitorJSONGetCPUData), we used to call qemuMonitorJSONGetCPUProperties to get the list of all boolean properties and then queried their values and ignored properties that were not true. By moving the filtering inside qemuMonitorJSONGetCP

[PATCH 06/14] qemu: Parse properties list from any JSON array

2025-09-04 Thread Jiri Denemark via Devel
From: Jiri Denemark The qemuMonitorJSONParsePropsList API expected a QMP reply as an input. By generalizing it to work on any JSON array, we can reuse the API even for commands which return the array of properties nested in an object. Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor_json

[PATCH 09/14] qemu: Add qemuMonitorJSONCPUDataAddFeatures helper

2025-09-04 Thread Jiri Denemark via Devel
From: Jiri Denemark The function translates a list of CPU feature names retrieved from QEMU and adds them to virCPUData. Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor_json.c | 43 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/src/

[PATCH 14/14] qemu: Don't query unavailable-features if qom-list-get is supported

2025-09-04 Thread Jiri Denemark via Devel
From: Jiri Denemark With qom-list-get we already have the value of unavailable-features property in the returned object (just like we have all values of all bool properties). Let's use the value from there instead of querying for it separately using qom-get. After this patch only a single QMP co

[PATCH 11/14] qemu: Always fetch disabled features in qemuMonitorJSONGetGuestCPU

2025-09-04 Thread Jiri Denemark via Devel
From: Jiri Denemark The function is always called with both enabled and disabled pointers set. Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor_json.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c ind

[PATCH 08/14] tests: Test qemuMonitorJSONGetGuestCPU with qom-get-list

2025-09-04 Thread Jiri Denemark via Devel
From: Jiri Denemark The test cases show both the legacy method and the new one produce identical results. Signed-off-by: Jiri Denemark --- .../get-guest-cpu-SierraForest.json | 2985 + .../get-guest-cpu-SkylakeClient.json | 2967 tests/qemumo

[PATCH 03/14] tests: Test qemuMonitorJSONGetGuestCPU with empty unavailable-features

2025-09-04 Thread Jiri Denemark via Devel
From: Jiri Denemark The key point here is that the unavailable-features property reports an empty array. Signed-off-by: Jiri Denemark --- .../get-guest-cpu-SkylakeClient-disabled.xml |2 + .../get-guest-cpu-SkylakeClient-enabled.xml |7 + .../get-guest-cpu-SkylakeClient.json

[PATCH 04/14] qemu: Generalize filtering in qemuMonitorJSONParsePropsList

2025-09-04 Thread Jiri Denemark via Devel
From: Jiri Denemark qemuMonitorJSONParsePropsList supported filtering based on type. Let's replace it with a callback supplied by the caller to allow for more advanced filtering. Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor_json.c | 51 +--- 1 file cha

Re: [PATCH v3 1/1] docs : add doc on cpu model and features

2025-09-02 Thread Jiri Denemark via Devel
On Wed, Aug 27, 2025 at 16:25:06 +0200, Hector Cao wrote: > Add documentation on the way libvirt displays the Host CPU > model and capabilities (features). There is an implicit > expectation from users to get the CPU model name matching the > CPU model they are running on, however, this does not ha

Release of libvirt-11.7.0

2025-09-01 Thread Jiri Denemark via Devel
The 11.7.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is

libvirt-11.7.0 release candidate 2

2025-08-28 Thread Jiri Denemark via Devel
I have just tagged v11.7.0-rc2 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

Re: [PATCH v3 0/1] docs : add doc on cpu model and features

2025-08-27 Thread Jiri Denemark via Devel
On Wed, Aug 27, 2025 at 14:24:13 +0200, Hector Cao wrote: > Hello, > > This is a follow-up of the submission: > https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/EZBLO5CIGC3FTI5J72WNVAKWPSNQFLCY/ > > Based on Jiri's feedback, it is better to tackle this situation by > documen

Re: [PATCH] NEWS: document bhyve changes for the release

2025-08-27 Thread Jiri Denemark via Devel
On Wed, Aug 27, 2025 at 09:52:11 +0200, Roman Bogorodskiy wrote: > Signed-off-by: Roman Bogorodskiy > --- > NEWS.rst | 15 +++ > 1 file changed, 15 insertions(+) Reviewed-by: Jiri Denemark

Entering freeze for libvirt-11.7.0

2025-08-25 Thread Jiri Denemark via Devel
I have just tagged v11.7.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

Re: [PATCH v2 1/1] docs : add doc on cpu model and features

2025-08-21 Thread Jiri Denemark via Devel
On Wed, Jul 09, 2025 at 11:03:19 +0200, Hector CAO wrote: > From: Hector Cao > > Add documentation on the way libvirt displays the Host CPU > model and capabilities (features). There is an implicit > expection from users to get the CPU model name matching the s/expection/expectation/ > CPU mode

Plans for 11.7.0 release (freeze on 2025-08-25)

2025-08-18 Thread Jiri Denemark via Devel
We are getting close to 11.7.0 release of libvirt. To aim for the release on Monday 01 Sep I suggest entering the freeze on Monday 25 Aug and tagging RC2 on Thursday 28 Aug. I hope this works for everyone. Jirka

Release of libvirt-11.6.0

2025-08-01 Thread Jiri Denemark via Devel
The 11.6.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is

Re: [PATCH] NEWS: Mention RBD namespaces, and auto-shutdown/key encipherment fixes

2025-07-31 Thread Jiri Denemark via Devel
On Thu, Jul 31, 2025 at 15:17:41 +0200, Peter Krempa wrote: > From: Peter Krempa > > Signed-off-by: Peter Krempa > --- > NEWS.rst | 19 +++ > 1 file changed, 19 insertions(+) Reviewed-by: Jiri Denemark

Re: [PATCH] NEWS: Document features/improvements/bug fixes I've participated in

2025-07-30 Thread Jiri Denemark via Devel
On Wed, Jul 30, 2025 at 14:42:20 +0200, Michal Privoznik wrote: > From: Michal Privoznik > > There are some features/improvements/bug fixes I've either > contributed or reviewed/merged. Document them for upcoming > release. > > Signed-off-by: Michal Privoznik > --- > NEWS.rst | 6 ++ > 1 f

libvirt-11.6.0 release candidate 2

2025-07-30 Thread Jiri Denemark via Devel
I have just tagged v11.6.0-rc2 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

Re: [PATCH] include: fix version for VIR_CONNECT_BASELINE_CPU_IGNORE_HOST

2025-07-28 Thread Jiri Denemark via Devel
On Mon, Jul 28, 2025 at 13:47:45 +0100, Daniel P. Berrangé wrote: > From: Daniel P. Berrangé > > Signed-off-by: Daniel P. Berrangé > --- > include/libvirt/libvirt-host.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/li

Entering freeze for libvirt-11.6.0

2025-07-28 Thread Jiri Denemark via Devel
I have just tagged v11.6.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

Re: [PATCH v5 0/5] Disable Deprecated Features by Default on s390 CPU Models

2025-07-25 Thread Jiri Denemark via Devel
On Thu, Jul 24, 2025 at 14:39:02 -0400, Collin Walling wrote: > On 7/24/25 03:35, Thomas Huth via Devel wrote: > > On 30/06/2025 05.19, Collin Walling wrote: > >> Changelog > >> > >> v5 > >> - dropped the "none" test in qemuxmlactivetest (see commit for > >> details) > >> -

Re: [PATCH] NEWS: mention disabling deprecated features by default on s390 CPU models

2025-07-25 Thread Jiri Denemark via Devel
On Thu, Jul 24, 2025 at 14:36:23 -0400, Collin Walling wrote: > Signed-off-by: Collin Walling > --- > NEWS.rst | 8 > 1 file changed, 8 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index e5e8626729..6cc8f23225 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @@ -32,6 +32,14 @@ v11.6.0

Plans for 11.6.0 release (freeze on 2025-07-28)

2025-07-18 Thread Jiri Denemark via Devel
We are getting close to 11.6.0 release of libvirt. To aim for the release on Friday 01 Aug I suggest entering the freeze on Monday 28 Jul and tagging RC2 on Wednesday 30 Jul. I hope this works for everyone. Jirka

[PATCH 7/6] NEWS: Mention virConnectHypervisorBaselineCPU improvements

2025-07-04 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- NEWS.rst | 12 1 file changed, 12 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index d8bd2559f4..4fd12d94f4 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,8 +17,20 @@ v11.6.0 (unreleased) * **New features** + * Introduce VI

[PATCH 6/6] virsh: Add support for VIR_CONNECT_BASELINE_CPU_IGNORE_HOST flag

2025-07-04 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- docs/manpages/virsh.rst | 11 --- tools/virsh-host.c | 8 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 7082ca773a..bcb5495ed9 100644 --- a/docs/

[PATCH 5/6] qemu: Implement VIR_CONNECT_BASELINE_CPU_IGNORE_HOST

2025-07-04 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- src/qemu/qemu_driver.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 2c06e50454..cf7407ce2d 100644 --- a/src/qemu/qemu_driver.c +++ b/

[PATCH 4/6] Introduce VIR_CONNECT_BASELINE_CPU_IGNORE_HOST flag

2025-07-04 Thread Jiri Denemark via Devel
From: Jiri Denemark With this new flag virConnectHypervisorBaselineCPU can be used on any host (rather than being limited to hosts described by individual CPUs passed to the API). Using the flag makes the API behave similarly to the old virConnectBaselineCPU. The main difference is the CPU defini

[PATCH 3/6] Change documentation style of virConnectBaselineCPUFlags

2025-07-04 Thread Jiri Denemark via Devel
From: Jiri Denemark Moving the documentation above each enum item gives us more space for it. Signed-off-by: Jiri Denemark --- include/libvirt/libvirt-host.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt-host.

[PATCH 2/6] Clarify documentation of virConnectBaselineHypervisorCPU

2025-07-04 Thread Jiri Denemark via Devel
From: Jiri Denemark The API was apparently never considered for being used on a host that is not represented in the input set of CPU definitions. The result is limited to the set of features and CPU models known to the host's hypervisor. This would likely not be a big issue, but thanks to a side

[PATCH 1/6] cpu: Show input CPU model names in debug log

2025-07-04 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- src/cpu/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index 77afb7e9b3..233686485d 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c @@ -581,7 +581,7 @@ virCPUBaseline(virArch arch,

[PATCH 0/6] Make virConnectBaselineHypervisorCPU a bit more sane

2025-07-04 Thread Jiri Denemark via Devel
See 2/6 for description of the issue this series is trying to deal with. Jiri Denemark (6): cpu: Show input CPU model names in debug log Clarify documentation of virConnectBaselineHypervisorCPU Change documentation style of virConnectBaselineCPUFlags Introduce VIR_CONNECT_BASELINE_CPU_IGNO

Release of libvirt-11.5.0

2025-07-01 Thread Jiri Denemark via Devel
The 11.5.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is

Re: [PATCH v2 18/24] qapi/migration: Deprecate capabilities commands

2025-07-01 Thread Jiri Denemark via Devel
On Mon, Jun 30, 2025 at 16:59:07 -0300, Fabiano Rosas wrote: > The concept of capabilities is being merged into the concept of > parameters. From now on, the commands that handle capabilities are > deprecated in favor of the commands that handle parameters. > > Affected commands: > > - migrate-se

[PATCH] NEWS: Mention shared filesystem detection fix

2025-06-30 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index ee4e9a022e..089224cbe3 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -66,6 +66,12 @@ v11.5.0 (unreleased) domain XML acquires QUERY job. But this caus

Re: [PATCH] NEWS: Document features/improvements/bug fixes I've participated in

2025-06-30 Thread Jiri Denemark via Devel
On Mon, Jun 30, 2025 at 10:40:36 +0200, Michal Privoznik wrote: > From: Michal Privoznik > > There are some features/improvements/bug fixes I've either > contributed or reviewed/merged. Document them for upcoming > release. > > Signed-off-by: Michal Privoznik > --- > NEWS.rst | 6 ++ > 1 f

Re: [PATCH v2 10/13] qemuBuildDeviceAddresDriveProps: Prepare for 'drive' address for usb-bot disks

2025-06-25 Thread Jiri Denemark via Devel
On Mon, Jun 23, 2025 at 21:59:15 +0200, Peter Krempa wrote: > From: Peter Krempa > > While the 'usb-storage' based disks use the USB address directly, with > 'usb-bot' the USB address is on the "controller" part of the device and > the 'scsi-hd/cd' device will use a 'drive' address from qemu's Po

Re: [PATCH v2 12/13] qemuxmlconftest: Prepare for proper testing in 'disk-cdrom-usb-empty'

2025-06-24 Thread Jiri Denemark via Devel
On Mon, Jun 23, 2025 at 21:59:17 +0200, Peter Krempa wrote: > From: Peter Krempa > > Modify the validation of empty cdroms to trigger only for > VIR_DOMAIN_DISK_MODEL_USB_STORAGE as with 'usb-bot' we can properly > emulate a cdrom. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_validate

Entering freeze for libvirt-11.5.0

2025-06-24 Thread Jiri Denemark via Devel
I have just tagged v11.5.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

Re: [PATCH v2 13/13] qemu: Replace usb-storage with usb-bot

2025-06-24 Thread Jiri Denemark via Devel
On Mon, Jun 23, 2025 at 21:59:18 +0200, Peter Krempa wrote: > From: Akihiko Odaki > > usb-storage is a compound device that automatically creates a USB mass > storage device and a SCSI device as its backend. Unfortunately it lacks > some configuration options that are usually present with a SCSI

Re: [PATCH v2 11/13] qemu: monitor: Introduce 'qemuMonitorSetUSBDiskAttached'

2025-06-24 Thread Jiri Denemark via Devel
On Mon, Jun 23, 2025 at 21:59:16 +0200, Peter Krempa wrote: > From: Peter Krempa > > The helper sets the 'attached' property of the 'usb-bot' device to true, > which will be used on the hotplug code path. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_monitor.c | 12 >

Re: [PATCH v2 07/13] qemuxmlconftest: Invoke "disk-usb-device" case also without QEMU_CAPS_DEVICE_USB_BOT and with ABI_UPDATE

2025-06-24 Thread Jiri Denemark via Devel
On Mon, Jun 23, 2025 at 21:59:12 +0200, Peter Krempa wrote: > From: Peter Krempa > > The QEMU_CAPS_DEVICE_USB_BOT device can be compiled out but > realistically it makes no sense to do it thus also makes no sense to > have another variant of input data for it. > > Add another invocation of "disk

Re: [PATCH v2 06/13] qemu_capabilities: Introduce QEMU_CAPS_DEVICE_USB_BOT

2025-06-24 Thread Jiri Denemark via Devel
On Mon, Jun 23, 2025 at 21:59:11 +0200, Peter Krempa wrote: > From: Akihiko Odaki > > usb-bot is supported by all supported QEMU versions; it is present since > 1.4.0 and libvirt supports 4.2.0 or later. > > Add a capability just in case USB_STORAGE_BOT is disabled when building > QEMU. > > Sig

Re: [PATCH v2 05/13] qemuxmlconftest: Distribute testing of 'removable' disk property

2025-06-24 Thread Jiri Denemark via Devel
On Mon, Jun 23, 2025 at 21:59:10 +0200, Peter Krempa wrote: > From: Peter Krempa > > The 'removable' property is tested for 'usb' and 'scsi' disks. The test > case for 'usb' disks already has another test case for this, so add > testing of 'removable' SCSI disks into the 'disk-scsi' case and remo

Re: [PATCH v2 04/13] qemuxmlconftest: Drop 'disk-cdrom-bus-other'

2025-06-24 Thread Jiri Denemark via Devel
On Mon, Jun 23, 2025 at 21:59:09 +0200, Peter Krempa wrote: > From: Peter Krempa > > The test case is now redundant since 'disk-usb-device' case also tests > all cdrom configurations. Remove it. > > Signed-off-by: Peter Krempa > --- > .../disk-cdrom-bus-other.x86_64-latest.args | 34

Re: [PATCH v2 03/13] qemusecuritytest: Use 'disk-usb-device' case instead of 'disk-cdrom-bus-other'

2025-06-24 Thread Jiri Denemark via Devel
On Mon, Jun 23, 2025 at 21:59:08 +0200, Peter Krempa wrote: > From: Peter Krempa > > Signed-off-by: Peter Krempa > --- > tests/qemusecuritytest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Jiri Denemark

Re: [PATCH v2 02/13] qemuxmlconftest: Test various combinations of config

2025-06-24 Thread Jiri Denemark via Devel
On Mon, Jun 23, 2025 at 21:59:07 +0200, Peter Krempa wrote: > From: Peter Krempa > > Add multiple USB disks to the definition testing a matrix of 'disk' and > 'cdrom' elements with user-aliases, 'serial' and 'removable' > properties configured. > > This patch also removes the 'ide' disk which i

Re: [PATCH v2 01/13] qemuhotplugtest: Use VIR_DOMAIN_DEF_PARSE_ABI_UPDATE for virDomainDeviceDefParse

2025-06-24 Thread Jiri Denemark via Devel
On Mon, Jun 23, 2025 at 21:59:06 +0200, Peter Krempa wrote: > From: Peter Krempa > > The qemu hotplug code parses the device with ABI updates enabled so > qemuhotplugtest ought to do the same. > > Signed-off-by: Peter Krempa > --- > tests/qemuhotplugtest.c | 4 ++-- > 1 file changed, 2 inserti

Re: [PATCH v2 09/13] qemu: Fill in model of 'usb' disks to preserve ABI compatibility

2025-06-24 Thread Jiri Denemark via Devel
On Mon, Jun 23, 2025 at 21:59:14 +0200, Peter Krempa wrote: > From: Peter Krempa > > While 'usb-bot' and 'usb-storage' are ABI and migration compatible for > disks it's not the case for cdroms. When migrating from a new config > using 'usb-bot' to an older daemon which would use 'usb-storage' the

Re: [PATCH v2 08/13] conf: introduce usb disk models 'usb-storage' and 'usb-bot'

2025-06-24 Thread Jiri Denemark via Devel
On Mon, Jun 23, 2025 at 21:59:13 +0200, Peter Krempa wrote: > From: Peter Krempa > > Historically libvirt specified 'usb-storage' as driver for USB disks. > This though combined with '-blockdev' doesn't properly configure the > device to look like CDROM for . > > 'usb-bot' acts like a controler

Re: [PATCH 0/1] cpu_map: fix vmx-* features wrong bitmaps

2025-06-18 Thread Jiri Denemark via Devel
On Mon, Jun 16, 2025 at 01:46:59 +0200, Hector Cao wrote: > Hello, > > A friendly ping, > > To fix this issue, I would like to propose this solution. > Here is the draft patch, I can submit a proper one in a separate mail if we > can reach an agreement > on this solution. > > Thanks ! > > diff

Plans for 11.5.0 release (freeze on 2025-06-24)

2025-06-18 Thread Jiri Denemark via Devel
We are getting close to 11.5.0 release of libvirt. To aim for the release on Tuesday 01 Jul I suggest entering the freeze on Tuesday 24 Jun and tagging RC2 on Friday 27 Jun. I hope this works for everyone. Jirka

[PATCH 2/2] util: Move virFileGetExistingParent out of ifdef __linux__

2025-06-03 Thread Jiri Denemark via Devel
From: Jiri Denemark The function is called by virFileIsSharedFSOverride which is not Linux specific and thus building on anything but Linux failes. Fixes: 94fb348d670f612c0b58901c9829b4eec81faa50 Signed-off-by: Jiri Denemark --- src/util/virfile.c | 55 +++--

[PATCH 1/2] util: Avoid statfs in virFileGetExistingParent

2025-06-03 Thread Jiri Denemark via Devel
From: Jiri Denemark The code was separated from virFileIsSharedFSType which is Linux-only, but virFileGetExistingParent is also called from virFileIsSharedFSOverride which is OS independent. Thus we can't use statfs. Let's use virFileExists (access) instead, we were not interested in anything but

[PATCH 0/2] Fix build on non-Linux

2025-06-03 Thread Jiri Denemark via Devel
Jiri Denemark (2): util: Avoid statfs in virFileGetExistingParent util: Move virFileGetExistingParent out of ifdef __linux__ src/util/virfile.c | 56 ++--- tests/virfilemock.c | 28 +++ 2 files changed, 56 insertions(+), 28 deletion

Release of libvirt-11.4.0

2025-06-02 Thread Jiri Denemark via Devel
The 11.4.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is

Re: [PATCH] cpu_map: Add more -noTSX x86 CPU models (Sapphire and Granite rapids)

2025-06-02 Thread Jiri Denemark via Devel
On Mon, Jun 02, 2025 at 01:19:29 +0200, Hector Cao wrote: > Several Intel CPU models with TSX technology (HLE & RTM features) are > affected by the vulnerability TAA[1]. One of the mitigation methods > for TAA is to disable TSX support on the host system. For that purpose, > in 2021, Intel publishe

Re: [PATCH v2] NEWS: Mention removal of compile time helper program lookup, virito-net ABI check and FDC capabilities

2025-05-30 Thread Jiri Denemark via Devel
On Fri, May 30, 2025 at 14:24:43 +0200, Peter Krempa wrote: > From: Peter Krempa > > Signed-off-by: Peter Krempa > --- > > v2: > - moved the entry about $PATH lookup under "packaging changes" > - added a note that it fixes libvirt on distros which merged /sbin to > /bin but only on new instal

Re: [PATCH v4 00/27] hw/i386/pc: Remove deprecated 2.6 and 2.7 PC machines

2025-05-30 Thread Jiri Denemark via Devel
On Fri, May 30, 2025 at 14:08:25 +0200, Peter Krempa wrote: > The rest are CPU properties > > DEFINE_PROP_BOOL("cpuid-0xb", X86CPU, enable_cpuid_0xb, true), > DEFINE_PROP_BOOL("fill-mtrr-mask", X86CPU, fill_mtrr_mask, true), > DEFINE_PROP_BOOL("full-cpuid-auto-level", X86CPU, full_cpuid_auto_le

libvirt-11.4.0 release candidate 2

2025-05-30 Thread Jiri Denemark via Devel
I have just tagged v11.4.0-rc2 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

Re: [PATCH] virConnectAuthCallbackDefault: Return failure if 'virGetPassword' returns NULL

2025-05-29 Thread Jiri Denemark via Devel
On Thu, May 29, 2025 at 22:43:20 +0200, Peter Krempa wrote: > From: Peter Krempa > > virGetPassword can return NULL on linux or BSD if it fails. The caller > in virConnectAuthCallbackDefault does dereference it unconditionally. > > Return failure if virGetPassword returns NULL. > > Fixes: db728

[PATCH 3/3] util: Fix virFileIsSharedFSOverride on nonexistent paths

2025-05-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Commit v11.0.0-162-gf2023e8018 added path canonicalization to virFileIsSharedFSOverride to make sure we can properly match shared filesystem override paths which include symlinks. But virFileCanonicalizePath only works on existing paths, while virFileIsSharedFSOverride may be

[PATCH 2/3] util: Introduce virFileGetExistingParent helper

2025-05-29 Thread Jiri Denemark via Devel
From: Jiri Denemark The code from virFileIsSharedFSType which finds the longest existing path for a given input is separated into a new helper so that it can be reused elsewhere. Signed-off-by: Jiri Denemark --- Notes: If you wonder why the code is almost the same as the original one, but

[PATCH 1/3] util: Document limitation of virFileCanonicalizePath

2025-05-29 Thread Jiri Denemark via Devel
From: Jiri Denemark On most platforms virFileCanonicalizePath is implemented using realpath(), which only works on existing paths. Signed-off-by: Jiri Denemark --- src/util/virfile.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/virfile.c b/src/util/virfile.c i

[PATCH 0/3] util: Fix virFileIsSharedFSOverride on nonexistent paths

2025-05-29 Thread Jiri Denemark via Devel
Jiri Denemark (3): util: Document limitation of virFileCanonicalizePath util: Introduce virFileGetExistingParent helper util: Fix virFileIsSharedFSOverride on nonexistent paths src/util/virfile.c | 76 +++--- 1 file changed, 45 insertions(+), 31 delet

[PATCH] qemu: Fix error when migration with shared TPM storage is unsupported

2025-05-28 Thread Jiri Denemark via Devel
From: Jiri Denemark The VIR_ERR_NO_SUPPORT error is supposed to be used for unsupported driver APIs. It is incorrectly used when swtpm does not support migration with shared storage resulting in a rather strange error message: this function is not supported by the connection driver: the runn

[PATCH] NEWS: Make sure releases are separated by two blank lines

2025-05-27 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- NEWS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index a880524ca2..0ba2d20191 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -533,6 +533,7 @@ v10.9.0 (2024-11-01) element is added for that CPU model listin

[PATCH 2/2] NEWS: Fix virtqemud crash when resuming failed post-copy migration

2025-05-27 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 636fcbd573..a880524ca2 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -42,6 +42,13 @@ v11.4.0 (unreleased) The only workaround is to avoid the broke

[PATCH 1/2] qemu: Fix crash when resuming failed post-copy migration

2025-05-27 Thread Jiri Denemark via Devel
From: Jiri Denemark Since commit 28a06215280 (released in 11.2.0) resuming a failed post-copy migration calls qemuProcessIncomingDefNew with fd == NULL rather than -1. The function does not expect to be called with NULL file descriptor and tries to dereference it causing virtqemud on the destinat

[PATCH 0/2] qemu: Fix crash when resuming failed post-copy migration

2025-05-27 Thread Jiri Denemark via Devel
Jiri Denemark (2): qemu: Fix crash when resuming failed post-copy migration NEWS: Fix virtqemud crash when resuming failed post-copy migration NEWS.rst | 7 +++ src/qemu/qemu_migration.c | 3 ++- 2 files changed, 9 insertions(+), 1 deletion(-) -- 2.49.0

Entering freeze for libvirt-11.4.0

2025-05-27 Thread Jiri Denemark via Devel
I have just tagged v11.4.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

Re: [PATCH 0/7] nss: Couple of fixes and small improvements

2025-05-22 Thread Jiri Denemark via Devel
On Thu, May 22, 2025 at 14:25:10 +0200, Michal Privoznik wrote: > I've noticed most of these after I've turned on debugging for the NSS > plugin: > > diff --git i/tools/nss/libvirt_nss.h w/tools/nss/libvirt_nss.h > index 54a0216013..f9c3136985 100644 > --- i/tools/nss/libvirt_nss.h > +++ w/tools/n

[PATCH] virsh: Do not print warnings with "error:" prefix

2025-05-22 Thread Jiri Denemark via Devel
From: Jiri Denemark Both vshWarn and vshError are just wrappers around vshPrintStderr which properly propagates the message level to the log, but fails to honor it when printing on stderr. https://issues.redhat.com/browse/RHEL-79460 Signed-off-by: Jiri Denemark --- tools/vsh.c | 6 +- 1 f

Re: [PATCH] cputest: Skip more tests requiring JSON_MODELS if QEMU is disabled

2025-05-20 Thread Jiri Denemark via Devel
On Tue, May 20, 2025 at 15:50:24 +0200, Jaroslav Suchanek wrote: > From: Jaroslav Suchanek > > Marking more tests with JSON_MODELS_REQUIRED as these tests fail if QEMU is > disabled, typically when running tests on FreeBSD or macOS systems. > > Signed-off-by: Jaroslav Suchanek > --- > tests/cp

Plans for 11.4.0 release (freeze on 2025-05-27)

2025-05-19 Thread Jiri Denemark via Devel
We are getting close to 11.4.0 release of libvirt. To aim for the release on Monday 02 Jun I suggest entering the freeze on Tuesday 27 May and tagging RC2 on Friday 30 May. I hope this works for everyone. Jirka

Re: [PATCH v2] qemu: fix qemuMigrationCapability enum

2025-05-07 Thread Jiri Denemark via Devel
On Wed, May 07, 2025 at 10:07:41 +0300, Dmitry Frolov wrote: > Enum variable of type qemuMigrationCapability is checked for zero in > src/qemu/qemu_migration_params.c:729. > > "if (item->optional) { ..." > > Actualy, QEMU_MIGRATION_CAP_XBZRLE enum constant has value 0. > So, at least, the conditi

Re: [PATCH] qemu: fix qemuMigrationCapability enum

2025-05-06 Thread Jiri Denemark via Devel
On Tue, May 06, 2025 at 17:08:18 +0300, Dmitry Frolov wrote: > Enum variable of type qemuMigrationCapability is checked for zero in > src/qemu/qemu_migration_params.c:729. > > "if (item->optional) { ..." > > Actualy, QEMU_MIGRATION_CAP_XBZRLE enum constant has value 0. > Thus, all uninitialized .

Re: [PATCH] virnetdevtap: Fix memory leak in virNetDevTapReattachBridge

2025-05-06 Thread Jiri Denemark via Devel
On Tue, May 06, 2025 at 10:47:34 +0800, liu.son...@zte.com.cn wrote: > From: QiangWei Zhang > > Variable 'master' needs to be free because it will be reassigned in > virNetDevOpenvswitchInterfaceGetMaster(). > > The leaked stack: > Direct leak of 11 byte(s) in 1 object(s) allocated from: > #0 0x

Release of libvirt-11.3.0

2025-05-02 Thread Jiri Denemark via Devel
The 11.3.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is

libvirt-11.3.0 release candidate 2

2025-04-30 Thread Jiri Denemark via Devel
I have just tagged v11.3.0-rc2 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

[PATCH 15/15] cpu_x86: Fix algorithm for computing CPU model weight

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark This patch is effectively a NOP, but it fixes a logic bug and makes the heuristics more visible and easier to change should there be a need to do so in the future. We decide which CPU model is the best match for given CPU data by comparing lists of features that need to be en

[PATCH 13/15] cputest: Add data for a newer version of Intel Atom(R) P5362 CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + .../x86_64-cpuid-Atom-P5362-2-disabled.xml|9 + .../x86_64-cpuid-Atom-P5362-2-enabled.xml | 19 + .../x86_64-cpuid-Atom-P5362-2-guest.xml | 43 + .../x86_64-cpuid-A

[PATCH 14/15] cpu_x86: Refactor virCPUx86CompareCandidateFeatureList

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Refactor weight calculation to a separate virCPUx86WeightFeatures function to avoid code duplication. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 83 ++- 1 file changed, 46 insertions(+), 37 deletions(-) diff --git a/src

[PATCH 12/15] cputest: Add data for Intel(R) Xeon(R) w7-3465X CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + .../x86_64-cpuid-Xeon-w7-3465X-disabled.xml | 10 + .../x86_64-cpuid-Xeon-w7-3465X-enabled.xml| 20 + .../x86_64-cpuid-Xeon-w7-3465X-guest.xml | 55 + .../x86_64-cpuid-X

[PATCH 11/15] cputest: Add data for Intel(R) Xeon(R) Gold 6530 CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + .../x86_64-cpuid-Xeon-Gold-6530-disabled.xml | 10 + .../x86_64-cpuid-Xeon-Gold-6530-enabled.xml | 20 + .../x86_64-cpuid-Xeon-Gold-6530-guest.xml | 58 + .../x86_64-cpuid-X

[PATCH 10/15] cputest: Add data for Intel(R) Xeon(R) Bronze 3408U CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + ...86_64-cpuid-Xeon-Bronze-3408U-disabled.xml |9 + ...x86_64-cpuid-Xeon-Bronze-3408U-enabled.xml | 21 + .../x86_64-cpuid-Xeon-Bronze-3408U-guest.xml | 59 + .../x86_64-cpuid-X

[PATCH 08/15] cputest: Add data for AMD EPYC 9334 32-Core CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + ...86_64-cpuid-EPYC-9334-32-Core-disabled.xml |9 + ...x86_64-cpuid-EPYC-9334-32-Core-enabled.xml | 15 + .../x86_64-cpuid-EPYC-9334-32-Core-guest.xml | 42 + .../x86_64-cpuid-E

[PATCH 09/15] cputest: Add data for Intel(R) Xeon(R) 6731E CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + .../x86_64-cpuid-Xeon-6731E-disabled.xml | 11 + .../x86_64-cpuid-Xeon-6731E-enabled.xml | 21 + .../x86_64-cpuid-Xeon-6731E-guest.xml | 128 + .../x86_64-cpuid-X

[PATCH 07/15] cputest: Add data for Intel(R) Xeon(R) Gold 6152 CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + .../x86_64-cpuid-Xeon-Gold-6152-disabled.xml |7 + .../x86_64-cpuid-Xeon-Gold-6152-enabled.xml | 19 + .../x86_64-cpuid-Xeon-Gold-6152-guest.xml | 40 + .../x86_64-cpuid-X

[PATCH 06/15] cputest: Add data for AMD Ryzen 5 5500U CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + ...-5-5500U-with-Radeon-Graphics-disabled.xml |9 + ...n-5-5500U-with-Radeon-Graphics-enabled.xml | 11 + ...zen-5-5500U-with-Radeon-Graphics-guest.xml | 39 + ...yzen-5-5500U-wi

  1   2   >