Re: [PATCH v3 0/2] conf: add support for 'edid' attribute to video model

2025-08-14 Thread Mark Cave-Ayland
On 14/08/2025 11:49, Peter Krempa wrote: On Thu, Aug 07, 2025 at 12:05:08 +0100, Mark Cave-Ayland wrote: This series adds support for a new 'edid' attribute to the video model to control whether the EDID is visible to the guest. If the 'edid' attribute is unspecified then

[PATCH v3 2/2] tests/qemuxmlconfdata: add tests for video model 'edid' attribute

2025-08-12 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Krempa --- .../video-bochs-edid-none.x86_64-latest.args | 34 +++ .../video-bochs-edid-none.x86_64-latest.xml | 41 +++ .../qemuxmlconfdata/video-bochs-edid-none.xml | 30 ++ .../video-bochs-edid

[PATCH v3 1/2] conf: add support for 'edid' attribute to video model

2025-08-12 Thread Mark Cave-Ayland
attribute is only valid for the vga, boch and virtio display models and is currently only implemented for the QEMU driver. Signed-off-by: Mark Cave-Ayland --- docs/formatdomain.rst | 8 src/conf/domain_conf.c| 13 + src/conf/domain_conf.h

Re: [PATCH v2 2/2] tests/qemuxmlconfdata: add tests for video model 'edid' attribute

2025-08-12 Thread Mark Cave-Ayland
On 06/08/2025 15:21, Peter Krempa wrote: On Mon, Aug 04, 2025 at 15:07:20 +0100, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland --- [...] diff --git a/tests/qemuxmlconfdata/video-virtio-edid-on.xml b/tests/qemuxmlconfdata/video-virtio-edid-on.xml new file mode 100644 index

Re: [PATCH v2 1/2] conf: add support for 'edid' attribute to video model

2025-08-12 Thread Mark Cave-Ayland
On 06/08/2025 15:10, Peter Krempa wrote: On Mon, Aug 04, 2025 at 15:07:19 +0100, Mark Cave-Ayland wrote: Add the ability to enable/disable exposing the EDID information to the guest. The edid attribute can specified in the domain XML as below: If the edid attribute is

[PATCH v3 0/2] conf: add support for 'edid' attribute to video model

2025-08-12 Thread Mark Cave-Ayland
default. The 'edid' attribute is only valid for the vga, boch and virtio display models and is currently only implemented for the QEMU driver. Signed-off-by: Mark Cave-Ayland v3 - Rebase onto master - Use backtacks for video models and values in docs/formatdomain.rst

[PATCH v2 2/2] tests/qemuxmlconfdata: add tests for video model 'edid' attribute

2025-08-04 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- .../video-bochs-edid-none.x86_64-latest.args | 37 +++ .../video-bochs-edid-none.x86_64-latest.xml | 47 +++ .../qemuxmlconfdata/video-bochs-edid-none.xml | 36 ++ .../video-bochs-edid-off.x86_64-latest.args | 37

[PATCH v2 1/2] conf: add support for 'edid' attribute to video model

2025-08-04 Thread Mark Cave-Ayland
attribute is only valid for the vga, boch and virtio display models and is currently only implemented for the QEMU driver. Signed-off-by: Mark Cave-Ayland --- docs/formatdomain.rst | 8 src/conf/domain_conf.c| 5 + src/conf/domain_conf.h| 1

[PATCH v2 0/2] conf: add support for 'edid' attribute to video model

2025-08-04 Thread Mark Cave-Ayland
default. The 'edid' attribute is only valid for the vga, boch and virtio display models and is currently only implemented for the QEMU driver. Signed-off-by: Mark Cave-Ayland v2 - Rebase onto master - Remove 2nd sentence from v1 patch 1 commit message - Remove unnecessary video->t

Re: [PATCH v2 0/2] Introduce hardware UUID (hwuuid) element

2025-08-04 Thread Mark Cave-Ayland
On 01/08/2025 18:30, Daniel P. Berrangé wrote: On Fri, Aug 01, 2025 at 10:19:11AM +0100, Mark Cave-Ayland wrote: On 18/07/2025 09:44, Mark Cave-Ayland wrote: Following on from the discussions at [1] and more recently [2], this series introduces a new hardware UUID (hwuuid) element that

Re: [PATCH v2 0/2] Introduce hardware UUID (hwuuid) element

2025-08-01 Thread Mark Cave-Ayland
On 18/07/2025 09:44, Mark Cave-Ayland wrote: Following on from the discussions at [1] and more recently [2], this series introduces a new hardware UUID (hwuuid) element that allows an external UUID to be provided to the guest, as opposed to the libvirt domain UUID. The use case for this

Re: [PATCH] conf: add support for 'edid' attribute to video model

2025-08-01 Thread Mark Cave-Ayland
On 31/07/2025 17:12, Peter Krempa wrote: On Thu, Jul 31, 2025 at 17:05:18 +0100, Mark Cave-Ayland wrote: On 31/07/2025 12:52, Peter Krempa wrote: On Thu, Jul 31, 2025 at 10:50:40 +0100, Mark Cave-Ayland wrote: Add the ability to enable/disable exposing the EDID information to the guest

Re: [PATCH] conf: add support for 'edid' attribute to video model

2025-07-31 Thread Mark Cave-Ayland
On 31/07/2025 13:04, Daniel P. Berrangé wrote: On Thu, Jul 31, 2025 at 10:50:40AM +0100, Mark Cave-Ayland wrote: Add the ability to enable/disable exposing the EDID information to the guest. This allows migration from legacy machine types that have EDID disabled to a newer machine type without

Re: [PATCH] conf: add support for 'edid' attribute to video model

2025-07-31 Thread Mark Cave-Ayland
On 31/07/2025 12:52, Peter Krempa wrote: On Thu, Jul 31, 2025 at 10:50:40 +0100, Mark Cave-Ayland wrote: Add the ability to enable/disable exposing the EDID information to the guest. This allows migration from legacy machine types that have EDID disabled to a newer machine type without any

[PATCH] conf: add support for 'edid' attribute to video model

2025-07-31 Thread Mark Cave-Ayland
: If the edid attribute is unspecified, it is not generated so that the virtualisation platform will continue to use its default. The edid attribute is only valid for the vga, boch and virtio display models and is currently only implemented for the QEMU driver. Signed-off-by: Mark Cave

[PATCH v2 2/2] qemuxmlconftest: add tests for new hardware UUID (hwuuid) element

2025-07-18 Thread Mark Cave-Ayland
ar to the existing logic works for the domain UUID and the smbios UUID. Signed-off-by: Mark Cave-Ayland Reviewed-by: Daniel P. Berrangé --- ...hwuuid-smbios-uuid-match.x86_64-latest.err | 1 + .../hwuuid-smbios-uuid-match.xml | 36 .../qemuxmlconfdata/

[PATCH v2 1/2] conf: introduce hardware UUID (hwuuid) element

2025-07-18 Thread Mark Cave-Ayland
element, documentation and core code for the hwuuid feature along with an implementation for the QEMU driver. Signed-off-by: Mark Cave-Ayland --- docs/formatdomain.rst | 7 + src/conf/domain_conf.c| 43 +++ src/conf/domain_conf.h| 1

[PATCH v2 0/2] Introduce hardware UUID (hwuuid) element

2025-07-18 Thread Mark Cave-Ayland
source it doesn't appear as if all virtualisation platforms will support this feature: I've included the relevant changes for the QEMU driver since that is what we use here at Nutanix. Signed-off-by: Mark Cave-Ayland [1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.

Re: [RFC PATCH 0/6] Fix building of sparc/sparc32plus test cases

2025-07-17 Thread Mark Cave-Ayland
On 16/07/2025 11:54, Alex Bennée wrote: We didn't have any reliable way to build sparc test cases. I have found someone who ships a compiler but the binaries still don't run due to the need for CASA. I'm posting mainly for those who actually care who might want to fix up the remaining cases. A

[PATCH 2/2] qemuxmlconftest: add tests for new hardware UUID (hwuuid) element

2025-07-16 Thread Mark Cave-Ayland
ilar to how the existing logic works for the domain UUID and the smbios UUID. Signed-off-by: Mark Cave-Ayland --- ...hwuuid-smbios-uuid-match.x86_64-latest.err | 1 + .../hwuuid-smbios-uuid-match.xml | 36 .../qemuxmlconfdata/hwuuid.x86_64-latest.args | 35 +++

[PATCH 1/2] conf: introduce hardware UUID (hwuuid) element

2025-07-16 Thread Mark Cave-Ayland
element, documentation and core code for the hwuuid feature along with an implementation for the QEMU driver. Signed-off-by: Mark Cave-Ayland --- docs/formatdomain.rst | 7 ++ src/conf/domain_conf.c| 38 --- src/conf/domain_conf.h

[PATCH 0/2] Introduce hardware UUID (hwuuid) element

2025-07-16 Thread Mark Cave-Ayland
source it doesn't appear as if all virtualisation platforms will support this feature: I've included the relevant changes for the QEMU driver since that is what we use here at Nutanix. Signed-off-by: Mark Cave-Ayland [1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.

Re: Support cloning of VMs - part 2

2025-07-11 Thread Mark Cave-Ayland
On 11/07/2025 13:53, Daniel P. Berrangé wrote: On Fri, Jul 11, 2025 at 01:49:28PM +0100, Mark Cave-Ayland wrote: (snip) This probably takes us back to needing to have another element at the top level in the XML. ... where is mandatory as today, and can optionally be used

Re: Support cloning of VMs - part 2

2025-07-11 Thread Mark Cave-Ayland
On 09/07/2025 13:57, Daniel P. Berrangé wrote: On Wed, Jul 09, 2025 at 01:42:20PM +0100, Mark Cave-Ayland wrote: On 09/07/2025 12:10, Daniel P. Berrangé wrote: On Wed, Jul 09, 2025 at 11:27:45AM +0100, Daniel P. Berrangé via Devel wrote: On Mon, Jul 07, 2025 at 02:19:10PM +0100, Mark Cave

Re: Support cloning of VMs - part 2

2025-07-09 Thread Mark Cave-Ayland
On 09/07/2025 12:10, Daniel P. Berrangé wrote: On Wed, Jul 09, 2025 at 11:27:45AM +0100, Daniel P. Berrangé via Devel wrote: On Mon, Jul 07, 2025 at 02:19:10PM +0100, Mark Cave-Ayland wrote: Hi all, I'm currently looking at how libvirt can be used to clone a saved VM, and have been foc

Support cloning of VMs - part 2

2025-07-07 Thread Mark Cave-Ayland
Hi all, I'm currently looking at how libvirt can be used to clone a saved VM, and have been focusing on the previous thread on this topic at https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/YXN2L2PYL4V4576ON5OKQKCV7RCWPSCT/#PJWWXVWIXB3L6DYUZDFW5DWIBFBBW3WS. My understand

Re: [PATCH-for-9.0 v2] hw/i386/pc: Deprecate 64-bit CPUs on ISA-only PC machine

2024-03-28 Thread Mark Cave-Ayland
;no_parallel = !module_object_class_by_name(TYPE_ISA_PARALLEL); The logic around checking CPUID_EXT2_LM looks good to me. Slightly curious as to whether people feel updating PCMachineClass is necessary, or you can simply do qdev_get_machine() and use object_dynamic_cast() to see if the machine matches MACHINE_NAME("isapc") and warn that way? FWIW I'd be amazed if anyone were actually overriding the default and trying to do this, but I guess that's what the warn_report() is for anyhow: Reviewed-by: Mark Cave-Ayland ATB, Mark. ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-28 Thread Mark Cave-Ayland
On 27/03/2024 07:09, Gerd Hoffmann wrote: On Tue, Mar 26, 2024 at 01:30:48PM +, Mark Cave-Ayland wrote: Heh I've actually been using isapc over the past couple of weeks to fire up some old programs in a Windows 3 VM :) I'm wondering why these use cases can't simply use t

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-26 Thread Mark Cave-Ayland
On 26/03/2024 12:51, Igor Mammedov wrote: ISAPC machine was introduced 25 years ago and it's a lot of time since such machine was around with real ISA only PC hardware practically defunct. Also it's slowly bit-rots (for example: I was able to boot RHEL6 on RHEL9 host in only TCG mode, while in K