On 9/18/24 15:42, Martin Kletzander wrote:
> This function sets the memoryBackingDir in qemuDomainObjPrivate struct
> so that it is remembered for the whole lifetime of a domain.
>
> Signed-off-by: Martin Kletzander
> ---
> src/qemu/qemu_domain.c | 21 +
> 1 file changed, 21
On 9/18/24 17:26, Laine Stump wrote:
> These patches are in response to a bug report filed a few years ago
> where I said "I can look at it next week" and then promptly forgot
> about it :-/
>
> https://bugzilla.redhat.com/1949432
>
> I was reminded of it when a bunch of old bugs were migrated
On 9/18/24 17:26, Laine Stump wrote:
> Attempts to use update-device to modify just the link state of a guest
> interface were failing due to a supposed attempt to modify something
> in the interface that can't be modified live (even though the only
> thing that was changing was the link state, whi
On 9/16/24 10:33, Martin Kletzander wrote:
> The code did it "just in case" the allocation was not reset for new
> subdirectories. That might've happened in the past with CAT settings,
> but checking it now it is properly reset to its maximum values for each
> new CLOSID (Class of Service ID).
>
On 9/12/24 16:47, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander
> ---
> src/conf/capabilities.c | 5 ++-
> src/util/virresctrl.c | 77 -
> src/util/virresctrl.h | 3 ++
> 3 files changed, 53 insertions(+), 32 deletions(-)
>
> diff --git
On 9/12/24 16:47, Martin Kletzander wrote:
> The value 100 represented the percentage as it was originally done from
> Intel in the Linux kernel and on their CPUs. Since then the situation
s/ / /
and I'm just gonna stop pointing that out. You get the picture by now.
> changed and there is no e
On 9/12/24 16:47, Martin Kletzander wrote:
> The meaning of the values as well as their maximums are hard to predict
> and accounting for all the possibilities (which by the way might change
> during daemon's execution) is borderline hallucinatory. There is
> already a way we represent them, which
On 9/12/24 16:47, Martin Kletzander wrote:
> In some scenarios the memory bandwidth in the schemata file might be 0
> and so can the minimum allocation in other ones. Remove checks which
s/ / /
> were added for extra cautiousness.
>
> Resolves: https://issues.redhat.com/browse/RHEL-54235
> Sig
On 9/12/24 16:47, Martin Kletzander wrote:
> The code is teeny tiny less terrible with these.
>
> Martin Kletzander (10):
> resctrl: Account for memory bandwidth of 0 being valid
> docs: Document memory bandwidth allocation limits more clearly
> resctrl: Relax the limit of maximum memory ban
On 9/12/24 15:19, Martin Kletzander wrote:
> On Wed, Aug 28, 2024 at 02:16:15PM +0200, Michal Privoznik wrote:
>> So far, virCommandMassCloseGetFDsLinux() opens "/proc/self/fd",
>> iterates over it marking opened FDs in @fds bitmap. Well, we can
>> do the same on other systems (with altered path),
On 9/11/24 14:36, Jakub Palacky wrote:
> When libbsd is available, use the preferred readpassphrase() function isntead
> of getpass()
> as the getpass() function has been marked as obsolete and shouldnt be used
>
> Signed-off-by: Jakub Palacky
> ---
> Changes in v2:
> - Fix possible memory lea
On 9/11/24 15:37, Jakub Palacky wrote:
> xmlParserCtxt->lastError was deprecated in libxml2 v2.13.0-103-g1228b4e0
> xmlCtxtGetLastError(xmlParserCtxt) should be used instead
>
> Signed-off-by: Jakub Palacky
> ---
> src/util/virxml.c | 16
> 1 file changed, 8 insertions(+), 8 del
On 9/6/24 14:31, Peter Krempa wrote:
> Don't allocate the struct if it exists already. This sidesteps the
> discussion about whether forbidding multiple feature definitions makes
> sense.
>
> Fixes: a8e0f9c682143c63897de5c379d3ac3791c51970
> Closes: https://gitlab.com/libvirt/libvirt/-/issues/670
On 9/6/24 14:31, Peter Krempa wrote:
> Peter Krempa (2):
> conf: Don't overwrite KVM feature config struct if the feature is
> present twicea
> virconf: Fix numeric overflow when parsing numbers in conf files
>
> src/conf/domain_conf.c | 15 ---
> src/util/virconf.c | 6 +
On 9/6/24 14:53, Peter Krempa wrote:
> Recent fix to use the proper 'async' monitor function would cause
> libvirt to leak some of the objects it's supposed to clean up in other
> places besides qemu.
>
> Don't skip the whole function on failure to enter the job but just the
> monitor section.
>
On 9/4/24 09:21, Peter Krempa wrote:
> Add a capability dump for 'riscv64' with 'qemu-9.1' release captured
> on a x86_64 host as I don't have hardware.
>
I think we both know a person who does ;-)
> The last dump for riscv64 was done with qemu-8.0 which didn't manifest
> the newest features suc
On 9/4/24 09:21, Peter Krempa wrote:
> Update the qemu-9.1 caps on x86_64 to final version after yesterday's
> qemu release and add caps for riscv64 captured on an x86_64 host to
> manifest that ACPI is already supported:
>
> https://gitlab.com/libvirt/libvirt/-/issues/665
>
> Peter Krempa (2):
>
On 9/5/24 10:10, Peter Krempa wrote:
> On Wed, Sep 04, 2024 at 23:47:12 +0300, Dmitrii Abramov wrote:
>>
>>
>> Hello, Libvirt community.
>> We have one strange issue with libivrtd.
>> We’ve been using Libvirtd in docker for several years. This year we switched
>> to the new generation of proces
On 9/4/24 10:39, Martin Kletzander wrote:
> When users pre-create a tap device to use with multiqueue interface that
> has `managed="no"`, change the error so that it does not indicate we are
> trying to create the device, and on top of that hint at the most
> probable error cause.
>
> Resolves: h
On 9/4/24 10:39, Martin Kletzander wrote:
> See PATCH 2/2 (duh!).
>
> Martin Kletzander (2):
> virnetdevtap: Do (not) use NULLSTR consistently
> virnetdevtap: Add better error message for a possible common user
> error
>
> src/util/virnetdevtap.c | 13 ++---
> 1 file changed, 10
On 8/29/24 18:22, Tim Wiederhake wrote:
> This was added in qemu commit 6e82d3b6220777667968a04c87e1667f164ebe88.
>
> Signed-off-by: Tim Wiederhake
> ---
> src/cpu_map/index.xml | 1 +
> src/cpu_map/x86_SierraForest.xml | 177 ++
> .../domai
On 8/28/24 17:12, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> docs/formatdomaincaps.rst | 6 ++
> 1 file changed, 6 insertions(+)
>
Reviewed-by: Michal Privoznik
Michal
On 8/28/24 15:08, Andrea Bolognani wrote:
> This advertises the feature only for the architectures and
> machine types where it can actually be used.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/conf/domain_capabilities.c | 1 +
> src/conf/domain_capabilities.h
On 8/28/24 15:08, Andrea Bolognani wrote:
>
>
> Andrea Bolognani (3):
> qemu: Export a few functions
> qemu: Change signature for virQEMUCapsSupportsI8042Toggle()
> qemu: Expose availability of PS/2 feature in domcaps
>
> 74 files changed, 115 insertions(+), 11 deletions(-)
>
Reviewed-
On 8/28/24 14:39, Daniel P. Berrangé wrote:
> On Wed, Aug 28, 2024 at 02:16:16PM +0200, Michal Privoznik wrote:
>> The point of calling sysconf(_SC_OPEN_MAX) is to allocate big
>> enough bitmap so that subsequent call to
>> virCommandMassCloseGetFDsDir() can just set the bit instead of
>> expanding
On 8/26/24 21:30, Praveen K Paladugu wrote:
> Enble Bridge network mode for ch guest.
>
> Praveen K Paladugu (2):
> ch: Enable bridge network mode
> NEWS: Add an entry for network support in ch driver.
>
> NEWS.rst | 4
> src/ch/ch_interface.c | 2 +-
> 2 files changed, 5 i
On 8/27/24 17:08, Andrea Bolognani wrote:
> Back when pvpanic-pci support was introduced 1.5 years ago (!), we
> required the user to manually provide the model name. This is
> incovenient and doesn't match the behavior seen on other
> architectures. Make things more user friendly.
>
> Andrea Bolo
On 8/27/24 20:00, Pavel Hrdina wrote:
> Originally nicindexes were updated only for VIR_DOMAIN_NET_TYPE_BRIDGE
> and VIR_DOMAIN_NET_TYPE_DIRECT. The mentioned commit adds support for
> NAT network mode and changes the code to update nicindexes for
> VIR_DOMAIN_NET_TYPE_ETHERNET and VIR_DOMAIN_NET_T
On 8/2/24 00:25, Praveen K Paladugu wrote:
> Move additional domain interface management methods to hypervisor
> and enable NAT mode network support for ch guests.
>
> Praveen K Paladugu (2):
> hypervisor: Move domain interface mgmt methods
> ch: Enable NAT Network mode support
>
> src/ch/ch
On 8/2/24 00:25, Praveen K Paladugu wrote:
> From: Praveen K Paladugu
>
> From: Praveen K Paladugu
>
> Move methods to connect domain interfaces to host bridges to hypervisor.
> This is to allow reuse between qemu and ch drivers.
>
> Signed-off-by: Praveen K Paladugu
> Signed-off-by: Praveen
On 8/26/24 11:54, Tim Wiederhake wrote:
> Introduced in qemu commit 138c3377a9b27accec516b2c0da90dedef98a780.
>
> Signed-off-by: Tim Wiederhake
> ---
> src/cpu_map/x86_features.xml | 3 +++
> 1 file changed, 3 insertions(+)
>
Reviewed-by: Michal Privoznik
Michal
On 8/19/24 03:16, Kamil Szczęk wrote:
> A while back QEMU introduced a new machine property for disabling the
> i8042 PS/2 controller (commit 4ccd5fe22feb95137d325f422016a6473541fe9f)
> which up until then was a built-in device included by all PC machine
> type descendants unconditionally. This new
On 8/7/24 14:44, Michal Privoznik wrote:
>
Ping. It'd be nice to have this merged before the release.
Michal
On 8/14/24 13:30, Nikolai Barybin via Devel wrote:
> This will allow to print full domains info:
>
> Id Name State UUID
> ---
>
> Signed-off-by: Nikolai Barybin
> ---
> docs/manpages/virsh.rst | 14 +++---
> tools/virsh-domain-monitor.c | 37 +
On 7/29/24 15:31, Peter Krempa wrote:
> On Thu, Jul 04, 2024 at 13:02:46 +0200, Michal Privoznik wrote:
>> The 'tc' program stores speeds in 64bit integers (unit is bytes
>> per second) and sizes in uints (unit is bytes). We use different
>> units: kilobytes per second and kibibytes and therefore w
On 8/12/24 15:19, Daniel P. Berrangé wrote:
> This method is deprecated in libssh 0.11.0 in favour of the more
> flexible ssh_channel_get_exit_state. Rewrite our code to call the
> latter, and provide a compat shim that only fills out exit status.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> sr
On 8/12/24 12:30, Daniel P. Berrangé wrote:
> This mostly reverts commit 65491a2dfe00bfcf9f09a8d6eab60234b56c8cc4.
>
> There was a bug introduced in glib 2.67.0 which impacted libvirt with
> clang causing -Wincompatible-pointer-types-discards-qualifiers warnings.
>
> This was actually fixed quite
On 8/9/24 14:40, Peter Krempa wrote:
> Patch 3/3 adds the actual test:
>
> Changes to v1:
> - fixed missing NULL termination of the 'skip' array
> - "backported" g_string_replace into glibcompat.c until we bump minimum
>glib
> - started striping 'abs_srcdir' strings from qemuxmlconftest's '
On 8/9/24 14:40, Peter Krempa wrote:
> Add test cases for few edge cases which excercise the XML reporting from
> libxml2 in anticipation of upcoming changes of behaviour.
>
> 'virschematest' must skip parsing of the broken file altogether so this
> patch adds infrastructure to allow that.
>
> Si
On 8/5/24 16:40, Purna Pavan Chandra wrote:
> Current ch driver supports restore only for domains without any network
> configuration defined. This was because libvirt explicitly passes network fds
> and CH did not had support to restore with new net FDS. This support has been
> added recently, htt
On 8/8/24 09:27, Peter Krempa wrote:
> Add test cases for few edge cases which excercise the XML reporting from
> libxml2 in anticipation of upcoming changes of behaviour.
>
> 'virschematest' must skip parsing of the broken file altogether so this
> patch adds infrastructure to allow that.
>
> Si
On 8/7/24 09:37, Sandesh Patel wrote:
> Since Qemu commit 8646d9c (Support IR-only mode without DMA translation)
> version 7.1.0,
> Qemu support dma-translation attribute for Intel IOMMU. This patch adds a new
> attribute
> dma_translation to configure this.
>
> Sandesh Patel (3):
> Conf: add
On 8/7/24 09:37, Sandesh Patel wrote:
> Add dma_translation attribute to iommu to enable/disable dma traslation
> for intel-iommu
>
> Signed-off-by: Sandesh Patel
> ---
> docs/formatdomain.rst | 7 +++
> src/conf/domain_conf.c| 15 +++
> src/conf/domain_c
On 8/8/24 17:37, Peter Krempa wrote:
> Peter Krempa (3):
> qemuxmlconftest: Add test for old-style NUMA memory specification
> qemuxmlconftest: Don't use soon-to-be-removed machine types
> qemucapabilitiesdata: Update data for qemu-9.1 dev cycle on x86_64
>
> .../caps_9.1.0_x86_64.replies
On 8/8/24 13:41, Jiri Denemark wrote:
> See 2/2 for details.
>
> Jiri Denemark (2):
> qemu: Add support for postcopy-recover-setup migration state
> qemu: Avoid false failure when resuming post-copy migration
>
> src/conf/virdomainjob.c | 1 +
> src/conf/virdomainjob.h | 1 +
> s
On 8/6/24 09:01, Adam Julis wrote:
> The original condition caused (after adding modify option)
> possibly access to not allocated memory. For consistency added
> new check for multiple same records.
>
> Resolves: https://gitlab.com/libvirt/libvirt/-/issues/654
> Signed-off-by: Adam Julis
> ---
>
On 8/6/24 09:01, Adam Julis wrote:
> The "modify" command allowed to replace an existing record, now
> checks for the NULL string in the new value and throw error if
> found.
>
> Resolves: https://gitlab.com/libvirt/libvirt/-/issues/655
> Signed-off-by: Adam Julis
> ---
> src/conf/network_conf.c
On 7/30/24 15:55, Andrea Bolognani wrote:
> On Mon, Jul 29, 2024 at 11:31:35AM GMT, Michal Privoznik wrote:
>> Introduced only a couple of commits ago (in
>> v10.5.0-84-g90e50e67c6) the pstore device acts as a nonvolatile
>> storage, where guest kernel can store information about crashes.
>> This d
On 7/30/24 16:04, Andrea Bolognani wrote:
> On Mon, Jul 29, 2024 at 11:31:36AM GMT, Michal Privoznik wrote:
>> +static int
>> +qemuProcessPreparePstore(virDomainObj *vm)
>> +{
>> +virDomainPstoreDef *pstore = vm->def->pstore;
>> +VIR_AUTOCLOSE fd = -1;
>> +
>> +if (!pstore)
>> +
On 7/25/24 14:33, Peter Krempa wrote:
> On Thu, Jul 25, 2024 at 12:57:59 +0200, Michal Privoznik wrote:
>> Currently, qemuProcessStop() unlocks given domain object right in
>> the middle of cleanup process. This is dangerous because there
>> might be another thread which is executing virDomainObjLi
On 7/25/24 14:18, Daniel P. Berrangé wrote:
> On Thu, Jul 25, 2024 at 12:57:59PM +0200, Michal Privoznik wrote:
>> Currently, qemuProcessStop() unlocks given domain object right in
>> the middle of cleanup process. This is dangerous because there
>> might be another thread which is executing virDom
On 7/19/24 15:25, Adam Julis wrote:
> Disk targets were generated in virVMXParseConfig() with
> virVMXGenerateDiskTarget(). It works on combination of
> controller, fix offset, unit and prefix. While SCSI and SATA have
> same prefix "sd", function virVMXGenerateDiskTarget() could
> returned in some
On 7/23/24 14:24, Ján Tomko wrote:
> The new option style renamed one of the cache modes.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_virtiofs.c | 11 ++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
Reviewed-by: Michal Privoznik
Michal
On 7/24/24 10:56, John Levon wrote:
> The current "building from git" test uses "test -d .git"; however, that
> doesn't work when libvirt is used as a submodule, as in that case .git
> is a normal file. Use "test -e .git" instead.
>
> Signed-off-by: John Levon
> ---
> meson.build | 2 +-
> 1 fil
On 7/23/24 14:47, Adam Julis wrote:
> New element 'openfiles' had confusing name. Since the patch with
> this new element wasn't propagate yet, old name ('rlimit_nofile')
> was changed.
>
> ...
>
>
>
> ...
>
> Signed-off-by: Adam Julis
> ---
> docs/formatdomain.rst
On 7/24/24 13:02, Kristina Hanicova wrote:
> If there are absent values in an already existing element
> specifying rom settings, we simply use the old ones. This
> behaviour is not desired, as users might think that deleting the
> element from XML would delete the setting (because the hotplug
> su
On 7/23/24 17:57, Boris Fiuczynski wrote:
> On 7/22/24 2:01 PM, Jiri Denemark wrote:
>> On Mon, Jul 22, 2024 at 10:55:05 +0200, Michal Prívozník wrote:
>>> On 7/19/24 17:44, Boris Fiuczynski wrote:
>>>> In cases when a QEMU process takes longer than the time sigterm
On 7/23/24 15:34, Abhiram Tilak wrote:
> From: notpua
>
> Provides completers for auth-type and source-format commands for
> virsh pool-create-as and pool-define-as commands. Use Empty completers
> for options where completions are not required.
>
> Related Issue: https://gitlab.com/libvirt/libv
On 7/23/24 13:08, Jiri Denemark wrote:
> On Tue, Jul 23, 2024 at 12:41:31 +0200, Michal Privoznik wrote:
>> On various occasions, virt-host-validate parses /proc/cpuinfo to
>> learn about CPU flags (see virHostValidateGetCPUFlags()). It does
>> so, by reading the file line by line until the line wi
On 2/20/24 07:31, Takashi Kajinami wrote:
> This introduces the new "model" field in sev elements, returned by
> domain capabilities API, so that client can ensure SEV-ES is available
> in this hypervisor.
>
> Signed-off-by: Takashi Kajinami
> ---
> docs/formatdomaincaps.rst | 5 ++
> src/
On 7/18/24 15:27, Tim Wiederhake wrote:
> Also, update the sync tool with new features introduced in qemu.
>
> Tim Wiederhake (2):
> sync_qemu_models_i386.py: Add missing features
> cpu_map: Add GraniteRapids CPU model
>
> src/cpu_map/index.xml | 1 +
> src/cpu_map/
On 6/21/24 15:24, Tim Wiederhake wrote:
> This adds an option to use libcpuinfo [1] as data source for
> libvirt's list of x86 cpu features. This is purely optional and
> does not change the script's behavior if libcpuinfo is not
> installed.
>
> libcpuinfo is a cross-vendor, cross-architecture so
On 7/19/24 17:44, Boris Fiuczynski wrote:
> In cases when a QEMU process takes longer than the time sigterm and
> sigkill are issued to kill the process do not simply fail and leave the
> VM in state VIR_DOMAIN_SHUTDOWN until the daemon stops. Instead set up
> an fd on /proc/$pid and get notified w
On 7/16/24 11:40, Adam Julis wrote:
> Add an element to configure the rlimit nofile size:
>
> ...
>
>
>
> ...
>
> Non-positive values are forbidden in 'domaincommon.rng'. Added separate
> test file, created by modifying the 'vhost-user-fs-fd-memory.xml'.
>
> Resolves: https://gitlab.com/lib
On 7/16/24 11:41, Adam Julis wrote:
> Resolves: https://gitlab.com/libvirt/libvirt/-/issues/485
> Signed-off-by: Adam Julis
> ---
> src/qemu/qemu_virtiofs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c
> index 0e3c7dbb58..703f122
On 7/15/24 16:12, Martin Kletzander wrote:
> So much can happen in the fileName field of the VMX that the easiest
> thing is to silently report a serial type="null".
>
> This effectively reverts commits de81bdb8d4cd and 62c53db0421a, but
> keeps the test files to show the fix is still in place.
>
On 7/15/24 11:55, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> NEWS.rst | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Michal Privoznik
Michal
On 7/15/24 10:32, Michal Prívozník wrote:
> On 7/12/24 16:21, Andrea Bolognani wrote:
>>
>>
>> Andrea Bolognani (2):
>> cpu_map: Add pauth Arm CPU feature
>> tests: Add coverage for pauth Arm CPU feature
>>
>> src/cpu_map/arm_features.xml
On 7/12/24 17:18, Daniel P. Berrangé wrote:
> User feedback has shown that the examples are not clear enough
> to illustrate the cli passthrough concept in action.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/drvqemu.rst | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
Tri
On 7/12/24 16:21, Andrea Bolognani wrote:
>
>
> Andrea Bolognani (2):
> cpu_map: Add pauth Arm CPU feature
> tests: Add coverage for pauth Arm CPU feature
>
> src/cpu_map/arm_features.xml | 3 ++
> ...aarch64-features-pauth.aarch64-latest.args | 31 +++
> .
On 7/5/24 11:59, Kshitij Jha wrote:
> As of now, libvirt supports few essential stats as
> part of virDomainGetJobStats for Live Migration such
> as memory transferred, dirty rate, number of iteration
> etc. Currently it does not have support for the vfio
> stats returned via QEMU. This patch adds
On 7/9/24 17:23, Adam Julis wrote:
> The "modify" command allows to replace an existing record (its
> text value). The primary key is the name of the record. If
> duplicity or missing record detected, throw error.
>
> Tests in networkxml2xmlupdatetest.c contain replacements of an
> existing DNS-te
On 7/9/24 17:23, Adam Julis wrote:
> The "modify" command allows you to replace an existing record
> (its hostname, sub-elements). IP address acts as the primary key.
> If it is not found, the attempt ends with an error message. If
> the XML contains a duplicate address, it will select the last
> o
On 7/4/24 13:52, Adam Julis wrote:
> The outdated comment refers to a non-existent member in the
> virDomainObj structure.
>
> Signed-off-by: Adam Julis
> ---
> src/conf/domain_conf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Michal Privoznik
Michal
On 7/9/24 17:23, Adam Julis wrote:
> The "modify" command allows to replace an existing Srv record
> (some of its elements respectively: port, priority and weight).
> The primary key used to choose the modify record is the remaining
> parameters, only one of them is required. Not using some of thes
On 7/4/24 15:54, Ján Tomko wrote:
> Run the daemon with --print-capabilities first, to see what it supports.
>
> Signed-off-by: Ján Tomko
> ---
> src/conf/domain_conf.h | 1 +
> src/qemu/qemu_vhost_user.c | 60 ++
> src/qemu/qemu_vhost_user.h | 12 +++
On 7/4/24 15:54, Ján Tomko wrote:
> Also, allow migration if we think we can.
>
> Ján Tomko (5):
> tests: vhostuser: add virtiofsd json descriptor
> tests: qemuxmlconf: adjust test case to new virtiofsd
> qemu: fill capabilities for virtiofsd
> qemu: do not use deprecated options for new v
On 7/4/24 17:44, Miroslav Los via Devel wrote:
> In a domain created with an interface with a subelement,
> the device contains a non-NULL virDomainVirtioOptions struct, even
> for non-virtio NIC models. The subelement need not be present again
> after libvirt restarts, or when the interface is pa
On 7/5/24 10:01, hongmianquan wrote:
> Fix libvirtd hang since fork() was called while another thread had
> security manager locked.
>
> We have the stack security driver, which internally manages other security
> drivers,
> just call them "top" and "nested".
>
> We call virSecurityStackPreFork(
On 7/5/24 10:01, hongmianquan wrote:
> We have the stack security driver, which internally manages other security
> drivers,
> just call them "top" and "nested".
>
> We call virSecurityStackPreFork() to lock the top one, and it also locks
> and then unlocks the nested drivers prior to fork. Then
On 7/5/24 10:46, Andrea Bolognani wrote:
> On Thu, Jul 04, 2024 at 01:13:36PM GMT, Michal Privoznik wrote:
>> When binary version of edk2 is distributed, the files reside
>> under /usr/share/edk2-ovmf as can be seen from Gentoo's ebuild
>> [1]. Allow virt-aa-helper to generate paths under that dir.
On 7/4/24 14:59, John Levon wrote:
> Pick up some more of the qemu_driver.c code so this function supports
> both CONFIG and LIVE updates.
>
> Note that qemuDomainUpdateDeviceFlags() passed vm->def to
> virDomainDeviceDefParse() for the VIR_DOMAIN_AFFECT_CONFIG case, which
> is technically incorre
On 7/4/24 11:52, Rayhan Faizel wrote:
> mem_nodes[i].ndistances is written outside the loop causing an out-of-bounds
> write leading to heap corruption.
>
> While we are at it, the entire cleanup portion can be removed as it can be
> handled in virDomainNumaFree. One instance of VIR_FREE is also r
On 7/4/24 13:47, Daniel P. Berrangé wrote:
> When debugging guest problems with TPMs it is helpful to be able to
> have full swtpm logging. This isn't possible currently and manually
> restarting the swtpm process of a running guest is disruptive.
>
> Daniel P. Berrangé (2):
> conf: add support
On 6/25/24 12:03, hongmianquan via Devel wrote:
> We need to ensure top lock is acquired before nested lock. Otherwise deadlock
> issues may arise. We have the stack security driver, which internally manages
> other security drivers, we call them "top" and "nested".
>
> We call virSecurityStackPre
On 7/3/24 23:40, Rayhan Faizel wrote:
> Under the test environment, driver->domainEventState is uninitialized. If a
> disk gets dropped, it will attempt to queue an event which will cause a
> segmentation fault. This crash does not occur during normal use.
>
> This patch moves driver->domainEventS
On 7/3/24 14:44, Tim Wiederhake wrote:
> This is just to demonstrate that libvirt currently exhibits undefined
> behavior due to pthread mutex misuse. With this patch applied, several
> libvirt tests fail due to the triggered `abort()` calls:
> * cputest
> * qemuagenttest
> * qemucapabilitiestest
>
On 7/3/24 14:44, Tim Wiederhake wrote:
> `pthread_mutex_destroy`, `pthread_mutex_lock` and `pthread_mutex_unlock`
> return an error code that is currently ignored.
>
> Add debug information if one of these operations failed, e.g. when there
> is an attempt to destroy a still locked mutex or unlock
On 7/3/24 14:44, Tim Wiederhake wrote:
> libvirt currently exhibits undefined behavior due to pthread mutex misuse,
> e.g. destroying a locked mutex or attempting to unlock an already unlocked
> mutex.
>
> Add a warning if such a case is detected, so we can start on fixing the
> issues.
>
I expe
On 7/3/24 18:29, John Levon wrote:
> On Wed, Jul 03, 2024 at 09:44:47AM +0200, Michal Prívozník wrote:
>
>>>> LIVE is not supported and thus shouldn't be in list of supported flags.
>>>
>>> I was a bit unclear on the test hypervisor case - in a sense ever
On 6/25/24 12:03, hongmianquan via Devel wrote:
> We need to ensure top lock is acquired before nested lock. Otherwise deadlock
> issues may arise. We have the stack security driver, which internally manages
> other security drivers, we call them "top" and "nested".
>
> We call virSecurityStackPre
On 7/2/24 16:57, Rayhan Faizel wrote:
> The current hostdev parsing logic sets rawio or sgio even if the hostdev type
> is not 'scsi'. The rawio field in virDomainHostdevSubsysSCSI overlaps with
> wwpn field in virDomainHostdevSubsysSCSIVHost, consequently setting a bogus
> pointer value such as 0x
On 7/1/24 13:17, Adam Julis wrote:
> Changing the postgroup attribute caused unexpected behavior.
> Although it can be implemented, it has a non-trivial solution.
> No requirement or use has yet been found for implementing this
> feature, so it has been disabled for hot-plug.
>
> Resolves: https:/
On 6/20/24 11:21, Rayhan Faizel wrote:
> Under the test environment, driver->domainEventState is uninitialized. If a
> disk gets dropped, it will attempt to queue an event which will cause a
> segmentation fault. This crash does not occur during normal use.
>
> This patch adds a quick check to ens
On 7/2/24 16:25, John Levon wrote:
> On Tue, Jul 02, 2024 at 04:07:48PM +0200, Michal Prívozník wrote:
>
>>> +// TODO: support these here once tested.
>>> +case VIR_DOMAIN_DEVICE_GRAPHICS:
>>> +case VIR_DOMAIN_DEVICE_NET:
>&
On 7/1/24 22:29, John Levon wrote:
> Add basic coverage of device update; for now, only support disk updates
> until other types are needed or tested.
>
> Signed-off-by: John Levon
> ---
> src/test/test_driver.c | 127 +
> 1 file changed, 127 insertions(+)
On 7/1/24 14:24, Peter Krempa wrote:
> As I don't have a sparc machine handy add emulated capabilities.
>
> This patch is in preparation for bumping minimum qemu version beyond the
> oldest 'sparc' caps we currently have.
>
> Signed-off-by: Peter Krempa
> ---
> tests/domaincapsdata/qemu_9.0.0.s
On 6/28/24 13:39, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> NEWS.rst | 6 ++
> 1 file changed, 6 insertions(+)
>
Reviewed-by: Michal Privoznik
Michal
On 5/12/24 21:45, Andrew Melnychenko wrote:
> This series of rfc patches adds support for loading the RSS eBPF
> program and passing it to the QEMU.
> Comments and suggestions would be useful.
Hey, any plans on sending another version? I think we were pretty close
to have this merged.
Michal
On 6/21/24 18:16, Adam Julis wrote:
> The attribute 'discard_no_unref' is not allowed to be changed while
> the virtual machine is running.
>
> Resolves: https://issues.redhat.com/browse/RHEL-37542
>
> Signed-off-by: Adam Julis
> ---
> src/qemu/qemu_domain.c | 1 +
> 1 file changed, 1 insertion
1 - 100 of 314 matches
Mail list logo
