Re: [PATCH v2 03/12] hw/arm/raspi: Unify RASPI_MACHINE types

2025-02-04 Thread Peter Maydell
On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé wrote: > > Merge Raspi4bMachineState within RaspiMachineState by > using an unnamed union. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/raspi.c | 21 +++-- > 1 file changed, 7 insertions(+), 14 deletions(-) > > diff

Re: [PATCH v2 07/12] hw/arm/raspi: Check ramsize is within chipset aperture

2025-02-04 Thread Peter Maydell
pi_base_machine_init(MachineState *machine, > g_free(size_str); > exit(1); > } > +max_ramsize = ramsize_max(board_rev); > +if (ram_size > max_ramsize) { > +g_autofree char *max_ramsize_str = size_to_str(max_ramsize); > +error_report("At most %s of RAM can be used", max_ramsize_str); > + exit(1); Indent error? > +} Otherwise Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 01/12] hw/arm/raspi: Access SoC parent object using BCM283X_BASE() macro

2025-02-04 Thread Peter Maydell
iles changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 06/12] hw/arm/raspi: Consider network interface for B models

2025-02-04 Thread Peter Maydell
On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé wrote: > > Raspberry Pi 'B' models have an ethernet chipset (the LAN9512). > Since we don't yet model it, add a /* TODO */ comment. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/raspi.c | 14 ++ > 1 file changed, 14 inser

Re: [PATCH v2 02/12] hw/arm/raspi: Merge model 4B with other models

2025-02-04 Thread Peter Maydell
hw/arm/raspi4b.c | 136 - > hw/arm/meson.build | 2 +- > 3 files changed, 114 insertions(+), 138 deletions(-) > delete mode 100644 hw/arm/raspi4b.c Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 05/12] hw/arm/raspi: Consider processor id in types[] array

2025-02-04 Thread Peter Maydell
On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé wrote: > > Expand the current type2model array to include the processor id. > > Since the BCM2838 is indistinctly used as BCM2711 (within the > Linux community), add it as alias in RaspiProcessorId. Can you explain this in more detail? Presumabl

Re: [PATCH v2 11/12] hw/arm/raspi: Deprecate old raspiX machine names

2025-02-04 Thread Peter Maydell
On Tue, 4 Feb 2025 at 13:40, Philippe Mathieu-Daudé wrote: > > On 4/2/25 12:13, Peter Maydell wrote: > > On Tue, 4 Feb 2025 at 09:57, Daniel P. Berrangé wrote: > >> IMHO we can have distinct machines for each model, but > >> *NOT* have further machines for eac

Re: [PATCH v2 11/12] hw/arm/raspi: Deprecate old raspiX machine names

2025-02-04 Thread Peter Maydell
On Tue, 4 Feb 2025 at 09:57, Daniel P. Berrangé wrote: > > On Tue, Feb 04, 2025 at 10:51:04AM +0100, Philippe Mathieu-Daudé wrote: > > On 4/2/25 10:22, Peter Maydell wrote: > > > On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé > > > wrote: > > > >

Re: [PATCH v2 11/12] hw/arm/raspi: Deprecate old raspiX machine names

2025-02-04 Thread Peter Maydell
On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé wrote: > > All previous raspi machines can be created using the > generic machine. Deprecate the old names to maintain > a single one. Update the tests. > > Signed-off-by: Philippe Mathieu-Daudé > diff --git a/docs/about/deprecated.rst b/docs/a

Re: [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM

2025-02-03 Thread Peter Maydell
On Mon, 3 Feb 2025 at 14:50, Daniel P. Berrangé wrote: > > On Mon, Feb 03, 2025 at 02:45:06PM +, Peter Maydell wrote: > > For Arm embedded boards we mostly tend to "restrict the user > > to what you can actually do", except for older boards where > > we tend

Re: [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM

2025-02-03 Thread Peter Maydell
On Mon, 3 Feb 2025 at 14:33, Daniel P. Berrangé wrote: > > On Mon, Feb 03, 2025 at 02:29:49PM +, Alex Bennée wrote: > > Peter Maydell writes: > > > > > On Sat, 1 Feb 2025 at 12:57, BALATON Zoltan wrote: > > >> > > >> On Sat, 1 Feb 2025, Phi

Re: [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM

2025-02-01 Thread Peter Maydell
On Sat, 1 Feb 2025 at 12:57, BALATON Zoltan wrote: > > On Sat, 1 Feb 2025, Philippe Mathieu-Daudé wrote: > > - Deprecate the 'raspi4b' machine name, renaming it as > > 'raspi4b-1g' on 32-bit hosts, 'raspi4b-2g' otherwise. > > - Add the 'raspi4b-4g' and 'raspi4b-8g' machines, with > > respectivel

Re: [PULL 0/2] chardev patches

2024-10-09 Thread Peter Maydell
On Wed, 9 Oct 2024 at 09:39, wrote: > > From: Marc-André Lureau > > The following changes since commit 2af37e791906cfda42cb9604a16d218e56994bb1: > > Merge tag 'pull-request-2024-10-07' of https://gitlab.com/thuth/qemu into > staging (2024-10-07 12:55:02 +0100) > > are available in the Git repo

Re: [RFC PATCH] deprecation: don't enable TCG plugins by default on 32 bit hosts

2024-09-05 Thread Peter Maydell
On Thu, 5 Sept 2024 at 12:13, Alex Bennée wrote: > > The existing plugins already liberally use host pointer stuffing for > passing user data which will fail when doing 64 bit guests on 32 bit > hosts. We should discourage this by officially deprecating support and > adding another nail to the 32

Re: [PATCH 0/3] hw/sh4: Remove the deprecated SHIX machine

2024-09-03 Thread Peter Maydell
OM > hw/sh4: Remove sh7750_register_io_device() helper Whole series: Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] target/cris: Remove the deprecated CRIS target

2024-09-03 Thread Peter Maydell
On Tue, 3 Sept 2024 at 16:28, Philippe Mathieu-Daudé wrote: > > The CRIS target is deprecated since v9.0 (commit c7bbef40234 > "docs: mark CRIS support as deprecated"). > > Remove: > - Buildsys / CI infra > - User emulation > - System emulation (axis-dev88 machine and ETRAX devices) > - Tests > >

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Peter Maydell
U version. > +If you are still using machine types from QEMU versions older than 6 years, ditto > +please update your setting to use a newer versioned machine type instead. > + > Arm ``virt`` machine ``dtb-kaslr-seed`` property (since 7.1) > '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' > Otherwise Reviewed-by: Peter Maydell thanks -- PMM ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Peter Maydell
On Wed, 27 Mar 2024 at 13:23, Daniel P. Berrangé wrote: > > On Wed, Mar 27, 2024 at 02:09:17PM +0100, Igor Mammedov wrote: > > On Wed, 27 Mar 2024 10:49:43 + > > Daniel P. Berrangé wrote: > > It's question of whether we are willing to do unthinkable, > > i.e. to break QEMU <-> guest ABI for i

Re: [PATCH-for-9.0 0/2] target/monitor: Deprecate 'info tlb/mem' in favor of 'info mmu'

2024-03-20 Thread Peter Maydell
On Wed, 20 Mar 2024 at 17:06, Philippe Mathieu-Daudé wrote: > > +Alex/Daniel > > On 20/3/24 17:53, Peter Maydell wrote: > > On Wed, 20 Mar 2024 at 16:40, Philippe Mathieu-Daudé > > wrote: > >> > >> 'info tlb' and 'info mem' comm

Re: [PATCH-for-9.0 0/2] target/monitor: Deprecate 'info tlb/mem' in favor of 'info mmu'

2024-03-20 Thread Peter Maydell
On Wed, 20 Mar 2024 at 16:40, Philippe Mathieu-Daudé wrote: > > 'info tlb' and 'info mem' commands don't scale in heterogeneous > emulation. They will be reworked after the next release, hidden > behind the 'info mmu' command. It is not too late to deprecate > commands, so add the 'info mmu' comma

Re: [PATCH 4/5] Revert "hw/elf_ops: Ignore loadable segments with zero size"

2024-02-01 Thread Peter Maydell
On Thu, 1 Feb 2024 at 12:30, Alex Bennée wrote: > > This regressed qemu-system-xtensa: > > TESTtest_load_store on xtensa > qemu-system-xtensa: Some ROM regions are overlapping > These ROM regions might have been loaded by direct user request or by > default. > They could be BIOS/fir

Re: [PATCH v2 08/14] docs/system: clarify limits of using gdbstub in system emulation

2023-11-20 Thread Peter Maydell
On Mon, 20 Nov 2023 at 15:08, Alex Bennée wrote: > > It seems some users will try and use the gdbstub to debug userspace > inside a system emulation. While possible clarify the limitations of > this approach and direct the users to a less head scratching way of > debugging user-space. > > Signed-o

Re: [PATCH v2 11/14] tests/tcg: enable arm softmmu tests

2023-11-20 Thread Peter Maydell
On Mon, 20 Nov 2023 at 15:08, Alex Bennée wrote: > > To make it easier to test 32 bit Arm softmmu issues implement a basic > boot.S so we can build the multiarch tests. Currently CHECK_UNALIGNED > is disabled as I haven't got the right magic set for it to work. > > Message-Id: <20231115205542.3092