Re: [PATCH v3 21/21] docs: domain: Add documentation for Intel TDX guest

2025-07-09 Thread Xiaoyao Li
On 7/9/2025 2:58 PM, Daniel P. Berrangé wrote: Could we rename "policy" to "attributes", or more precisely "tdAttributes"? It's not intuitive for users to connect "policy" with "TD attributes". Will use "attributes" as QAPI exposes "attributes". IMHO 'policy' is preferrable as it is consistent

Re: [PATCH v3 21/21] docs: domain: Add documentation for Intel TDX guest

2025-07-08 Thread Xiaoyao Li
On 7/9/2025 11:46 AM, Duan, Zhenzhong wrote: (It should be commenting on the patch that enables the policy. I'm just too lazy to find that patch) Will do. It's just myself excuse for not commenting it in patch 07 Could we rename "policy" to "attributes", or more precisely "tdAttributes"? It'

Re: [PATCH v3 02/21] qemu: Check if INTEL Trust Domain Extention support is enabled

2025-07-08 Thread Xiaoyao Li
x27;Y': meaning TDX is enabled in the host kernel. Signed-off-by: Zhenzhong Duan Reviewed-by: Daniel P. Berrangé Reviewed-by: Xiaoyao Li

Re: [PATCH v3 01/21] tools: Secure guest check for Intel in virt-host-validate

2025-07-08 Thread Xiaoyao Li
On 6/30/2025 2:17 PM, Zhenzhong Duan wrote: Add check in virt-host-validate for secure guest support on x86 for Intel Trust Domain Extentions. Suggested-by: Daniel P. Berrangé Signed-off-by: Zhenzhong Duan Reviewed-by: Daniel P. Berrangé Reviewed-by: Xiaoyao Li

Re: [PATCH v3 21/21] docs: domain: Add documentation for Intel TDX guest

2025-07-08 Thread Xiaoyao Li
On 6/30/2025 2:17 PM, Zhenzhong Duan wrote: Signed-off-by: Zhenzhong Duan --- docs/formatdomain.rst | 63 +++ 1 file changed, 63 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 9a2f065590..5acebefec0 100644 --- a/docs/for

Re: [PATCH v8 55/55] docs: Add TDX documentation

2025-04-09 Thread Xiaoyao Li
On 4/2/2025 6:50 PM, Daniel P. Berrangé wrote: CC libvirt / Jiri, for confirmation about whether the CPUID restrictions listed below will have any possible impact on libvirt CPUID handling... On Tue, Apr 01, 2025 at 09:02:05AM -0400, Xiaoyao Li wrote: Add docs/system/i386/tdx.rst for TDX

Re: [PATCH 2/2] tests: add testing of parameter=1 for SMP topology

2024-05-20 Thread Xiaoyao Li
On 5/13/2024 8:33 PM, Daniel P. Berrangé wrote: Validate that it is possible to pass 'parameter=1' for any SMP topology parameter, since unsupported parameters are implicitly considered to always have a value of 1. Signed-off-by: Daniel P. Berrangé --- tests/unit/test-smp-parse.c | 8