Re: [PATCH] lib: Document VIR_DUMP_LIVE flag quirk

2025-06-03 Thread Michal Prívozník via Devel
On 6/2/25 16:18, Daniel P. Berrangé wrote: > On Mon, Jun 02, 2025 at 03:27:32PM +0200, Michal Privoznik via Devel wrote: >> From: Michal Privoznik >> >> The virDomainCoreDump() API has VIR_DUMP_LIVE flag which is >> documented to leave vCPUs running throughout making of the dump >> of guest memory

Re: [PATCH] lib: Document VIR_DUMP_LIVE flag quirk

2025-06-02 Thread Daniel P . Berrangé via Devel
On Mon, Jun 02, 2025 at 03:27:32PM +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > The virDomainCoreDump() API has VIR_DUMP_LIVE flag which is > documented to leave vCPUs running throughout making of the dump > of guest memory. Well, this is not the case for QEMU which pause

[PATCH] lib: Document VIR_DUMP_LIVE flag quirk

2025-06-02 Thread Michal Privoznik via Devel
From: Michal Privoznik The virDomainCoreDump() API has VIR_DUMP_LIVE flag which is documented to leave vCPUs running throughout making of the dump of guest memory. Well, this is not the case for QEMU which pauses vCPUs unconditionally (it calls vm_stop() in dump_init()). Document this quirk. And